November 2018 - tor-commits - lists.torproject.org

[torspec/master] Remove sentence about including headers but no lines
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit addf056f201561f1d967be45279c27f602b1eb2c Author: juga0 <juga(a)riseup.net> Date: Wed Nov 7 16:37:32 2018 +0000 Remove sentence about including headers but no lines When the are not enough eligible relays, since it's already mentioned in one of the KeyValues. --- bandwidth-file-spec.txt | 20 -------------------- 1 file changed, 20 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 84429b8..6afc0a8 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -215,10 +215,6 @@ It consists of: The number of relays that have enough measurements to be included in the bandwidth file. - Implementations SHOULD include this KeyValue when - "minimum_percent_eligible_relays" is minor than - "percent_eligible_relays" and MAY not include any RelayLine. - This Line has been added in version 1.2.0 of this specification. "minimum_percent_eligible_relays=" Int NL @@ -233,10 +229,6 @@ It consists of: The minimum percentage is 60% in Torflow, so sbws uses 60% as the default. - Implementations SHOULD include this KeyValue when - "minimum_percent_eligible_relays" is minor than - "percent_eligible_relays" and MAY not include any RelayLine. - This Line has been added in version 1.2.0 of this specification. "number_consensus_relays=" Int NL @@ -245,10 +237,6 @@ It consists of: The number of relays in the consensus. - Implementations SHOULD include this KeyValue when - "minimum_percent_eligible_relays" is minor than - "percent_eligible_relays" and MAY not include any RelayLine. - This Line has been added in version 1.2.0 of this specification. "percent_eligible_relays=" Int NL @@ -262,10 +250,6 @@ It consists of: (number_eligible_relays * 100.0) / number_consensus_relays to the number of relays in the consensus to include in this file. - Implementations SHOULD include this KeyValue when - "minimum_percent_eligible_relays" is minor than - "percent_eligible_relays" and MAY not include any RelayLine. - This Line has been added in version 1.2.0 of this specification. "minimum_number_eligible_relays=" Int NL @@ -277,10 +261,6 @@ It consists of: This line SHOULD be equal to: number_consensus_relays * (minimum_percent_eligible_relays / 100.0) - Implementations SHOULD include this KeyValue when - "minimum_percent_eligible_relays" is minor than - "percent_eligible_relays" and MAY not include any RelayLine. - This Line has been added in version 1.2.0 of this specification. KeyValue NL

1 0

[torspec/master] Rephrase definition of number_eligible_relays
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 6b1ccb00e66eec8235ed238bcadea50601c20bb3 Author: teor <teor(a)torproject.org> Date: Wed Nov 7 13:54:16 2018 +0000 Rephrase definition of number_eligible_relays Co-Authored-By: juga0 <juga(a)riseup.net> --- bandwidth-file-spec.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index bf77187..5403311 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -256,7 +256,8 @@ It consists of: [Zero or one time.] - The number of relays that has been measured and are eligible to + The number of relays that have enough measurements to be + included in the bandwidth file. include in the bandwidth file. Implementations SHOULD include this KeyValue when

1 0

[torspec/master] Include calculations for minimum_number_eligible_relays
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit b77eb0995defdf92eac9166d8d2e1c12bf0d0a50 Author: teor <teor(a)torproject.org> Date: Wed Nov 7 13:53:17 2018 +0000 Include calculations for minimum_number_eligible_relays Co-Authored-By: juga0 <juga(a)riseup.net> --- bandwidth-file-spec.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index c57b480..bf77187 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -231,6 +231,9 @@ It consists of: The minimum number of relays to include in the bandwidth file. + This line SHOULD be equal to: + number_consensus_relays * (minimum_percent_eligible_relays / 100.0) + Implementations SHOULD include this KeyValue when "minimum_percent_eligible_relays" is minor than "percent_eligible_relays" and MAY not include any RelayLine.

1 0

[torspec/master] Remove duplicated line
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 958df7bc3c521e691e432a3aa5a810a42010dda4 Author: teor <teor(a)torproject.org> Date: Wed Nov 7 15:47:43 2018 +0000 Remove duplicated line Co-Authored-By: juga0 <juga(a)riseup.net> --- bandwidth-file-spec.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 5403311..62bee23 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -258,7 +258,6 @@ It consists of: The number of relays that have enough measurements to be included in the bandwidth file. - include in the bandwidth file. Implementations SHOULD include this KeyValue when "minimum_percent_eligible_relays" is minor than

1 0

[torspec/master] Change order of KeyValues
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 6eddf6d1d53b41e4efae35c877e0c3dc0897a407 Author: juga0 <juga(a)riseup.net> Date: Wed Nov 7 16:30:40 2018 +0000 Change order of KeyValues As suggested by teor --- bandwidth-file-spec.txt | 46 +++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 62bee23..84429b8 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -208,16 +208,12 @@ It consists of: This Line has been added in version 1.1.0 of this specification. - "percent_eligible_relays=" Int NL + "number_eligible_relays=" Int NL [Zero or one time.] - The number of eligible relays, as a percentage of the number - of relays in the consensus. - - This line SHOULD be equal to: - (number_eligible_relays * 100.0) / number_consensus_relays - to the number of relays in the consensus to include in this file. + The number of relays that have enough measurements to be + included in the bandwidth file. Implementations SHOULD include this KeyValue when "minimum_percent_eligible_relays" is minor than @@ -225,14 +221,17 @@ It consists of: This Line has been added in version 1.2.0 of this specification. - "minimum_number_eligible_relays=" Int NL + "minimum_percent_eligible_relays=" Int NL [Zero or one time.] - The minimum number of relays to include in the bandwidth file. + The percentage of relays in the consensus that SHOULD be + included in every generated bandwidth file. If there are not + enough eligible relays, the bandwidth file SHOULD contain a + header, but no relays. - This line SHOULD be equal to: - number_consensus_relays * (minimum_percent_eligible_relays / 100.0) + The minimum percentage is 60% in Torflow, so sbws uses + 60% as the default. Implementations SHOULD include this KeyValue when "minimum_percent_eligible_relays" is minor than @@ -252,12 +251,16 @@ It consists of: This Line has been added in version 1.2.0 of this specification. - "number_eligible_relays=" Int NL + "percent_eligible_relays=" Int NL [Zero or one time.] - The number of relays that have enough measurements to be - included in the bandwidth file. + The number of eligible relays, as a percentage of the number + of relays in the consensus. + + This line SHOULD be equal to: + (number_eligible_relays * 100.0) / number_consensus_relays + to the number of relays in the consensus to include in this file. Implementations SHOULD include this KeyValue when "minimum_percent_eligible_relays" is minor than @@ -265,18 +268,15 @@ It consists of: This Line has been added in version 1.2.0 of this specification. - "minimum_percent_eligible_relays=" Int NL + "minimum_number_eligible_relays=" Int NL [Zero or one time.] - The percentage of relays in the consensus that SHOULD be - included in every generated bandwidth file. If there are not - enough eligible relays, the bandwidth file SHOULD contain a - header, but no relays. - - The minimum percentage is 60% in Torflow, so sbws uses - 60% as the default. - + The minimum number of relays to include in the bandwidth file. + + This line SHOULD be equal to: + number_consensus_relays * (minimum_percent_eligible_relays / 100.0) + Implementations SHOULD include this KeyValue when "minimum_percent_eligible_relays" is minor than "percent_eligible_relays" and MAY not include any RelayLine.

1 0

[torspec/master] Correct specification version in the examples
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 3f3f225531c01febcbb9049b4676f831088e662f Author: juga0 <juga(a)riseup.net> Date: Wed Nov 7 18:23:10 2018 +0000 Correct specification version in the examples Also change sbws version in the examples by X and add TODO to change that when it is implemented. --- bandwidth-file-spec.txt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 8ab0493..0006952 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -563,12 +563,12 @@ earliest_bandwidth=2018-04-16T15:13:26 bw=380 error_circ=0 error_misc=0 error_stream=1 master_key_ed25519=YaqV4vbvPYKucElk297eVdNArDz9HtIwUoIeo0+cVIpQ nick=Test node_id=$68A483E05A2ABDCA6DA5A3EF8DB5177638A27F80 rtt=380 success=1 time=2018-05-08T16:13:26 bw=189 error_circ=0 error_misc=0 error_stream=0 master_key_ed25519=a6a+dZadrQBtfSbmQkP7j2ardCmLnm5NJ4ZzkvDxbo0I nick=Test2 node_id=$96C15995F30895689291F455587BD94CA427B6FC rtt=378 success=1 time=2018-05-08T16:13:36 -A.3. Generated by sbws version 0.2.X - +A.3. Generated by sbws version 1.X.X +[TODO: change the version of sbws that generates this when it is implemented] 1523911758 -version=1.1.0 +version=1.2.0 software=sbws -software_version=0.1.0 +software_version=1.X.X latest_bandwidth=2018-04-16T20:49:18 file_created=2018-04-16T21:49:18 generator_started=2018-04-16T15:13:25 @@ -580,7 +580,7 @@ bw=1 bw_mean=199162 bw_median=185675 desc_avg_bw=409600 desc_obs_bw_last=836165 When there are not enough eligible measured relays: 1540496079 -version=1.1.0 +version=1.2.0 earliest_bandwidth=2018-10-20T19:35:52 file_created=2018-10-25T19:35:03 generator_started=2018-10-25T11:42:56 @@ -591,7 +591,7 @@ num_target_relays=3862 perc_measured_relays=46 perc_measured_targed=60 software=sbws -software_version=0.8.1-dev0 +software_version=1.X.X B. Scaling bandwidths

1 0

[torspec/master] Correct number of characters in terminator
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 4805cae3b910ce9050556d0df4d79009b9b3d567 Author: teor <teor(a)torproject.org> Date: Thu Nov 8 07:39:37 2018 +0000 Correct number of characters in terminator Co-Authored-By: juga0 <juga(a)riseup.net> --- bandwidth-file-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 0cc7b81..f7138f7 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -578,7 +578,7 @@ perc_measured_relays=93 perc_measured_targed=60 software=sbws software_version=1.X.X -==== +===== bw=38000 bw_mean=1127824 bw_median=1180062 desc_avg_bw=1073741824 desc_obs_bw_last=17230879 desc_obs_bw_mean=14732306 error_circ=0 error_misc=0 error_stream=1 master_key_ed25519=YaqV4vbvPYKucElk297eVdNArDz9HtIwUoIeo0+cVIpQ nick=Test node_id=$68A483E05A2ABDCA6DA5A3EF8DB5177638A27F80 rtt=380 success=1 time=2018-05-08T16:13:26 bw=1 bw_mean=199162 bw_median=185675 desc_avg_bw=409600 desc_obs_bw_last=836165 desc_obs_bw_mean=858030 error_circ=0 error_misc=0 error_stream=0 master_key_ed25519=a6a+dZadrQBtfSbmQkP7j2ardCmLnm5NJ4ZzkvDxbo0I nick=Test2 node_id=$96C15995F30895689291F455587BD94CA427B6FC rtt=378 success=1 time=2018-05-08T16:13:36

1 0

[torspec/master] Include terminator in examples without RelayLines
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 40d380753250987500ea8a0b0f05575de6284836 Author: teor <teor(a)torproject.org> Date: Thu Nov 8 07:41:04 2018 +0000 Include terminator in examples without RelayLines Co-Authored-By: juga0 <juga(a)riseup.net> --- bandwidth-file-spec.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index f7138f7..d082a7e 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -597,6 +597,7 @@ perc_measured_relays=46 perc_measured_targed=60 software=sbws software_version=1.X.X +===== B. Scaling bandwidths

1 0

[torspec/master] Add new version (1.2) in Format Versions
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit d86cea62c2ca8db814794c434e7e4b70bc07f2b7 Author: juga0 <juga(a)riseup.net> Date: Wed Nov 7 16:47:24 2018 +0000 Add new version (1.2) in Format Versions --- bandwidth-file-spec.txt | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 6afc0a8..8ab0493 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -47,6 +47,11 @@ 1.1.0 - Adds KeyValue Lines to the Header List section, add KeyValues to RelayLines and format versions. + 1.2.0 - Adds new KeyValue Lines to the Header List section with + statistics about the number of relays included in the file. + Add new KeyValue Lines to the Relays' Bandwidth List section + with different bandwidth values. + All Tor versions can consume format version 1.0.0. All Tor versions can consume format version 1.1.0, but they warn on additional header Lines.

1 0

[torspec/master] Include v1.2 headers in example with relays
by nickm＠torproject.org 26 Nov '18

26 Nov '18

commit 9afc14ba50060642bce91649350ff2cd4bf0fee9 Author: juga0 <juga(a)riseup.net> Date: Wed Nov 7 18:27:15 2018 +0000 Include v1.2 headers in example with relays --- bandwidth-file-spec.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 0006952..0cc7b81 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -567,12 +567,17 @@ A.3. Generated by sbws version 1.X.X [TODO: change the version of sbws that generates this when it is implemented] 1523911758 version=1.2.0 -software=sbws -software_version=1.X.X latest_bandwidth=2018-04-16T20:49:18 file_created=2018-04-16T21:49:18 generator_started=2018-04-16T15:13:25 earliest_bandwidth=2018-04-16T15:13:26 +num_measured_relays=6000 +num_net_relays=6436 +num_target_relays=3862 +perc_measured_relays=93 +perc_measured_targed=60 +software=sbws +software_version=1.X.X ==== bw=38000 bw_mean=1127824 bw_median=1180062 desc_avg_bw=1073741824 desc_obs_bw_last=17230879 desc_obs_bw_mean=14732306 error_circ=0 error_misc=0 error_stream=1 master_key_ed25519=YaqV4vbvPYKucElk297eVdNArDz9HtIwUoIeo0+cVIpQ nick=Test node_id=$68A483E05A2ABDCA6DA5A3EF8DB5177638A27F80 rtt=380 success=1 time=2018-05-08T16:13:26 bw=1 bw_mean=199162 bw_median=185675 desc_avg_bw=409600 desc_obs_bw_last=836165 desc_obs_bw_mean=858030 error_circ=0 error_misc=0 error_stream=0 master_key_ed25519=a6a+dZadrQBtfSbmQkP7j2ardCmLnm5NJ4ZzkvDxbo0I nick=Test2 node_id=$96C15995F30895689291F455587BD94CA427B6FC rtt=378 success=1 time=2018-05-08T16:13:36

1 0