October 2018 - tor-commits - lists.torproject.org

[tor/master] expand the blurb
by nickm＠torproject.org 17 Oct '18

17 Oct '18

commit 444e9b37c53b0246158a4fca2e4e6e732deb8799 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 17 14:20:55 2018 -0400 expand the blurb --- ChangeLog | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 246f584f0..6c043638b 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,7 +1,9 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 Tor 0.3.5.3-alpha fixes several bugs, mostly from previous 0.3.5.x - versions. It's still an alpha, but we hope it's getting closer and - closer to stability. + versions. One important fix for relays addresses a problem with rate- + limiting code from back in 0.3.4.x: If the fix works out, we'll be + backporting it soon. This release is still an alpha, but we hope it's + getting closer and closer to stability. o Major features (onion services): - Version 3 onion services can now use the per-service

1 0

[tor/master] Reflow the changelog
by nickm＠torproject.org 17 Oct '18

17 Oct '18

commit cd6e75a6b4316575cfc66099580831dc2b20aa04 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 17 14:19:33 2018 -0400 Reflow the changelog --- ChangeLog | 46 +++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/ChangeLog b/ChangeLog index df8e57c51..246f584f0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,12 +3,12 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 versions. It's still an alpha, but we hope it's getting closer and closer to stability. - o Major bugfixes (relay): - - When our write bandwidth limit is exhausted, stop writing on the - connection. Previously, we had a typo in the code that would make us - stop reading instead, leading to relay connections being stuck - indefinitely and consuming kernel RAM. Fixes bug 28089; bugfix on - 0.3.4.1-alpha. + o Major features (onion services): + - Version 3 onion services can now use the per-service + HiddenServiceExportCircuitID option to differentiate client + circuits. It communicates with the service by using the HAProxy + protocol to assign virtual IP addresses to inbound client + circuits. Closes ticket 4700. Patch by Mahrud Sayrafi. o Major bugfixes (compilation): - Fix compilation on ARM (and other less-used CPUs) when compiling @@ -25,6 +25,13 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 when a client port was set (Socks, Trans, NATD, DNS or HTTPTunnel port). Fixes bug 27849; bugfix on 0.3.4.1-alpha. + o Major bugfixes (relay): + - When our write bandwidth limit is exhausted, stop writing on the + connection. Previously, we had a typo in the code that would make + us stop reading instead, leading to relay connections being stuck + indefinitely and consuming kernel RAM. Fixes bug 28089; bugfix + on 0.3.4.1-alpha. + o Minor features (continuous integration): - Use the Travis Homebrew addon to install packages on macOS during Travis CI. The package list is the same, but the Homebrew addon @@ -37,13 +44,6 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 - Update geoip and geoip6 to the October 9 2018 Maxmind GeoLite2 Country database. Closes ticket 27991. - o Major features (onion services): - - Version 3 onion services can now use the per-service - HiddenServiceExportCircuitID option to differentiate client - circuits. It communicates with the service by using the HAProxy - protocol to assign virtual IP addresses to inbound client - circuits. Closes ticket 4700. Patch by Mahrud Sayrafi. - o Minor bugfixes (code safety): - Rewrite our assertion macros so that they no longer suppress the compiler's -Wparentheses warnings. Fixes bug 27709; bugfix @@ -92,14 +92,14 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 point without having a descriptor for it. Fixes bug 27774; bugfix on 0.3.2.1-alpha. - Don't warn so loudly when Tor is unable to decode an onion - descriptor. This can now happen as a normal use case if a client gets a - descriptor with client authorization but the client is not + descriptor. This can now happen as a normal use case if a client + gets a descriptor with client authorization but the client is not authorized. Fixes bug 27550; bugfix on 0.3.5.1-alpha. - When selecting a v3 rendezvous point, don't only look at the protover, but also check whether the curve25519 onion key is present. This way we avoid picking a relay that supports the v3 - rendezvous but for which we don't have the microdescriptor. Fixes bug - 27797; bugfix on 0.3.2.1-alpha. + rendezvous but for which we don't have the microdescriptor. Fixes + bug 27797; bugfix on 0.3.2.1-alpha. o Minor bugfixes (protover): - Reject protocol names containing bytes other than alphanumeric @@ -107,10 +107,10 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 on 0.2.9.4-alpha. o Minor bugfixes (testing): - - Make the hs_service tests use the same time source when - creating the introduction point and when testing it. Now tests work - better on very slow systems like ARM or Travis. Fixes bug 27810; - bugfix on 0.3.2.1-alpha. + - Make the hs_service tests use the same time source when creating + the introduction point and when testing it. Now tests work better + on very slow systems like ARM or Travis. Fixes bug 27810; bugfix + on 0.3.2.1-alpha. - In test_rebind.py, check if the Python version is in the supported range. Fixes bug 27675; bugfix on 0.3.5.1-alpha. @@ -130,8 +130,8 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 help with future modularization. Closes ticket 27864. o Documentation: - - In the tor-resolve(1) manpage, fix the reference to - socks-extensions.txt by adding a web URL. Resolves ticket 27853. + - In the tor-resolve(1) manpage, fix the reference to socks- + extensions.txt by adding a web URL. Resolves ticket 27853. - Mention that we require Python to be 2.7 or newer for some integration tests that we ship with Tor. Resolves ticket 27677.

1 0

[translation/https_everywhere_completed] Update translations for https_everywhere_completed
by translation＠torproject.org 17 Oct '18

17 Oct '18

commit 0d2ce862a492458e569949b366d7f3d0b5650827 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 17 18:15:46 2018 +0000 Update translations for https_everywhere_completed --- ru/https-everywhere.dtd | 1 + 1 file changed, 1 insertion(+) diff --git a/ru/https-everywhere.dtd b/ru/https-everywhere.dtd index 1c17d4019..36391fcb1 100644 --- a/ru/https-everywhere.dtd +++ b/ru/https-everywhere.dtd @@ -18,6 +18,7 @@ <!ENTITY https-everywhere.options.enableMixedRulesets "Включить наборы правил для смешанного содержимого"> <!ENTITY https-everywhere.options.showDevtoolsTab "Показывать вкладку инструментов разработчика"> <!ENTITY https-everywhere.options.autoUpdateRulesets "Автоматическое обновление наборов правил"> +<!ENTITY https-everywhere.options.userRulesListed "Пользовательские правила HTTPS Everywhere"> <!ENTITY https-everywhere.options.disabledUrlsListed "Сайты с отключенным HTTPS Everywhere"> <!ENTITY https-everywhere.options.updateChannelsWarning "Предупреждение: добавление каналов обновления может привести к атакам злоумышленников на ваш браузер. Редактируйте этот раздел, только если знаете, что делаете!"> <!ENTITY https-everywhere.options.addUpdateChannel "Добавить канал обновления">

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 17 Oct '18

17 Oct '18

commit 0623d2b37c5f76ced18c80a7c940fdf629954035 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 17 18:15:39 2018 +0000 Update translations for https_everywhere --- ru/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ru/https-everywhere.dtd b/ru/https-everywhere.dtd index 4ede6bc4c..36391fcb1 100644 --- a/ru/https-everywhere.dtd +++ b/ru/https-everywhere.dtd @@ -18,7 +18,7 @@ <!ENTITY https-everywhere.options.enableMixedRulesets "Включить наборы правил для смешанного содержимого"> <!ENTITY https-everywhere.options.showDevtoolsTab "Показывать вкладку инструментов разработчика"> <!ENTITY https-everywhere.options.autoUpdateRulesets "Автоматическое обновление наборов правил"> -<!ENTITY https-everywhere.options.userRulesListed "HTTPS Everywhere User Rules"> +<!ENTITY https-everywhere.options.userRulesListed "Пользовательские правила HTTPS Everywhere"> <!ENTITY https-everywhere.options.disabledUrlsListed "Сайты с отключенным HTTPS Everywhere"> <!ENTITY https-everywhere.options.updateChannelsWarning "Предупреждение: добавление каналов обновления может привести к атакам злоумышленников на ваш браузер. Редактируйте этот раздел, только если знаете, что делаете!"> <!ENTITY https-everywhere.options.addUpdateChannel "Добавить канал обновления">

1 0

[tor/master] merge in some fixes i found in a sandbox
by arma＠torproject.org 17 Oct '18

17 Oct '18

commit df78a2730cda08bcf4021b84ef301d58ba1f391a Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Oct 17 13:56:41 2018 -0400 merge in some fixes i found in a sandbox --- ChangeLog | 4 ++-- ReleaseNotes | 4 ++-- src/feature/hs/hs_cache.c | 6 +++--- src/feature/hs/hs_client.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index d2a616660..df8e57c51 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1252,7 +1252,7 @@ Changes in version 0.3.4.6-rc - 2018-08-06 o Minor bugfixes (correctness, flow control): - Upon receiving a stream-level SENDME cell, verify that our window has not grown too large. Fixes bug 26214; bugfix on svn - r54 (pre-0.0.1) + r54 (pre-0.0.1). o Minor bugfixes (memory, correctness): - Fix a number of small memory leaks identified by coverity. Fixes @@ -2366,7 +2366,7 @@ Changes in version 0.3.4.1-alpha - 2018-05-17 once had an ed25519 key associated with their RSA key to always have that key, instead of allowing them to drop back to a version that didn't support ed25519. This means they need to use a new RSA - key if the want to downgrade to an older version of tor without + key if they want to downgrade to an older version of tor without ed25519. Closes ticket 20522. o Documentation: diff --git a/ReleaseNotes b/ReleaseNotes index ac107b7f3..dd7e82321 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -692,7 +692,7 @@ Changes in version 0.3.4.8 - 2018-09-10 o Minor bugfixes (correctness, flow control): - Upon receiving a stream-level SENDME cell, verify that our window has not grown too large. Fixes bug 26214; bugfix on svn - r54 (pre-0.0.1) + r54 (pre-0.0.1). o Minor bugfixes (directory authority): - When voting for recommended versions, make sure that all of the @@ -937,7 +937,7 @@ Changes in version 0.3.4.8 - 2018-09-10 once had an ed25519 key associated with their RSA key to always have that key, instead of allowing them to drop back to a version that didn't support ed25519. This means they need to use a new RSA - key if the want to downgrade to an older version of tor without + key if they want to downgrade to an older version of tor without ed25519. Closes ticket 20522. o Removed features: diff --git a/src/feature/hs/hs_cache.c b/src/feature/hs/hs_cache.c index 58bb10b19..b9bcb446a 100644 --- a/src/feature/hs/hs_cache.c +++ b/src/feature/hs/hs_cache.c @@ -467,7 +467,7 @@ cache_intro_state_free_(hs_cache_intro_state_t *state) tor_free(state); } -/* Helper function: use by the free all function. */ +/* Helper function: used by the free all function. */ static void cache_intro_state_free_void(void *state) { @@ -488,7 +488,7 @@ cache_client_intro_state_new(void) FREE_AND_NULL(hs_cache_client_intro_state_t, \ cache_client_intro_state_free_, (val)) -/* Free a cache client intro state object. */ +/* Free a cache_client_intro_state object. */ static void cache_client_intro_state_free_(hs_cache_client_intro_state_t *cache) { @@ -499,7 +499,7 @@ cache_client_intro_state_free_(hs_cache_client_intro_state_t *cache) tor_free(cache); } -/* Helper function: use by the free all function. */ +/* Helper function: used by the free all function. */ static void cache_client_intro_state_free_void(void *entry) { diff --git a/src/feature/hs/hs_client.c b/src/feature/hs/hs_client.c index 31837c5a9..11e24a366 100644 --- a/src/feature/hs/hs_client.c +++ b/src/feature/hs/hs_client.c @@ -265,7 +265,7 @@ retry_all_socks_conn_waiting_for_desc(void) } /* In this loop, we will possibly try to fetch a descriptor for the * pending connections because we just got more directory information. - * However, the refetch process can cleanup all SOCKS request so the same + * However, the refetch process can cleanup all SOCKS request to the same * service if an internal error happens. Thus, we can end up with closed * connections in our list. */ if (base_conn->marked_for_close) {

1 0

[tor/master] 0.3.5.3-alpha changelog touch-ups
by arma＠torproject.org 17 Oct '18

17 Oct '18

commit 1a3fbba92bace91588d9548f1dec5e919f97e8c2 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Oct 17 13:42:59 2018 -0400 0.3.5.3-alpha changelog touch-ups --- ChangeLog | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 73fcee495..d2a616660 100644 --- a/ChangeLog +++ b/ChangeLog @@ -37,7 +37,7 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 - Update geoip and geoip6 to the October 9 2018 Maxmind GeoLite2 Country database. Closes ticket 27991. - o Minor features (onion services): + o Major features (onion services): - Version 3 onion services can now use the per-service HiddenServiceExportCircuitID option to differentiate client circuits. It communicates with the service by using the HAProxy @@ -62,10 +62,10 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 on 0.3.5.1-alpha. o Minor bugfixes (continuous integration, appveyor): - - Only install the necessary mingw packages during our appveyor + - Install only the necessary mingw packages during our appveyor builds. This change makes the build a little faster, and prevents a conflict with a preinstalled mingw openssl that appveyor now - ships. Fixes bugs 27943 and 27765; bugfix on 0.3.4.2-alpha. + ships. Fixes bugs 27765 and 27943; bugfix on 0.3.4.2-alpha. o Minor bugfixes (directory permissions): - When a user requests a group-readable DataDirectory, give it to @@ -91,14 +91,14 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 - Stop dumping a stack trace when trying to connect to an intro point without having a descriptor for it. Fixes bug 27774; bugfix on 0.3.2.1-alpha. - - Don't warn so loudly when Tor is unable to decode a descriptor. - This can now happen as a normal use case if a client gets a + - Don't warn so loudly when Tor is unable to decode an onion + descriptor. This can now happen as a normal use case if a client gets a descriptor with client authorization but the client is not authorized. Fixes bug 27550; bugfix on 0.3.5.1-alpha. - When selecting a v3 rendezvous point, don't only look at the protover, but also check whether the curve25519 onion key is present. This way we avoid picking a relay that supports the v3 - rendezvous but for which we don't have the descriptor. Fixes bug + rendezvous but for which we don't have the microdescriptor. Fixes bug 27797; bugfix on 0.3.2.1-alpha. o Minor bugfixes (protover): @@ -107,12 +107,12 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 on 0.2.9.4-alpha. o Minor bugfixes (testing): - - Make the the hs_service tests uses the same time source when - creating the introduction point and testing it. This helps make - test work on very slow system like ARM or Travis. Fixes bug 27810; + - Make the hs_service tests use the same time source when + creating the introduction point and when testing it. Now tests work + better on very slow systems like ARM or Travis. Fixes bug 27810; bugfix on 0.3.2.1-alpha. - - In test_rebind.py, check if the Python version is in supported - ranges. Fixes bug 27675; bugfix on 0.3.5.1-alpha. + - In test_rebind.py, check if the Python version is in the supported + range. Fixes bug 27675; bugfix on 0.3.5.1-alpha. o Code simplification and refactoring: - Divide more large Tor source files -- especially ones that span @@ -130,8 +130,8 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 help with future modularization. Closes ticket 27864. o Documentation: - - In the tor-resolve(1) manpage, fix the reference to socks- - extensions.txt by adding web URL. Resolves ticket 27853. + - In the tor-resolve(1) manpage, fix the reference to + socks-extensions.txt by adding a web URL. Resolves ticket 27853. - Mention that we require Python to be 2.7 or newer for some integration tests that we ship with Tor. Resolves ticket 27677.

1 0

[translation/liveusb-creator_completed] Update translations for liveusb-creator_completed
by translation＠torproject.org 17 Oct '18

17 Oct '18

commit 1891610f33edefa0f7d2757fd6086aa7cb242cf4 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 17 17:15:55 2018 +0000 Update translations for liveusb-creator_completed --- fr/fr.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fr/fr.po b/fr/fr.po index 7112291c9..601d742e0 100644 --- a/fr/fr.po +++ b/fr/fr.po @@ -29,8 +29,8 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-10-17 13:11+0200\n" -"PO-Revision-Date: 2018-10-17 14:51+0000\n" -"Last-Translator: erinm\n" +"PO-Revision-Date: 2018-10-17 16:55+0000\n" +"Last-Translator: AO <ao(a)localizationlab.org>\n" "Language-Team: French (http://www.transifex.com/otf/torproject/language/fr/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n"

1 0

[translation/liveusb-creator] Update translations for liveusb-creator
by translation＠torproject.org 17 Oct '18

17 Oct '18

commit d173a52112261a61821ab37d90d0a3ff6cb9f3d1 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 17 17:15:50 2018 +0000 Update translations for liveusb-creator --- fr/fr.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fr/fr.po b/fr/fr.po index 7112291c9..601d742e0 100644 --- a/fr/fr.po +++ b/fr/fr.po @@ -29,8 +29,8 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-10-17 13:11+0200\n" -"PO-Revision-Date: 2018-10-17 14:51+0000\n" -"Last-Translator: erinm\n" +"PO-Revision-Date: 2018-10-17 16:55+0000\n" +"Last-Translator: AO <ao(a)localizationlab.org>\n" "Language-Team: French (http://www.transifex.com/otf/torproject/language/fr/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n"

1 0

[tor/master] Fold in the entry for 28089
by nickm＠torproject.org 17 Oct '18

17 Oct '18

commit 498a852bba149975f7fe50180bfb24077dcdc4c4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 17 13:12:24 2018 -0400 Fold in the entry for 28089 --- ChangeLog | 7 +++++++ changes/ticket28089 | 6 ------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index ca9729c00..73fcee495 100644 --- a/ChangeLog +++ b/ChangeLog @@ -3,6 +3,13 @@ Changes in version 0.3.5.3-alpha - 2018-10-17 versions. It's still an alpha, but we hope it's getting closer and closer to stability. + o Major bugfixes (relay): + - When our write bandwidth limit is exhausted, stop writing on the + connection. Previously, we had a typo in the code that would make us + stop reading instead, leading to relay connections being stuck + indefinitely and consuming kernel RAM. Fixes bug 28089; bugfix on + 0.3.4.1-alpha. + o Major bugfixes (compilation): - Fix compilation on ARM (and other less-used CPUs) when compiling with OpenSSL before 1.1. Fixes bug 27781; bugfix on 0.3.4.1-alpha. diff --git a/changes/ticket28089 b/changes/ticket28089 deleted file mode 100644 index a900ec18f..000000000 --- a/changes/ticket28089 +++ /dev/null @@ -1,6 +0,0 @@ - o Major bugfixes (relay): - - When our write bandwidth limit is exhausted, stop writing on the - connection. Previously, we had a typo in the code that would make us stop - reading leading to relay connections being stuck indefinitely. Fixes bug - 28089; bugfix on 0.3.4.1-alpha. -

1 0

[tor/maint-0.3.4] conn: Stop writing when our write bandwidth limist is exhausted
by nickm＠torproject.org 17 Oct '18

17 Oct '18

commit 2000d04cb67fa1ee88105e61666dceba40b8c368 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Oct 17 12:25:12 2018 -0400 conn: Stop writing when our write bandwidth limist is exhausted Commit 488e2b00bf881b97bcc8e4bbe304845ff1d79a03 introduced an issue, most likely introduced by a bad copy paste, that made us stop reading on the connection if our write bandwidth limit was reached. The problem is that because "read_blocked_on_bw" was never set, the connection was never reenabled for reading. This is most likely the cause of #27813 where bytes were accumulating in the kernel TCP bufers because tor was not doing reads. Only relays with RelayBandwidthRate would suffer from this but affecting all relays connecting to them. And using that tor option is recommended and best practice so many many relays have it enabled. Fixes #28089. --- changes/ticket28089 | 6 ++++++ src/or/connection.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changes/ticket28089 b/changes/ticket28089 new file mode 100644 index 000000000..a900ec18f --- /dev/null +++ b/changes/ticket28089 @@ -0,0 +1,6 @@ + o Major bugfixes (relay): + - When our write bandwidth limit is exhausted, stop writing on the + connection. Previously, we had a typo in the code that would make us stop + reading leading to relay connections being stuck indefinitely. Fixes bug + 28089; bugfix on 0.3.4.1-alpha. + diff --git a/src/or/connection.c b/src/or/connection.c index 7283a8104..0a2a63509 100644 --- a/src/or/connection.c +++ b/src/or/connection.c @@ -3111,7 +3111,7 @@ connection_write_bw_exhausted(connection_t *conn, bool is_global_bw) { (void)is_global_bw; conn->write_blocked_on_bw = 1; - connection_stop_reading(conn); + connection_stop_writing(conn); reenable_blocked_connection_schedule(); }

1 0