January 2018 - tor-commits - lists.torproject.org

[meek/master] Show an error when missing a meek-client command line.
by dcf＠torproject.org 11 Jan '18

11 Jan '18

commit dcfbef8d459adf916f5c4ce8c6ff4ff777be06ff Author: David Fifield <david(a)bamsoftware.com> Date: Thu Jan 11 13:04:34 2018 -0800 Show an error when missing a meek-client command line. Running meek-client-torbrowser without arguments would panic as it tried to index the nonexistent arguments. 2018/01/11 21:02:07 running firefox command ["firefox" "--invisible" "-no-remote" "-profile" "TorBrowser/Data/Browser/profile.meek-http-helper"] 2018/01/11 21:02:07 firefox started with pid 23721 2018/01/11 21:02:08 killing PID 23721 panic: runtime error: index out of range goroutine 1 [running]: panic(0x4e95a0, 0xc42000a110) /usr/lib/go-1.7/src/runtime/panic.go:500 +0x1a1 main.runMeekClient(0xc420010589, 0xf, 0xc42000a2c0, 0x0, 0x0, 0x0, 0x10, 0xc42000e440) meek-client-torbrowser.go:267 +0x416 main.main() meek-client-torbrowser.go:354 +0x3d2 --- meek-client-torbrowser/meek-client-torbrowser.go | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/meek-client-torbrowser/meek-client-torbrowser.go b/meek-client-torbrowser/meek-client-torbrowser.go index 691a566..db35080 100644 --- a/meek-client-torbrowser/meek-client-torbrowser.go +++ b/meek-client-torbrowser/meek-client-torbrowser.go @@ -296,6 +296,11 @@ func main() { log.SetOutput(f) } + meekClientCommandLine := flag.Args() + if len(meekClientCommandLine) == 0 { + log.Fatal("need a meek-client command line") + } + // By default, writes to file descriptor 1 and 2 when the descriptor has // been closed will terminate the program with a SIGPIPE signal. This is // a problem because the default log destination is stderr (file @@ -351,7 +356,7 @@ func main() { } // Start meek-client with the helper address. - meekClientCmd, err := runMeekClient(helperAddr, flag.Args()) + meekClientCmd, err := runMeekClient(helperAddr, meekClientCommandLine) if err != nil { log.Print(err) return

1 0

[translation/torcheck_completed] Update translations for torcheck_completed
by translation＠torproject.org 11 Jan '18

11 Jan '18

commit db67c03a7c676f323f1f2c60e9e8c679b24c61f1 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Jan 11 19:45:22 2018 +0000 Update translations for torcheck_completed --- mk/torcheck.po | 33 ++++++++++++++++++++++----------- 1 file changed, 22 insertions(+), 11 deletions(-) diff --git a/mk/torcheck.po b/mk/torcheck.po index 34257c19d..909d8e7bf 100644 --- a/mk/torcheck.po +++ b/mk/torcheck.po @@ -2,15 +2,17 @@ # Copyright (C) 2008-2013 The Tor Project, Inc # # Translators: +# Bojan Jankuloski <bojan.jankuloski(a)gmail.com>, 2016 # Nena <nena100janovska(a)gmail.com>, 2014 -# runasand <runa.sandvik(a)gmail.com>, 2011 +# runasand <inactive+runasand(a)transifex.com>, 2011 +# Zarko Gjurov <zarkogjurov(a)gmail.com>, 2018 msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2014-03-19 11:40+0000\n" -"Last-Translator: Nena <nena100janovska(a)gmail.com>\n" -"Language-Team: Macedonian (http://www.transifex.com/projects/p/torproject/language/mk/)\n" +"PO-Revision-Date: 2018-01-11 19:34+0000\n" +"Last-Translator: Zarko Gjurov <zarkogjurov(a)gmail.com>\n" +"Language-Team: Macedonian (http://www.transifex.com/otf/torproject/language/mk/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" "Content-Transfer-Encoding: 8bit\n" @@ -19,31 +21,31 @@ msgstr "" "Plural-Forms: nplurals=2; plural=(n % 10 == 1 && n % 100 != 11) ? 0 : 1;\n" msgid "Congratulations. This browser is configured to use Tor." -msgstr "Честитаме. Прелистувачот е нагоден за употреба на Tor." +msgstr "Честититки. Прелистувачот е конфигуриран за употреба на Tor." msgid "" "Please refer to the <a href=\"https://www.torproject.org/\">Tor website</a> " "for further information about using Tor safely. You are now free to browse " "the Internet anonymously." -msgstr " Ве молиме посетете ја <a href=\"https://www.torproject.org/\">веб локацијата Tor</a> за повеќе информации за безбедна употреба на Tor. Сега слободно можете да го прелистувате интернетот анонимно" +msgstr "Посетете го <a href=\"https://www.torproject.org/\">мрежното месот на Tor</a> за повеќе информации за негова безбедна употреба. Сега слободно можете да прелистувате на Интернет анонимно." -msgid "There is a security update available for the Tor Browser Bundle." -msgstr "Достапна е безбедносна надградба за прелистувачкиот пакет Tor" +msgid "There is a security update available for Tor Browser." +msgstr "Достапна е надоградба за Tor прелистувачот." msgid "" "<a href=\"https://www.torproject.org/download/download-easy.html\">Click " "here to go to the download page</a>" -msgstr "<a href=\"https://www.torproject.org/download/download-easy.html\">Кликнете овде за да се префрлите на страницата за симнување</a>" +msgstr "<a href=\"https://www.torproject.org/download/download-easy.html\">Кликнете овде за да одите на страницата за преземање</a>" msgid "Sorry. You are not using Tor." -msgstr "Жал ни е, но Вие не користите Тор." +msgstr "За жал, не го користите Tor." msgid "" "If you are attempting to use a Tor client, please refer to the <a " "href=\"https://www.torproject.org/\">Tor website</a> and specifically the <a" " href=\"https://www.torproject.org/docs/faq#DoesntWork\">instructions for " "configuring your Tor client</a>." -msgstr "Ако се обидувате да го употребите Tor клиентот, Ве молиме посетете ја <a href=\"https://www.torproject.org/\">веб-локацијата на Tor</a> а особено <a href=\"https://www.torproject.org/docs/faq#DoesntWork\">упатствата за конфигурација на Вашиот instructions Tor клиент</a>." +msgstr "Ако се обидувате да го употребите Tor клиентот, Ве молиме посетете ја <a href=\"https://www.torproject.org/\">веб-локацијата на Tor</a> а особено <a href=\"https://www.torproject.org/docs/faq#DoesntWork\">упатствата за конфигурација на Вашиот Tor клиент</a>." msgid "Sorry, your query failed or an unexpected response was received." msgstr "Жал ни е, но или Вашето барање не успеа или примивме неочекуван одговор." @@ -93,3 +95,12 @@ msgstr "Опцијата JavaScript е овозможена." msgid "JavaScript is disabled." msgstr "Опцијата JavaScript е оневозможена." + +msgid "However, it does not appear to be Tor Browser." +msgstr "Како и да е, не изгледа дека е Tor прелистувач." + +msgid "Run a Relay" +msgstr "Покрени јазол" + +msgid "Stay Anonymous" +msgstr "Останете анонимни"

1 0

[translation/torcheck] Update translations for torcheck
by translation＠torproject.org 11 Jan '18

11 Jan '18

commit a49636bed1765aa3432c6f528470f77d85446d7d Author: Translation commit bot <translation(a)torproject.org> Date: Thu Jan 11 19:45:16 2018 +0000 Update translations for torcheck --- mk/torcheck.po | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/mk/torcheck.po b/mk/torcheck.po index 696b5f842..909d8e7bf 100644 --- a/mk/torcheck.po +++ b/mk/torcheck.po @@ -5,12 +5,13 @@ # Bojan Jankuloski <bojan.jankuloski(a)gmail.com>, 2016 # Nena <nena100janovska(a)gmail.com>, 2014 # runasand <inactive+runasand(a)transifex.com>, 2011 +# Zarko Gjurov <zarkogjurov(a)gmail.com>, 2018 msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2017-12-20 19:01+0000\n" -"Last-Translator: Bojan Jankuloski <bojan.jankuloski(a)gmail.com>\n" +"PO-Revision-Date: 2018-01-11 19:34+0000\n" +"Last-Translator: Zarko Gjurov <zarkogjurov(a)gmail.com>\n" "Language-Team: Macedonian (http://www.transifex.com/otf/torproject/language/mk/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -20,21 +21,21 @@ msgstr "" "Plural-Forms: nplurals=2; plural=(n % 10 == 1 && n % 100 != 11) ? 0 : 1;\n" msgid "Congratulations. This browser is configured to use Tor." -msgstr "Честитаме. Прелистувачот е нагоден за употреба на Tor." +msgstr "Честититки. Прелистувачот е конфигуриран за употреба на Tor." msgid "" "Please refer to the <a href=\"https://www.torproject.org/\">Tor website</a> " "for further information about using Tor safely. You are now free to browse " "the Internet anonymously." -msgstr "Посетете го <a href=\"https://www.torproject.org/\">мрежното месот на Tor</a> за повеќе информации за негова безбедна употреба. Сега слободно можете да го прелистувате семрежјето анонимно." +msgstr "Посетете го <a href=\"https://www.torproject.org/\">мрежното месот на Tor</a> за повеќе информации за негова безбедна употреба. Сега слободно можете да прелистувате на Интернет анонимно." msgid "There is a security update available for Tor Browser." -msgstr "" +msgstr "Достапна е надоградба за Tor прелистувачот." msgid "" "<a href=\"https://www.torproject.org/download/download-easy.html\">Click " "here to go to the download page</a>" -msgstr "<a href=\"https://www.torproject.org/download/download-easy.html\">Стиснете овде за да се префрлите на страницата за преземање</a>" +msgstr "<a href=\"https://www.torproject.org/download/download-easy.html\">Кликнете овде за да одите на страницата за преземање</a>" msgid "Sorry. You are not using Tor." msgstr "За жал, не го користите Tor." @@ -44,7 +45,7 @@ msgid "" "href=\"https://www.torproject.org/\">Tor website</a> and specifically the <a" " href=\"https://www.torproject.org/docs/faq#DoesntWork\">instructions for " "configuring your Tor client</a>." -msgstr "Ако се обидувате да го употребите Tor клиентот, Ве молиме посетете ја <a href=\"https://www.torproject.org/\">веб-локацијата на Tor</a> а особено <a href=\"https://www.torproject.org/docs/faq#DoesntWork\">упатствата за конфигурација на Вашиот instructions Tor клиент</a>." +msgstr "Ако се обидувате да го употребите Tor клиентот, Ве молиме посетете ја <a href=\"https://www.torproject.org/\">веб-локацијата на Tor</a> а особено <a href=\"https://www.torproject.org/docs/faq#DoesntWork\">упатствата за конфигурација на Вашиот Tor клиент</a>." msgid "Sorry, your query failed or an unexpected response was received." msgstr "Жал ни е, но или Вашето барање не успеа или примивме неочекуван одговор." @@ -96,10 +97,10 @@ msgid "JavaScript is disabled." msgstr "Опцијата JavaScript е оневозможена." msgid "However, it does not appear to be Tor Browser." -msgstr "" +msgstr "Како и да е, не изгледа дека е Tor прелистувач." msgid "Run a Relay" -msgstr "" +msgstr "Покрени јазол" msgid "Stay Anonymous" -msgstr "" +msgstr "Останете анонимни"

1 0

[tor/master] On exit, free the event_base and set its pointer to NULL.
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 322abc030e53c7e84ca9f22a47b2965f262f5ffa Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 11 11:33:54 2017 -0500 On exit, free the event_base and set its pointer to NULL. When we didn't do this before, we'd have some still-reachable memory warnings, and we'd find ourselves crashing when we tried to reinitialize libevent. Part of 24581 (don't crash when restarting Tor in-process) --- src/common/compat_libevent.c | 10 ++++++++++ src/common/compat_libevent.h | 1 + src/or/main.c | 1 + 3 files changed, 12 insertions(+) diff --git a/src/common/compat_libevent.c b/src/common/compat_libevent.c index 10489bf29..b5e9cc933 100644 --- a/src/common/compat_libevent.c +++ b/src/common/compat_libevent.c @@ -237,6 +237,16 @@ tor_init_libevent_rng(void) return rv; } +/** + * Un-initialize libevent in preparation for an exit + */ +void +tor_libevent_free_all(void) +{ + event_base_free(the_event_base); + the_event_base = NULL; +} + #if defined(LIBEVENT_VERSION_NUMBER) && \ LIBEVENT_VERSION_NUMBER >= V(2,1,1) && \ !defined(TOR_UNIT_TESTS) diff --git a/src/common/compat_libevent.h b/src/common/compat_libevent.h index 0cdb73fbb..1853e5091 100644 --- a/src/common/compat_libevent.h +++ b/src/common/compat_libevent.h @@ -52,6 +52,7 @@ const char *tor_libevent_get_method(void); void tor_check_libevent_header_compatibility(void); const char *tor_libevent_get_version_str(void); const char *tor_libevent_get_header_version_str(void); +void tor_libevent_free_all(void); int tor_init_libevent_rng(void); diff --git a/src/or/main.c b/src/or/main.c index aae98dd8a..bebe9fff4 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -3388,6 +3388,7 @@ tor_free_all(int postfork) if (!postfork) { release_lockfile(); } + tor_libevent_free_all(); /* Stuff in util.c and address.c*/ if (!postfork) { escaped(NULL);

1 0

[tor/master] Mark libevent unitialized on shutdown.
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 474ca13d6a5e8aa2cf099e92e68eb932b15b2315 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 11 11:37:20 2017 -0500 Mark libevent unitialized on shutdown. This is necessary so that we will reinitialize it on startup. --- src/or/config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/or/config.c b/src/or/config.c index 23184af31..e7d11df07 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -796,6 +796,8 @@ static smartlist_t *configured_ports = NULL; /** True iff we're currently validating options, and any calls to * get_options() are likely to be bugs. */ static int in_option_validation = 0; +/* True iff we've initialized libevent */ +static int libevent_initialized = 0; /** Return the contents of our frontpage string, or NULL if not configured. */ MOCK_IMPL(const char*, @@ -986,6 +988,7 @@ config_free_all(void) tor_free(the_tor_version); have_parsed_cmdline = 0; + libevent_initialized = 0; } /** Make <b>address</b> -- a piece of information related to our operation as @@ -1336,7 +1339,6 @@ options_act_reversible(const or_options_t *old_options, char **msg) { smartlist_t *new_listeners = smartlist_new(); smartlist_t *replaced_listeners = smartlist_new(); - static int libevent_initialized = 0; or_options_t *options = get_options_mutable(); int running_tor = options->command == CMD_RUN_TOR; int set_conn_limit = 0;

1 0

[tor/master] Set DH parameters to NULL on shutdown
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 06ffafcb9d4107297b6e72ee53d6e6db782cbdea Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 11 11:37:54 2017 -0500 Set DH parameters to NULL on shutdown If we don't do this, we will use freed memory on restart. Part of 24581. --- src/common/crypto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/common/crypto.c b/src/common/crypto.c index 575bfd0c0..45aa3a02c 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -3470,6 +3470,8 @@ crypto_global_cleanup(void) if (dh_param_g) BN_clear_free(dh_param_g); + dh_param_p = dh_param_p_tls = dh_param_g = NULL; + #ifndef DISABLE_ENGINES ENGINE_cleanup(); #endif

1 0

[tor/master] Changes file and tor_api.h tweaks for 24581.
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 3b465ebf2eedecfa0659f91a6ed7dc667e7acde7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 11 11:55:41 2017 -0500 Changes file and tor_api.h tweaks for 24581. --- changes/bug24581 | 7 +++++++ src/or/tor_api.h | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/changes/bug24581 b/changes/bug24581 new file mode 100644 index 000000000..d8ddce3cc --- /dev/null +++ b/changes/bug24581 @@ -0,0 +1,7 @@ + o Major features (embedding): + - Tor now has support for restarting in the same process. + Controllers that run Tor using the "tor_api.h" interface can now + restart Tor after Tor has exited. This support is incomplete, however: + we have fixed the crash bugs that prevented it from working at all + before, but many bugs probably remain. Implements ticket 24581. + diff --git a/src/or/tor_api.h b/src/or/tor_api.h index b12ed718c..e7d70c2a6 100644 --- a/src/or/tor_api.h +++ b/src/or/tor_api.h @@ -71,8 +71,9 @@ void tor_main_configuration_free(tor_main_configuration_t *cfg); * fix it. * * BUG 23847: You can only call tor_main() once in a single process; if it - * returns and you call it again, you may crash. This is not intended - * long-term behavior; we are trying to fix it. + * returns and you call it again, you may crash, or you may encounter other + * unexpected behavior. This is not intended long-term behavior; we are + * trying to fix it. * * LIMITATION: You cannot run more than one instance of Tor in the same * process at the same time. Concurrent calls will cause undefined behavior.

1 0

[tor/master] Merge branch 'restart_nocrash'
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 05ac3d0458466bd8ffc69339a4bf8e34088d9d80 Merge: 751595551 3b465ebf2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 11 12:45:25 2018 -0500 Merge branch 'restart_nocrash' changes/bug24581 | 7 +++++++ src/common/compat_libevent.c | 10 ++++++++++ src/common/compat_libevent.h | 1 + src/common/crypto.c | 2 ++ src/or/config.c | 4 +++- src/or/main.c | 1 + src/or/tor_api.h | 5 +++-- 7 files changed, 27 insertions(+), 3 deletions(-)

1 0

[tor/master] Make the warnings about restarting tor in-process more scary.
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 18ea91ee6b3ad2a8088d6fb3361c9a598ceffe83 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 11 12:46:50 2018 -0500 Make the warnings about restarting tor in-process more scary. --- changes/bug24581 | 3 ++- src/or/tor_api.h | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/changes/bug24581 b/changes/bug24581 index d8ddce3cc..9a5daa01c 100644 --- a/changes/bug24581 +++ b/changes/bug24581 @@ -3,5 +3,6 @@ Controllers that run Tor using the "tor_api.h" interface can now restart Tor after Tor has exited. This support is incomplete, however: we have fixed the crash bugs that prevented it from working at all - before, but many bugs probably remain. Implements ticket 24581. + before, but many bugs probably remain, including the possibility of + security issues. Implements ticket 24581. diff --git a/src/or/tor_api.h b/src/or/tor_api.h index e7d70c2a6..7e86c7fec 100644 --- a/src/or/tor_api.h +++ b/src/or/tor_api.h @@ -72,8 +72,8 @@ void tor_main_configuration_free(tor_main_configuration_t *cfg); * * BUG 23847: You can only call tor_main() once in a single process; if it * returns and you call it again, you may crash, or you may encounter other - * unexpected behavior. This is not intended long-term behavior; we are - * trying to fix it. + * unexpected behavior, including possible security issues. This is not + * intended long-term behavior; we are trying to fix it. * * LIMITATION: You cannot run more than one instance of Tor in the same * process at the same time. Concurrent calls will cause undefined behavior.

1 0

[tor/master] On shutdown, mark openssl as uninitialized.
by nickm＠torproject.org 11 Jan '18

11 Jan '18

commit 42751e2123f6dcc87f3992d38c1889f7da981a7b Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 11 12:49:28 2018 -0500 On shutdown, mark openssl as uninitialized. This causes openssl to get completely reinitialized on startup, which is probably a good idea. --- src/common/crypto.c | 9 ++++++++- src/ext/csiphash.c | 6 ++++++ src/ext/siphash.h | 1 + 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/src/common/crypto.c b/src/common/crypto.c index 85bed538e..b519caed0 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -283,11 +283,12 @@ crypto_force_rand_ssleay(void) return 0; } +static int have_seeded_siphash = 0; + /** Set up the siphash key if we haven't already done so. */ int crypto_init_siphash_key(void) { - static int have_seeded_siphash = 0; struct sipkey key; if (have_seeded_siphash) return 0; @@ -3495,6 +3496,12 @@ crypto_global_cleanup(void) tor_free(crypto_openssl_version_str); tor_free(crypto_openssl_header_version_str); + + crypto_early_initialized_ = 0; + crypto_global_initialized_ = 0; + have_seeded_siphash = 0; + siphash_unset_global_key(); + return 0; } diff --git a/src/ext/csiphash.c b/src/ext/csiphash.c index 508e4f6ce..0427c8795 100644 --- a/src/ext/csiphash.c +++ b/src/ext/csiphash.c @@ -123,3 +123,9 @@ void siphash_set_global_key(const struct sipkey *key) the_siphash_key.k1 = key->k1; the_siphash_key_is_set = 1; } + +void siphash_unset_global_key(void) +{ + the_siphash_key_is_set = 0; + memset(&the_siphash_key, 0, sizeof(the_siphash_key)); +} diff --git a/src/ext/siphash.h b/src/ext/siphash.h index d9b34b898..730e49937 100644 --- a/src/ext/siphash.h +++ b/src/ext/siphash.h @@ -9,5 +9,6 @@ uint64_t siphash24(const void *src, unsigned long src_sz, const struct sipkey *k void siphash_set_global_key(const struct sipkey *key); uint64_t siphash24g(const void *src, unsigned long src_sz); +void siphash_unset_global_key(void); #endif

1 0