July 2017 - tor-commits - lists.torproject.org

[tor/maint-0.3.1] Fix build warnings from Coverity related to our BUG macro
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 32b9edeb91a7d9b9752083622d1ce400f45e42ea Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 25 10:14:24 2017 -0400 Fix build warnings from Coverity related to our BUG macro In the Linux kernel, the BUG() macro causes an instant panic. Our BUG() macro is different, however: it generates a nonfatal assertion failure, and is usable as an expression. Additionally, this patch tells util_bug.h to make all assertion failures into fatal conditions when we're building with a static analysis tool, so that the analysis tool can look for instances where they're reachable. Fixes bug 23030. --- changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+) diff --git a/changes/bug23030_029 b/changes/bug23030_029 new file mode 100644 index 000000000..89a1b507d --- /dev/null +++ b/changes/bug23030_029 @@ -0,0 +1,7 @@ + o Minor bugfixes (coverity builds): + - Avoid Coverity build warnings related to our BUG() macro. By + default, Coverity treats BUG() as the Linux kernel does: an + instant abort(). We need to override that so our BUG() macro + doesn't prevent Coverity from analyzing functions that use it. + Fixes bug 23030; bugfix on 0.2.9.1-alpha. + diff --git a/src/common/util_bug.h b/src/common/util_bug.h index e02778110..069580691 100644 --- a/src/common/util_bug.h +++ b/src/common/util_bug.h @@ -58,6 +58,19 @@ * return -1; */ +#ifdef __COVERITY__ +#undef BUG +// Coverity defines this in global headers; let's override it. This is a +// magic coverity-only preprocessor thing. +#nodef BUG(x) ((x)?(__coverity_panic__(),1):0) +#endif + +#if defined(__COVERITY__) || defined(__clang_analyzer__) +// We're running with a static analysis tool: let's treat even nonfatal +// assertion failures as something that we need to avoid. +#define ALL_BUGS_ARE_FATAL +#endif + #ifdef ALL_BUGS_ARE_FATAL #define tor_assert_nonfatal_unreached() tor_assert(0) #define tor_assert_nonfatal(cond) tor_assert((cond))

1 0

[tor/release-0.3.0] Fix build warnings from Coverity related to our BUG macro
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 32b9edeb91a7d9b9752083622d1ce400f45e42ea Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 25 10:14:24 2017 -0400 Fix build warnings from Coverity related to our BUG macro In the Linux kernel, the BUG() macro causes an instant panic. Our BUG() macro is different, however: it generates a nonfatal assertion failure, and is usable as an expression. Additionally, this patch tells util_bug.h to make all assertion failures into fatal conditions when we're building with a static analysis tool, so that the analysis tool can look for instances where they're reachable. Fixes bug 23030. --- changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+) diff --git a/changes/bug23030_029 b/changes/bug23030_029 new file mode 100644 index 000000000..89a1b507d --- /dev/null +++ b/changes/bug23030_029 @@ -0,0 +1,7 @@ + o Minor bugfixes (coverity builds): + - Avoid Coverity build warnings related to our BUG() macro. By + default, Coverity treats BUG() as the Linux kernel does: an + instant abort(). We need to override that so our BUG() macro + doesn't prevent Coverity from analyzing functions that use it. + Fixes bug 23030; bugfix on 0.2.9.1-alpha. + diff --git a/src/common/util_bug.h b/src/common/util_bug.h index e02778110..069580691 100644 --- a/src/common/util_bug.h +++ b/src/common/util_bug.h @@ -58,6 +58,19 @@ * return -1; */ +#ifdef __COVERITY__ +#undef BUG +// Coverity defines this in global headers; let's override it. This is a +// magic coverity-only preprocessor thing. +#nodef BUG(x) ((x)?(__coverity_panic__(),1):0) +#endif + +#if defined(__COVERITY__) || defined(__clang_analyzer__) +// We're running with a static analysis tool: let's treat even nonfatal +// assertion failures as something that we need to avoid. +#define ALL_BUGS_ARE_FATAL +#endif + #ifdef ALL_BUGS_ARE_FATAL #define tor_assert_nonfatal_unreached() tor_assert(0) #define tor_assert_nonfatal(cond) tor_assert((cond))

1 0

[tor/maint-0.3.1] Merge branch 'bug23030_029_v2' into maint-0.2.9
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 0117e2ea0dc09408e2fbc7224e335968af009874 Merge: 6d3c5b8fb 32b9edeb9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:17 2017 -0400 Merge branch 'bug23030_029_v2' into maint-0.2.9 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/master] Merge branch 'maint-0.3.0' into maint-0.3.1
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 431c8d09ee062621d8b826799a667f746a783103 Merge: 30a98c765 18734d3b2 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:22 2017 -0400 Merge branch 'maint-0.3.0' into maint-0.3.1 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/maint-0.3.0] Merge branch 'bug23030_029_v2' into maint-0.2.9
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 0117e2ea0dc09408e2fbc7224e335968af009874 Merge: 6d3c5b8fb 32b9edeb9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:17 2017 -0400 Merge branch 'bug23030_029_v2' into maint-0.2.9 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/release-0.2.9] Merge branch 'bug23030_029_v2' into maint-0.2.9
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 0117e2ea0dc09408e2fbc7224e335968af009874 Merge: 6d3c5b8fb 32b9edeb9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:17 2017 -0400 Merge branch 'bug23030_029_v2' into maint-0.2.9 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/maint-0.3.1] Merge branch 'maint-0.2.9' into maint-0.3.0
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 18734d3b25f3a26fea3fd78e64136da9bcd3836d Merge: 3c017e823 0117e2ea0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:22 2017 -0400 Merge branch 'maint-0.2.9' into maint-0.3.0 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/master] Merge branch 'maint-0.2.9' into maint-0.3.0
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 18734d3b25f3a26fea3fd78e64136da9bcd3836d Merge: 3c017e823 0117e2ea0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:22 2017 -0400 Merge branch 'maint-0.2.9' into maint-0.3.0 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/master] Merge branch 'bug23030_029_v2' into maint-0.2.9
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 0117e2ea0dc09408e2fbc7224e335968af009874 Merge: 6d3c5b8fb 32b9edeb9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 26 12:58:17 2017 -0400 Merge branch 'bug23030_029_v2' into maint-0.2.9 changes/bug23030_029 | 7 +++++++ src/common/util_bug.h | 13 +++++++++++++ 2 files changed, 20 insertions(+)

1 0

[tor/maint-0.3.1] Fix zstd 1.3.0 trouble: Be more respectful of its state machine
by nickm＠torproject.org 26 Jul '17

26 Jul '17

commit 2ae51ed5e20ee045251d9d6ddf12755bca7c9c8c Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jul 14 16:21:51 2017 -0400 Fix zstd 1.3.0 trouble: Be more respectful of its state machine In zstd 1.3.0, once you have called ZSTD_endStream and been told that your putput buffer is full, it really doesn't want you to call ZSTD_compressStream again. ZSTD 1.2.0 didn't seem to mind about this. This patch fixes the issue by making sure never to call ZSTD_endStream if there's any more data on the input buffer to process, by flushing even when we're about to call "endStream", and by never calling "compress" or "flush" after "endStream". --- changes/bug22927 | 6 ++++++ src/common/compress_zstd.c | 29 +++++++++++++++++++++++------ 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/changes/bug22927 b/changes/bug22927 new file mode 100644 index 000000000..6e68e6ff0 --- /dev/null +++ b/changes/bug22927 @@ -0,0 +1,6 @@ + o Minor bugfixes (compatibility, zstd): + - Write zstd epilogues correctly when the epilogue requires reallocation + of the output buffer, even with zstd 1.3.0. (Previously, + we worked on 1.2.0 and failed with 1.3.0). Fixes bug 22927; bugfix on + 0.3.1.1-alpha. + diff --git a/src/common/compress_zstd.c b/src/common/compress_zstd.c index a136db48b..94974dec0 100644 --- a/src/common/compress_zstd.c +++ b/src/common/compress_zstd.c @@ -98,6 +98,8 @@ struct tor_zstd_compress_state_t { #endif // HAVE_ZSTD. int compress; /**< True if we are compressing; false if we are inflating */ + int have_called_end; /**< True if we are compressing and we've called + * ZSTD_endStream */ /** Number of bytes read so far. Used to detect compression bombs. */ size_t input_so_far; @@ -270,9 +272,16 @@ tor_zstd_compress_process(tor_zstd_compress_state_t *state, ZSTD_inBuffer input = { *in, *in_len, 0 }; ZSTD_outBuffer output = { *out, *out_len, 0 }; + if (BUG(finish == 0 && state->have_called_end)) { + finish = 1; + } + if (state->compress) { - retval = ZSTD_compressStream(state->u.compress_stream, - &output, &input); + if (! state->have_called_end) + retval = ZSTD_compressStream(state->u.compress_stream, + &output, &input); + else + retval = 0; } else { retval = ZSTD_decompressStream(state->u.decompress_stream, &output, &input); @@ -300,7 +309,7 @@ tor_zstd_compress_process(tor_zstd_compress_state_t *state, return TOR_COMPRESS_ERROR; } - if (state->compress && !finish) { + if (state->compress && !state->have_called_end) { retval = ZSTD_flushStream(state->u.compress_stream, &output); *out = (char *)output.dst + output.pos; @@ -314,16 +323,24 @@ tor_zstd_compress_process(tor_zstd_compress_state_t *state, // ZSTD_flushStream returns 0 if the frame is done, or >0 if it // is incomplete. - if (retval > 0) + if (retval > 0) { return TOR_COMPRESS_BUFFER_FULL; + } } if (!finish) { - // We're not done with the input, so no need to flush. + // The caller says we're not done with the input, so no need to write an + // epilogue. return TOR_COMPRESS_OK; } else if (state->compress) { - retval = ZSTD_endStream(state->u.compress_stream, &output); + if (*in_len) { + // We say that we're not done with the input, so we can't write an + // epilogue. + return TOR_COMPRESS_OK; + } + retval = ZSTD_endStream(state->u.compress_stream, &output); + state->have_called_end = 1; *out = (char *)output.dst + output.pos; *out_len = output.size - output.pos;

1 0