May 2017 - tor-commits - lists.torproject.org

[tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 12 May '17

12 May '17

commit e4848686fd6078cd9cbdf3c8a9fe979f0f9a7283 Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 12 13:05:35 2017 +0000 fixup! TB4: Tor Browser's Firefox preference overrides. Hide the TLS error reporting checkbox for now as Mozilla seems to be the wrong party to get Tor Browser reports. One day we might want to repurpose this checkbox to point to our own infrastructure to help finding bad relays (see bug 19119). Fixes bug 22072. --- browser/app/profile/000-tor-browser.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 98cfec5..956eb2d 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -314,6 +314,11 @@ pref("security.cert_pinning.enforcement_level", 2); // Enforce SHA1 deprecation, see: bug 18042. pref("security.pki.sha1_enforcement_level", 2); +// Avoid report TLS errors to Mozilla. We might want to repurpose this feature +// one day to help detecting bad relays (which is bug 19119). For now we just +// hide the checkbox, see bug 22072. +pref("security.ssl.errorReporting.enabled", false); + // Workaround for https://bugs.torproject.org/13579. Progress on // `about:downloads` is only shown if the following preference is set to `true` // in case the download panel got removed from the toolbar.

1 0

[tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! TB3: Tor Browser's official .mozconfigs.
by gk＠torproject.org 12 May '17

12 May '17

commit b51157dc9a520a693c2fb27ab3213e3bdf1cb5f1 Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 12 14:05:05 2017 +0000 fixup! TB3: Tor Browser's official .mozconfigs. The executables are not PIE anymore with the switch to ESR52. We need to set --enable-pie now even though we still use the hardening wrapper. Fixes #22238, patch by boklm. --- .mozconfig | 1 + .mozconfig-asan | 1 + 2 files changed, 2 insertions(+) diff --git a/.mozconfig b/.mozconfig index cde5b49..4398849 100755 --- a/.mozconfig +++ b/.mozconfig @@ -27,3 +27,4 @@ ac_add_options --disable-webrtc ac_add_options --disable-eme #ac_add_options --disable-ctypes ac_add_options --enable-jemalloc=4 +ac_add_options --enable-pie diff --git a/.mozconfig-asan b/.mozconfig-asan index 096bcc6..87e5008 100644 --- a/.mozconfig-asan +++ b/.mozconfig-asan @@ -41,3 +41,4 @@ ac_add_options --disable-crashreporter ac_add_options --disable-webrtc #ac_add_options --disable-ctypes ac_add_options --disable-eme +ac_add_options --enable-pie

1 0

[tor/master] Untangle cleanup logic in test_hs_intropoint.c
by nickm＠torproject.org 12 May '17

12 May '17

commit 61a367cadd235dacf3cdc5543ba261dfee66f5d4 Author: Taylor Yu <catalyst(a)torproject.org> Date: Thu May 11 12:55:18 2017 -0400 Untangle cleanup logic in test_hs_intropoint.c Cleanup logic in test_intro_point_registration() invoked tt_assert() in a way that could cause it to jump backward into the cleanup code if the assertion failed, causing Coverity to see a double free (CID 1397192). Move the tt_assert() calls into a helper function having the well-defined task of testing hs_circuitmap_free_all(). Fixes #22231. --- src/test/test_hs_intropoint.c | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/src/test/test_hs_intropoint.c b/src/test/test_hs_intropoint.c index ef5cb46..c619787 100644 --- a/src/test/test_hs_intropoint.c +++ b/src/test/test_hs_intropoint.c @@ -503,6 +503,24 @@ helper_establish_intro_v2(or_circuit_t *intro_circ) return key1; } +/* Helper function: test circuitmap free_all function outside of + * test_intro_point_registration to prevent Coverity from seeing a + * double free if the assertion hypothetically fails. + */ +static void +test_circuitmap_free_all(void) +{ + hs_circuitmap_ht *the_hs_circuitmap = NULL; + + the_hs_circuitmap = get_hs_circuitmap(); + tt_assert(the_hs_circuitmap); + hs_circuitmap_free_all(); + the_hs_circuitmap = get_hs_circuitmap(); + tt_assert(!the_hs_circuitmap); + done: + ; +} + /** Successfuly register a v2 intro point and a v3 intro point. Ensure that HS * circuitmap is maintained properly. */ static void @@ -583,14 +601,7 @@ test_intro_point_registration(void *arg) circuit_free(TO_CIRCUIT(intro_circ)); circuit_free(TO_CIRCUIT(legacy_intro_circ)); trn_cell_establish_intro_free(establish_intro_cell); - - { /* Test circuitmap free_all function. */ - the_hs_circuitmap = get_hs_circuitmap(); - tt_assert(the_hs_circuitmap); - hs_circuitmap_free_all(); - the_hs_circuitmap = get_hs_circuitmap(); - tt_assert(!the_hs_circuitmap); - } + test_circuitmap_free_all(); UNMOCK(hs_intro_send_intro_established_cell); }

1 0

[tor/master] Enable some windows hardening features
by nickm＠torproject.org 12 May '17

12 May '17

commit 503f101d2b1d8dfdd17cc2aa79fc10d79eecd04c Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu May 11 16:39:02 2017 -0400 Enable some windows hardening features One (HeapEnableTerminationOnCorruption) is on-by-default since win8; the other (PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION) supposedly only affects ATL, which (we think) we don't use. Still, these are good hygiene. Closes ticket 21953. --- changes/ticket21953 | 6 ++++++ src/or/main.c | 7 ++++++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/changes/ticket21953 b/changes/ticket21953 new file mode 100644 index 0000000..7cc84f5 --- /dev/null +++ b/changes/ticket21953 @@ -0,0 +1,6 @@ + o Minor features: + - Enable a couple of pieces of Windows hardening: one + (HeapEnableTerminationOnCorruption) that has been on-by-default since + Windows 8, and unavailable before Windows 7, and one + (PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION) which we believe doesn't + affect us, but shouldn't do any harm. Closes ticket 21953. diff --git a/src/or/main.c b/src/or/main.c index 66a8571..2de8ed2 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -3426,6 +3426,8 @@ tor_main(int argc, char *argv[]) int result = 0; #ifdef _WIN32 + /* On heap corruption, just give up; don't try to play along. */ + HeapSetInformation(NULL, HeapEnableTerminationOnCorruption, NULL, 0); /* Call SetProcessDEPPolicy to permanently enable DEP. The function will not resolve on earlier versions of Windows, and failure is not dangerous. */ @@ -3434,7 +3436,10 @@ tor_main(int argc, char *argv[]) typedef BOOL (WINAPI *PSETDEP)(DWORD); PSETDEP setdeppolicy = (PSETDEP)GetProcAddress(hMod, "SetProcessDEPPolicy"); - if (setdeppolicy) setdeppolicy(1); /* PROCESS_DEP_ENABLE */ + if (setdeppolicy) { + /* PROCESS_DEP_ENABLE | PROCESS_DEP_DISABLE_ATL_THUNK_EMULATION */ + setdeppolicy(3); + } } #endif

1 0

[tor/master] Merge branch 'ticket21953_029'
by nickm＠torproject.org 12 May '17

12 May '17

commit 44102714460aafe59d77fdba0b1101a7bea8ab75 Merge: 61a367c 503f101 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri May 12 08:40:30 2017 -0400 Merge branch 'ticket21953_029' changes/ticket21953 | 6 ++++++ src/or/main.c | 7 ++++++- 2 files changed, 12 insertions(+), 1 deletion(-)

1 0

[tor-browser-build/master] Add ChangeLog.txt symlink
by boklm＠torproject.org 12 May '17

12 May '17

commit 905f80c552d967413df71790b11f85df5880c9ca Author: Nicolas Vigier <boklm(a)torproject.org> Date: Fri May 12 13:47:51 2017 +0200 Add ChangeLog.txt symlink --- ChangeLog.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog.txt b/ChangeLog.txt new file mode 120000 index 0000000..e9fcf5d --- /dev/null +++ b/ChangeLog.txt @@ -0,0 +1 @@ +projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt \ No newline at end of file

1 0

[tor-browser-build/master] Bug 20761: Tor Browser 6.5a4 is ignoring additional SocksPorts
by boklm＠torproject.org 12 May '17

12 May '17

commit 6395f3e322cfea745c6d0521d407ac5d68a0fe36 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue Jan 31 11:49:41 2017 -0500 Bug 20761: Tor Browser 6.5a4 is ignoring additional SocksPorts Remove the SocksPort and ControlPort configuration from torrc-defaults. Tor Launcher configures the ports via args when starting tor, and we must avoid conflicts. Also, strengthen the warning to users about not editing torrc-defaults. --- projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults | 8 +++----- .../Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults | 8 +++----- projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults | 8 +++----- 3 files changed, 9 insertions(+), 15 deletions(-) diff --git a/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults b/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults index 0a87e5f..f383525 100644 --- a/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults +++ b/projects/tor-browser/Bundle-Data/linux/Data/Tor/torrc-defaults @@ -1,6 +1,8 @@ # torrc-defaults for Tor Browser # -# This file is distributed with Tor Browser and should not be modified (it +# DO NOT EDIT THIS FILE +# +# This file is distributed with Tor Browser and SHOULD NOT be modified (it # may be overwritten during the next Tor Browser update). To customize your # Tor configuration, shut down Tor Browser and edit the torrc file. # @@ -9,8 +11,4 @@ AvoidDiskWrites 1 # Where to send logging messages. Format is minSeverity[-maxSeverity] # (stderr|stdout|syslog|file FILENAME). Log notice stdout -# Bind to this address to listen to connections from SOCKS-speaking -# applications. -SocksPort 9150 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth -ControlPort 9151 CookieAuthentication 1 diff --git a/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults b/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults index 0a87e5f..f383525 100644 --- a/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults +++ b/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Tor/torrc-defaults @@ -1,6 +1,8 @@ # torrc-defaults for Tor Browser # -# This file is distributed with Tor Browser and should not be modified (it +# DO NOT EDIT THIS FILE +# +# This file is distributed with Tor Browser and SHOULD NOT be modified (it # may be overwritten during the next Tor Browser update). To customize your # Tor configuration, shut down Tor Browser and edit the torrc file. # @@ -9,8 +11,4 @@ AvoidDiskWrites 1 # Where to send logging messages. Format is minSeverity[-maxSeverity] # (stderr|stdout|syslog|file FILENAME). Log notice stdout -# Bind to this address to listen to connections from SOCKS-speaking -# applications. -SocksPort 9150 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth -ControlPort 9151 CookieAuthentication 1 diff --git a/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults b/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults index 0a87e5f..f383525 100644 --- a/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults +++ b/projects/tor-browser/Bundle-Data/windows/Data/Tor/torrc-defaults @@ -1,6 +1,8 @@ # torrc-defaults for Tor Browser # -# This file is distributed with Tor Browser and should not be modified (it +# DO NOT EDIT THIS FILE +# +# This file is distributed with Tor Browser and SHOULD NOT be modified (it # may be overwritten during the next Tor Browser update). To customize your # Tor configuration, shut down Tor Browser and edit the torrc file. # @@ -9,8 +11,4 @@ AvoidDiskWrites 1 # Where to send logging messages. Format is minSeverity[-maxSeverity] # (stderr|stdout|syslog|file FILENAME). Log notice stdout -# Bind to this address to listen to connections from SOCKS-speaking -# applications. -SocksPort 9150 IPv6Traffic PreferIPv6 KeepAliveIsolateSOCKSAuth -ControlPort 9151 CookieAuthentication 1

1 0

[tor-browser-build/master] Remove FTE from OSX torrc-defaults
by boklm＠torproject.org 12 May '17

12 May '17

commit 747b697d335a023bae8da70671275a6750e7e02d Author: Nicolas Vigier <boklm(a)torproject.org> Date: Fri May 12 13:42:11 2017 +0200 Remove FTE from OSX torrc-defaults --- projects/tor-browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix | 3 --- 1 file changed, 3 deletions(-) diff --git a/projects/tor-browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix b/projects/tor-browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix index f5eb5e4..271b36c 100644 --- a/projects/tor-browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix +++ b/projects/tor-browser/Bundle-Data/PTConfigs/mac/torrc-defaults-appendix @@ -1,6 +1,3 @@ -## fteproxy configuration -ClientTransportPlugin fte exec PluggableTransports/fteproxy.bin --managed - ## obfs4proxy configuration ClientTransportPlugin obfs2,obfs3,obfs4,scramblesuit exec PluggableTransports/obfs4proxy

1 0

[tor-browser-build/master] Fold in stable changelog
by boklm＠torproject.org 12 May '17

12 May '17

commit cab94ec562e71a2e3e379111f35d319f739d1b49 Author: Georg Koppen <gk(a)torproject.org> Date: Tue May 2 09:04:21 2017 +0000 Fold in stable changelog --- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index b2ee463..afe3999 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -83,6 +83,18 @@ Tor Browser 7.0a3 -- April 20 2017 * Bug 21960: Linux bundles based on ESR 52 are not reproducible anymore * Bug 21629: Fix broken ASan builds when switching to ESR 52 +Tor Browser 6.5.2 -- April 19 2017 + * All Platforms + * Update Firefox to 45.9.0esr + * Update HTTPS-Everywhere to 5.2.14 + * Update NoScript to 5.0.2 + * Bug 21555+16450: Don't remove Authorization header on subdomains (e.g. Twitter) + * Bug 19316: Make sure our Windows updates can deal with the SSE2 requirement + * Bug 21917: Add new obfs4 bridges + * Bug 21918: Move meek-amazon to d2cly7j4zqgua7.cloudfront.net backend + * Windows + * Bug 21795: Fix Tor Browser crashing on github.com + Tor Browser 7.0a2-hardened -- March 7 2017 * All Platforms * Update Firefox to 45.8.0esr

1 0

[tor-browser-build/master] Bug 21879: Use our default bookmarks on OSX.
by boklm＠torproject.org 12 May '17

12 May '17

commit a826868cf9771049ae33a710f5a2cd764d99494a Author: Nicolas Vigier <boklm(a)torproject.org> Date: Fri May 12 13:12:47 2017 +0200 Bug 21879: Use our default bookmarks on OSX. Account for the changes Mozilla to support localized default bookmarks (see: https://bugzilla.mozilla.org/show_bug.cgi?id=1235107) Currently, Tor Browser uses the same bookmarks for all locales. tor-browser-bundle.git author: Kathy Brade <brade(a)pearlcrescent.com> tor-browser-bundle.git commit: 57f088b981a0292d5370b3c56c6d7e5a18f95aca --- projects/tor-browser/build | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/projects/tor-browser/build b/projects/tor-browser/build index 084ec7d..69469db 100644 --- a/projects/tor-browser/build +++ b/projects/tor-browser/build @@ -152,11 +152,12 @@ rm -rf chrome/en-US unzip omni.ja defaults/preferences/000-tor-browser.js || [ $? -lt 3 ] cp defaults/preferences/000-tor-browser.js $rootdir [% IF c("var/osx") %] - # Embed our default bookmarks. - mkdir -p defaults/profile/ - cp -p $rootdir/bookmarks.html defaults/profile/ - [% c("var/touch") %] defaults/profile/bookmarks.html - zip -Xm omni.ja defaults/profile/bookmarks.html + # Embed our default bookmarks within the en-US locale. + mkdir -p chrome/en-US/locale/browser + cp -p $rootdir/bookmarks.html chrome/en-US/locale/browser/ + [% c("var/touch") %] chrome/en-US/locale/browser/bookmarks.html + zip -Xm omni.ja chrome/en-US/locale/browser/bookmarks.html + rm -rf chrome [% END %] # Set the locale of the bundle. echo "pref(\"general.useragent.locale\", \"en-US\");" >> defaults/preferences/000-tor-browser.js @@ -165,8 +166,8 @@ zip -Xm omni.ja defaults/preferences/000-tor-browser.js rm -rf defaults popd -# Prepare our language packs for using the proper search engines. See bug -# 18915 for more details. +# Prepare our language packs for using the proper search engines and embed +# our default bookmarks. See bugs 18915 and 21879 for more details. [% FOREACH lang = c('var/locales') %] [% SET lang = tmpl(lang); SET xpi = '$rootdir/' _ c('input_files_by_name/firefox-langpacks') _ '/' _ lang _ '.xpi'; @@ -175,6 +176,9 @@ popd search_plugins_path=prep_[% lang %]/browser/chrome/[% lang %]/locale/browser rm -rf $search_plugins_path/searchplugins cp -rf $rootdir/searchplugins $search_plugins_path + [% IF c("var/osx") -%] + cp $rootdir/bookmarks.html prep_[% lang %]/browser/chrome/[% lang %]/locale/browser/ + [% END -%] rm [% xpi %] cd prep_[% lang %] [% c('zip', {

1 0