tor-commits December 2017

tor-commits@lists.torproject.org

14 participants
2422 discussions

[tor/master] Merge branch 'maint-0.3.2'
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit f5d89fab2525fd8a105f9f0ea9258147bf16290e Merge: 20e9b428c 94c59851d Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 14:22:58 2017 -0500 Merge branch 'maint-0.3.2' "ours" to avoid version bump.

1 0

[tor/release-0.3.2] Increment version to 0.3.2.8-rc-dev
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 94c59851df353442ca5e56119ae4b0affa630e56 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 14:22:54 2017 -0500 Increment version to 0.3.2.8-rc-dev --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index f8c888445..1bd782eb8 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2017, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.2.8-rc]) +AC_INIT([tor],[0.3.2.8-rc-dev]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 40459a951..0f276b49e 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.2.8-rc" +!define VERSION "0.3.2.8-rc-dev" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 674c324f8..133ebf4e3 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.2.8-rc" +#define VERSION "0.3.2.8-rc-dev"

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.2' into release-0.3.2
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 11336cfa0997709176bc912fde71338eaeab3851 Merge: 63b84335d 94c59851d Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 14:23:06 2017 -0500 Merge branch 'maint-0.3.2' into release-0.3.2 configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

1 0

[tor/master] forward-port the 0.3.2.8-rc changelog
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 20e9b428c210913d1a95c43b514f466a56c4833f Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 14:22:30 2017 -0500 forward-port the 0.3.2.8-rc changelog --- ChangeLog | 44 ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/ChangeLog b/ChangeLog index c50bb42ca..d0fbbf01c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,47 @@ +Changes in version 0.3.2.8-rc - 2017-12-21 + Tor 0.3.2.8-rc fixes a pair of bugs in the KIST and KISTLite + schedulers that had led servers under heavy load to overload their + outgoing connections. All relay operators running earlier 0.3.2.x + versions should upgrade. This version also includes a mitigation for + over-full DESTROY queues leading to out-of-memory conditions: if it + works, we will soon backport it to earlier release series. + + This is the second release candidate in the 0.3.2 series. If we find + no new bugs or regression here, then the first stable 0.3.2 release + will be nearly identical to this. + + o Major bugfixes (KIST, scheduler): + - The KIST scheduler did not correctly account for data already + enqueued in each connection's send socket buffer, particularly in + cases when the TCP/IP congestion window was reduced between + scheduler calls. This situation lead to excessive per-connection + buffering in the kernel, and a potential memory DoS. Fixes bug + 24665; bugfix on 0.3.2.1-alpha. + + o Minor features (geoip): + - Update geoip and geoip6 to the December 6 2017 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (hidden service v3): + - Bump hsdir_spread_store parameter from 3 to 4 in order to increase + the probability of reaching a service for a client missing + microdescriptors. Fixes bug 24425; bugfix on 0.3.2.1-alpha. + + o Minor bugfixes (memory usage): + - When queuing DESTROY cells on a channel, only queue the circuit-id + and reason fields: not the entire 514-byte cell. This fix should + help mitigate any bugs or attacks that fill up these queues, and + free more RAM for other uses. Fixes bug 24666; bugfix + on 0.2.5.1-alpha. + + o Minor bugfixes (scheduler, KIST): + - Use a sane write limit for KISTLite when writing onto a connection + buffer instead of using INT_MAX and shoving as much as it can. + Because the OOM handler cleans up circuit queues, we are better + off at keeping them in that queue instead of the connection's + buffer. Fixes bug 24671; bugfix on 0.3.2.1-alpha. + + Changes in version 0.3.2.7-rc - 2017-12-14 Tor 0.3.2.7-rc fixes various bugs in earlier versions of Tor, including some that could affect reliability or correctness.

1 0

[webwml/master] tor 0.3.2.8-rc is released
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit be812bbffdbcd43746e370c0477cfaeac85edb97 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 14:16:53 2017 -0500 tor 0.3.2.8-rc is released --- Makefile | 2 +- include/versions.wmi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8372d43a..4a026e9e 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ # website component, and set it to needs_review. export STABLETAG=tor-0.3.1.9 -export DEVTAG=tor-0.3.2.7-rc +export DEVTAG=tor-0.3.2.8-rc WMLBASE=. SUBDIRS=docs eff projects press about download getinvolved donate docs/torbutton diff --git a/include/versions.wmi b/include/versions.wmi index cd45bf00..b7e019f5 100644 --- a/include/versions.wmi +++ b/include/versions.wmi @@ -1,5 +1,5 @@ <define-tag version-stable whitespace=delete>0.3.1.9</define-tag> -<define-tag version-alpha whitespace=delete>0.3.2.7-rc</define-tag> +<define-tag version-alpha whitespace=delete>0.3.2.8-rc</define-tag> <define-tag version-torbrowserdevelopbranch whitespace=delete>maint-7.0</define-tag>

1 0

[tor/master] scan-build: Replace some test-assertions with fatal assertions
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 713a71702201d80b95605a2af1392a7fb7ab0227 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 13:26:57 2017 -0500 scan-build: Replace some test-assertions with fatal assertions Using tt_assert in these helpers was implying to scan-build that our 'new' functions might be returning NULL, which in turn would make it warn about null-pointer use. --- src/test/test_hs_service.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c index 73200a5a6..3e3a7d8e0 100644 --- a/src/test/test_hs_service.c +++ b/src/test/test_hs_service.c @@ -194,7 +194,7 @@ helper_create_origin_circuit(int purpose, int flags) origin_circuit_t *circ = NULL; circ = origin_circuit_init(purpose, flags); - tt_assert(circ); + tor_assert(circ); circ->cpath = tor_malloc_zero(sizeof(crypt_path_t)); circ->cpath->magic = CRYPT_PATH_MAGIC; circ->cpath->state = CPATH_STATE_OPEN; @@ -206,7 +206,6 @@ helper_create_origin_circuit(int purpose, int flags) /* Create a default HS identifier. */ circ->hs_ident = tor_malloc_zero(sizeof(hs_ident_circuit_t)); - done: return circ; } @@ -219,7 +218,7 @@ helper_create_service(void) { /* Set a service for this circuit. */ hs_service_t *service = hs_service_new(get_options()); - tt_assert(service); + tor_assert(service); service->config.version = HS_VERSION_THREE; ed25519_secret_key_generate(&service->keys.identity_sk, 0); ed25519_public_key_generate(&service->keys.identity_pk, @@ -241,7 +240,7 @@ helper_create_service_ip(void) { hs_desc_link_specifier_t *ls; hs_service_intro_point_t *ip = service_intro_point_new(NULL, 0); - tt_assert(ip); + tor_assert(ip); /* Add a first unused link specifier. */ ls = tor_malloc_zero(sizeof(*ls)); ls->type = LS_IPV4; @@ -252,7 +251,6 @@ helper_create_service_ip(void) memset(ls->u.legacy_id, 'A', sizeof(ls->u.legacy_id)); smartlist_add(ip->base.link_specifiers, ls); - done: return ip; }

1 0

[tor/master] Increment version to 0.3.2.8-rc
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 1a777996651bcc63e3d91391c27c5d6ec46c8015 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 12:42:00 2017 -0500 Increment version to 0.3.2.8-rc --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 608d6864b..f8c888445 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2017, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.2.7-rc-dev]) +AC_INIT([tor],[0.3.2.8-rc]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index e9099b108..40459a951 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.2.7-rc-dev" +!define VERSION "0.3.2.8-rc" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 7def010cd..674c324f8 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.2.7-rc-dev" +#define VERSION "0.3.2.8-rc"

1 0

[tor/master] remove changes files that appear in 0.3.2.8-rc
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 7b9e790956b6af471eababed8092f47671f14efa Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 12:41:25 2017 -0500 remove changes files that appear in 0.3.2.8-rc --- changes/bug24665 | 6 ------ changes/bug24666 | 7 ------- changes/bug24671 | 6 ------ changes/geoip-2017-12-06 | 4 ---- changes/ticket24425 | 4 ---- 5 files changed, 27 deletions(-) diff --git a/changes/bug24665 b/changes/bug24665 deleted file mode 100644 index f950d9dd0..000000000 --- a/changes/bug24665 +++ /dev/null @@ -1,6 +0,0 @@ - o Major bugfixes (KIST, scheduler): - - The KIST scheduler did not correctly account for data already enqueued - in each connection's send socket buffer, particularly in cases when the - TCP/IP congestion window was reduced between scheduler calls. This - situation lead to excessive per-connection buffering in the kernel, and - a potential memory DoS. Fixes bug 24665; bugfix on 0.3.2.1-alpha. diff --git a/changes/bug24666 b/changes/bug24666 deleted file mode 100644 index 830775f5f..000000000 --- a/changes/bug24666 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (memory usage): - - - When queuing DESTROY cells on a channel, only queue the - circuit-id and reason fields: not the entire 514-byte - cell. This fix should help mitigate any bugs or attacks that - fill up these queues, and free more RAM for other uses. Fixes - bug 24666; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug24671 b/changes/bug24671 deleted file mode 100644 index 34d09e704..000000000 --- a/changes/bug24671 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (scheduler, KIST): - - Use a sane write limit for KISTLite when writing onto a connection - buffer instead of using INT_MAX and shoving as much as it can. Because - the OOM handler cleans up circuit queues, we are better off at keeping - them in that queue instead of the connection's buffer. Fixes bug 24671; - bugfix on 0.3.2.1-alpha. diff --git a/changes/geoip-2017-12-06 b/changes/geoip-2017-12-06 deleted file mode 100644 index ae4fb1149..000000000 --- a/changes/geoip-2017-12-06 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (geoip): - - Update geoip and geoip6 to the December 6 2017 Maxmind GeoLite2 - Country database. - diff --git a/changes/ticket24425 b/changes/ticket24425 deleted file mode 100644 index aa6f082bc..000000000 --- a/changes/ticket24425 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (hidden service v3): - - Bump hsdir_spread_store parameter from 3 to 4 in order to increase the - probability of reaching a service for a client missing microdescriptors. - Fixes bug 24425; bugfix on 0.3.2.1-alpha.

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.2' into release-0.3.2
by nickm＠torproject.org 21 Dec '17

21 Dec '17

commit 63b84335dc590499e5f22498383d6a3432e91ec4 Merge: afacaa02a 1a7779966 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 21 12:42:22 2017 -0500 Merge branch 'maint-0.3.2' into release-0.3.2 configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)

1 0

[tor/maint-0.3.2] Increment version to 0.3.2.8-rc
by nickm＠torproject.org 21 Dec '17

21 Dec '17

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits December 2017