December 2017 - tor-commits - lists.torproject.org

[tor/master] Don't consider a port "handled" by an isolated circuit.
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 2bd91dbd346d6dcaa718ad7b952264cbfb713db6 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Tue Dec 5 20:23:02 2017 -0800 Don't consider a port "handled" by an isolated circuit. Previously, circuit_stream_is_being_handled incorrectly reported that (1) an exit port was "handled" by a circuit regardless of whether the circuit was already isolated in some way, and (2) that a stream could be "handled" by a circuit even if their isolation settings were incompatible. As a result of (1), in Tor Browser, circuit_get_unhandled_ports was reporting that all ports were handled even though all non-internal circuits had already been isolated by a SOCKS username+password. Therefore, circuit_predict_and_launch_new was declining to launch new exit circuits. Then, when the user visited a new site in Tor Browser, a stream with new SOCKS credentials would be initiated, and the stream would have to wait while a new circuit with those credentials could be built. That wait was making the time-to-first-byte longer than it needed to be. Now, clean, not-yet-isolated circuit(s) will be automatically launched ahead of time and be ready for use whenever a new stream with new SOCKS credentials (or other isolation criteria) is initiated. Fixes bug 18859. Thanks to Nick Mathewson for improvements. --- changes/bug18859 | 5 +++++ src/or/circuituse.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/changes/bug18859 b/changes/bug18859 new file mode 100644 index 000000000..993074079 --- /dev/null +++ b/changes/bug18859 @@ -0,0 +1,5 @@ + o Minor bugfixes (circuit prediction): + - Fix circuit_stream_is_being_handled so it correctly reports on circuits + with isolation settings. Ports must not be said to be "handled" by + already-isolated circuits, and a stream can only be handled by a circuit + if their isolation settings are compatible. Fixes bug 18859. diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 9f9d3abf7..6378cb8ac 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -973,7 +973,7 @@ circuit_remove_handled_ports(smartlist_t *needed_ports) tor_assert(*port); if (circuit_stream_is_being_handled(NULL, *port, MIN_CIRCUITS_HANDLING_STREAM)) { -// log_debug(LD_CIRC,"Port %d is already being handled; removing.", port); + log_debug(LD_CIRC,"Port %d is already being handled; removing.", *port); smartlist_del(needed_ports, i--); tor_free(port); } else { @@ -1010,6 +1010,10 @@ circuit_stream_is_being_handled(entry_connection_t *conn, continue; if (origin_circ->unusable_for_new_conns) continue; + if (origin_circ->isolation_values_set && + (conn == NULL || + !connection_edge_compatible_with_circuit(conn, origin_circ))) + continue; exitnode = build_state_get_exit_node(build_state); if (exitnode && (!need_uptime || build_state->need_uptime)) {

1 0

[tor/master] Rewrite 18859 changes file from user POV.
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 13049a9866311b30d43b6b8268e57b9631b591f3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:41:00 2017 -0500 Rewrite 18859 changes file from user POV. --- changes/bug18859 | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/changes/bug18859 b/changes/bug18859 index 993074079..1fe5bc210 100644 --- a/changes/bug18859 +++ b/changes/bug18859 @@ -1,5 +1,7 @@ - o Minor bugfixes (circuit prediction): - - Fix circuit_stream_is_being_handled so it correctly reports on circuits - with isolation settings. Ports must not be said to be "handled" by - already-isolated circuits, and a stream can only be handled by a circuit - if their isolation settings are compatible. Fixes bug 18859. + o Major bugfixes (circuit prediction): + - Fix circuit prediction logic so that a client doesn't treat a stream as + being "handled" by a circuit if that circuit already has isolation + settings on it that might make it incompatible with the stream. This + change should make Tor clients more responsive by improving their + chances of having a pre-created circuit ready for use when a new client + request arrives. Fixes bug 18859; bugfix on 0.2.3.3-alpha.

1 0

[tor/master] Merge branch 'arthuredelstein_18859+1_031' into maint-0.3.2
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 4b41ffa64d251268602b06552a53da8cbd60af5c Merge: d4ca18573 13049a986 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:42:49 2017 -0500 Merge branch 'arthuredelstein_18859+1_031' into maint-0.3.2 changes/bug18859 | 7 +++++++ src/or/circuituse.c | 6 +++++- 2 files changed, 12 insertions(+), 1 deletion(-)

1 0

[tor/master] Merge branch 'maint-0.3.2'
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 45b9b2245fc141df26cfda62b93e2acfac1b50e9 Merge: c2c0f83c2 4b41ffa64 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:42:56 2017 -0500 Merge branch 'maint-0.3.2' changes/bug18859 | 7 +++++++ src/or/circuituse.c | 6 +++++- 2 files changed, 12 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.2] Rewrite 18859 changes file from user POV.
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 13049a9866311b30d43b6b8268e57b9631b591f3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:41:00 2017 -0500 Rewrite 18859 changes file from user POV. --- changes/bug18859 | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/changes/bug18859 b/changes/bug18859 index 993074079..1fe5bc210 100644 --- a/changes/bug18859 +++ b/changes/bug18859 @@ -1,5 +1,7 @@ - o Minor bugfixes (circuit prediction): - - Fix circuit_stream_is_being_handled so it correctly reports on circuits - with isolation settings. Ports must not be said to be "handled" by - already-isolated circuits, and a stream can only be handled by a circuit - if their isolation settings are compatible. Fixes bug 18859. + o Major bugfixes (circuit prediction): + - Fix circuit prediction logic so that a client doesn't treat a stream as + being "handled" by a circuit if that circuit already has isolation + settings on it that might make it incompatible with the stream. This + change should make Tor clients more responsive by improving their + chances of having a pre-created circuit ready for use when a new client + request arrives. Fixes bug 18859; bugfix on 0.2.3.3-alpha.

1 0

[tor/release-0.3.2] Merge branch 'arthuredelstein_18859+1_031' into maint-0.3.2
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 4b41ffa64d251268602b06552a53da8cbd60af5c Merge: d4ca18573 13049a986 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:42:49 2017 -0500 Merge branch 'arthuredelstein_18859+1_031' into maint-0.3.2 changes/bug18859 | 7 +++++++ src/or/circuituse.c | 6 +++++- 2 files changed, 12 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.2] Don't consider a port "handled" by an isolated circuit.
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 2bd91dbd346d6dcaa718ad7b952264cbfb713db6 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Tue Dec 5 20:23:02 2017 -0800 Don't consider a port "handled" by an isolated circuit. Previously, circuit_stream_is_being_handled incorrectly reported that (1) an exit port was "handled" by a circuit regardless of whether the circuit was already isolated in some way, and (2) that a stream could be "handled" by a circuit even if their isolation settings were incompatible. As a result of (1), in Tor Browser, circuit_get_unhandled_ports was reporting that all ports were handled even though all non-internal circuits had already been isolated by a SOCKS username+password. Therefore, circuit_predict_and_launch_new was declining to launch new exit circuits. Then, when the user visited a new site in Tor Browser, a stream with new SOCKS credentials would be initiated, and the stream would have to wait while a new circuit with those credentials could be built. That wait was making the time-to-first-byte longer than it needed to be. Now, clean, not-yet-isolated circuit(s) will be automatically launched ahead of time and be ready for use whenever a new stream with new SOCKS credentials (or other isolation criteria) is initiated. Fixes bug 18859. Thanks to Nick Mathewson for improvements. --- changes/bug18859 | 5 +++++ src/or/circuituse.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/changes/bug18859 b/changes/bug18859 new file mode 100644 index 000000000..993074079 --- /dev/null +++ b/changes/bug18859 @@ -0,0 +1,5 @@ + o Minor bugfixes (circuit prediction): + - Fix circuit_stream_is_being_handled so it correctly reports on circuits + with isolation settings. Ports must not be said to be "handled" by + already-isolated circuits, and a stream can only be handled by a circuit + if their isolation settings are compatible. Fixes bug 18859. diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 9f9d3abf7..6378cb8ac 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -973,7 +973,7 @@ circuit_remove_handled_ports(smartlist_t *needed_ports) tor_assert(*port); if (circuit_stream_is_being_handled(NULL, *port, MIN_CIRCUITS_HANDLING_STREAM)) { -// log_debug(LD_CIRC,"Port %d is already being handled; removing.", port); + log_debug(LD_CIRC,"Port %d is already being handled; removing.", *port); smartlist_del(needed_ports, i--); tor_free(port); } else { @@ -1010,6 +1010,10 @@ circuit_stream_is_being_handled(entry_connection_t *conn, continue; if (origin_circ->unusable_for_new_conns) continue; + if (origin_circ->isolation_values_set && + (conn == NULL || + !connection_edge_compatible_with_circuit(conn, origin_circ))) + continue; exitnode = build_state_get_exit_node(build_state); if (exitnode && (!need_uptime || build_state->need_uptime)) {

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.2' into release-0.3.2
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit cd084c2036d19b344bae2bf4d920e6a3256fd7fb Merge: 0c7a540ba 4b41ffa64 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:42:56 2017 -0500 Merge branch 'maint-0.3.2' into release-0.3.2 changes/bug18859 | 7 +++++++ src/or/circuituse.c | 6 +++++- 2 files changed, 12 insertions(+), 1 deletion(-)

1 0

[tor/maint-0.3.2] Don't consider a port "handled" by an isolated circuit.
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 2bd91dbd346d6dcaa718ad7b952264cbfb713db6 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Tue Dec 5 20:23:02 2017 -0800 Don't consider a port "handled" by an isolated circuit. Previously, circuit_stream_is_being_handled incorrectly reported that (1) an exit port was "handled" by a circuit regardless of whether the circuit was already isolated in some way, and (2) that a stream could be "handled" by a circuit even if their isolation settings were incompatible. As a result of (1), in Tor Browser, circuit_get_unhandled_ports was reporting that all ports were handled even though all non-internal circuits had already been isolated by a SOCKS username+password. Therefore, circuit_predict_and_launch_new was declining to launch new exit circuits. Then, when the user visited a new site in Tor Browser, a stream with new SOCKS credentials would be initiated, and the stream would have to wait while a new circuit with those credentials could be built. That wait was making the time-to-first-byte longer than it needed to be. Now, clean, not-yet-isolated circuit(s) will be automatically launched ahead of time and be ready for use whenever a new stream with new SOCKS credentials (or other isolation criteria) is initiated. Fixes bug 18859. Thanks to Nick Mathewson for improvements. --- changes/bug18859 | 5 +++++ src/or/circuituse.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/changes/bug18859 b/changes/bug18859 new file mode 100644 index 000000000..993074079 --- /dev/null +++ b/changes/bug18859 @@ -0,0 +1,5 @@ + o Minor bugfixes (circuit prediction): + - Fix circuit_stream_is_being_handled so it correctly reports on circuits + with isolation settings. Ports must not be said to be "handled" by + already-isolated circuits, and a stream can only be handled by a circuit + if their isolation settings are compatible. Fixes bug 18859. diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 9f9d3abf7..6378cb8ac 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -973,7 +973,7 @@ circuit_remove_handled_ports(smartlist_t *needed_ports) tor_assert(*port); if (circuit_stream_is_being_handled(NULL, *port, MIN_CIRCUITS_HANDLING_STREAM)) { -// log_debug(LD_CIRC,"Port %d is already being handled; removing.", port); + log_debug(LD_CIRC,"Port %d is already being handled; removing.", *port); smartlist_del(needed_ports, i--); tor_free(port); } else { @@ -1010,6 +1010,10 @@ circuit_stream_is_being_handled(entry_connection_t *conn, continue; if (origin_circ->unusable_for_new_conns) continue; + if (origin_circ->isolation_values_set && + (conn == NULL || + !connection_edge_compatible_with_circuit(conn, origin_circ))) + continue; exitnode = build_state_get_exit_node(build_state); if (exitnode && (!need_uptime || build_state->need_uptime)) {

1 0

[tor/maint-0.3.2] Rewrite 18859 changes file from user POV.
by nickm＠torproject.org 07 Dec '17

07 Dec '17

commit 13049a9866311b30d43b6b8268e57b9631b591f3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 7 08:41:00 2017 -0500 Rewrite 18859 changes file from user POV. --- changes/bug18859 | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/changes/bug18859 b/changes/bug18859 index 993074079..1fe5bc210 100644 --- a/changes/bug18859 +++ b/changes/bug18859 @@ -1,5 +1,7 @@ - o Minor bugfixes (circuit prediction): - - Fix circuit_stream_is_being_handled so it correctly reports on circuits - with isolation settings. Ports must not be said to be "handled" by - already-isolated circuits, and a stream can only be handled by a circuit - if their isolation settings are compatible. Fixes bug 18859. + o Major bugfixes (circuit prediction): + - Fix circuit prediction logic so that a client doesn't treat a stream as + being "handled" by a circuit if that circuit already has isolation + settings on it that might make it incompatible with the stream. This + change should make Tor clients more responsive by improving their + chances of having a pre-created circuit ready for use when a new client + request arrives. Fixes bug 18859; bugfix on 0.2.3.3-alpha.

1 0