tor-commits January 2017

tor-commits@lists.torproject.org

22 participants
1796 discussions

[tor-browser-bundle/hardened-builds] Bump NoScript version to 2.9.5.3
by gk＠torproject.org 23 Jan '17

23 Jan '17

commit 97dc2d422e1ff5daf72546a96c87221336527b58 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Jan 18 12:02:15 2017 +0000 Bump NoScript version to 2.9.5.3 --- gitian/versions.alpha | 4 ++-- gitian/versions.nightly | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gitian/versions.alpha b/gitian/versions.alpha index d9ce0cb..da847c6 100755 --- a/gitian/versions.alpha +++ b/gitian/versions.alpha @@ -80,7 +80,7 @@ ELFUTILS_VER=0.160 ## File names for the source packages OPENSSL_PACKAGE=openssl-${OPENSSL_VER}.tar.gz GMP_PACKAGE=gmp-${GMP_VER}.tar.bz2 -NOSCRIPT_PACKAGE=noscript_security_suite-2.9.5.2-fx+sm.xpi +NOSCRIPT_PACKAGE=noscript_security_suite-2.9.5.3-fx+sm.xpi TOOLCHAIN4_OLD_PACKAGE=multiarch-darwin11-cctools127.2-gcc42-5666.3-llvmgcc42-2336.1-Linux-120724.tar.xz CCTOOLS_PACKAGE=cctools.tar.gz OSXSDK_PACKAGE=MacOSX10.7.sdk.tar.gz @@ -115,7 +115,7 @@ GMP_HASH=752079520b4690531171d0f4532e40f08600215feefede70b24fabdc6f1ab160 OSXSDK_HASH=da77bb0003fcca5ea8c4e8cb2da8828ded750c54afdcac29ec6f3b46ad5e3adf OSXSDK_OLD_HASH=6602d8d5ddb371fbc02e2a5967d9bd0cd7358d46f9417753c8234b923f2ea6fc TOOLCHAIN4_OLD_HASH=65c1b2d302358a6b95a26c6828a66908a199276193bb0b268f2dcc1a997731e9 -NOSCRIPT_HASH=ed71ca922790e81bc5e8c6a87bb81f394a38676ac37d1fba518a6a428d128dd5 +NOSCRIPT_HASH=ce9779a3a5a2574b958f8e4d079a99d43a8f84193bef52c587c704ed81c2fbbd CCTOOLS_HASH=e908fdebc2886ee5491ebfc7e7950af451b3c4e2439c2d7a923ed06ad05113e4 MSVCR100_HASH=1221a09484964a6f38af5e34ee292b9afefccb3dc6e55435fd3aaf7c235d9067 PYCRYPTO_HASH=f2ce1e989b272cfcb677616763e0a2e7ec659effa67a88aa92b3a65528f60a3c diff --git a/gitian/versions.nightly b/gitian/versions.nightly index ad3f017..cb196ed 100755 --- a/gitian/versions.nightly +++ b/gitian/versions.nightly @@ -83,7 +83,7 @@ ELFUTILS_VER=0.160 ## File names for the source packages OPENSSL_PACKAGE=openssl-${OPENSSL_VER}.tar.gz GMP_PACKAGE=gmp-${GMP_VER}.tar.bz2 -NOSCRIPT_PACKAGE=noscript_security_suite-2.9.5.2-fx+sm.xpi +NOSCRIPT_PACKAGE=noscript_security_suite-2.9.5.3-fx+sm.xpi TOOLCHAIN4_OLD_PACKAGE=multiarch-darwin11-cctools127.2-gcc42-5666.3-llvmgcc42-2336.1-Linux-120724.tar.xz CCTOOLS_PACKAGE=cctools.tar.gz OSXSDK_PACKAGE=MacOSX10.7.sdk.tar.gz @@ -118,7 +118,7 @@ GMP_HASH=752079520b4690531171d0f4532e40f08600215feefede70b24fabdc6f1ab160 OSXSDK_HASH=da77bb0003fcca5ea8c4e8cb2da8828ded750c54afdcac29ec6f3b46ad5e3adf OSXSDK_OLD_HASH=6602d8d5ddb371fbc02e2a5967d9bd0cd7358d46f9417753c8234b923f2ea6fc TOOLCHAIN4_OLD_HASH=65c1b2d302358a6b95a26c6828a66908a199276193bb0b268f2dcc1a997731e9 -NOSCRIPT_HASH=ed71ca922790e81bc5e8c6a87bb81f394a38676ac37d1fba518a6a428d128dd5 +NOSCRIPT_HASH=ce9779a3a5a2574b958f8e4d079a99d43a8f84193bef52c587c704ed81c2fbbd CCTOOLS_HASH=e908fdebc2886ee5491ebfc7e7950af451b3c4e2439c2d7a923ed06ad05113e4 MSVCR100_HASH=1221a09484964a6f38af5e34ee292b9afefccb3dc6e55435fd3aaf7c235d9067 PYCRYPTO_HASH=f2ce1e989b272cfcb677616763e0a2e7ec659effa67a88aa92b3a65528f60a3c

1 0

[tor/master] clean up changelog for 0.3.0.2-alpha release
by arma＠torproject.org 23 Jan '17

23 Jan '17

commit 4fc0a312870d10ccf0eb3737f61581567795bb9e Author: Roger Dingledine <arma(a)torproject.org> Date: Sun Jan 22 22:08:15 2017 -0500 clean up changelog for 0.3.0.2-alpha release --- ChangeLog | 149 ++++++++++++++++++++++++++++++-------------------------------- 1 file changed, 72 insertions(+), 77 deletions(-) diff --git a/ChangeLog b/ChangeLog index 57b6556..6e7b80e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,19 +1,23 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 - Blurb here. Lorax ipsum gruvvulus thneed amet, snergelly once-ler - lerkim, sed do barbaloot tempor gluppitus ut labore et truffula magna - aliqua. Ut enim ad grickle-grass veniam, quis miff-muffered ga-zumpco - laboris nisi ut cruffulus ex ea schloppity consequat. Duis aute - snarggle in swomeeswans in voluptate axe-hacker esse rippulus crummii - eu moof nulla snuvv. + Tor 0.3.0.2-alpha improves how exit relays and clients handle DNS + time-to-live values, makes directory authorities enforce the 1-to-1 + mapping of relay RSA identity keys to ED25519 identity keys, fixes a + client-side onion service reachability bug, does better at selecting + the set of fallback directories, and more. o Major features (security): - Change the algorithm used to decide DNS TTLs on client and server side, to better resist DNS-based correlation attacks like the DefecTor attack of Greschbach, Pulls, Roberts, Winter, and - Feamster). Now relays only return one of two possible DNS TTL + Feamster. Now relays only return one of two possible DNS TTL values, and clients are willing to believe DNS TTL values up to 3 hours long. Closes ticket 19769. + o Major features (directory authority, security): + - The default for AuthDirPinKeys is now 1: directory authorities + will reject relays where the RSA identity key matches a previously + seen value, but the Ed25519 key has changed. Closes ticket 18319. + o Major bugfixes (client, guard, crash): - In circuit_get_global_origin_list(), return the actual list of origin circuits. The previous version of this code returned the @@ -25,10 +29,10 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 - Fix a client-side onion service reachability bug, where multiple socks requests to an onion service (or a single slow request) could cause us to mistakenly mark some of the service's introduction - points as failed, and we cache that failure so eventually we - run out and can't reach the service. Also resolves a mysterious - "Remote server sent bogus reason code 65021" log warning. The bug - was introduced in task 17218, where we tried to remember the circuit + points as failed, and we cache that failure so eventually we run + out and can't reach the service. Also resolves a mysterious "Remote + server sent bogus reason code 65021" log warning. The bug was + introduced in ticket 17218, where we tried to remember the circuit end reason as a uint16_t, which mangled negative values. Partially fixes bug 21056 and fixes bug 20307; bugfix on 0.2.8.1-alpha. @@ -36,38 +40,30 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 - Fix a bug that prevented exit nodes from caching DNS records for more than 60 seconds. Fixes bug 19025; bugfix on 0.2.4.7-alpha. - o Minor features (directory authority, security): - - The default for AuthDirPinKeys is now 1: directory authorities - will reject relays where the RSA identity key matches a previously - seen value, but the Ed25519 key has changed. Closes ticket 18319. - o Minor features (controller): - - Add GETINFO sr/current and sr/previous keys, to expose shared- - random values to the controller. Closes ticket 19925. + - Add "GETINFO sr/current" and "GETINFO sr/previous" keys, to + expose shared-random values to the controller. Closes ticket 19925. o Minor features (entry guards): - Add UseEntryGuards to TEST_OPTIONS_DEFAULT_VALUES in order to not - break regresson tests. - - Require UseEntryGuards when UseBridges is set in order to make + break regression tests. + - Require UseEntryGuards when UseBridges is set, in order to make sure bridges aren't bypassed. Resolves ticket 20502. o Minor features (fallback directories): - - Allow 3 fallbacks per operator. (This is safe now we are choosing - 200 fallbacks.) Closes ticket 20912. - - Display the fingerprint when downloading consensuses from - fallbacks. Closes ticket 20908. - - Exclude relays affected by 20499 from the fallback list. Exclude - known affected versions, and any relay that delivers a stale - consensus, as long as that consensus expired more than 24 hours - ago. Closes ticket 20539. - - Make it easier to change the output sort order of fallbacks. - Closes ticket 20822. - - Provide bandwidth and consensus weight for each candidate fallback - in updateFallbackDirs.py. Closes ticket 20878. + - Select 200 fallback directories for each release. Closes + ticket 20881. + - Allow 3 fallback relays per operator, which is safe now that we are + choosing 200 fallback relays. Closes ticket 20912. + - Exclude relays affected by bug 20499 from the fallback list. Exclude + relays from the fallback list if they are running versions known to + be affected by bug 20499, or if in our tests they deliver a stale + consensus (i.e. one that expired more than 24 hours ago). Closes + ticket 20539. - Reduce the minimum fallback bandwidth to 1 MByte/s. Part of ticket 18828. - Require fallback directories to have the same address and port for - 7 dayss. (Due to the number of relays with enough stability.) + 7 days (now that we have enough relays with this stability). Relays whose OnionOO stability timer is reset on restart by bug 18050 should upgrade to Tor 0.2.8.7 or later, which has a fix for this issue. Closes ticket 20880; maintains short-term fix @@ -76,35 +72,39 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 decaying average), rather than 95%. This allows at least 73% of clients to bootstrap in the first 5 seconds without contacting an authority. Part of ticket 18828. - - Select 200 fallback directories for each release. Closes - ticket 20881. + - Annotate updateFallbackDirs.py with the bandwidth and consensus + weight for each candidate fallback. Closes ticket 20878. + - Make it easier to change the output sort order of fallbacks. + Closes ticket 20822. + - Display the relay fingerprint when downloading consensuses from + fallbacks. Closes ticket 20908. o Minor features (geoip): - Update geoip and geoip6 to the January 4 2017 Maxmind GeoLite2 Country database. - o Minor features (hidden service directories): - - Relays are now willing act as v3 hidden service directories, - regardless of the EnableOnionServicvesV3 parameter. Implements - ticket 19899. + o Minor features (next-gen onion service directories): + - Remove the "EnableOnionServicesV3" consensus parameter that we + introduced in 0.3.0.1-alpha: relays are now always willing to act + as v3 onion service directories. Resolves ticket 19899. o Minor features (linting): - Enhance the changes file linter to warn on Tor versions that are - prefixed with 'tor-'. Closes ticket 21096. + prefixed with "tor-". Closes ticket 21096. o Minor features (logging): - In several places, describe unset ed25519 keys as "<unset>", - rather than "AAAAAAAA...AAA". Closes ticket 21037. + rather than the scary "AAAAAAAA...AAA". Closes ticket 21037. o Minor bugfix (control protocol): - The reply to a "GETINFO config/names" request via the control protocol now spells the type "Dependent" correctly. This is a - breaking change in the control protocol. (It seems to be ignored - by the most common known clients.) Fixes bug 18146; bugfix - on 0.1.1.4-alpha. + breaking change in the control protocol. (The field seems to be + ignored by the most common known controllers.) Fixes bug 18146; + bugfix on 0.1.1.4-alpha. o Minor bugfixes (bug resilience): - - Fix an (unreachable) size_t overflow in base64_decode(). Fixes bug + - Fix an unreachable size_t overflow in base64_decode(). Fixes bug 19222; bugfix on 0.2.0.9-alpha. Found by Guido Vranken; fixed by Hans Jerry Illikainen. @@ -123,9 +123,10 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 installed. Fixes bug 21051; bugfix on 0.2.9.1-alpha. o Minor bugfixes (config): - - Don't assert when trying to get the options list when - LearnCircuitBuildTimeout is set to 0 and we are actually currently - parsing the options. Fixes bug 21062; bugfix on 0.2.9.3-alpha. + - Don't assert on startup when trying to get the options list and + LearnCircuitBuildTimeout is set to 0: we are currently parsing + the options so of course they aren't ready yet. Fixes bug 21062; + bugfix on 0.2.9.3-alpha. o Minor bugfixes (controller): - Make the GETINFO interface for inquiring about entry guards @@ -133,50 +134,45 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 on 0.3.0.1-alpha. o Minor bugfixes (dead code): - - Remove a rendundant check for PidFile changes at runtime in + - Remove a redundant check for PidFile changes at runtime in options_transition_allowed(): this check is already performed regardless of whether the sandbox is active. Fixes bug 21123; - bugfix on commit 2ae47d3 in 0.2.5.4-alpha. + bugfix on 0.2.5.4-alpha. o Minor bugfixes (documentation): - Update the tor manual page to document every option that can not - be changed while tor is running. Fixes bug 21122; bugfix on - multiple tor versions. + be changed while tor is running. Fixes bug 21122. o Minor bugfixes (fallback directories): + - Stop failing when a relay has no uptime data in + updateFallbackDirs.py. Fixes bug 20945; bugfix on 0.2.8.1-alpha. - Avoid checking fallback candidates' DirPorts if they are down in OnionOO. When a relay operator has multiple relays, this - prioritises relays that are up over relays that are down. Fixes + prioritizes relays that are up over relays that are down. Fixes bug 20926; bugfix on 0.2.8.3-alpha. - Stop failing when OUTPUT_COMMENTS is True in updateFallbackDirs.py. Fixes bug 20877; bugfix on 0.2.8.3-alpha. - - Stop failing when a relay has no uptime data in - updateFallbackDirs.py. Fixes bug 20945; bugfix on 0.2.8.1-alpha. o Minor bugfixes (guards, bootstrapping): - When connecting to a directory guard during bootstrap, do not mark the guard as successful until we receive a good-looking directory response from it. Fixes bug 20974; bugfix on 0.3.0.1-alpha. - o Minor bugfixes (hidden service): + o Minor bugfixes (onion services): - Fix the config reload pruning of old vs new services so it - actually works when both ephemeral and non ephemeral services were - configured which lead to a BUG() stacktrace. Fixes bug 21054; - bugfix on 0.3.0.1-alpha. - - Restrict the number of introduction point from 0 to the maximum - allowed instead of the default value to the maximum. That was - stopping operators from using less than 3 introduction points. - Fixes bug 21033; bugfix on 0.2.7.2-alpha. + actually works when both ephemeral and non-ephemeral services are + configured. Fixes bug 21054; bugfix on 0.3.0.1-alpha. + - Allow the number of introduction points to be as low as 0, rather + than as low as 3. Fixes bug 21033; bugfix on 0.2.7.2-alpha. o Minor bugfixes (IPv6): - - Make IP6-using clients try harder to find an IPv6 directory server. - Fixes bug 20999; bugfix on 77a9de0 from 17840 in 0.2.8.2-alpha. - - When IPv6 addresses have not been downloaded, use hard-coded - address info for authorities, fallbacks, and configured bridges. - (When IPv6-only clients receive a microdesc consensus, it has no - IPv6 addresses, so they can't use it until microdescs are - downloaded.) This allows IPv6-only clients to use microdescriptors. - Fixes bug 20996; bugfix on b167e82 from 19608 in 0.2.8.5-alpha. + - Make IPv6-using clients try harder to find an IPv6 directory server. + Fixes bug 20999; bugfix on 0.2.8.2-alpha. + - When IPv6 addresses have not been downloaded yet (microdesc + consensus documents don't list relay IPv6 addresses), use hard-coded + addresses for authorities, fallbacks, and configured bridges. Now + IPv6-only clients can use microdescriptors. Fixes bug 20996; + bugfix on b167e82 from 19608 in 0.2.8.5-alpha. o Minor bugfixes (memory leaks): - Fix a memory leak when configuring hidden services. Fixes bug @@ -190,8 +186,8 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 o Minor bugfixes (relay): - Honor DataDirectoryGroupReadable when tor is a relay. Previously, - the initialization of the keys would reset the DataDirectory to - 0700 instead of 0750 if DataeDirectoryGroupReadable was set to 1. + initializing the keys would reset the DataDirectory to 0700 + instead of 0750 even if DataDirectoryGroupReadable was set to 1. Fixes bug 19953; bugfix on 0.0.2pre16. Patch by "redfish". o Minor bugfixes (testing): @@ -200,9 +196,8 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 o Minor bugfixes (unit tests): - Allow the unit tests to pass even when DNS lookups of bogus - addresses do not fail as expected. Fixes bug 20862 and 20863; - bugfix on unit tests introduced in 0.2.8.1-alpha - through 0.2.9.4-alpha. + addresses do not fail as expected. Fixes bug 20862 and 20863; bugfix + on unit tests introduced in 0.2.8.1-alpha through 0.2.9.4-alpha. o Code simplification and refactoring: - Refactor code to manipulate global_origin_circuit_list into @@ -213,7 +208,7 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 blocks were incorrectly appearing. Closes ticket 20885. o Documentation (man page): - - Clarify a number of options in tor.1 and add some min/max values + - Clarify many options in tor.1 and add some min/max values for HiddenService options. Closes ticket 21058.

1 0

[tor/master] try to explain bug 20307 better
by arma＠torproject.org 23 Jan '17

23 Jan '17

commit 5066facb23ab0481ef255b3c3cec58876ee16ada Author: Roger Dingledine <arma(a)torproject.org> Date: Sun Jan 22 20:51:57 2017 -0500 try to explain bug 20307 better --- ChangeLog | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/ChangeLog b/ChangeLog index d467c95..57b6556 100644 --- a/ChangeLog +++ b/ChangeLog @@ -21,6 +21,17 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 including possible crashes. Fixes bug 21118; bugfix on 0.3.0.1-alpha. + o Major bugfixes (client, onion service): + - Fix a client-side onion service reachability bug, where multiple + socks requests to an onion service (or a single slow request) could + cause us to mistakenly mark some of the service's introduction + points as failed, and we cache that failure so eventually we + run out and can't reach the service. Also resolves a mysterious + "Remote server sent bogus reason code 65021" log warning. The bug + was introduced in task 17218, where we tried to remember the circuit + end reason as a uint16_t, which mangled negative values. Partially + fixes bug 21056 and fixes bug 20307; bugfix on 0.2.8.1-alpha. + o Major bugfixes (DNS): - Fix a bug that prevented exit nodes from caching DNS records for more than 60 seconds. Fixes bug 19025; bugfix on 0.2.4.7-alpha. @@ -102,15 +113,6 @@ Changes in version 0.3.0.2-alpha - 2017-01-23 prevent similar issues in the future. Fixes bug 20990; bugfix on 0.1.0.1-rc. - o Minor bugfixes (circuit, hidden service): - - When closing a circuit, the reason for doing so was assigned from - an int value to a uint16_t which is quite a problem for negative - values that are our internal reasons (ex: - END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS side, this was - causing introduction points to be flagged as unusable because the - reason wasn't the right one due to the bad conversion. Partially - fixes bug 21056 and fixes bug 20307; bugfix on 0.2.8.1-alpha. - o Minor bugfixes (client, guards): - Fix bug where Tor would think that there are circuits waiting for better guards even though those circuits have been freed. Fixes

1 0

[tor/master] oh, here it is
by nickm＠torproject.org 23 Jan '17

23 Jan '17

commit d78ed9fb7362ed5662a5fee52ec69b977bdbf7ec Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jan 22 19:40:30 2017 -0500 oh, here it is --- ChangeLog | 217 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 217 insertions(+) diff --git a/ChangeLog b/ChangeLog index 013dddf..d467c95 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,220 @@ +Changes in version 0.3.0.2-alpha - 2017-01-23 + Blurb here. Lorax ipsum gruvvulus thneed amet, snergelly once-ler + lerkim, sed do barbaloot tempor gluppitus ut labore et truffula magna + aliqua. Ut enim ad grickle-grass veniam, quis miff-muffered ga-zumpco + laboris nisi ut cruffulus ex ea schloppity consequat. Duis aute + snarggle in swomeeswans in voluptate axe-hacker esse rippulus crummii + eu moof nulla snuvv. + + o Major features (security): + - Change the algorithm used to decide DNS TTLs on client and server + side, to better resist DNS-based correlation attacks like the + DefecTor attack of Greschbach, Pulls, Roberts, Winter, and + Feamster). Now relays only return one of two possible DNS TTL + values, and clients are willing to believe DNS TTL values up to 3 + hours long. Closes ticket 19769. + + o Major bugfixes (client, guard, crash): + - In circuit_get_global_origin_list(), return the actual list of + origin circuits. The previous version of this code returned the + list of all the circuits, and could have caused strange bugs, + including possible crashes. Fixes bug 21118; bugfix + on 0.3.0.1-alpha. + + o Major bugfixes (DNS): + - Fix a bug that prevented exit nodes from caching DNS records for + more than 60 seconds. Fixes bug 19025; bugfix on 0.2.4.7-alpha. + + o Minor features (directory authority, security): + - The default for AuthDirPinKeys is now 1: directory authorities + will reject relays where the RSA identity key matches a previously + seen value, but the Ed25519 key has changed. Closes ticket 18319. + + o Minor features (controller): + - Add GETINFO sr/current and sr/previous keys, to expose shared- + random values to the controller. Closes ticket 19925. + + o Minor features (entry guards): + - Add UseEntryGuards to TEST_OPTIONS_DEFAULT_VALUES in order to not + break regresson tests. + - Require UseEntryGuards when UseBridges is set in order to make + sure bridges aren't bypassed. Resolves ticket 20502. + + o Minor features (fallback directories): + - Allow 3 fallbacks per operator. (This is safe now we are choosing + 200 fallbacks.) Closes ticket 20912. + - Display the fingerprint when downloading consensuses from + fallbacks. Closes ticket 20908. + - Exclude relays affected by 20499 from the fallback list. Exclude + known affected versions, and any relay that delivers a stale + consensus, as long as that consensus expired more than 24 hours + ago. Closes ticket 20539. + - Make it easier to change the output sort order of fallbacks. + Closes ticket 20822. + - Provide bandwidth and consensus weight for each candidate fallback + in updateFallbackDirs.py. Closes ticket 20878. + - Reduce the minimum fallback bandwidth to 1 MByte/s. Part of + ticket 18828. + - Require fallback directories to have the same address and port for + 7 dayss. (Due to the number of relays with enough stability.) + Relays whose OnionOO stability timer is reset on restart by bug + 18050 should upgrade to Tor 0.2.8.7 or later, which has a fix for + this issue. Closes ticket 20880; maintains short-term fix + in 0.2.8.2-alpha. + - Require fallbacks to have flags for 90% of the time (weighted + decaying average), rather than 95%. This allows at least 73% of + clients to bootstrap in the first 5 seconds without contacting an + authority. Part of ticket 18828. + - Select 200 fallback directories for each release. Closes + ticket 20881. + + o Minor features (geoip): + - Update geoip and geoip6 to the January 4 2017 Maxmind GeoLite2 + Country database. + + o Minor features (hidden service directories): + - Relays are now willing act as v3 hidden service directories, + regardless of the EnableOnionServicvesV3 parameter. Implements + ticket 19899. + + o Minor features (linting): + - Enhance the changes file linter to warn on Tor versions that are + prefixed with 'tor-'. Closes ticket 21096. + + o Minor features (logging): + - In several places, describe unset ed25519 keys as "<unset>", + rather than "AAAAAAAA...AAA". Closes ticket 21037. + + o Minor bugfix (control protocol): + - The reply to a "GETINFO config/names" request via the control + protocol now spells the type "Dependent" correctly. This is a + breaking change in the control protocol. (It seems to be ignored + by the most common known clients.) Fixes bug 18146; bugfix + on 0.1.1.4-alpha. + + o Minor bugfixes (bug resilience): + - Fix an (unreachable) size_t overflow in base64_decode(). Fixes bug + 19222; bugfix on 0.2.0.9-alpha. Found by Guido Vranken; fixed by + Hans Jerry Illikainen. + + o Minor bugfixes (build): + - Replace obsolete Autoconf macros with their modern equivalent and + prevent similar issues in the future. Fixes bug 20990; bugfix + on 0.1.0.1-rc. + + o Minor bugfixes (circuit, hidden service): + - When closing a circuit, the reason for doing so was assigned from + an int value to a uint16_t which is quite a problem for negative + values that are our internal reasons (ex: + END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS side, this was + causing introduction points to be flagged as unusable because the + reason wasn't the right one due to the bad conversion. Partially + fixes bug 21056 and fixes bug 20307; bugfix on 0.2.8.1-alpha. + + o Minor bugfixes (client, guards): + - Fix bug where Tor would think that there are circuits waiting for + better guards even though those circuits have been freed. Fixes + bug 21142; bugfix on 0.3.0.1-alpha. + + o Minor bugfixes (compilation): + - Fix Libevent detection on platforms without Libevent 1 headers + installed. Fixes bug 21051; bugfix on 0.2.9.1-alpha. + + o Minor bugfixes (config): + - Don't assert when trying to get the options list when + LearnCircuitBuildTimeout is set to 0 and we are actually currently + parsing the options. Fixes bug 21062; bugfix on 0.2.9.3-alpha. + + o Minor bugfixes (controller): + - Make the GETINFO interface for inquiring about entry guards + support the new guards backend. Fixes bug 20823; bugfix + on 0.3.0.1-alpha. + + o Minor bugfixes (dead code): + - Remove a rendundant check for PidFile changes at runtime in + options_transition_allowed(): this check is already performed + regardless of whether the sandbox is active. Fixes bug 21123; + bugfix on commit 2ae47d3 in 0.2.5.4-alpha. + + o Minor bugfixes (documentation): + - Update the tor manual page to document every option that can not + be changed while tor is running. Fixes bug 21122; bugfix on + multiple tor versions. + + o Minor bugfixes (fallback directories): + - Avoid checking fallback candidates' DirPorts if they are down in + OnionOO. When a relay operator has multiple relays, this + prioritises relays that are up over relays that are down. Fixes + bug 20926; bugfix on 0.2.8.3-alpha. + - Stop failing when OUTPUT_COMMENTS is True in updateFallbackDirs.py. + Fixes bug 20877; bugfix on 0.2.8.3-alpha. + - Stop failing when a relay has no uptime data in + updateFallbackDirs.py. Fixes bug 20945; bugfix on 0.2.8.1-alpha. + + o Minor bugfixes (guards, bootstrapping): + - When connecting to a directory guard during bootstrap, do not mark + the guard as successful until we receive a good-looking directory + response from it. Fixes bug 20974; bugfix on 0.3.0.1-alpha. + + o Minor bugfixes (hidden service): + - Fix the config reload pruning of old vs new services so it + actually works when both ephemeral and non ephemeral services were + configured which lead to a BUG() stacktrace. Fixes bug 21054; + bugfix on 0.3.0.1-alpha. + - Restrict the number of introduction point from 0 to the maximum + allowed instead of the default value to the maximum. That was + stopping operators from using less than 3 introduction points. + Fixes bug 21033; bugfix on 0.2.7.2-alpha. + + o Minor bugfixes (IPv6): + - Make IP6-using clients try harder to find an IPv6 directory server. + Fixes bug 20999; bugfix on 77a9de0 from 17840 in 0.2.8.2-alpha. + - When IPv6 addresses have not been downloaded, use hard-coded + address info for authorities, fallbacks, and configured bridges. + (When IPv6-only clients receive a microdesc consensus, it has no + IPv6 addresses, so they can't use it until microdescs are + downloaded.) This allows IPv6-only clients to use microdescriptors. + Fixes bug 20996; bugfix on b167e82 from 19608 in 0.2.8.5-alpha. + + o Minor bugfixes (memory leaks): + - Fix a memory leak when configuring hidden services. Fixes bug + 20987; bugfix on 0.3.0.1-alpha. + + o Minor bugfixes (portability): + - Avoid crashing when Tor is built using headers that contain + CLOCK_MONOTONIC_COARSE, but then tries to run on an older kernel + without CLOCK_MONOTONIC_COARSE. Fixes bug 21035; bugfix + on 0.2.9.1-alpha. + + o Minor bugfixes (relay): + - Honor DataDirectoryGroupReadable when tor is a relay. Previously, + the initialization of the keys would reset the DataDirectory to + 0700 instead of 0750 if DataeDirectoryGroupReadable was set to 1. + Fixes bug 19953; bugfix on 0.0.2pre16. Patch by "redfish". + + o Minor bugfixes (testing): + - Remove undefined behavior from the backtrace generator by removing + its signal handler. Fixes bug 21026; bugfix on 0.2.5.2-alpha. + + o Minor bugfixes (unit tests): + - Allow the unit tests to pass even when DNS lookups of bogus + addresses do not fail as expected. Fixes bug 20862 and 20863; + bugfix on unit tests introduced in 0.2.8.1-alpha + through 0.2.9.4-alpha. + + o Code simplification and refactoring: + - Refactor code to manipulate global_origin_circuit_list into + separate functions. Closes ticket 20921. + + o Documentation (formatting): + - Clean up formatting of tor.1 man page and HTML doc, where <pre> + blocks were incorrectly appearing. Closes ticket 20885. + + o Documentation (man page): + - Clarify a number of options in tor.1 and add some min/max values + for HiddenService options. Closes ticket 21058. + + Changes in version 0.3.0.1-alpha - 2016-12-19 Tor 0.3.0.1-alpha is the first alpha release in the 0.3.0 development series. It strengthens Tor's link and circuit handshakes by

1 0

[tor/master] Begin 0.3.0.2-alpha changelog
by nickm＠torproject.org 23 Jan '17

23 Jan '17

commit 5baa3ec06ea0e80d58b5cf2bcdd3b16636b12fdf Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jan 22 19:05:50 2017 -0500 Begin 0.3.0.2-alpha changelog (Automated sort and format) --- changes/18146 | 5 ----- changes/20885 | 3 --- changes/bug19025 | 4 ---- changes/bug19222 | 4 ---- changes/bug19899 | 5 ----- changes/bug19953 | 6 ------ changes/bug20307 | 7 ------- changes/bug20502 | 5 ----- changes/bug20823 | 5 ----- changes/bug20862 | 6 ------ changes/bug20974 | 5 ----- changes/bug20987 | 3 --- changes/bug20996 | 9 --------- changes/bug21033 | 5 ----- changes/bug21035 | 6 ------ changes/bug21051 | 3 --- changes/bug21054 | 5 ----- changes/bug21058 | 3 --- changes/bug21062 | 4 ---- changes/bug21118 | 6 ------ changes/bug21122 | 4 ---- changes/bug21123 | 5 ----- changes/bug21142 | 4 ---- changes/fallbacks-201612 | 37 ------------------------------------- changes/geoip-january2017 | 4 ---- changes/ticket18319 | 4 ---- changes/ticket19769 | 7 ------- changes/ticket19925 | 3 --- changes/ticket20921 | 4 ---- changes/ticket20990 | 4 ---- changes/ticket21026 | 3 --- changes/ticket21037 | 4 ---- changes/ticket21096 | 3 --- 33 files changed, 185 deletions(-) diff --git a/changes/18146 b/changes/18146 deleted file mode 100644 index 35565da..0000000 --- a/changes/18146 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfix (control protocol): - - The reply to a "GETINFO config/names" request via the control protocol - now spells the type "Dependent" correctly. This is a breaking change in - the control protocol. (It seems to be ignored by the most common known - clients.) Fixes bug 18146; bugfix on 0.1.1.4-alpha. diff --git a/changes/20885 b/changes/20885 deleted file mode 100644 index f1cddda..0000000 --- a/changes/20885 +++ /dev/null @@ -1,3 +0,0 @@ - o Documentation (formatting): - - Clean up formatting of tor.1 man page and HTML doc, where <pre> blocks - were incorrectly appearing. Closes ticket 20885. diff --git a/changes/bug19025 b/changes/bug19025 deleted file mode 100644 index 0f365f5..0000000 --- a/changes/bug19025 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (DNS): - - Fix a bug that prevented exit nodes from caching DNS records for more - than 60 seconds. - Fixes bug 19025; bugfix on 0.2.4.7-alpha. diff --git a/changes/bug19222 b/changes/bug19222 deleted file mode 100644 index 72714e1..0000000 --- a/changes/bug19222 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (bug resilience): - - Fix an (unreachable) size_t overflow in base64_decode(). Fixes bug - 19222; bugfix on 0.2.0.9-alpha. Found by Guido Vranken; fixed by - Hans Jerry Illikainen. diff --git a/changes/bug19899 b/changes/bug19899 deleted file mode 100644 index c4038cf..0000000 --- a/changes/bug19899 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor features (hidden service directories): - - Relays are now willing act as v3 hidden service directories, - regardless of the EnableOnionServicvesV3 parameter. Implements - ticket 19899. - diff --git a/changes/bug19953 b/changes/bug19953 deleted file mode 100644 index 4bfcb0e..0000000 --- a/changes/bug19953 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (relay): - - Honor DataDirectoryGroupReadable when tor is a relay. Previously, the - initialization of the keys would reset the DataDirectory to 0700 instead - of 0750 if DataeDirectoryGroupReadable was set to 1. Fixes bug 19953; - bugfix on 0.0.2pre16. - Patch by "redfish". diff --git a/changes/bug20307 b/changes/bug20307 deleted file mode 100644 index ae9f90b..0000000 --- a/changes/bug20307 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (circuit, hidden service) - - When closing a circuit, the reason for doing so was assigned from an int - value to a uint16_t which is quite a problem for negative values that are - our internal reasons (ex: END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS - side, this was causing introduction points to be flagged as unusable - because the reason wasn't the right one due to the bad conversion. - Partially fixes bug 21056 and fixes bug 20307; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug20502 b/changes/bug20502 deleted file mode 100644 index 1390a0b..0000000 --- a/changes/bug20502 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor features (entry guards): - - Require UseEntryGuards when UseBridges is set in order to make sure - bridges aren't bypassed. Resolves ticket 20502. - - Add UseEntryGuards to TEST_OPTIONS_DEFAULT_VALUES in order to not break - regresson tests. diff --git a/changes/bug20823 b/changes/bug20823 deleted file mode 100644 index 07c52fe..0000000 --- a/changes/bug20823 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (controller): - - Make the GETINFO interface for inquiring about entry guards - support the new guards backend. Fixes bug 20823; bugfix on - 0.3.0.1-alpha. - diff --git a/changes/bug20862 b/changes/bug20862 deleted file mode 100644 index fba98c8..0000000 --- a/changes/bug20862 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (unit tests): - - Allow the unit tests to pass even when DNS lookups of bogus - addresses do not fail as expected. Fixes bug 20862 and 20863; - bugfix on unit tests introduced in 0.2.8.1-alpha through - 0.2.9.4-alpha. - diff --git a/changes/bug20974 b/changes/bug20974 deleted file mode 100644 index febe510..0000000 --- a/changes/bug20974 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (guards, bootstrapping): - - When connecting to a directory guard during bootstrap, do not - mark the guard as successful until we receive a good-looking - directory response from it. Fixes bug 20974; bugfix on 0.3.0.1-alpha. - diff --git a/changes/bug20987 b/changes/bug20987 deleted file mode 100644 index 9922d73..0000000 --- a/changes/bug20987 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (memory leaks): - - Fix a memory leak when configuring hidden services. Fixes bug 20987; - bugfix on 0.3.0.1-alpha. diff --git a/changes/bug20996 b/changes/bug20996 deleted file mode 100644 index b2be805..0000000 --- a/changes/bug20996 +++ /dev/null @@ -1,9 +0,0 @@ - o Minor bugfixes (IPv6): - - Make IP6-using clients try harder to find an IPv6 directory server. - Fixes bug 20999; bugfix on 77a9de0 from 17840 in 0.2.8.2-alpha. - - When IPv6 addresses have not been downloaded, use hard-coded address - info for authorities, fallbacks, and configured bridges. - (When IPv6-only clients receive a microdesc consensus, it has no IPv6 - addresses, so they can't use it until microdescs are downloaded.) - This allows IPv6-only clients to use microdescriptors. - Fixes bug 20996; bugfix on b167e82 from 19608 in 0.2.8.5-alpha. diff --git a/changes/bug21033 b/changes/bug21033 deleted file mode 100644 index f49577a..0000000 --- a/changes/bug21033 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (hidden service): - - Restrict the number of introduction point from 0 to the maximum allowed - instead of the default value to the maximum. That was stopping operators - from using less than 3 introduction points. Fixes bug 21033; bugfix on - 0.2.7.2-alpha. diff --git a/changes/bug21035 b/changes/bug21035 deleted file mode 100644 index bbf3340..0000000 --- a/changes/bug21035 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (portability): - - Avoid crashing when Tor is built using headers that contain - CLOCK_MONOTONIC_COARSE, but then tries to run on an older kernel - without CLOCK_MONOTONIC_COARSE. Fixes bug 21035; bugfix on - 0.2.9.1-alpha. - diff --git a/changes/bug21051 b/changes/bug21051 deleted file mode 100644 index 8bb4f80..0000000 --- a/changes/bug21051 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (compilation): - - Fix Libevent detection on platforms without Libevent 1 headers - installed. Fixes bug 21051; bugfix on 0.2.9.1-alpha. diff --git a/changes/bug21054 b/changes/bug21054 deleted file mode 100644 index 34a0cca..0000000 --- a/changes/bug21054 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (hidden service): - - Fix the config reload pruning of old vs new services so it actually - works when both ephemeral and non ephemeral services were configured - which lead to a BUG() stacktrace. Fixes bug 21054; bugfix on - 0.3.0.1-alpha. diff --git a/changes/bug21058 b/changes/bug21058 deleted file mode 100644 index 8ca2037..0000000 --- a/changes/bug21058 +++ /dev/null @@ -1,3 +0,0 @@ - o Documentation (man page): - - Clarify a number of options in tor.1 and add some min/max values for - HiddenService options. Closes ticket 21058. diff --git a/changes/bug21062 b/changes/bug21062 deleted file mode 100644 index 5e4060e..0000000 --- a/changes/bug21062 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (config): - - Don't assert when trying to get the options list when - LearnCircuitBuildTimeout is set to 0 and we are actually currently - parsing the options. Fixes bug 21062; bugfix on 0.2.9.3-alpha. diff --git a/changes/bug21118 b/changes/bug21118 deleted file mode 100644 index 88e860c..0000000 --- a/changes/bug21118 +++ /dev/null @@ -1,6 +0,0 @@ - o Major bugfixes (client, guard, crash): - - In circuit_get_global_origin_list(), return the actual list of - origin circuits. The previous version of this code returned - the list of all the circuits, and could have caused strange bugs, - including possible crashes. Fixes bug 21118; bugfix on 0.3.0.1-alpha. - diff --git a/changes/bug21122 b/changes/bug21122 deleted file mode 100644 index 72d09b2..0000000 --- a/changes/bug21122 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (documentation): - - Update the tor manual page to document every option that can not be - changed while tor is running. Fixes bug 21122; bugfix on multiple tor - versions. diff --git a/changes/bug21123 b/changes/bug21123 deleted file mode 100644 index cb16580..0000000 --- a/changes/bug21123 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (dead code): - - Remove a rendundant check for PidFile changes at runtime in - options_transition_allowed(): this check is already performed regardless - of whether the sandbox is active. Fixes bug 21123; bugfix on commit - 2ae47d3 in 0.2.5.4-alpha. diff --git a/changes/bug21142 b/changes/bug21142 deleted file mode 100644 index 5ead10d..0000000 --- a/changes/bug21142 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (client, guards): - - Fix bug where Tor would think that there are circuits waiting for better - guards even though those circuits have been freed. Fixes bug 21142; - bugfix on 0.3.0.1-alpha. diff --git a/changes/fallbacks-201612 b/changes/fallbacks-201612 deleted file mode 100644 index b31aceb..0000000 --- a/changes/fallbacks-201612 +++ /dev/null @@ -1,37 +0,0 @@ - o Minor features (fallback directories): - - Select 200 fallback directories for each release. - Closes ticket 20881. - - Provide bandwidth and consensus weight for each candidate fallback in - updateFallbackDirs.py. - Closes ticket 20878. - - Require fallback directories to have the same address and port for - 7 dayss. (Due to the number of relays with enough stability.) Relays - whose OnionOO stability timer is reset on restart by bug 18050 should - upgrade to Tor 0.2.8.7 or later, which has a fix for this issue. - Closes ticket 20880; maintains short-term fix in 0.2.8.2-alpha. - - Make it easier to change the output sort order of fallbacks. - Closes ticket 20822. - - Exclude relays affected by 20499 from the fallback list. Exclude known - affected versions, and any relay that delivers a stale consensus, as - long as that consensus expired more than 24 hours ago. - Closes ticket 20539. - - Require fallbacks to have flags for 90% of the time (weighted decaying - average), rather than 95%. This allows at least 73% of clients to - bootstrap in the first 5 seconds without contacting an authority. - Part of ticket 18828. - - Display the fingerprint when downloading consensuses from fallbacks. - Closes ticket 20908. - - Allow 3 fallbacks per operator. (This is safe now we are choosing 200 - fallbacks.) Closes ticket 20912. - - Reduce the minimum fallback bandwidth to 1 MByte/s. - Part of ticket 18828. - - o Minor bugfixes (fallback directories): - - Stop failing when OUTPUT_COMMENTS is True in updateFallbackDirs.py. - Fixes bug 20877; bugfix on 0.2.8.3-alpha. - - Avoid checking fallback candidates' DirPorts if they are down in - OnionOO. When a relay operator has multiple relays, this prioritises - relays that are up over relays that are down. - Fixes bug 20926; bugfix on 0.2.8.3-alpha. - - Stop failing when a relay has no uptime data in updateFallbackDirs.py. - Fixes bug 20945; bugfix on 0.2.8.1-alpha. diff --git a/changes/geoip-january2017 b/changes/geoip-january2017 deleted file mode 100644 index 77bc9a5..0000000 --- a/changes/geoip-january2017 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (geoip): - - Update geoip and geoip6 to the January 4 2017 Maxmind GeoLite2 - Country database. - diff --git a/changes/ticket18319 b/changes/ticket18319 deleted file mode 100644 index 41c5b56..0000000 --- a/changes/ticket18319 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (directory authority, security): - - The default for AuthDirPinKeys is now 1: directory authorities will - reject relays where the RSA identity key matches a previously seen - value, but the Ed25519 key has changed. Closes ticket 18319. diff --git a/changes/ticket19769 b/changes/ticket19769 deleted file mode 100644 index 9fc05c3..0000000 --- a/changes/ticket19769 +++ /dev/null @@ -1,7 +0,0 @@ - o Major features (security): - - Change the algorithm used to decide DNS TTLs on client and server side, - to better resist DNS-based correlation attacks like the DefecTor attack - of Greschbach, Pulls, Roberts, Winter, and Feamster). Now - relays only return one of two possible DNS TTL values, and clients - are willing to believe DNS TTL values up to 3 hours long. - Closes ticket 19769. diff --git a/changes/ticket19925 b/changes/ticket19925 deleted file mode 100644 index a169aa5..0000000 --- a/changes/ticket19925 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (controller): - - Add GETINFO sr/current and sr/previous keys, to expose shared- - random values to the controller. Closes ticket 19925. diff --git a/changes/ticket20921 b/changes/ticket20921 deleted file mode 100644 index 7bc0074..0000000 --- a/changes/ticket20921 +++ /dev/null @@ -1,4 +0,0 @@ - o Code simplification and refactoring: - - Refactor code to manipulate global_origin_circuit_list into separate - functions. Closes ticket 20921. - diff --git a/changes/ticket20990 b/changes/ticket20990 deleted file mode 100644 index 3dbe441..0000000 --- a/changes/ticket20990 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (build): - - Replace obsolete Autoconf macros with their modern equivalent and - prevent similar issues in the future. Fixes bug 20990; bugfix on - 0.1.0.1-rc. diff --git a/changes/ticket21026 b/changes/ticket21026 deleted file mode 100644 index 530a52c..0000000 --- a/changes/ticket21026 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (testing): - - Remove undefined behavior from the backtrace generator by removing - its signal handler. Fixes bug 21026; bugfix on 0.2.5.2-alpha. diff --git a/changes/ticket21037 b/changes/ticket21037 deleted file mode 100644 index 8507b88..0000000 --- a/changes/ticket21037 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (logging): - - In several places, describe unset ed25519 keys as "<unset>", rather - than "AAAAAAAA...AAA". Closes ticket 21037. - diff --git a/changes/ticket21096 b/changes/ticket21096 deleted file mode 100644 index 4265a3d..0000000 --- a/changes/ticket21096 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (linting): - - Enhance the changes file linter to warn on Tor versions that are - prefixed with 'tor-'. Closes ticket 21096.

1 0

[tor/master] clean up grammar on bug20307 changes file
by nickm＠torproject.org 23 Jan '17

23 Jan '17

commit bcbb2d111bb08a9578d31e0240a24af8137dc766 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Jan 13 18:09:50 2017 -0500 clean up grammar on bug20307 changes file pointed out by toralf on irc --- changes/bug20307 | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/changes/bug20307 b/changes/bug20307 index 6036b99..9112c9c 100644 --- a/changes/bug20307 +++ b/changes/bug20307 @@ -1,7 +1,7 @@ o Minor bugfixes (circuit, hidden service) - - When closing a circuit, the reason for doing so was assigned from a int - value to a uint16_t which is quite a problem for negative value that are + - When closing a circuit, the reason for doing so was assigned from an int + value to a uint16_t which is quite a problem for negative values that are our internal reasons (ex: END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS - side, this was causing introduction point to be flagged as unusable + side, this was causing introduction points to be flagged as unusable because the reason wasn't the right one due to the bad conversion. - Partially fixes #21056 and fixes #20307; Bugfix on tor-0.2.8.1-alpha. + Partially fixes bug 21056 and fixes bug 20307; Bugfix on 0.2.8.1-alpha.

1 0

[tor/master] Merge branch 'maint-0.2.9'
by nickm＠torproject.org 23 Jan '17

23 Jan '17

commit da65bdd3208015d68eb1273393a5215b07eac0a5 Merge: 955846f bcbb2d1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jan 22 19:04:02 2017 -0500 Merge branch 'maint-0.2.9' "ours" merge to avoid taking cherry-picked 20307 fix

1 0

[tor/master] circuit: Change close reasons from uint16_t to int
by nickm＠torproject.org 23 Jan '17

23 Jan '17

commit 96c7ddbc7e8a38385fa0f7b5d810d0bf8bdf6990 Author: David Goulet <dgoulet(a)torproject.org> Date: Thu Dec 22 12:37:42 2016 -0500 circuit: Change close reasons from uint16_t to int When marking for close a circuit, the reason value, a integer, was assigned to a uint16_t converting any negative reasons (internal) to the wrong value. On the HS side, this was causing the client to flag introduction points to be unreachable as the internal reason was wrongfully converted to a positive 16bit value leading to flag 2 out of 3 intro points to be unreachable. Fixes #20307 and partially fixes #21056 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/bug20307 | 7 +++++++ src/or/or.h | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/changes/bug20307 b/changes/bug20307 new file mode 100644 index 0000000..6036b99 --- /dev/null +++ b/changes/bug20307 @@ -0,0 +1,7 @@ + o Minor bugfixes (circuit, hidden service) + - When closing a circuit, the reason for doing so was assigned from a int + value to a uint16_t which is quite a problem for negative value that are + our internal reasons (ex: END_CIRC_REASON_IP_NOW_REDUNDANT). On the HS + side, this was causing introduction point to be flagged as unusable + because the reason wasn't the right one due to the bad conversion. + Partially fixes #21056 and fixes #20307; Bugfix on tor-0.2.8.1-alpha. diff --git a/src/or/or.h b/src/or/or.h index 6671779..b7c67ba 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -2964,11 +2964,11 @@ typedef struct circuit_t { /** For what reason (See END_CIRC_REASON...) is this circuit being closed? * This field is set in circuit_mark_for_close and used later in * circuit_about_to_free. */ - uint16_t marked_for_close_reason; + int marked_for_close_reason; /** As marked_for_close_reason, but reflects the underlying reason for * closing this circuit. */ - uint16_t marked_for_close_orig_reason; + int marked_for_close_orig_reason; /** Unique ID for measuring tunneled network status requests. */ uint64_t dirreq_id;

1 0

[tor/release-0.2.9] clean up grammar on bug20307 changes file
by nickm＠torproject.org 23 Jan '17

23 Jan '17

1 0

[tor/release-0.2.9] Merge branch 'maint-0.2.9' into release-0.2.9
by nickm＠torproject.org 23 Jan '17

23 Jan '17

commit d83aa8c90ad99bed08691240e7320441b811b2d7 Merge: 9899045 bcbb2d1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Sun Jan 22 19:03:25 2017 -0500 Merge branch 'maint-0.2.9' into release-0.2.9 changes/bug20307 | 7 +++++++ src/or/or.h | 4 ++-- 2 files changed, 9 insertions(+), 2 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits January 2017