July 2016 - tor-commits - lists.torproject.org

[tor/release-0.2.8] attempted clarity improvements in changelog.
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 2238e60b9254834a1de04fcafe7c4053350a8a42 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 6 11:36:35 2016 -0400 attempted clarity improvements in changelog. --- ChangeLog | 24 +++++++++++------------- 1 file changed, 11 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index f204bbf..1cea4eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,15 +8,13 @@ Changes in version 0.2.8.5-rc - 2016-07-0? - Urras is no longer a directory authority. Closes ticket 19271. o Major bugfixes (heartbeat): - - Fix a regression that would crash Tor when heartbeats are - disabled. Fixes bug 19454; bugfix on tor-0.2.8.1-alpha. Reported - by "kubaku". + - Fix a regression that would crash Tor when the periodic + "heartbeat" log messages were disabled. Fixes bug 19454; bugfix on + tor-0.2.8.1-alpha. Reported by "kubaku". o Minor features (build): - Tor now again builds with the recent OpenSSL 1.1 development branch (tested against 1.1.0-pre6-dev). Closes ticket 19499. - - o Minor bugfixes (build): - When building manual pages, set the timezone to "UTC", so that the output is reproducible. Fixes bug 19558; bugfix on 0.2.2.9-alpha. Patch from intrigeri. @@ -34,16 +32,16 @@ Changes in version 0.2.8.5-rc - 2016-07-0? on 0.2.8.2-alpha. o Minor bugfixes (logging): - - Reduce excessive logging when directory servers can't be found. - Fixes bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. Patch - by teor. + - Reduce pointlessly verbose log messages when directory servers + can't be found. Fixes bug 18849; bugfix on 0.2.8.3-alpha and + 0.2.8.1-alpha. Patch by teor. - When a fallback directory changes its fingerprint from the hard- coded fingerprint, log a less severe, more explanatory log message. Fixes bug 18812; bugfix on 0.2.8.1-alpha. Patch by teor. - o Minor bugfixes (sandboxing): - - Allow statistics to be written to disk when sandboxing is enabled. - Fixes bugs 19556 and 19957; bugfix on 0.2.5.1-alpha and + o Minor bugfixes (Linux seccomp2 sandboxing): + - Allow statistics to be written to disk when "Sandbox 1" is + enabled. Fixes bugs 19556 and 19957; bugfix on 0.2.5.1-alpha and 0.2.6.1-alpha respectively. o Minor bugfixes (user interface): @@ -58,8 +56,8 @@ Changes in version 0.2.8.5-rc - 2016-07-0? explains how to comment out unsuitable fallbacks in a way that's compatible with the stem fallback parser. - Update fallback whitelist and blacklist based on relay operator - emails. Blacklist unsuitable fallbacks. Resolves ticket 19071. - Patch by teor. + emails. Blacklist unsuitable (non-working, over-volatile) + fallbacks. Resolves ticket 19071. Patch by teor. - Update hard-coded fallback list to remove unsuitable fallbacks. Resolves ticket 19071. Patch by teor.

1 0

[tor/release-0.2.8] Fold another entry into the changelog
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 9baf4d10b4656139e18c178f5c669ef0cd70c057 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 6 10:20:57 2016 -0400 Fold another entry into the changelog --- ChangeLog | 7 +++++++ changes/bug19608 | 6 ------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index a1e7257..f204bbf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -26,6 +26,13 @@ Changes in version 0.2.8.5-rc - 2016-07-0? fallbacks. Fixes bug 19480; bugfix on 0.2.8.3-alpha. Patch by teor. + o Minor bugfixes (IPv6, microdescriptors): + - Don't check node addresses when we only have a routerstatus. This + allows IPv6-only clients to bootstrap by fetching microdescriptors + from fallback directory mirrors. (The microdescriptor consensus + has no IPv6 addresses in it.) Fixes bug 19608; bugfix + on 0.2.8.2-alpha. + o Minor bugfixes (logging): - Reduce excessive logging when directory servers can't be found. Fixes bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. Patch diff --git a/changes/bug19608 b/changes/bug19608 deleted file mode 100644 index 66c2de2..0000000 --- a/changes/bug19608 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (IPv6, microdescriptors): - - Don't check node addresses when we only have a routerstatus. - This allows IPv6-only clients to bootstrap by fetching - microdescriptors from fallback directory mirrors. - (The microdescriptor consensus has no IPv6 addresses in it.) - Fixes bug 19608; bugfix on c281c036 in 0.2.8.2-alpha.

1 0

[tor/release-0.2.8] small edits to changelog
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 3a6cbded53cafd5e86e914703a964feb9922e3a8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 18:57:21 2016 -0400 small edits to changelog --- ChangeLog | 38 ++++++++++++++++---------------------- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/ChangeLog b/ChangeLog index f6b5ef8..a1e7257 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,8 +8,9 @@ Changes in version 0.2.8.5-rc - 2016-07-0? - Urras is no longer a directory authority. Closes ticket 19271. o Major bugfixes (heartbeat): - - Fix regression that crashes Tor when disabling heartbeats. Fixes - bug 19454; bugfix on tor-0.2.8.1-alpha. Reported by "kubaku". + - Fix a regression that would crash Tor when heartbeats are + disabled. Fixes bug 19454; bugfix on tor-0.2.8.1-alpha. Reported + by "kubaku". o Minor features (build): - Tor now again builds with the recent OpenSSL 1.1 development @@ -22,28 +23,21 @@ Changes in version 0.2.8.5-rc - 2016-07-0? o Minor bugfixes (fallback directory selection): - Avoid errors during fallback selection if there are no eligible - fallbacks. Fixes bug 19480; bugfix on ba76910 and 78ec782 in - 0.2.8.3-alpha. Patch by teor. + fallbacks. Fixes bug 19480; bugfix on 0.2.8.3-alpha. Patch + by teor. o Minor bugfixes (logging): - - Reduce excessive logging when directories can't be found. Fixes - bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. Patch + - Reduce excessive logging when directory servers can't be found. + Fixes bug 18849; bugfix on 0.2.8.3-alpha and 0.2.8.1-alpha. Patch by teor. - - When a fallback changes its fingerprint from the hard-coded - fingerprint, log a less severe, more explanatory log message. - Fixes bug 18812; bugfix on 0.2.8.1-alpha. Patch by teor. + - When a fallback directory changes its fingerprint from the hard- + coded fingerprint, log a less severe, more explanatory log + message. Fixes bug 18812; bugfix on 0.2.8.1-alpha. Patch by teor. o Minor bugfixes (sandboxing): - - When sandboxing is enabled, we could not write any stats to disk. - check_or_create_data_subdir("stats"), which prepares the private - stats directory, calls check_private_dir(), which also opens and - not just stats() the directory. Therefore, we need to also allow - open() for the stats dir in our sandboxing setup. Fixes bug 19556; - bugfix on 0.2.5.1-alpha. - - Our sandboxing code would not allow us to write to stats/hidserv- - stats, causing tor to abort while trying to write stats. This was - previously masked by bug 19556. Fixes bug 19557; bugfix - on 0.2.6.1-alpha. + - Allow statistics to be written to disk when sandboxing is enabled. + Fixes bugs 19556 and 19957; bugfix on 0.2.5.1-alpha and + 0.2.6.1-alpha respectively. o Minor bugfixes (user interface): - Remove a warning message "Service [scrubbed] not found after @@ -53,9 +47,9 @@ Changes in version 0.2.8.5-rc - 2016-07-0? pointless and confusing. Fixes bug 19464; bugfix on 0.2.7.2-alpha. o Fallback directory list: - - Add a comment to the generated list that explains how to comment- - out unsuitable fallbacks in a way that's compatible with the stem - fallback parser. + - Add a comment to the generated fallback directory list that + explains how to comment out unsuitable fallbacks in a way that's + compatible with the stem fallback parser. - Update fallback whitelist and blacklist based on relay operator emails. Blacklist unsuitable fallbacks. Resolves ticket 19071. Patch by teor.

1 0

[tor/release-0.2.8] Merge branch 'maint-0.2.7' into maint-0.2.8
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 4f4d77c435d74bdb6359e86ff60c4a4c0d7e45b8 Merge: 8f44d28 7c25b41 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 13:52:18 2016 -0400 Merge branch 'maint-0.2.7' into maint-0.2.8 changes/19271 | 2 ++ 1 file changed, 2 insertions(+)

1 0

[tor/master] When checking if a routerstatus is reachable, don't check the node
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit b167e82f62119c3f25b8294793f0643125fd43c6 Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Wed Jul 6 14:35:01 2016 +1000 When checking if a routerstatus is reachable, don't check the node This fixes #19608, allowing IPv6-only clients to use microdescriptors, while preserving the ability of bridge clients to have some IPv4 bridges and some IPv6 bridges. Fix on c281c036 in 0.2.8.2-alpha. --- changes/bug19608 | 6 ++++++ src/or/policies.c | 36 +++++++++++++++--------------------- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/changes/bug19608 b/changes/bug19608 new file mode 100644 index 0000000..66c2de2 --- /dev/null +++ b/changes/bug19608 @@ -0,0 +1,6 @@ + o Minor bugfixes (IPv6, microdescriptors): + - Don't check node addresses when we only have a routerstatus. + This allows IPv6-only clients to bootstrap by fetching + microdescriptors from fallback directory mirrors. + (The microdescriptor consensus has no IPv6 addresses in it.) + Fixes bug 19608; bugfix on c281c036 in 0.2.8.2-alpha. diff --git a/src/or/policies.c b/src/or/policies.c index f9718b6..50fec3a 100644 --- a/src/or/policies.c +++ b/src/or/policies.c @@ -618,7 +618,7 @@ fascist_firewall_allows_ri_impl(const routerinfo_t *ri, pref_ipv6); } -/** Like fascist_firewall_allows_rs, but doesn't consult the node. */ +/** Like fascist_firewall_allows_rs, but takes pref_ipv6. */ static int fascist_firewall_allows_rs_impl(const routerstatus_t *rs, firewall_connection_t fw_connection, @@ -636,10 +636,11 @@ fascist_firewall_allows_rs_impl(const routerstatus_t *rs, } /** Like fascist_firewall_allows_base(), but takes rs. - * Consults the corresponding node, then falls back to rs if node is NULL. - * This should only happen when there's no valid consensus, and rs doesn't - * correspond to a bridge client's bridge. - */ + * When rs is a fake_status from a dir_server_t, it can have a reachable + * address, even when the corresponding node does not. + * nodes can be missing addresses when there's no consensus (IPv4 and IPv6), + * or when there is a microdescriptor consensus, but no microdescriptors + * (microdescriptors have IPv6, the microdesc consensus does not). */ int fascist_firewall_allows_rs(const routerstatus_t *rs, firewall_connection_t fw_connection, int pref_only) @@ -648,21 +649,15 @@ fascist_firewall_allows_rs(const routerstatus_t *rs, return 0; } - const node_t *node = node_get_by_id(rs->identity_digest); - - if (node) { - return fascist_firewall_allows_node(node, fw_connection, pref_only); - } else { - /* There's no node-specific IPv6 preference, so use the generic IPv6 - * preference instead. */ - const or_options_t *options = get_options(); - int pref_ipv6 = (fw_connection == FIREWALL_OR_CONNECTION - ? fascist_firewall_prefer_ipv6_orport(options) - : fascist_firewall_prefer_ipv6_dirport(options)); + /* We don't have access to the node-specific IPv6 preference, so use the + * generic IPv6 preference instead. */ + const or_options_t *options = get_options(); + int pref_ipv6 = (fw_connection == FIREWALL_OR_CONNECTION + ? fascist_firewall_prefer_ipv6_orport(options) + : fascist_firewall_prefer_ipv6_dirport(options)); - return fascist_firewall_allows_rs_impl(rs, fw_connection, pref_only, - pref_ipv6); - } + return fascist_firewall_allows_rs_impl(rs, fw_connection, pref_only, + pref_ipv6); } /** Return true iff we think our firewall will let us make a connection to @@ -742,8 +737,7 @@ fascist_firewall_allows_dir_server(const dir_server_t *ds, /* A dir_server_t always has a fake_status. As long as it has the same * addresses/ports in both fake_status and dir_server_t, this works fine. * (See #17867.) - * This function relies on fascist_firewall_choose_address_rs looking up the - * node if it can, because that will get the latest info for the relay. */ + * fascist_firewall_allows_rs only checks the addresses in fake_status. */ return fascist_firewall_allows_rs(&ds->fake_status, fw_connection, pref_only); }

1 0

[tor/maint-0.2.8] When checking if a routerstatus is reachable, don't check the node
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit b167e82f62119c3f25b8294793f0643125fd43c6 Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Wed Jul 6 14:35:01 2016 +1000 When checking if a routerstatus is reachable, don't check the node This fixes #19608, allowing IPv6-only clients to use microdescriptors, while preserving the ability of bridge clients to have some IPv4 bridges and some IPv6 bridges. Fix on c281c036 in 0.2.8.2-alpha. --- changes/bug19608 | 6 ++++++ src/or/policies.c | 36 +++++++++++++++--------------------- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/changes/bug19608 b/changes/bug19608 new file mode 100644 index 0000000..66c2de2 --- /dev/null +++ b/changes/bug19608 @@ -0,0 +1,6 @@ + o Minor bugfixes (IPv6, microdescriptors): + - Don't check node addresses when we only have a routerstatus. + This allows IPv6-only clients to bootstrap by fetching + microdescriptors from fallback directory mirrors. + (The microdescriptor consensus has no IPv6 addresses in it.) + Fixes bug 19608; bugfix on c281c036 in 0.2.8.2-alpha. diff --git a/src/or/policies.c b/src/or/policies.c index f9718b6..50fec3a 100644 --- a/src/or/policies.c +++ b/src/or/policies.c @@ -618,7 +618,7 @@ fascist_firewall_allows_ri_impl(const routerinfo_t *ri, pref_ipv6); } -/** Like fascist_firewall_allows_rs, but doesn't consult the node. */ +/** Like fascist_firewall_allows_rs, but takes pref_ipv6. */ static int fascist_firewall_allows_rs_impl(const routerstatus_t *rs, firewall_connection_t fw_connection, @@ -636,10 +636,11 @@ fascist_firewall_allows_rs_impl(const routerstatus_t *rs, } /** Like fascist_firewall_allows_base(), but takes rs. - * Consults the corresponding node, then falls back to rs if node is NULL. - * This should only happen when there's no valid consensus, and rs doesn't - * correspond to a bridge client's bridge. - */ + * When rs is a fake_status from a dir_server_t, it can have a reachable + * address, even when the corresponding node does not. + * nodes can be missing addresses when there's no consensus (IPv4 and IPv6), + * or when there is a microdescriptor consensus, but no microdescriptors + * (microdescriptors have IPv6, the microdesc consensus does not). */ int fascist_firewall_allows_rs(const routerstatus_t *rs, firewall_connection_t fw_connection, int pref_only) @@ -648,21 +649,15 @@ fascist_firewall_allows_rs(const routerstatus_t *rs, return 0; } - const node_t *node = node_get_by_id(rs->identity_digest); - - if (node) { - return fascist_firewall_allows_node(node, fw_connection, pref_only); - } else { - /* There's no node-specific IPv6 preference, so use the generic IPv6 - * preference instead. */ - const or_options_t *options = get_options(); - int pref_ipv6 = (fw_connection == FIREWALL_OR_CONNECTION - ? fascist_firewall_prefer_ipv6_orport(options) - : fascist_firewall_prefer_ipv6_dirport(options)); + /* We don't have access to the node-specific IPv6 preference, so use the + * generic IPv6 preference instead. */ + const or_options_t *options = get_options(); + int pref_ipv6 = (fw_connection == FIREWALL_OR_CONNECTION + ? fascist_firewall_prefer_ipv6_orport(options) + : fascist_firewall_prefer_ipv6_dirport(options)); - return fascist_firewall_allows_rs_impl(rs, fw_connection, pref_only, - pref_ipv6); - } + return fascist_firewall_allows_rs_impl(rs, fw_connection, pref_only, + pref_ipv6); } /** Return true iff we think our firewall will let us make a connection to @@ -742,8 +737,7 @@ fascist_firewall_allows_dir_server(const dir_server_t *ds, /* A dir_server_t always has a fake_status. As long as it has the same * addresses/ports in both fake_status and dir_server_t, this works fine. * (See #17867.) - * This function relies on fascist_firewall_choose_address_rs looking up the - * node if it can, because that will get the latest info for the relay. */ + * fascist_firewall_allows_rs only checks the addresses in fake_status. */ return fascist_firewall_allows_rs(&ds->fake_status, fw_connection, pref_only); }

1 0

[tor/release-0.2.8] Merge branch 'maint-0.2.8' into release-0.2.8
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 8e633d06435e4b78f0ec45ba3b5d81d25aae1d3f Merge: 3a6cbde b167e82 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 6 10:17:16 2016 -0400 Merge branch 'maint-0.2.8' into release-0.2.8 changes/bug19608 | 6 ++++++ src/or/policies.c | 36 +++++++++++++++--------------------- 2 files changed, 21 insertions(+), 21 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.2.8'
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 9c1d8cdd8d22f4004a0dec144527d73656bace2d Merge: 3252550 b167e82 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Jul 6 10:17:22 2016 -0400 Merge branch 'maint-0.2.8' changes/bug19608 | 6 ++++++ src/or/policies.c | 36 +++++++++++++++--------------------- 2 files changed, 21 insertions(+), 21 deletions(-)

1 0

[tor/release-0.2.8] When checking if a routerstatus is reachable, don't check the node
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit b167e82f62119c3f25b8294793f0643125fd43c6 Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Wed Jul 6 14:35:01 2016 +1000 When checking if a routerstatus is reachable, don't check the node This fixes #19608, allowing IPv6-only clients to use microdescriptors, while preserving the ability of bridge clients to have some IPv4 bridges and some IPv6 bridges. Fix on c281c036 in 0.2.8.2-alpha. --- changes/bug19608 | 6 ++++++ src/or/policies.c | 36 +++++++++++++++--------------------- 2 files changed, 21 insertions(+), 21 deletions(-) diff --git a/changes/bug19608 b/changes/bug19608 new file mode 100644 index 0000000..66c2de2 --- /dev/null +++ b/changes/bug19608 @@ -0,0 +1,6 @@ + o Minor bugfixes (IPv6, microdescriptors): + - Don't check node addresses when we only have a routerstatus. + This allows IPv6-only clients to bootstrap by fetching + microdescriptors from fallback directory mirrors. + (The microdescriptor consensus has no IPv6 addresses in it.) + Fixes bug 19608; bugfix on c281c036 in 0.2.8.2-alpha. diff --git a/src/or/policies.c b/src/or/policies.c index f9718b6..50fec3a 100644 --- a/src/or/policies.c +++ b/src/or/policies.c @@ -618,7 +618,7 @@ fascist_firewall_allows_ri_impl(const routerinfo_t *ri, pref_ipv6); } -/** Like fascist_firewall_allows_rs, but doesn't consult the node. */ +/** Like fascist_firewall_allows_rs, but takes pref_ipv6. */ static int fascist_firewall_allows_rs_impl(const routerstatus_t *rs, firewall_connection_t fw_connection, @@ -636,10 +636,11 @@ fascist_firewall_allows_rs_impl(const routerstatus_t *rs, } /** Like fascist_firewall_allows_base(), but takes rs. - * Consults the corresponding node, then falls back to rs if node is NULL. - * This should only happen when there's no valid consensus, and rs doesn't - * correspond to a bridge client's bridge. - */ + * When rs is a fake_status from a dir_server_t, it can have a reachable + * address, even when the corresponding node does not. + * nodes can be missing addresses when there's no consensus (IPv4 and IPv6), + * or when there is a microdescriptor consensus, but no microdescriptors + * (microdescriptors have IPv6, the microdesc consensus does not). */ int fascist_firewall_allows_rs(const routerstatus_t *rs, firewall_connection_t fw_connection, int pref_only) @@ -648,21 +649,15 @@ fascist_firewall_allows_rs(const routerstatus_t *rs, return 0; } - const node_t *node = node_get_by_id(rs->identity_digest); - - if (node) { - return fascist_firewall_allows_node(node, fw_connection, pref_only); - } else { - /* There's no node-specific IPv6 preference, so use the generic IPv6 - * preference instead. */ - const or_options_t *options = get_options(); - int pref_ipv6 = (fw_connection == FIREWALL_OR_CONNECTION - ? fascist_firewall_prefer_ipv6_orport(options) - : fascist_firewall_prefer_ipv6_dirport(options)); + /* We don't have access to the node-specific IPv6 preference, so use the + * generic IPv6 preference instead. */ + const or_options_t *options = get_options(); + int pref_ipv6 = (fw_connection == FIREWALL_OR_CONNECTION + ? fascist_firewall_prefer_ipv6_orport(options) + : fascist_firewall_prefer_ipv6_dirport(options)); - return fascist_firewall_allows_rs_impl(rs, fw_connection, pref_only, - pref_ipv6); - } + return fascist_firewall_allows_rs_impl(rs, fw_connection, pref_only, + pref_ipv6); } /** Return true iff we think our firewall will let us make a connection to @@ -742,8 +737,7 @@ fascist_firewall_allows_dir_server(const dir_server_t *ds, /* A dir_server_t always has a fake_status. As long as it has the same * addresses/ports in both fake_status and dir_server_t, this works fine. * (See #17867.) - * This function relies on fascist_firewall_choose_address_rs looking up the - * node if it can, because that will get the latest info for the relay. */ + * fascist_firewall_allows_rs only checks the addresses in fake_status. */ return fascist_firewall_allows_rs(&ds->fake_status, fw_connection, pref_only); }

1 0

[tor/master] Merge remote-tracking branch 'teor/bug18456'
by nickm＠torproject.org 06 Jul '16

06 Jul '16

commit 78196c8822ec8dda5df95428dbb4ae96ec4d2b7f Merge: dfa41ac 514f004 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Jul 5 19:10:08 2016 -0400 Merge remote-tracking branch 'teor/bug18456' changes/bug18456 | 6 ++++ doc/tor.1.txt | 28 +++++++++++------- src/or/config.c | 3 ++ src/or/control.c | 2 +- src/or/main.c | 8 +++--- src/or/or.h | 8 +++++- src/or/policies.c | 78 ++++++++++++++++++++++++++++++++++++-------------- src/or/policies.h | 7 +++-- src/test/test_policy.c | 34 +++++++++++++++++++++- 9 files changed, 133 insertions(+), 41 deletions(-)

1 0