March 2016 - tor-commits - lists.torproject.org

[tor/master] make changes files pass lintChanges as appropriate
by nickm＠torproject.org 22 Mar '16

22 Mar '16

commit 778e8e604d561a47ca6223a570a691b6dc81128e Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 22 09:59:51 2016 -0400 make changes files pass lintChanges as appropriate --- changes/bug17702 | 2 +- changes/bug18318_ed | 2 +- changes/bug18368 | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/changes/bug17702 b/changes/bug17702 index 4fda36f..eddfe1e 100644 --- a/changes/bug17702 +++ b/changes/bug17702 @@ -1,4 +1,4 @@ - o Major bugfixes: + o Major bugfixes (voting): - Actually enable Ed25519-based directory collation. Previously, the code had been written, but some debugging code that had accidentally been left in the codebase made it stay turned off. diff --git a/changes/bug18318_ed b/changes/bug18318_ed index af39234..268ad02 100644 --- a/changes/bug18318_ed +++ b/changes/bug18318_ed @@ -1,4 +1,4 @@ - o Major bugfixes: + o Major bugfixes (voting): - When generating a vote with keypinning disabled, never include two entries for the same ed25519 identity. This bug was causing authorities to generate votes that they could not parse when a router diff --git a/changes/bug18368 b/changes/bug18368 index 17218d4..628831d 100644 --- a/changes/bug18368 +++ b/changes/bug18368 @@ -1,4 +1,4 @@ - o Minor bugfixes: + o Minor bugfixes (logging): - When logging information about an unparseable networkstatus vote or consensus, do not say "vote" when we mean consensus. Fixes bug 18368; bugfix on 0.2.0.8-alpha.

1 0

[tor/master] Changes file for bug18253
by nickm＠torproject.org 22 Mar '16

22 Mar '16

commit f930824914a1ebf10f502543dbc8bf598be19c3c Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 14 14:09:43 2016 -0400 Changes file for bug18253 --- changes/bug18253 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changes/bug18253 b/changes/bug18253 new file mode 100644 index 0000000..56bc701 --- /dev/null +++ b/changes/bug18253 @@ -0,0 +1,3 @@ + o Minor bugfixes (linux seccomp2 sandbox): + - Fix the sandbox's interoprability with unix sockets under setuid. + Fixes bug 18253; bugfix on 0.2.8.1-alpha.

1 0

[tor/master] Merge remote-tracking branch 'public/bug18253'
by nickm＠torproject.org 22 Mar '16

22 Mar '16

commit ca8423a703803db860ee39906f8b5d362e0f64f2 Merge: 778e8e6 f930824 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 22 10:08:50 2016 -0400 Merge remote-tracking branch 'public/bug18253' changes/bug18253 | 3 ++ src/common/sandbox.c | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++- src/common/sandbox.h | 3 ++ src/or/connection.c | 13 ++++++-- src/or/main.c | 14 +++++++++ 5 files changed, 118 insertions(+), 3 deletions(-)

1 0

[translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties
by translation＠torproject.org 22 Mar '16

22 Mar '16

commit 9c702f70db19dd5913a29396b79aa03006346014 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 22 13:17:23 2016 +0000 Update translations for torbutton-torbuttonproperties --- de/torbutton.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/de/torbutton.properties b/de/torbutton.properties index ca89e29..3e0623b 100644 --- a/de/torbutton.properties +++ b/de/torbutton.properties @@ -76,4 +76,4 @@ profileProblemTitle=%S-Profilproblem profileReadOnly=Es ist nicht möglich %S auf einem nur lesbaren Dateisystem zu starten. Bitte kopiere %S an einen anderen Ort bevor Sie es benutzen. profileReadOnlyMac=Es ist nicht möglich %S auf einem nur lesbaren Dateisystem zu starten. Bitte %S auf Ihren Schreibtisch oder den Anwendungsordner kopieren, bevor Sie es benutzen. profileAccessDenied=%S hat keine Berechtigung um dieses Profil abzurufen. Bitte die Berechtigungen Ihres Dateisystems einstellen und es noch einmal probieren. -profileMigrationFailed=Migration of your existing %S profile failed.\nNew settings will be used. +profileMigrationFailed=Übernahme des bestehenden %S Profils ist fehlgeschlagen.\nEs werden neue Einstellungen verwendet.

1 0

[translation/tor-launcher-properties_completed] Update translations for tor-launcher-properties_completed
by translation＠torproject.org 22 Mar '16

22 Mar '16

commit e7d243b0501627591078fc45d179cd37f535dee7 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 22 13:16:33 2016 +0000 Update translations for tor-launcher-properties_completed --- de/torlauncher.properties | 6 +++--- hu/torlauncher.properties | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/de/torlauncher.properties b/de/torlauncher.properties index 0da42da..20aa8b3 100644 --- a/de/torlauncher.properties +++ b/de/torlauncher.properties @@ -1,4 +1,4 @@ -### Copyright (c) 2014, The Tor Project, Inc. +### Copyright (c) 2016, The Tor Project, Inc. ### See LICENSE for licensing information. torlauncher.error_title=Tor-Starter @@ -13,8 +13,8 @@ torlauncher.tor_bootstrap_failed_details=%1$S gescheitert (%2$S). torlauncher.unable_to_start_tor=Tor kann nicht gestartet werden.\n\n%S torlauncher.tor_missing=Die Tor-Programmdatei ist nicht vorhanden. -torlauncher.torrc_missing=Die torrc-Datei ist nicht vorhanden. -torlauncher.datadir_missing=Das Tor-Datenverzeichniss existiert nicht. +torlauncher.torrc_missing=Die torrc Datei fehlt und konnte nicht erstellt werden. +torlauncher.datadir_missing=Das Tor Dateiverzeichnis existiert nicht und konnte nicht erstellt werden. torlauncher.password_hash_missing=Erhalt des Hash-Passwortes ist fehlgeschlagen. torlauncher.failed_to_get_settings=Die Tor-Einstellungen können nicht abgefragt werden.\n\n%S diff --git a/hu/torlauncher.properties b/hu/torlauncher.properties index d2b6ea2..82ef206 100644 --- a/hu/torlauncher.properties +++ b/hu/torlauncher.properties @@ -1,4 +1,4 @@ -### Copyright (c) 2014, The Tor Project, Inc. +### Copyright (c) 2016, The Tor Project, Inc. ### See LICENSE for licensing information. torlauncher.error_title=Tor Indító @@ -13,8 +13,8 @@ torlauncher.tor_bootstrap_failed_details=%1$S hiba (%2$S). torlauncher.unable_to_start_tor=Nem sikerült a Tor-t elindítani.\n\n%S torlauncher.tor_missing=A Tor futtatható állomány hiányzik. -torlauncher.torrc_missing=A torrc fájl hiányzik. -torlauncher.datadir_missing=A Tor adat könyvtár nem létezik. +torlauncher.torrc_missing=A torrc fájl hiányzik és nem lehet létrehozni. +torlauncher.datadir_missing=A Tor data könyvtár nem létezik és nem lehet létrehozni. torlauncher.password_hash_missing=Nem sikerült megszerezni a hash-elt jelszót. torlauncher.failed_to_get_settings=Sikertelen a Tor beállítások lekérése.\n\n%S

1 0

[translation/tor-launcher-properties] Update translations for tor-launcher-properties
by translation＠torproject.org 22 Mar '16

22 Mar '16

commit a46e33085c25afddc16e31aad2751ffbca7fcfc0 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 22 13:16:27 2016 +0000 Update translations for tor-launcher-properties --- de/torlauncher.properties | 4 ++-- hu/torlauncher.properties | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/de/torlauncher.properties b/de/torlauncher.properties index bc0a809..20aa8b3 100644 --- a/de/torlauncher.properties +++ b/de/torlauncher.properties @@ -13,8 +13,8 @@ torlauncher.tor_bootstrap_failed_details=%1$S gescheitert (%2$S). torlauncher.unable_to_start_tor=Tor kann nicht gestartet werden.\n\n%S torlauncher.tor_missing=Die Tor-Programmdatei ist nicht vorhanden. -torlauncher.torrc_missing=The torrc file is missing and could not be created. -torlauncher.datadir_missing=The Tor data directory does not exist and could not be created. +torlauncher.torrc_missing=Die torrc Datei fehlt und konnte nicht erstellt werden. +torlauncher.datadir_missing=Das Tor Dateiverzeichnis existiert nicht und konnte nicht erstellt werden. torlauncher.password_hash_missing=Erhalt des Hash-Passwortes ist fehlgeschlagen. torlauncher.failed_to_get_settings=Die Tor-Einstellungen können nicht abgefragt werden.\n\n%S diff --git a/hu/torlauncher.properties b/hu/torlauncher.properties index e653775..82ef206 100644 --- a/hu/torlauncher.properties +++ b/hu/torlauncher.properties @@ -13,8 +13,8 @@ torlauncher.tor_bootstrap_failed_details=%1$S hiba (%2$S). torlauncher.unable_to_start_tor=Nem sikerült a Tor-t elindítani.\n\n%S torlauncher.tor_missing=A Tor futtatható állomány hiányzik. -torlauncher.torrc_missing=The torrc file is missing and could not be created. -torlauncher.datadir_missing=The Tor data directory does not exist and could not be created. +torlauncher.torrc_missing=A torrc fájl hiányzik és nem lehet létrehozni. +torlauncher.datadir_missing=A Tor data könyvtár nem létezik és nem lehet létrehozni. torlauncher.password_hash_missing=Nem sikerült megszerezni a hash-elt jelszót. torlauncher.failed_to_get_settings=Sikertelen a Tor beállítások lekérése.\n\n%S

1 0

[tor/master] Never use sprintf. tor_snprintf instead. Bug in tests, not in any released tor.
by nickm＠torproject.org 22 Mar '16

22 Mar '16

commit 9dff41694a9706f91ac175ebb7a3e23566dad189 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 22 08:52:17 2016 -0400 Never use sprintf. tor_snprintf instead. Bug in tests, not in any released tor. --- src/test/test_dir_handle_get.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_dir_handle_get.c b/src/test/test_dir_handle_get.c index d74aeb6..05657ca 100644 --- a/src/test/test_dir_handle_get.c +++ b/src/test/test_dir_handle_get.c @@ -255,7 +255,7 @@ test_dir_handle_get_bytes_txt(void *data) tt_assert(strstr(header, "Content-Encoding: identity\r\n")); tt_assert(strstr(header, "Pragma: no-cache\r\n")); - sprintf(buff, "Content-Length: %ld\r\n", (long) body_len); + tor_snprintf(buff, sizeof(buff), "Content-Length: %ld\r\n", (long) body_len); tt_assert(strstr(header, buff)); tt_int_op(body_used, OP_EQ, strlen(body));

1 0

[tor/master] Try to fix an intermittent test failure on openbsd.
by nickm＠torproject.org 22 Mar '16

22 Mar '16

commit dae8484107282edde19c766aeb8713dbdcdb03b4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 22 09:12:59 2016 -0400 Try to fix an intermittent test failure on openbsd. --- src/test/test_scheduler.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/test_scheduler.c b/src/test/test_scheduler.c index 977ce6f..6e9889b 100644 --- a/src/test/test_scheduler.c +++ b/src/test/test_scheduler.c @@ -461,11 +461,11 @@ test_scheduler_compare_channels(void *arg) /* * This is to test the different-policies case, which uses the policy - * cast to an intptr_t as an arbitrary but definite thing to compare. + * cast to an uintptr_t as an arbitrary but definite thing to compare. */ mock_cgp_val_1 = tor_malloc_zero(16); mock_cgp_val_2 = tor_malloc_zero(16); - if ( ((intptr_t) mock_cgp_val_1) > ((intptr_t) mock_cgp_val_2) ) { + if ( ((uintptr_t) mock_cgp_val_1) > ((uintptr_t) mock_cgp_val_2) ) { void *tmp = mock_cgp_val_1; mock_cgp_val_1 = mock_cgp_val_2; mock_cgp_val_2 = tmp;

1 0

[tor/master] Fix an fd leak in check_private_dir().
by nickm＠torproject.org 22 Mar '16

22 Mar '16

commit a17537a2386a98cba39c94dfb8b09b50edf16922 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 22 08:29:51 2016 -0400 Fix an fd leak in check_private_dir(). The fd would leak when the User wasn't recogniezed by getpwnam(). Since we'd then go on to exit, this wasn't a terribad leak, but it's still not as nice as no leak at all. CID 1355640; bugfix on no released Tor. --- src/common/util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/common/util.c b/src/common/util.c index 39d6502..056817e 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -2157,6 +2157,7 @@ check_private_dir(const char *dirname, cpd_check_t check, if (pw == NULL) { log_warn(LD_CONFIG, "Error setting configured user: %s not found", effective_user); + close(fd); return -1; } running_uid = pw->pw_uid;

1 0

[tor-browser-bundle/hardened-builds] Preparing hardened nightly builds
by gk＠torproject.org 22 Mar '16

22 Mar '16

commit eba255bf0c2a9ba5949499afc395e4cc919b5592 Author: Georg Koppen <gk(a)torproject.org> Date: Tue Mar 22 11:03:52 2016 +0000 Preparing hardened nightly builds --- gitian/versions.nightly | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitian/versions.nightly b/gitian/versions.nightly index dd8989e..43c3c9a 100755 --- a/gitian/versions.nightly +++ b/gitian/versions.nightly @@ -1,6 +1,6 @@ TORBROWSER_VERSION_TYPE=nightly -TORBROWSER_VERSION=tbb-nightly -TORBROWSER_BUILDDIR=tbb-nightly +TORBROWSER_VERSION=tbb-nightly-hardened +TORBROWSER_BUILDDIR=tbb-nightly-hardened TORBROWSER_SYMLINK_VERSION=0 BUNDLE_LOCALES="ar ru zh-CN" BUNDLE_LOCALES_LINUX="ja"

1 0