November 2016 - tor-commits - lists.torproject.org

[tor/master] Add "TByte" and "TBytes" units; also add "TBits" to man page
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 7dee70c3e1e12389a15c6f5bb4e41c9adeaaf054 Author: Matt Nordhoff <mnordhoff(a)mattnordhoff.com> Date: Wed Nov 9 14:49:48 2016 +0000 Add "TByte" and "TBytes" units; also add "TBits" to man page --- changes/bug20622 | 8 ++++++++ doc/tor.1.txt | 26 +++++++++++++------------- src/or/confparse.c | 2 ++ 3 files changed, 23 insertions(+), 13 deletions(-) diff --git a/changes/bug20622 b/changes/bug20622 new file mode 100644 index 0000000..eb7a8fb --- /dev/null +++ b/changes/bug20622 @@ -0,0 +1,8 @@ + o Minor bugfixes (configuration): + - Support "TByte" and "TBytes" units in options given in bytes. + "TB", "terabyte(s)", "TBit(s)" and "terabit(s)" were already + supported. Fixes bug 20622; bugfix on 0.2.0.14-alpha. + + o Minor bugfixes (documentation): + - Include the "TBits" unit in Tor's man page. Fixes part of bug + 20622; bugfix on tor-0.2.5.1-alpha. diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 97eeb96..cbc7ac1 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -176,7 +176,7 @@ forward slash (/) in the configuration file and on the command line. GENERAL OPTIONS --------------- -[[BandwidthRate]] **BandwidthRate** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[BandwidthRate]] **BandwidthRate** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: A token bucket limits the average incoming bandwidth usage on this node to the specified number of bytes per second, and the average outgoing bandwidth usage to that same value. If you want to run a relay in the @@ -195,35 +195,35 @@ GENERAL OPTIONS To avoid confusion, we recommend writing "bytes" or "bits" explicitly, since it's easy to forget that "B" means bytes, not bits. -[[BandwidthBurst]] **BandwidthBurst** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[BandwidthBurst]] **BandwidthBurst** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: Limit the maximum token bucket size (also known as the burst) to the given number of bytes in each direction. (Default: 1 GByte) -[[MaxAdvertisedBandwidth]] **MaxAdvertisedBandwidth** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[MaxAdvertisedBandwidth]] **MaxAdvertisedBandwidth** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: If set, we will not advertise more than this amount of bandwidth for our BandwidthRate. Server operators who want to reduce the number of clients who ask to build circuits through them (since this is proportional to advertised bandwidth rate) can thus reduce the CPU demands on their server without impacting network performance. -[[RelayBandwidthRate]] **RelayBandwidthRate** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[RelayBandwidthRate]] **RelayBandwidthRate** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: If not 0, a separate token bucket limits the average incoming bandwidth usage for \_relayed traffic_ on this node to the specified number of bytes per second, and the average outgoing bandwidth usage to that same value. Relayed traffic currently is calculated to include answers to directory requests, but that may change in future versions. (Default: 0) -[[RelayBandwidthBurst]] **RelayBandwidthBurst** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[RelayBandwidthBurst]] **RelayBandwidthBurst** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: If not 0, limit the maximum token bucket size (also known as the burst) for \_relayed traffic_ to the given number of bytes in each direction. (Default: 0) -[[PerConnBWRate]] **PerConnBWRate** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[PerConnBWRate]] **PerConnBWRate** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: If set, do separate rate limiting for each connection from a non-relay. You should never need to change this value, since a network-wide value is published in the consensus and your relay will use that value. (Default: 0) -[[PerConnBWBurst]] **PerConnBWBurst** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[PerConnBWBurst]] **PerConnBWBurst** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: If set, do separate rate limiting for each connection from a non-relay. You should never need to change this value, since a network-wide value is published in the consensus and your relay will use that value. (Default: 0) @@ -608,7 +608,7 @@ GENERAL OPTIONS message currently has at least one domain; most currently have exactly one. This doesn't affect controller log messages. (Default: 0) -[[MaxUnparseableDescSizeToLog]] **MaxUnparseableDescSizeToLog** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**:: +[[MaxUnparseableDescSizeToLog]] **MaxUnparseableDescSizeToLog** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**:: Unparseable descriptors (e.g. for votes, consensuses, routers) are logged in separate files by hash, up to the specified size in total. Note that only files logged during the lifetime of this Tor process count toward the @@ -1867,7 +1867,7 @@ is non-zero): to 0 will disable the heartbeat. Otherwise, it must be at least 30 minutes. (Default: 6 hours) -[[AccountingMax]] **AccountingMax** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**|**TBytes**:: +[[AccountingMax]] **AccountingMax** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: Limits the max number of bytes sent and received within a set time period using a given calculation rule (see: AccountingStart, AccountingRule). Useful if you need to stay under a specific bandwidth. By default, the @@ -2240,12 +2240,12 @@ on the public Tor network. Authoritative directories only. Like AuthDirMaxServersPerAddr, but applies to addresses shared with directory authorities. (Default: 5) -[[AuthDirFastGuarantee]] **AuthDirFastGuarantee** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[AuthDirFastGuarantee]] **AuthDirFastGuarantee** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: Authoritative directories only. If non-zero, always vote the Fast flag for any relay advertising this amount of capacity or more. (Default: 100 KBytes) -[[AuthDirGuardBWGuarantee]] **AuthDirGuardBWGuarantee** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[AuthDirGuardBWGuarantee]] **AuthDirGuardBWGuarantee** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: Authoritative directories only. If non-zero, this advertised capacity or more is always sufficient to satisfy the bandwidth requirement for the Guard flag. (Default: 2 MBytes) @@ -2523,7 +2523,7 @@ The following options are used for running a testing Tor network. time. Changing this requires that **TestingTorNetwork** is set. (Default: 10 minutes) -[[TestingMinFastFlagThreshold]] **TestingMinFastFlagThreshold** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[TestingMinFastFlagThreshold]] **TestingMinFastFlagThreshold** __N__ **bytes**|**KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: Minimum value for the Fast flag. Overrides the ordinary minimum taken from the consensus when TestingTorNetwork is set. (Default: 0.) @@ -2643,7 +2643,7 @@ The following options are used for running a testing Tor network. events. Changing this requires that **TestingTorNetwork** is set. (Default: 0) -[[TestingMinExitFlagThreshold]] **TestingMinExitFlagThreshold** __N__ **KBytes**|**MBytes**|**GBytes**|**KBits**|**MBits**|**GBits**:: +[[TestingMinExitFlagThreshold]] **TestingMinExitFlagThreshold** __N__ **KBytes**|**MBytes**|**GBytes**|**TBytes**|**KBits**|**MBits**|**GBits**|**TBits**:: Sets a lower-bound for assigning an exit flag when running as an authority on a testing network. Overrides the usual default lower bound of 4 KB. (Default: 0) diff --git a/src/or/confparse.c b/src/or/confparse.c index ca54284..1706fa8 100644 --- a/src/or/confparse.c +++ b/src/or/confparse.c @@ -1224,6 +1224,8 @@ static struct unit_table_t memory_units[] = { { "gbits", 1<<27 }, { "gbit", 1<<27 }, { "tb", U64_LITERAL(1)<<40 }, + { "tbyte", U64_LITERAL(1)<<40 }, + { "tbytes", U64_LITERAL(1)<<40 }, { "terabyte", U64_LITERAL(1)<<40 }, { "terabytes", U64_LITERAL(1)<<40 }, { "terabits", U64_LITERAL(1)<<37 },

1 0

[tor/master] Merge remote-tracking branch 'dgoulet/ticket19642_030_01'
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 217b8958311421c6819213af01f685160938f5d0 Merge: 7dee70c 34f14a3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Nov 10 09:16:00 2016 -0500 Merge remote-tracking branch 'dgoulet/ticket19642_030_01' src/or/hs_descriptor.c | 13 +++++++++++++ src/or/hs_descriptor.h | 3 +++ src/or/parsecommon.h | 1 + src/test/test_hs_descriptor.c | 1 + 4 files changed, 18 insertions(+)

1 0

[tor/maint-0.2.9] Call get_options() once at the top of circuit_log_ancient_one_hop_circuits()
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 5dca9487c422f06a056711591c3f8f4344fd075f Author: teor <teor2345(a)gmail.com> Date: Wed Nov 9 11:15:48 2016 +1100 Call get_options() once at the top of circuit_log_ancient_one_hop_circuits() Refactoring, no behaviour change. --- src/or/circuituse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/or/circuituse.c b/src/or/circuituse.c index f344703..18cd7e3 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -797,6 +797,7 @@ circuit_log_ancient_one_hop_circuits(int age) time_t cutoff = now - age; int n_found = 0; smartlist_t *log_these = smartlist_new(); + const or_options_t *options = get_options(); SMARTLIST_FOREACH_BEGIN(circuit_get_global_list(), circuit_t *, circ) { const origin_circuit_t *ocirc; @@ -839,7 +840,7 @@ circuit_log_ancient_one_hop_circuits(int age) tor_asprintf(&dirty, "Dirty since %s (%ld seconds vs %ld-second cutoff)", dirty_since, (long)(now - circ->timestamp_dirty), - (long) get_options()->MaxCircuitDirtiness); + (long) options->MaxCircuitDirtiness); } else { dirty = tor_strdup("Not marked dirty"); }

1 0

[tor/master] Call get_options() once at the top of circuit_log_ancient_one_hop_circuits()
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 5dca9487c422f06a056711591c3f8f4344fd075f Author: teor <teor2345(a)gmail.com> Date: Wed Nov 9 11:15:48 2016 +1100 Call get_options() once at the top of circuit_log_ancient_one_hop_circuits() Refactoring, no behaviour change. --- src/or/circuituse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/or/circuituse.c b/src/or/circuituse.c index f344703..18cd7e3 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -797,6 +797,7 @@ circuit_log_ancient_one_hop_circuits(int age) time_t cutoff = now - age; int n_found = 0; smartlist_t *log_these = smartlist_new(); + const or_options_t *options = get_options(); SMARTLIST_FOREACH_BEGIN(circuit_get_global_list(), circuit_t *, circ) { const origin_circuit_t *ocirc; @@ -839,7 +840,7 @@ circuit_log_ancient_one_hop_circuits(int age) tor_asprintf(&dirty, "Dirty since %s (%ld seconds vs %ld-second cutoff)", dirty_since, (long)(now - circ->timestamp_dirty), - (long) get_options()->MaxCircuitDirtiness); + (long) options->MaxCircuitDirtiness); } else { dirty = tor_strdup("Not marked dirty"); }

1 0

[tor/maint-0.2.9] Stop logging single onion and Tor2web long-term one-hop circuits
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 0ec94588ab4e83dbc8d405dc780139cd3e596880 Author: teor <teor2345(a)gmail.com> Date: Wed Nov 9 11:22:08 2016 +1100 Stop logging single onion and Tor2web long-term one-hop circuits Single onion services and Tor2web deliberately create long-term one-hop circuits to their intro and rend points, respectively. These log messages are intended to diagnose issue 8387, which relates to circuits hanging around forever for no reason. Fixes bug 20613; bugfix on 0.2.9.1-alpha. Reported by "pastly". --- changes/bug20613 | 6 ++++++ src/or/circuituse.c | 15 +++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/changes/bug20613 b/changes/bug20613 new file mode 100644 index 0000000..19bb61f --- /dev/null +++ b/changes/bug20613 @@ -0,0 +1,6 @@ + o Minor bugfixes (single onion services, Tor2web): + - Stop logging long-term one-hop circuits deliberately created by single + onion services and Tor2web. These log messages are intended to diagnose + issue 8387, which relates to circuits hanging around forever for no + reason. + Fixes bug 20613; bugfix on 0.2.9.1-alpha. Reported by "pastly". diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 18cd7e3..84574cd 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -788,6 +788,8 @@ static time_t last_expired_clientside_circuits = 0; * As a diagnostic for bug 8387, log information about how many one-hop * circuits we have around that have been there for at least <b>age</b> * seconds. Log a few of them. + * Ignores Single Onion Service intro and Tor2web redezvous circuits, they are + * expected to be long-term one-hop circuits. */ void circuit_log_ancient_one_hop_circuits(int age) @@ -805,6 +807,19 @@ circuit_log_ancient_one_hop_circuits(int age) continue; if (circ->timestamp_created.tv_sec >= cutoff) continue; + /* Single Onion Services deliberately make long term one-hop intro + * connections. We only ignore active intro point connections, if we take + * a long time establishing, that's worth logging. */ + if (rend_service_allow_non_anonymous_connection(options) && + circ->purpose == CIRCUIT_PURPOSE_S_INTRO) + continue; + /* Tor2web deliberately makes long term one-hop rend connections, + * particularly when Tor2webRendezvousPoints is used. We only ignore + * active rend point connections, if we take a long time to rendezvous, + * that's worth logging. */ + if (rend_client_allow_non_anonymous_connection(options) && + circ->purpose == CIRCUIT_PURPOSE_C_REND_JOINED) + continue; ocirc = CONST_TO_ORIGIN_CIRCUIT(circ); if (ocirc->build_state && ocirc->build_state->onehop_tunnel) {

1 0

[tor/maint-0.2.9] Merge remote-tracking branch 'teor/bug20613' into maint-0.2.9
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit e8e7a8f3db9dfbc71e455eef3c7991c715231260 Merge: e4ef9f7 0ec9458 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Nov 10 09:10:55 2016 -0500 Merge remote-tracking branch 'teor/bug20613' into maint-0.2.9 changes/bug20613 | 6 ++++++ src/or/circuituse.c | 18 +++++++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.9] Stop logging single onion and Tor2web long-term one-hop circuits
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 0ec94588ab4e83dbc8d405dc780139cd3e596880 Author: teor <teor2345(a)gmail.com> Date: Wed Nov 9 11:22:08 2016 +1100 Stop logging single onion and Tor2web long-term one-hop circuits Single onion services and Tor2web deliberately create long-term one-hop circuits to their intro and rend points, respectively. These log messages are intended to diagnose issue 8387, which relates to circuits hanging around forever for no reason. Fixes bug 20613; bugfix on 0.2.9.1-alpha. Reported by "pastly". --- changes/bug20613 | 6 ++++++ src/or/circuituse.c | 15 +++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/changes/bug20613 b/changes/bug20613 new file mode 100644 index 0000000..19bb61f --- /dev/null +++ b/changes/bug20613 @@ -0,0 +1,6 @@ + o Minor bugfixes (single onion services, Tor2web): + - Stop logging long-term one-hop circuits deliberately created by single + onion services and Tor2web. These log messages are intended to diagnose + issue 8387, which relates to circuits hanging around forever for no + reason. + Fixes bug 20613; bugfix on 0.2.9.1-alpha. Reported by "pastly". diff --git a/src/or/circuituse.c b/src/or/circuituse.c index 18cd7e3..84574cd 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -788,6 +788,8 @@ static time_t last_expired_clientside_circuits = 0; * As a diagnostic for bug 8387, log information about how many one-hop * circuits we have around that have been there for at least <b>age</b> * seconds. Log a few of them. + * Ignores Single Onion Service intro and Tor2web redezvous circuits, they are + * expected to be long-term one-hop circuits. */ void circuit_log_ancient_one_hop_circuits(int age) @@ -805,6 +807,19 @@ circuit_log_ancient_one_hop_circuits(int age) continue; if (circ->timestamp_created.tv_sec >= cutoff) continue; + /* Single Onion Services deliberately make long term one-hop intro + * connections. We only ignore active intro point connections, if we take + * a long time establishing, that's worth logging. */ + if (rend_service_allow_non_anonymous_connection(options) && + circ->purpose == CIRCUIT_PURPOSE_S_INTRO) + continue; + /* Tor2web deliberately makes long term one-hop rend connections, + * particularly when Tor2webRendezvousPoints is used. We only ignore + * active rend point connections, if we take a long time to rendezvous, + * that's worth logging. */ + if (rend_client_allow_non_anonymous_connection(options) && + circ->purpose == CIRCUIT_PURPOSE_C_REND_JOINED) + continue; ocirc = CONST_TO_ORIGIN_CIRCUIT(circ); if (ocirc->build_state && ocirc->build_state->onehop_tunnel) {

1 0

[tor/release-0.2.9] Merge remote-tracking branch 'teor/bug20613' into maint-0.2.9
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit e8e7a8f3db9dfbc71e455eef3c7991c715231260 Merge: e4ef9f7 0ec9458 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Nov 10 09:10:55 2016 -0500 Merge remote-tracking branch 'teor/bug20613' into maint-0.2.9 changes/bug20613 | 6 ++++++ src/or/circuituse.c | 18 +++++++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-)

1 0

[tor/master] Merge remote-tracking branch 'teor/bug20613' into maint-0.2.9
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit e8e7a8f3db9dfbc71e455eef3c7991c715231260 Merge: e4ef9f7 0ec9458 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Nov 10 09:10:55 2016 -0500 Merge remote-tracking branch 'teor/bug20613' into maint-0.2.9 changes/bug20613 | 6 ++++++ src/or/circuituse.c | 18 +++++++++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-)

1 0

[tor/release-0.2.9] Call get_options() once at the top of circuit_log_ancient_one_hop_circuits()
by nickm＠torproject.org 10 Nov '16

10 Nov '16

commit 5dca9487c422f06a056711591c3f8f4344fd075f Author: teor <teor2345(a)gmail.com> Date: Wed Nov 9 11:15:48 2016 +1100 Call get_options() once at the top of circuit_log_ancient_one_hop_circuits() Refactoring, no behaviour change. --- src/or/circuituse.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/or/circuituse.c b/src/or/circuituse.c index f344703..18cd7e3 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -797,6 +797,7 @@ circuit_log_ancient_one_hop_circuits(int age) time_t cutoff = now - age; int n_found = 0; smartlist_t *log_these = smartlist_new(); + const or_options_t *options = get_options(); SMARTLIST_FOREACH_BEGIN(circuit_get_global_list(), circuit_t *, circ) { const origin_circuit_t *ocirc; @@ -839,7 +840,7 @@ circuit_log_ancient_one_hop_circuits(int age) tor_asprintf(&dirty, "Dirty since %s (%ld seconds vs %ld-second cutoff)", dirty_since, (long)(now - circ->timestamp_dirty), - (long) get_options()->MaxCircuitDirtiness); + (long) options->MaxCircuitDirtiness); } else { dirty = tor_strdup("Not marked dirty"); }

1 0