June 2015 - tor-commits - lists.torproject.org

[bridgedb/develop] Fix non-deterministic CI errors with use of Queue in test_smtp.
by isis＠torproject.org 25 Jun '15

25 Jun '15

commit 069659d51d06a86cd1b609b42106774f536b58e4 Author: Isis Lovecruft <isis(a)torproject.org> Date: Sat Apr 18 03:37:50 2015 +0000 Fix non-deterministic CI errors with use of Queue in test_smtp. See https://travis-ci.org/isislovecruft/bridgedb/jobs/58996136#L3281 --- lib/bridgedb/test/test_smtp.py | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/lib/bridgedb/test/test_smtp.py b/lib/bridgedb/test/test_smtp.py index 1cbafba..de443b3 100644 --- a/lib/bridgedb/test/test_smtp.py +++ b/lib/bridgedb/test/test_smtp.py @@ -84,11 +84,21 @@ class EmailServer(SMTPServer): assert self._thread.is_alive() == False, "Thread is alive and kicking" def getAndCheckMessageContains(self, text, timeoutInSecs=2.0): - #print("Checking for reponse") - message = self.message_queue.get(block=True, timeout=timeoutInSecs) - assert message.find(text) != -1, ("Message did not contain text '%s'." - "Full message is:\n %s" - % (text, message)) + try: + message = self.message_queue.get(block=True, timeout=timeoutInSecs) + # Queue.Empty, according to its documentation, is only supposed to be + # raised when Queue.get(block=False) or Queue.get_nowait() are called. + # I've no idea why it's getting raised here, when we're blocking for + # it, but nonetheless it causes occasional, non-deterministic CI + # failures: + # + # https://travis-ci.org/isislovecruft/bridgedb/jobs/58996136#L3281 + except Queue.Empty: + pass + else: + assert message.find(text) != -1, ("Message did not contain text '%s'." + "Full message is:\n %s" + % (text, message)) def checkNoMessageReceived(self, timeoutInSecs=2.0): try:

1 0

[bridgedb/develop] Remove annoying and unnecessary log statements with memory addresses.
by isis＠torproject.org 25 Jun '15

25 Jun '15

commit dfbc8e0abbfba32324c4c2c9573d0671a150cf34 Author: Isis Lovecruft <isis(a)torproject.org> Date: Mon Apr 20 22:27:05 2015 +0000 Remove annoying and unnecessary log statements with memory addresses. The information which these log statements were trying to log is captured by other log statements within the same functions, and both of them included non-human-useful data like locations of various objects in memory. Conflicts: lib/bridgedb/Bridges.py --- lib/bridgedb/Bridges.py | 3 --- lib/bridgedb/Filters.py | 1 - 2 files changed, 4 deletions(-) diff --git a/lib/bridgedb/Bridges.py b/lib/bridgedb/Bridges.py index 58a81cd..d9b28e2 100644 --- a/lib/bridgedb/Bridges.py +++ b/lib/bridgedb/Bridges.py @@ -634,9 +634,6 @@ class FilteredBridgeSplitter(BridgeHolder): # I suppose since it contains memory addresses, it *is* technically # likely to be a unique string, but it is messy. - logging.debug("Adding '%s' subring to %s..." - % (ringname, self.__class__.__name__)) - if not isinstance(subring, BridgeHolder): logging.fatal("%s hashring can't add invalid subring: %r" % (self.distributorName, subring)) diff --git a/lib/bridgedb/Filters.py b/lib/bridgedb/Filters.py index eadf012..aade069 100644 --- a/lib/bridgedb/Filters.py +++ b/lib/bridgedb/Filters.py @@ -12,7 +12,6 @@ def filterAssignBridgesToRing(hmac, numRings, assignedRing): # ruleset ensures that the same logging.debug("Creating a filter for assigning bridges to hashrings...") ruleset = frozenset([hmac, numRings, assignedRing]) - logging.debug("Filter created: %s" % ruleset) try: return funcs[ruleset]

1 0

[tor-browser/tor-browser-38.1.0esr-5.x-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit c1baf26f15edaf6964436175b98bf33d13531207 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Jun 24 20:06:46 2015 -0700 fixup! TB4: Tor Browser's Firefox preference overrides. Bug #16222: Disable WebIDE to prevent remote debugging and addon downloads. --- browser/app/profile/000-tor-browser.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index cffb790..cddb430 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -139,6 +139,11 @@ pref("browser.eme.ui.enabled", false); pref("media.gmp-eme-adobe.enabled", false); pref("media.eme.enabled", false); pref("media.eme.apiVisible", false); +// WebIDE can bypass proxy settings for remote debugging. It also downloads +// some additional addons that we have not reviewed. Turn all that off. +pref("devtools.webide.autoinstallADBHelper", false); +pref("devtools.webide.autoinstallFxdtAdapters", false); +pref("devtools.webide.enabled", false); // Security slider pref("svg.in-content.enabled", true);

1 0

[tor-launcher/master] Bug 16428: Use internal update URL
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit 06f135535fac7e79be9051229030d195a44c84a7 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Jun 24 10:26:10 2015 +0000 Bug 16428: Use internal update URL We avoid using https://127.0.0.1 as update URL in order to omit scary Tor warnings (see: #13129). --- src/install.rdf | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/install.rdf b/src/install.rdf index 2e9babc..0b8fc34 100644 --- a/src/install.rdf +++ b/src/install.rdf @@ -9,7 +9,8 @@ <em:id>tor-launcher(a)torproject.org</em:id> <em:version>0.2.7.6</em:version> <em:homepageURL>https://www.torproject.org/projects/torbrowser.html</em:homepageURL> - <em:updateURL>https://127.0.0.1/</em:updateURL> + <em:updateURL>data:text/plain,</em:updateURL> + <em:updateKey>-</em:updateKey>

1 0

[torbutton/master] Bug 16427: Use internal update URL
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit 2b9497e060ac6e9610b695102e087b74a4474d19 Author: Georg Koppen <gk(a)torproject.org> Date: Wed Jun 24 10:30:04 2015 +0000 Bug 16427: Use internal update URL We avoid using https://127.0.0.1 as update URL in order to omit scary Tor warnings (see: #13129). --- src/install.rdf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/install.rdf b/src/install.rdf index ae087f7..86a87db 100644 --- a/src/install.rdf +++ b/src/install.rdf @@ -10,8 +10,8 @@ <em:homepageURL>https://www.torproject.org/projects/torbrowser.html.en</em:homepageURL> <em:optionsURL>chrome://torbutton/content/preferences.xul</em:optionsURL> <em:iconURL>chrome://torbutton/skin/tor.png</em:iconURL> - <em:updateURL>https://127.0.0.1/</em:updateURL> -  + <em:updateURL>data:text/plain,</em:updateURL> + <em:updateKey>-</em:updateKey>  <em:targetApplication> <Description>

1 0

[torbutton/master] Merge remote-tracking branch 'gk/bug_16427'
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit bdf2289fdcf4485a16ade68b51cbd6532ef460b9 Merge: d379c3e 2b9497e Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Jun 24 19:48:03 2015 -0700 Merge remote-tracking branch 'gk/bug_16427' src/install.rdf | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

1 0

[torbutton/master] Bug 16200. Wipe cache on New Identity for TBB/FFESR38
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit d37746c1077bf65666c13fed761afba385c3bb07 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Mon Jun 8 00:19:25 2015 -0700 Bug 16200. Wipe cache on New Identity for TBB/FFESR38 (This updates and consolidates offline cache code as well.) --- src/chrome/content/torbutton.js | 30 ++++++++++++++---------------- 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index 3454613..5f4ba5c 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -19,6 +19,8 @@ XPCOMUtils.defineLazyModuleGetter(this, "ConsoleServiceListener", XPCOMUtils.defineLazyModuleGetter(this, "WebConsoleUtils", "resource://gre/modules/devtools/WebConsoleUtils.jsm"); +let { LoadContextInfo } = Cu.import('resource://gre/modules/LoadContextInfo.jsm'); + const k_tb_last_browser_version_pref = "extensions.torbutton.lastBrowserVersion"; const k_tb_browser_update_needed_pref = "extensions.torbutton.updateNeeded"; const k_tb_last_update_check_pref = "extensions.torbutton.lastUpdateCheck"; @@ -1785,30 +1787,26 @@ function torbutton_do_new_identity() { torbutton_log(3, "New Identity: Clearing Offline Cache"); - var cache = Components.classes["@mozilla.org/network/cache-service;1"]. - getService(Components.interfaces.nsICacheService); - try { - cache.evictEntries(Ci.nsICache.STORE_OFFLINE); + for (let contextInfo of [LoadContextInfo.default, LoadContextInfo.private]) { + let appCacheStorage = Services.cache2.appCacheStorage(contextInfo, null); + // The following call (asyncEvictStorage) is actually synchronous, either + // if we have pref "browser.cache.use_new_backend" -> 1 or + // "browser.cache.use_new_backend_temp" -> true, + // then we are using the new cache (cache2) which operates synchronously. + // If we are using the old cache, then the tor-browser.git patch for + // #5715 also makes this synchronous. So we pass a null callback. + appCacheStorage.asyncEvictStorage(null); + } } catch(e) { torbutton_log(5, "Exception on cache clearing: "+e); window.alert("Torbutton: Unexpected error during offline cache clearing: "+e); } - torbutton_log(3, "New Identity: Clearing LocalStorage"); - - try { - Components.utils.import("resource:///modules/offlineAppCache.jsm"); - OfflineAppCacheHelper.clear(); - } catch(e) { - torbutton_log(5, "Exception on localStorage clearing: "+e); - window.alert("Torbutton: Unexpected error during localStorage clearing: "+e); - } - - torbutton_log(3, "New Identity: Clearing Disk Cache"); + torbutton_log(3, "New Identity: Clearing Disk and Memory Caches"); try { - cache.evictEntries(0); + Services.cache2.clear(); } catch(e) { torbutton_log(5, "Exception on cache clearing: "+e); window.alert("Torbutton: Unexpected error during cache clearing: "+e);

1 0

[torbutton/master] Bug 16200: Torbutton changes for ESR 38
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit 699617776da868b4eabf982d23e7c901498905ef Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Mon Jun 22 13:43:43 2015 -0400 Bug 16200: Torbutton changes for ESR 38 Removed old, unused default preference values. --- src/defaults/preferences/preferences.js | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/defaults/preferences/preferences.js b/src/defaults/preferences/preferences.js index 4d1dee0..6b4ec0c 100644 --- a/src/defaults/preferences/preferences.js +++ b/src/defaults/preferences/preferences.js @@ -94,11 +94,6 @@ pref("extensions.torbutton.saved.appname_override",""); pref("extensions.torbutton.saved.appversion_override",""); pref("extensions.torbutton.saved.platform_override",""); pref("extensions.torbutton.saved.oscpu_override", ""); -pref("extensions.torbutton.saved.useragent_override", ""); -pref("extensions.torbutton.saved.productsub_override",""); -pref("extensions.torbutton.saved.buildID_override",""); -pref("extensions.torbutton.saved.useragent_vendor", ""); -pref("extensions.torbutton.saved.useragent_vendorSub",""); pref("extensions.torbutton.saved.transparentTor",false); pref("extensions.torbutton.saved.webgl_disabled", false); // network.dns.disablePrefetch is a hidden option. It has no default value: @@ -220,14 +215,6 @@ pref("extensions.torbutton.appversion_override","5.0 (Windows)"); pref("extensions.torbutton.platform_override","Win32"); pref("extensions.torbutton.oscpu_override", "Windows NT 6.1"); -pref("extensions.torbutton.useragent_override", - "Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20100101 Firefox/17.0"); - -pref("extensions.torbutton.productsub_override","20100101"); -pref("extensions.torbutton.buildID_override","0"); -pref("extensions.torbutton.useragent_vendor", ""); -pref("extensions.torbutton.useragent_vendorSub",""); - pref("extensions.torbutton.prompt_torbrowser", true); pref("extensions.torbutton.confirm_plugins", true); pref("extensions.torbutton.confirm_newnym", true);

1 0

[torbutton/master] Merge remote-tracking branch 'brade/bug16200-02'
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit d379c3e7992d18f5bab152c527f164b53b217ff6 Merge: d37746c 6996177 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Jun 24 19:36:17 2015 -0700 Merge remote-tracking branch 'brade/bug16200-02' src/defaults/preferences/preferences.js | 13 ------------- 1 file changed, 13 deletions(-)

1 0

[tor-browser/tor-browser-38.1.0esr-5.x-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by mikeperry＠torproject.org 25 Jun '15

25 Jun '15

commit e27dde72950d96837684f956949477ef87162313 Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed Jun 24 19:38:34 2015 -0700 fixup! TB4: Tor Browser's Firefox preference overrides. Bump our useragent for FF38. --- browser/app/profile/000-tor-browser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index f148f4d..cffb790 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -71,7 +71,7 @@ pref("general.appname.override", "Netscape"); pref("general.appversion.override", "5.0 (Windows)"); pref("general.oscpu.override", "Windows NT 6.1"); pref("general.platform.override", "Win32"); -pref("general.useragent.override", "Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0"); +pref("general.useragent.override", "Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0"); pref("general.productSub.override", "20100101"); pref("general.buildID.override", "20100101"); pref("browser.startup.homepage_override.buildID", "20100101");

1 0