February 2015 - tor-commits - lists.torproject.org

[tor/master] reflow 0.2.6.3 changelog
by nickm＠torproject.org 19 Feb '15

19 Feb '15

commit 61f9030409143efff07b3a9b6d12dbc05ad36587 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 19 09:54:00 2015 -0500 reflow 0.2.6.3 changelog --- ChangeLog | 83 +++++++++++++++++++++++++++++++------------------------------ 1 file changed, 42 insertions(+), 41 deletions(-) diff --git a/ChangeLog b/ChangeLog index 09a915b..bcade74 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,10 +1,9 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? Tor 0.2.6.3-alpha is the third (and hopefully final) alpha release in - the 0.2.6.x series. It introduces support for - more kinds of sockets, makes it harder to accidentally run an - exit, improves our multithreading backend, incorporates several fixes - for the AutomapHostsOnResolve option, and fixes numerous other - bugs besides. + the 0.2.6.x series. It introduces support for more kinds of sockets, + makes it harder to accidentally run an exit, improves our + multithreading backend, incorporates several fixes for the + AutomapHostsOnResolve option, and fixes numerous other bugs besides. If no major regressions or security holes are found in this version, the next version will be a release candidate. @@ -16,12 +15,13 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? o Major features (security, unix domain sockets): - Allow SocksPort to be an AF_UNIX Unix Domain Socket. Now high risk applications can reach Tor without having to create AF_INET or - AF_INET6 sockets, meaning they can completely disable their ability - to make non-Tor network connections. To create a socket of this - type, use "SocksPort unix:/path/to/socket". Implements ticket 12585. + AF_INET6 sockets, meaning they can completely disable their + ability to make non-Tor network connections. To create a socket of + this type, use "SocksPort unix:/path/to/socket". Implements + ticket 12585. - Support mapping hidden service virtual ports to AF_UNIX sockets. - The syntax is "HiddenServicePort 80 - unix:/path/to/socket". Implements ticket 11485. + The syntax is "HiddenServicePort 80 unix:/path/to/socket". + Implements ticket 11485. o Major features (changed defaults): - Prevent relay operators from unintentionally running exits: When a @@ -31,21 +31,6 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? can indicate accidental misconfiguration. Setting "ExitRelay 0" stops Tor from running as an exit relay. Closes ticket 10067. - o Major features (performance): - - Make the CPU worker implementation more efficient by avoiding - the kernel and lengthening pipelines. The original implementation - used sockets to transfer data from the main thread to the workers, - and didn't allow any thread to be assigned more than a single - piece of work at once. The new implementation avoids communications - overhead by making requests in shared memory, avoiding kernel IO - where possible, and keeping more requests in flight at once. - Implements ticket 9682. - - o Major features (relay): - - Raise the minimum acceptable configured bandwidth rate for bridges - to 50 KiB/sec and for relays to 75 KiB/sec. (The old values were - 20 KiB/sec.) Closes ticket 13822. - o Major features (directory system): - When downloading server- or microdescriptors from a directory server, we no longer launch multiple simultaneous requests to the @@ -60,10 +45,25 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? notified of updates and their correct digests. Implements proposal 227. Closes ticket 10395. + o Major features (performance): + - Make the CPU worker implementation more efficient by avoiding the + kernel and lengthening pipelines. The original implementation used + sockets to transfer data from the main thread to the workers, and + didn't allow any thread to be assigned more than a single piece of + work at once. The new implementation avoids communications + overhead by making requests in shared memory, avoiding kernel IO + where possible, and keeping more requests in flight at once. + Implements ticket 9682. + + o Major features (relay): + - Raise the minimum acceptable configured bandwidth rate for bridges + to 50 KiB/sec and for relays to 75 KiB/sec. (The old values were + 20 KiB/sec.) Closes ticket 13822. + o Major bugfixes (client): - Allow MapAddress and AutomapHostsOnResolve to work together when - an address is mapped into another address type (like .onion) - that must be automapped at resolve time. Fixes bug 7555; bugfix + an address is mapped into another address type (like .onion) that + must be automapped at resolve time. Fixes bug 7555; bugfix on 0.2.0.1-alpha. o Major bugfixes (exit node stability): @@ -81,8 +81,8 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? o Minor features (build): - New --disable-system-torrc compile-time option to prevent Tor from - looking for the system-wide torrc or torrc-defaults files. Resolves - ticket 13037. + looking for the system-wide torrc or torrc-defaults files. + Resolves ticket 13037. o Minor features (controller): - Include SOCKS_USERNAME and SOCKS_PASSWORD values in controller @@ -107,8 +107,8 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? for small requests. Closes ticket 11791. o Minor features (geoip): - - Update geoip and geoip6 files to the January 7 2015 Maxmind GeoLite2 - Country database. + - Update geoip and geoip6 files to the January 7 2015 Maxmind + GeoLite2 Country database. o Minor features (guard nodes): - Reduce the time delay before saving guard status to disk from 10 @@ -142,8 +142,8 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? o Minor features (stability): - Add assertions in our hash-table iteration code to check for - corrupted values that could cause infinite loops. Closes ticket - 11737. + corrupted values that could cause infinite loops. Closes + ticket 11737. o Minor features (systemd): - Various improvements and modernizations in systemd hardening @@ -153,9 +153,10 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? - Drop the minimum RendPostPeriod on a testing network to 5 seconds, and the default on a testing network to 2 minutes. Drop the MIN_REND_INITIAL_POST_DELAY on a testing network to 5 seconds, but - keep the default on a testing network at 30 seconds. This reduces HS - bootstrap time to around 25 seconds. Also, change the default time - in test-network.sh to match. Closes ticket 13401. Patch by "teor". + keep the default on a testing network at 30 seconds. This reduces + HS bootstrap time to around 25 seconds. Also, change the default + time in test-network.sh to match. Closes ticket 13401. Patch + by "teor". - Create TestingDirAuthVoteHSDir to correspond to TestingDirAuthVoteExit/Guard. Ensures that authorities vote the HSDir flag for the listed relays regardless of uptime or ORPort @@ -174,9 +175,9 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? on 0.2.0.1-alpha. o Minor bugfixes (client DNS): - - Report the correct cached DNS expiration times on SOCKS port or in DNS replies. Previously, we - would report everything as "never expires." Fixes bug 14193; - bugfix on 0.2.3.17-beta. + - Report the correct cached DNS expiration times on SOCKS port or in + DNS replies. Previously, we would report everything as "never + expires." Fixes bug 14193; bugfix on 0.2.3.17-beta. - Avoid a small memory leak when we find a cached answer for a reverse DNS lookup in a client-side DNS cache. (Remember, client- side DNS caching is off by default, and is not recommended.) Fixes @@ -251,8 +252,8 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? o Minor bugfixes (hidden services): - Close the introduction circuit when we have no more usable intro points, instead of waiting for it to time out. This also ensures - that no follow-up HS descriptor fetch is triggered when the circuit - eventually times out. Fixes bug 14224; bugfix on 0.0.6. + that no follow-up HS descriptor fetch is triggered when the + circuit eventually times out. Fixes bug 14224; bugfix on 0.0.6. - When fetching a hidden service descriptor for a down service that was recently up, do not keep refetching until we try the same replica twice in a row. Fixes bug 14219; bugfix on 0.2.0.10-alpha.

1 0

[tor/master] Check for # characters in lintchanges
by nickm＠torproject.org 19 Feb '15

19 Feb '15

commit 94a877381de43d4042f1e151747457278070ad1e Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 19 09:54:09 2015 -0500 Check for # characters in lintchanges --- scripts/maint/lintChanges.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/maint/lintChanges.py b/scripts/maint/lintChanges.py index fcadc5e..69963ae 100755 --- a/scripts/maint/lintChanges.py +++ b/scripts/maint/lintChanges.py @@ -33,6 +33,9 @@ def lintfile(fname): contents = " ".join(contents.split()) + if re.search(r'\#\d{2,}', contents): + warn("don't use a # before ticket numbers") + if isBug and not re.search(r'(\d+)', contents): warn("bugfix does not mention a number") elif isBug and not re.search(r'Fixes ([a-z ]*)bug (\d+)', contents):

1 0

[tor/master] Check ENABLE_TOR2WEB_MODE before any tor2webmode code
by nickm＠torproject.org 19 Feb '15

19 Feb '15

commit 86105a4009bf3e128abfa3e735d8fa6f1f4d5975 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 19 09:09:25 2015 -0500 Check ENABLE_TOR2WEB_MODE before any tor2webmode code --- changes/bug12844_macros | 4 ++++ src/or/circuituse.c | 2 ++ src/or/config.c | 2 ++ src/or/connection_edge.c | 2 ++ src/or/rendclient.c | 7 ++++++- 5 files changed, 16 insertions(+), 1 deletion(-) diff --git a/changes/bug12844_macros b/changes/bug12844_macros new file mode 100644 index 0000000..bf3b2d8 --- /dev/null +++ b/changes/bug12844_macros @@ -0,0 +1,4 @@ + o Minor features (compilation): + - Do not compile any code related to Tor2Web mode when Tor2Web mode + is not enabled at compile time. Previously, this code was included + in a disabled state. See discussion on ticket #12844. diff --git a/src/or/circuituse.c b/src/or/circuituse.c index e11242a..d0d31ad 100644 --- a/src/or/circuituse.c +++ b/src/or/circuituse.c @@ -2036,11 +2036,13 @@ circuit_get_open_circ_or_launch(entry_connection_t *conn, else new_circ_purpose = desired_circuit_purpose; +#ifdef ENABLE_TOR2WEB_MODE if (options->Tor2webMode && (new_circ_purpose == CIRCUIT_PURPOSE_C_ESTABLISH_REND || new_circ_purpose == CIRCUIT_PURPOSE_C_INTRODUCING)) { want_onehop = 1; } +#endif { int flags = CIRCLAUNCH_NEED_CAPACITY; diff --git a/src/or/config.c b/src/or/config.c index f2c6221..fa0e753 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -3037,6 +3037,7 @@ options_validate(or_options_t *old_options, or_options_t *options, options->PredictedPortsRelevanceTime = MAX_PREDICTED_CIRCS_RELEVANCE; } +#ifdef ENABLE_TOR2WEB_MODE if (options->Tor2webMode && options->LearnCircuitBuildTimeout) { /* LearnCircuitBuildTimeout and Tor2webMode are incompatible in * two ways: @@ -3068,6 +3069,7 @@ options_validate(or_options_t *old_options, or_options_t *options, "Tor2WebMode is enabled; disabling UseEntryGuards."); options->UseEntryGuards = 0; } +#endif if (options->Tor2webRendezvousPoints && !options->Tor2webMode) { REJECT("Tor2webRendezvousPoints cannot be set without Tor2webMode."); diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c index dd2f8d4..3c817de 100644 --- a/src/or/connection_edge.c +++ b/src/or/connection_edge.c @@ -1278,6 +1278,7 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, return -1; } +#ifdef ENABLE_TOR2WEB_MODE /* If we're running in Tor2webMode, we don't allow anything BUT .onion * addresses. */ if (options->Tor2webMode) { @@ -1287,6 +1288,7 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn, connection_mark_unattached_ap(conn, END_STREAM_REASON_ENTRYPOLICY); return -1; } +#endif /* See if this is a hostname lookup that we can answer immediately. * (For example, an attempt to look up the IP address for an IP address.) diff --git a/src/or/rendclient.c b/src/or/rendclient.c index 0c02243..162e0ac 100644 --- a/src/or/rendclient.c +++ b/src/or/rendclient.c @@ -620,7 +620,12 @@ directory_get_from_hs_dir(const char *desc_id, const rend_data_t *rend_query) char desc_id_base32[REND_DESC_ID_V2_LEN_BASE32 + 1]; time_t now = time(NULL); char descriptor_cookie_base64[3*REND_DESC_COOKIE_LEN_BASE64]; +#ifdef ENABLE_TOR2WEB_MODE const int tor2web_mode = options->Tor2webMode; + const int how_to_fetch = tor2web_mode ? DIRIND_ONEHOP : DIRIND_ANONYMOUS; +#else + const int how_to_fetch = DIRIND_ANONYMOUS; +#endif int excluded_some; tor_assert(desc_id); tor_assert(rend_query); @@ -697,7 +702,7 @@ directory_get_from_hs_dir(const char *desc_id, const rend_data_t *rend_query) directory_initiate_command_routerstatus_rend(hs_dir, DIR_PURPOSE_FETCH_RENDDESC_V2, ROUTER_PURPOSE_GENERAL, - tor2web_mode?DIRIND_ONEHOP:DIRIND_ANONYMOUS, + how_to_fetch, desc_id_base32, NULL, 0, 0, rend_query);

1 0

[tor/master] Merge branch 'bug12844_macros'
by nickm＠torproject.org 19 Feb '15

19 Feb '15

commit b897e386da9f7e13eed123c7576046e4b40d410c Merge: 85f9794 86105a4 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 19 09:41:36 2015 -0500 Merge branch 'bug12844_macros' changes/bug12844_macros | 4 ++++ src/or/circuituse.c | 2 ++ src/or/config.c | 2 ++ src/or/connection_edge.c | 2 ++ src/or/rendclient.c | 7 ++++++- 5 files changed, 16 insertions(+), 1 deletion(-)

1 0

[tor/master] Merge branch 'bug13762_quiet_squashed'
by nickm＠torproject.org 19 Feb '15

19 Feb '15

commit 85f97941dff26508e703e76a78cd50d1e845b470 Merge: 0d46978 557a0c8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 19 09:40:41 2015 -0500 Merge branch 'bug13762_quiet_squashed' changes/bug13762_quiet | 5 +++++ src/or/routerlist.c | 43 ++++++++++++++++++++++++++++++++----------- 2 files changed, 37 insertions(+), 11 deletions(-)

1 0

[tor/master] Do not try to download an EI for which we don't have a matching SD.
by nickm＠torproject.org 19 Feb '15

19 Feb '15

commit 557a0c83f36eb1ea9a6c96aa94a488f4ce92f9ba Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 19 09:27:42 2015 -0500 Do not try to download an EI for which we don't have a matching SD. This quiets some log messages for #13762, and adds a better INFO message for the underlying confusion. --- changes/bug13762_quiet | 5 +++++ src/or/routerlist.c | 43 ++++++++++++++++++++++++++++++++----------- 2 files changed, 37 insertions(+), 11 deletions(-) diff --git a/changes/bug13762_quiet b/changes/bug13762_quiet new file mode 100644 index 0000000..df541cc --- /dev/null +++ b/changes/bug13762_quiet @@ -0,0 +1,5 @@ + o Minor bugfixes (directory authority): + - Do not attempt to download extrainfo documents which we will be + unable to validate with a matching server descriptor. Fixes bug + 13762; bugfix on 0.2.0.1-alpha. + diff --git a/src/or/routerlist.c b/src/or/routerlist.c index a0437ce..375732a 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -4705,7 +4705,34 @@ update_extrainfo_downloads(time_t now) ++n_pending; continue; } - if (router_get_by_extrainfo_digest(d) != sd) { + + const signed_descriptor_t *sd2 = router_get_by_extrainfo_digest(d); + if (sd2 != sd) { + if (sd2 != NULL) { + char d1[HEX_DIGEST_LEN+1], d2[HEX_DIGEST_LEN+1]; + char d3[HEX_DIGEST_LEN+1], d4[HEX_DIGEST_LEN+1]; + base16_encode(d1, sizeof(d1), sd->identity_digest, DIGEST_LEN); + base16_encode(d2, sizeof(d2), sd2->identity_digest, DIGEST_LEN); + base16_encode(d3, sizeof(d3), d, DIGEST_LEN); + base16_encode(d4, sizeof(d3), sd2->extra_info_digest, DIGEST_LEN); + + log_info(LD_DIR, "Found an entry in %s with mismatched " + "router_get_by_extrainfo_digest() value. This has ID %s " + "but the entry in the map has ID %s. This has EI digest " + "%s and the entry in the map has EI digest %s.", + old_routers?"old_routers":"routers", + d1, d2, d3, d4); + } else { + char d1[HEX_DIGEST_LEN+1], d2[HEX_DIGEST_LEN+1]; + base16_encode(d1, sizeof(d1), sd->identity_digest, DIGEST_LEN); + base16_encode(d2, sizeof(d2), d, DIGEST_LEN); + + log_info(LD_DIR, "Found an entry in %s with NULL " + "router_get_by_extrainfo_digest() value. This has ID %s " + "and EI digest %s.", + old_routers?"old_routers":"routers", + d1, d2); + } ++n_bogus[old_routers]; continue; } @@ -4715,16 +4742,10 @@ update_extrainfo_downloads(time_t now) digestmap_free(pending, NULL); log_info(LD_DIR, "Extrainfo download status: %d router with no ei, %d " - "with present ei, %d delaying, %d pending, %d downloadable.", - n_no_ei, n_have, n_delay, n_pending, smartlist_len(wanted)); - - if (n_bogus[0] || n_bogus[1]) { - static ratelim_t bogus_ei_warning = RATELIM_INIT(1800); - log_fn_ratelim(&bogus_ei_warning, LOG_WARN, LD_BUG, - "While downloading extrainfo documents, I found %d " - "inconsistencies in routers and %d inconsistencies in " - "old_routers.", n_bogus[0], n_bogus[1]); - } + "with present ei, %d delaying, %d pending, %d downloadable, %d " + "bogus in routers, %d bogus in old_routers", + n_no_ei, n_have, n_delay, n_pending, smartlist_len(wanted), + n_bogus[0], n_bogus[1]); smartlist_shuffle(wanted);

1 0

[tor/master] final cleanups
by arma＠torproject.org 19 Feb '15

19 Feb '15

commit df4b4407521a8df30c12564841c4e317fc8b9324 Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Feb 19 09:25:34 2015 -0500 final cleanups --- ChangeLog | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index e05ecb9..b6db380 100644 --- a/ChangeLog +++ b/ChangeLog @@ -295,7 +295,7 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? bug 14764; bugfix on 0.2.6.2-alpha. Reported by Christian Kujau. o Minor bugfixes (sandbox): - - Allow Glibc fatal errors to be sent to stderr before Tor exits. + - Allow glibc fatal errors to be sent to stderr before Tor exits. Previously, glibc would try to write them to /dev/tty, and the sandbox would trap the call and make Tor exit prematurely. Fixes bug 14759; bugfix on 0.2.5.1-alpha. @@ -778,7 +778,7 @@ Changes in version 0.2.6.1-alpha - 2014-10-30 messages that were generated before opening the log file were only logged to stdout. Closes ticket 6938. - Add a TruncateLogFile option to overwrite logs instead of - appending to them. Closes ticket #5583. + appending to them. Closes ticket 5583. o Minor features (portability, Solaris): - Threads are no longer disabled by default on Solaris; we believe @@ -830,7 +830,7 @@ Changes in version 0.2.6.1-alpha - 2014-10-30 - In circuit_build_times_calculate_timeout() in circuitstats.c, avoid dividing by zero in the pareto calculations. This traps under clang's "undefined-trap" sanitizer. Fixes bug 13290; bugfix - on tor-0.2.2.2-alpha. + on 0.2.2.2-alpha. - Fix an integer overflow in format_time_interval(). Fixes bug 13393; bugfix on 0.2.0.10-alpha. - Set the correct day of year value when the system's localtime(_r) @@ -1668,7 +1668,7 @@ Changes in version 0.2.5.5-alpha - 2014-06-18 o Removed code: - Remove /tor/dbg-stability.txt URL that was meant to help debug WFU - and MTBF calculations, but that nobody was using. Fixes #11742. + and MTBF calculations, but that nobody was using. Fixes ticket 11742. - The TunnelDirConns and PreferTunnelledDirConns options no longer exist; tunneled directory connections have been available since 0.1.2.5-alpha, and turning them off is not a good idea. This is a

1 0

[tor/master] sorry brits
by arma＠torproject.org 19 Feb '15

19 Feb '15

commit 0d46978de6f7f98fc29847951335a5c5c17dc8ae Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Feb 19 09:26:32 2015 -0500 sorry brits --- ChangeLog | 16 ++++++++-------- ReleaseNotes | 10 +++++----- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index b6db380..ed7abc3 100644 --- a/ChangeLog +++ b/ChangeLog @@ -378,9 +378,9 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? - Test that tor does not fail when key files are zero-length. Check that tor generates new keys, and overwrites the empty key files. - Test that tor generates new keys when keys are missing - (existing behaviour). + (existing behavior). - Test that tor does not overwrite key files that already contain - data (existing behaviour). Tests bug 13111. Patch by "teor". + data (existing behavior). Tests bug 13111. Patch by "teor". - New "make test-stem" target to run stem integration tests. Requires that the "STEM_SOURCE_DIR" environment variable be set. Closes ticket 14107. @@ -4311,7 +4311,7 @@ Changes in version 0.2.3.23-rc - 2012-10-20 - Correct file sizes when reading binary files on Cygwin, to avoid a bug where Tor would fail to read its state file. Fixes bug 6844; bugfix on 0.1.2.7-alpha. - - Avoid undefined behaviour when parsing the list of supported + - Avoid undefined behavior when parsing the list of supported rendezvous/introduction protocols in a hidden service descriptor. Previously, Tor would have confused (as-yet-unused) protocol version numbers greater than 32 with lower ones on many platforms. Fixes @@ -4387,7 +4387,7 @@ Changes in version 0.2.4.3-alpha - 2012-09-22 - Reject consensus votes with more than 64 known-flags. We aren't even close to that limit yet, and our code doesn't handle it correctly. Fixes bug 6833; bugfix on 0.2.0.1-alpha. - - Avoid undefined behaviour when parsing the list of supported + - Avoid undefined behavior when parsing the list of supported rendezvous/introduction protocols in a hidden service descriptor. Previously, Tor would have confused (as-yet-unused) protocol version numbers greater than 32 with lower ones on many platforms. Fixes @@ -5824,7 +5824,7 @@ Changes in version 0.2.3.11-alpha - 2012-01-22 be disabled using the new CloseHSClientCircuitsImmediatelyOnTimeout option. Fixes part of bug 1297; bugfix on 0.2.2.2-alpha. - Don't close hidden-service-side rendezvous circuits when they - reach the normal circuit-build timeout. This behaviour change can + reach the normal circuit-build timeout. This behavior change can be disabled using the new CloseHSServiceRendCircuitsImmediatelyOnTimeout option. Fixes the remaining part of bug 1297; bugfix on 0.2.2.2-alpha. @@ -7405,14 +7405,14 @@ Changes in version 0.2.2.29-beta - 2011-06-20 directory's group would be checked against the current group, not the configured group. Patch by Jérémy Bobbio. Fixes bug 3393; bugfix on 0.2.2.26-beta. - - Make connection_printf_to_buf()'s behaviour sane. Its callers + - Make connection_printf_to_buf()'s behavior sane. Its callers expect it to emit a CRLF iff the format string ends with CRLF; it actually emitted a CRLF iff (a) the format string ended with CRLF or (b) the resulting string was over 1023 characters long or (c) the format string did not end with CRLF *and* the resulting string was 1021 characters long or longer. Bugfix on 0.1.1.9-alpha; fixes part of bug 3407. - - Make send_control_event_impl()'s behaviour sane. Its callers + - Make send_control_event_impl()'s behavior sane. Its callers expect it to always emit a CRLF at the end of the string; it might have emitted extra control characters as well. Bugfix on 0.1.1.9-alpha; fixes another part of bug 3407. @@ -9513,7 +9513,7 @@ Changes in version 0.2.2.9-alpha - 2010-02-22 - Avoid a bogus overlapped memcpy in tor_addr_copy(). Reported by "memcpyfail". - Make the DNSPort option work with libevent 2.x. Don't alter the - behaviour for libevent 1.x. Fixes bug 1143. Found by SwissTorExit. + behavior for libevent 1.x. Fixes bug 1143. Found by SwissTorExit. - Emit a GUARD DROPPED controller event for a case we missed. - Make more fields in the controller protocol case-insensitive, since control-spec.txt said they were. diff --git a/ReleaseNotes b/ReleaseNotes index 9d5b8ae..a9c8cee 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -2883,7 +2883,7 @@ Changes in version 0.2.3.25 - 2012-11-19 but not that other sensitive operations on the client and service side are not performed using single-hop circuits. Fixes bug 3332; bugfix on 0.0.6. - - Avoid undefined behaviour when parsing the list of supported + - Avoid undefined behavior when parsing the list of supported rendezvous/introduction protocols in a hidden service descriptor. Previously, Tor would have confused (as-yet-unused) protocol version numbers greater than 32 with lower ones on many platforms. Fixes @@ -2901,7 +2901,7 @@ Changes in version 0.2.3.25 - 2012-11-19 o Minor bugfixes (hidden services, service-side): - Don't close hidden-service-side rendezvous circuits when they - reach the normal circuit-build timeout. This behaviour change can + reach the normal circuit-build timeout. This behavior change can be disabled using the new CloseHSServiceRendCircuitsImmediatelyOnTimeout option. Fixes the remaining part of bug 1297; bugfix on 0.2.2.2-alpha. @@ -4730,7 +4730,7 @@ Changes in version 0.2.2.32 - 2011-08-27 - Resolve an edge case in path weighting that could make us misweight our relay selection. Fixes bug 1203; bugfix on 0.0.8rc1. - Make the DNSPort option work with libevent 2.x. Don't alter the - behaviour for libevent 1.x. Fixes bug 1143. Found by SwissTorExit. + behavior for libevent 1.x. Fixes bug 1143. Found by SwissTorExit. o Minor bugfixes (directory authorities): - Make directory authorities more accurate at recording when @@ -4945,14 +4945,14 @@ Changes in version 0.2.2.32 - 2011-08-27 passing it to the kernel. (Not a security issue: kernels are smart enough to reject bad sockaddr_uns.) Found by Coverity; CID #428. Bugfix on Tor 0.2.0.3-alpha. - - Make connection_printf_to_buf()'s behaviour sane. Its callers + - Make connection_printf_to_buf()'s behavior sane. Its callers expect it to emit a CRLF iff the format string ends with CRLF; it actually emitted a CRLF iff (a) the format string ended with CRLF or (b) the resulting string was over 1023 characters long or (c) the format string did not end with CRLF *and* the resulting string was 1021 characters long or longer. Bugfix on 0.1.1.9-alpha; fixes part of bug 3407. - - Make send_control_event_impl()'s behaviour sane. Its callers + - Make send_control_event_impl()'s behavior sane. Its callers expect it to always emit a CRLF at the end of the string; it might have emitted extra control characters as well. Bugfix on 0.1.1.9-alpha; fixes another part of bug 3407.

1 0

[tor/master] reach into the past and fix two changelog stanzas
by arma＠torproject.org 19 Feb '15

19 Feb '15

commit 0615cc82d47deb71a2721253cd580bdd257e7685 Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Feb 19 09:11:13 2015 -0500 reach into the past and fix two changelog stanzas --- ChangeLog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6c18d81..e05ecb9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -483,7 +483,7 @@ Changes in version 0.2.6.2-alpha - 2014-12-31 circuits until we have successfully built a circuit. This makes hidden services come up faster when the network is re-enabled. Patch from "akwizgran". Closes ticket 13447. - - When we fail to a retrieve hidden service descriptor, send the + - When we fail to retrieve a hidden service descriptor, send the controller an "HS_DESC FAILED" controller event. Implements feature 13212. - New HiddenServiceDirGroupReadable option to cause hidden service @@ -726,7 +726,7 @@ Changes in version 0.2.6.1-alpha - 2014-10-30 o Major bugfixes (directory authorities): - Do not assign the HSDir flag to relays if they are not Valid, or - currently hibernating. Fixes #12573. Bugfix on tor-0.2.0.10-alpha + currently hibernating. Fixes 12573; bugfix on 0.2.0.10-alpha. o Major bugfixes (directory bandwidth performance): - Don't flush the zlib buffer aggressively when compressing

1 0

[tor/master] some more changelog cleanups
by arma＠torproject.org 19 Feb '15

19 Feb '15

commit 55e2c0536dc6613c0a3cdb69e1bbef0a841cbf92 Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Feb 19 09:07:14 2015 -0500 some more changelog cleanups --- ChangeLog | 42 +++++++++++++++++++++--------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/ChangeLog b/ChangeLog index e19ad9f..6c18d81 100644 --- a/ChangeLog +++ b/ChangeLog @@ -194,45 +194,45 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? - When we are using bridges and we had a network connectivity problem, only retry connecting to our currently configured bridges, not all bridges we know about and remember using. Fixes - bug 14216; bugfix on tor-0.2.2.17-alpha. Patch from arma. + bug 14216; bugfix on 0.2.2.17-alpha. - o Minor bugfixes (client, IPV6): + o Minor bugfixes (client, IPv6): - Reject socks requests to literal IPv6 addresses when IPv6Traffic flag is not set; and not because the NoIPv4Traffic flag was set. Previously we'd looked at the NoIPv4Traffic flag for both types of literal addresses. Fixes bug 14280; bugfix on 0.2.4.7-alpha. o Minor bugfixes (compilation): - - Build without warnings with the stock OpenSSL srtp.h header, which - has a duplicate declaration of SSL_get_selected_srtp_profile(). - Fixes bug 14220; this is OpenSSL's bug, not ours. - The address of an array in the middle of a structure will always be non-NULL. clang recognises this and complains. Disable the tautologous and redundant check to silence this warning. Fixes bug 14001; bugfix on 0.2.1.2-alpha. - - Compile correctly with (unreleased) OpenSSL 1.1.0 headers. - Addresses ticket 14188. - Avoid warnings when building with systemd 209 or later. Fixes bug 14072; bugfix on 0.2.6.2-alpha. Patch from "h.venev". + - Compile correctly with (unreleased) OpenSSL 1.1.0 headers. + Addresses ticket 14188. + - Build without warnings with the stock OpenSSL srtp.h header, which + has a duplicate declaration of SSL_get_selected_srtp_profile(). + Fixes bug 14220; this is OpenSSL's bug, not ours. - Remove the --disable-threads configure option again. It was accidentally partially reintroduced in 29ac883606d6d. Fixes bug 14819; bugfix on 0.2.6.2-alpha. o Minor bugfixes (controller): - - Add a code for the END_CIRC_REASON_IP_NOW_REDUNDANT circuit close - reason. Fixes bug 14207; bugfix on 0.2.6.2-alpha. - - Avoid crashing on a malformed EXTENDCIRCUIT command. Fixes bug - 14116; bugfix on 0.2.2.9-alpha. - Report "down" in response to the "GETINFO entry-guards" command when relays are down with an unreachable_since value. Previously, we would report "up". Fixes bug 14184; bugfix on 0.1.2.2-alpha. + - Avoid crashing on a malformed EXTENDCIRCUIT command. Fixes bug + 14116; bugfix on 0.2.2.9-alpha. + - Add a code for the END_CIRC_REASON_IP_NOW_REDUNDANT circuit close + reason. Fixes bug 14207; bugfix on 0.2.6.2-alpha. o Minor bugfixes (directory authority): - Allow directory authorities to fetch more data from one another if they find themselves missing lots of votes. Previously, they had been bumping against the 10 MB queued data limit. Fixes bug 14261; bugfix on 0.1.2.5-alpha. - - Enlarge the buffer to read bw-auth generated files to avoid an + - Enlarge the buffer to read bwauth generated files to avoid an issue when parsing the file in dirserv_read_measured_bandwidths(). Fixes bug 14125; bugfix on 0.2.2.1-alpha. @@ -243,19 +243,19 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? - Stop generating a fresh .old RSA onion key file when the .old file is missing. Fixes part of 13111; bugfix on 0.0.6rc1. - Avoid overwriting .old key files with empty key files. - - Skip loading zero-length extra info store, router store, stats, + - Skip loading zero-length extrainfo store, router store, stats, state, and key files. - Avoid crashing when trying to reload a torrc specified as a relative path with RunAsDaemon turned on. Fixes bug 13397; bugfix on 0.2.3.11-alpha. o Minor bugfixes (hidden services): - - Close the introduction circuit when we have no, more usable intro - points, instead of waiting for it to time out. This also make sure - no extra HS descriptor fetch is triggered. Fixes bug 14224; bugfix - on 0.0.6. + - Close the introduction circuit when we have no more usable intro + points, instead of waiting for it to time out. This also ensures + that no follow-up HS descriptor fetch is triggered when the circuit + eventually times out. Fixes bug 14224; bugfix on 0.0.6. - When fetching a hidden service descriptor for a down service that - we recently up, do not keep refetching until we try the same + was recently up, do not keep refetching until we try the same replica twice in a row. Fixes bug 14219; bugfix on 0.2.0.10-alpha. - Successfully launch Tor with a nonexistent hidden service directory. Our fix for bug 13942 didn't catch this case. Fixes bug @@ -280,7 +280,7 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? - When deciding whether the consensus lists any exit nodes, count the number listed in the consensus, not the number we have descriptors for. Fixes part of bug 14918; bugfix on 0.2.6.2-alpha. - - When deciding whether we have any exit nodes, only process + - When deciding whether we have any exit nodes, only examine ExitNodes when the ExitNodes option is actually set. Fixes part of bug 14918; bugfix on 0.2.6.2-alpha. - Get rid of redundant and possibly scary warnings that we are @@ -365,8 +365,8 @@ Changes in version 0.2.6.3-alpha - 2015-02-2? ntor onion key. Closes ticket 9635. o Removed features: - - To avoid confusion with the 'ExitRelay' option, 'ExitNode' is no - longer silently accepted as an alias for 'ExitNodes'. + - To avoid confusion with the "ExitRelay" option, "ExitNode" is no + longer silently accepted as an alias for "ExitNodes". - The --enable-mempool and --enable-buf-freelists options, which were originally created to work around bad malloc implementations, no longer exist. They were off-by-default in 0.2.5. Closes

1 0