October 2015 - tor-commits - lists.torproject.org

[tor-commits] [translation/tor-messenger-accountsproperties_completed] Update translations for tor-messenger-accountsproperties_completed
by translation＠torproject.org 21 Oct '15

21 Oct '15

commit b1aa981dba841074355b593e4681832b5a1b21a1 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 21 20:16:08 2015 +0000 Update translations for tor-messenger-accountsproperties_completed --- ta/accounts.properties | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/ta/accounts.properties b/ta/accounts.properties new file mode 100644 index 0000000..b92151c --- /dev/null +++ b/ta/accounts.properties @@ -0,0 +1,9 @@ +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. + +# LOCALIZATION NOTE (passwordPromptTitle, passwordPromptText): +# %S is replaced with the name of the account +passwordPromptTitle=%S இன் கடவுச்சொல் +passwordPromptText=அது இணைக்க வேண்டும் %S உங்கள் கடவுச்சொல்லை உள்ளிடவும். +passwordPromptSaveCheckbox=இந்த கடவுச்சொல்லை நினைவில் கொள்ள கடவுச்சொல் மேலாளர் பயன்படுத்தவும்.

1 0

[translation/tor-messenger-accountsproperties] Update translations for tor-messenger-accountsproperties
by translation＠torproject.org 21 Oct '15

21 Oct '15

commit 2f4b4d77722cf68263c55fa0e39a8d12b19b5dcf Author: Translation commit bot <translation(a)torproject.org> Date: Wed Oct 21 20:16:03 2015 +0000 Update translations for tor-messenger-accountsproperties --- ta/accounts.properties | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ta/accounts.properties b/ta/accounts.properties index 051ba0d..b92151c 100644 --- a/ta/accounts.properties +++ b/ta/accounts.properties @@ -4,6 +4,6 @@ # LOCALIZATION NOTE (passwordPromptTitle, passwordPromptText): # %S is replaced with the name of the account -passwordPromptTitle=Password for %S -passwordPromptText=Please enter your password for %S in order to connect it. -passwordPromptSaveCheckbox=Use Password Manager to remember this password. +passwordPromptTitle=%S இன் கடவுச்சொல் +passwordPromptText=அது இணைக்க வேண்டும் %S உங்கள் கடவுச்சொல்லை உள்ளிடவும். +passwordPromptSaveCheckbox=இந்த கடவுச்சொல்லை நினைவில் கொள்ள கடவுச்சொல் மேலாளர் பயன்படுத்தவும்.

1 0

[tor/master] Fix various coverity-found issues
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit 5e9f2384cf0f97646d7ee1b9eccaab4dfe382536 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 16:01:29 2015 -0400 Fix various coverity-found issues --- src/common/tortls.c | 5 ++++- src/test/test_rendcache.c | 7 ++++--- src/test/test_tortls.c | 3 ++- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/common/tortls.c b/src/common/tortls.c index 2a2a5d7..1057cf4 100644 --- a/src/common/tortls.c +++ b/src/common/tortls.c @@ -891,9 +891,12 @@ tor_tls_cert_is_valid(int severity, { check_no_tls_errors(); EVP_PKEY *cert_key; - EVP_PKEY *signing_key = X509_get_pubkey(signing_cert->cert); int r, key_ok = 0; + if (!signing_cert) + goto bad; + + EVP_PKEY *signing_key = X509_get_pubkey(signing_cert->cert); if (!signing_key) goto bad; r = X509_verify(cert->cert, signing_key); diff --git a/src/test/test_rendcache.c b/src/test/test_rendcache.c index dda527f..11f1114 100644 --- a/src/test/test_rendcache.c +++ b/src/test/test_rendcache.c @@ -30,8 +30,8 @@ mock_rend_data(const char *onion_address) { rend_data_t *rend_query = tor_malloc_zero(sizeof(rend_data_t)); - strncpy(rend_query->onion_address, onion_address, - REND_SERVICE_ID_LEN_BASE32+1); + strlcpy(rend_query->onion_address, onion_address, + sizeof(rend_query->onion_address)); rend_query->auth_type = REND_NO_AUTH; rend_query->hsdirs_fp = smartlist_new(); smartlist_add(rend_query->hsdirs_fp, tor_memdup("aaaaaaaaaaaaaaaaaaaaaaaa", @@ -1041,7 +1041,7 @@ test_rend_cache_purge(void *data) rend_cache_purge(); tt_assert(rend_cache); tt_assert(strmap_size(rend_cache) == 0); - tt_assert(rend_cache != our_rend_cache); + tt_assert(rend_cache == our_rend_cache); done: rend_cache_free_all(); @@ -1244,6 +1244,7 @@ test_rend_cache_failure_purge(void *data) rend_cache_failure_purge(); + tt_ptr_op(rend_cache_failure, OP_NE, NULL); tt_int_op(strmap_size(rend_cache_failure), OP_EQ, 0); done: diff --git a/src/test/test_tortls.c b/src/test/test_tortls.c index 4d92e17..944edc4 100644 --- a/src/test/test_tortls.c +++ b/src/test/test_tortls.c @@ -663,7 +663,7 @@ test_tortls_cert_get_key(void *ignored) { (void)ignored; tor_x509_cert_t *cert = NULL; - crypto_pk_t *res; + crypto_pk_t *res = NULL; cert = tor_malloc_zero(sizeof(tor_x509_cert_t)); X509 *key = NULL; key = tor_malloc_zero(sizeof(X509)); @@ -684,6 +684,7 @@ test_tortls_cert_get_key(void *ignored) done: fake_x509_free(key); tor_free(cert); + crypto_pk_free(res); } #endif

1 0

[tor/master] forwardport the changelog for 0.2.7.4-rc
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit bebf6c6c676e9d8df73743b2619bda23a59c54df Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 15:34:30 2015 -0400 forwardport the changelog for 0.2.7.4-rc --- ChangeLog | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/ChangeLog b/ChangeLog index 46005a9..4c4d014 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,71 @@ +Changes in version 0.2.7.4-rc - 2015-10-21 + Tor 0.2.7.4-rc is the second release candidate in the 0.2.7 series. It + fixes some important memory leaks, and a scary-looking (but mostly + harmless in practice) invalid-read bug. It also has a few small + bugfixes, notably fixes for compilation and portability on different + platforms. If no further significant bounds are found, the next + release will the the official stable release. + + o Major bugfixes (security, correctness): + - Fix an error that could cause us to read 4 bytes before the + beginning of an openssl string. This bug could be used to cause + Tor to crash on systems with unusual malloc implementations, or + systems with unusual hardening installed. Fixes bug 17404; bugfix + on 0.2.3.6-alpha. + + o Major bugfixes (correctness): + - Fix a use-after-free bug in validate_intro_point_failure(). Fixes + bug 17401; bugfix on 0.2.7.3-rc. + + o Major bugfixes (memory leaks): + - Fix a memory leak in ed25519 batch signature checking. Fixes bug + 17398; bugfix on 0.2.6.1-alpha. + - Fix a memory leak in rend_cache_failure_entry_free(). Fixes bug + 17402; bugfix on 0.2.7.3-rc. + - Fix a memory leak when reading an expired signing key from disk. + Fixes bug 17403; bugfix on 0.2.7.2-rc. + + o Minor features (geoIP): + - Update geoip and geoip6 to the October 9 2015 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (compilation): + - Repair compilation with the most recent (unreleased, alpha) + vesions of OpenSSL 1.1. Fixes part of ticket 17237. + - Fix an integer overflow warning in test_crypto_slow.c. Fixes bug + 17251; bugfix on 0.2.7.2-alpha. + - Fix compilation of sandbox.c with musl-libc. Fixes bug 17347; + bugfix on 0.2.5.1-alpha. Patch from 'jamestk'. + + o Minor bugfixes (portability): + - Use libexecinfo on FreeBSD to enable backtrace support. Fixes + part of bug 17151; bugfix on 0.2.5.2-alpha. Patch from + Marcin Cieślak. + + o Minor bugfixes (sandbox): + - Add the "hidserv-stats" filename to our sandbox filter for the + HiddenServiceStatistics option to work properly. Fixes bug 17354; + bugfix on tor-0.2.6.2-alpha. Patch from David Goulet. + + o Minor bugfixes (testing): + - Add unit tests for get_interface_address* failure cases. Fixes bug + 17173; bugfix on 0.2.7.3-rc. Patch by fk/teor. + - Fix breakage when running 'make check' with BSD make. Fixes bug + 17154; bugfix on 0.2.7.3-rc. Patch by Marcin Cieślak. + - Make the get_ifaddrs_* unit tests more tolerant of different + network configurations. (Don't assume every test box has an IPv4 + address, and don't assume every test box has a non-localhost + address.) Fixes bug 17255; bugfix on 0.2.7.3-rc. Patch by "teor". + - Skip backtrace tests when backtrace support is not compiled in. + Fixes part of bug 17151; bugfix on 0.2.7.1-alpha. Patch from + Marcin Cieślak. + + o Documentation: + - Fix capitalization of SOCKS in sample torrc. Closes ticket 15609. + - Note that HiddenServicePorts can take a unix domain socket. Closes + ticket 17364. + + Changes in version 0.2.7.3-rc - 2015-09-25 Tor 0.2.7.3-rc is the first release candidate in the 0.2.7 series. It contains numerous usability fixes for Ed25519 keys, safeguards against

1 0

[webwml/master] trivial change to try rebuild. I forgot to tag.
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit a12fd3f1ce839cb2c1c256226159bbe9ef1f1843 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 15:28:48 2015 -0400 trivial change to try rebuild. I forgot to tag. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 3f827f6..16a3328 100644 --- a/Makefile +++ b/Makefile @@ -17,6 +17,7 @@ export STABLETAG=tor-0.2.6.10 export DEVTAG=tor-0.2.7.4-rc + WMLBASE=. SUBDIRS=docs eff projects press about download getinvolved donate docs/torbutton include $(WMLBASE)/Makefile.local

1 0

[webwml/master] Bump 0.2.7.{3->4}-rc on website
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit 3a35b79f5e0e949adae40aa19a8dba3148b50e0b Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 15:23:10 2015 -0400 Bump 0.2.7.{3->4}-rc on website --- Makefile | 2 +- include/versions.wmi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index d949bdf..3f827f6 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ # website component, and set it to needs_review. export STABLETAG=tor-0.2.6.10 -export DEVTAG=tor-0.2.7.3-rc +export DEVTAG=tor-0.2.7.4-rc WMLBASE=. SUBDIRS=docs eff projects press about download getinvolved donate docs/torbutton diff --git a/include/versions.wmi b/include/versions.wmi index 8162d0a..76cb6d1 100644 --- a/include/versions.wmi +++ b/include/versions.wmi @@ -1,5 +1,5 @@ <define-tag version-stable whitespace=delete>0.2.6.10</define-tag> -<define-tag version-alpha whitespace=delete>0.2.7.3-rc</define-tag> +<define-tag version-alpha whitespace=delete>0.2.7.4-rc</define-tag> <define-tag version-win32-stable whitespace=delete>0.2.6.10</define-tag>

1 0

[tor/release-0.2.7] remove a comma that coderman didn't like
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit f55d23e1e66e9b0f6971016a9c880341e0209db0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 15:13:31 2015 -0400 remove a comma that coderman didn't like --- ChangeLog | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5226fef..0e6fe6a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -38,9 +38,8 @@ Changes in version 0.2.7.4-rc - 2015-10-21 bugfix on 0.2.5.1-alpha. Patch from 'jamestk'. o Minor bugfixes (portability): - - Use libexecinfo on FreeBSD, to enable backtrace support. Fixes - part of bug 17151; bugfix on 0.2.5.2-alpha. Patch from - Marcin Cieślak. + - Use libexecinfo on FreeBSD to enable backtrace support. Fixes part + of bug 17151; bugfix on 0.2.5.2-alpha. Patch from Marcin Cieślak. o Minor bugfixes (sandbox): - Add the "hidserv-stats" filename to our sandbox filter for the

1 0

[tor/release-0.2.7] Reflow changelog
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit 5f60216b3b7bbe335f6e0f07452b46c38bb97d0c Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 15:10:21 2015 -0400 Reflow changelog --- ChangeLog | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index afddbba..5226fef 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,15 +1,15 @@ Changes in version 0.2.7.4-rc - 2015-10-21 - Tor 0.2.7.4-rc is the second release candidate in the 0.2.7 series. - It fixes some important memory leaks, and a scary-looking (but mostly - harmless in practice) invalid-read bug. It also has a few small + Tor 0.2.7.4-rc is the second release candidate in the 0.2.7 series. It + fixes some important memory leaks, and a scary-looking (but mostly + harmless in practice) invalid-read bug. It also has a few small bugfixes, notably fixes for compilation and portability on different platforms. If no further significant bounds are found, the next release will the the official stable release. o Major bugfixes (security, correctness): - - Fix an error that could cause us to read 4 bytes before - the beginning of an openssl string. This bug could be used to - cause Tor to crash on systems with unusual malloc implementations, or + - Fix an error that could cause us to read 4 bytes before the + beginning of an openssl string. This bug could be used to cause + Tor to crash on systems with unusual malloc implementations, or systems with unusual hardening installed. Fixes bug 17404; bugfix on 0.2.3.6-alpha.

1 0

[tor/release-0.2.7] Edit more changelog text (thanks to rl1987 for noticing)
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit 08b96160fc39720cbe3a2a2e2aa51694e303bb08 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 14:42:47 2015 -0400 Edit more changelog text (thanks to rl1987 for noticing) --- ChangeLog | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6d40010..afddbba 100644 --- a/ChangeLog +++ b/ChangeLog @@ -45,7 +45,7 @@ Changes in version 0.2.7.4-rc - 2015-10-21 o Minor bugfixes (sandbox): - Add the "hidserv-stats" filename to our sandbox filter for the HiddenServiceStatistics option to work properly. Fixes bug 17354; - bugfix on tor-0.2.6.2-alpha~54^2~1. Patch from David Goulet. + bugfix on tor-0.2.6.2-alpha. Patch from David Goulet. o Minor bugfixes (testing): - Add unit tests for get_interface_address* failure cases. Fixes bug @@ -54,7 +54,7 @@ Changes in version 0.2.7.4-rc - 2015-10-21 17154; bugfix on 0.2.7.3-rc. Patch by Marcin Cieślak. - Make the get_ifaddrs_* unit tests more tolerant of different network configurations. (Don't assume every test box has an IPv4 - address, and Don't assume every test box has a non-localhost + address, and don't assume every test box has a non-localhost address.) Fixes bug 17255; bugfix on 0.2.7.3-rc. Patch by "teor". - Skip backtrace tests when backtrace support is not compiled in. Fixes part of bug 17151; bugfix on 0.2.7.1-alpha. Patch from

1 0

[tor/release-0.2.7] Edit some changelog text
by nickm＠torproject.org 21 Oct '15

21 Oct '15

commit 1512e7e5398701aa3a33acbf7b884e5d1409608b Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 21 14:34:48 2015 -0400 Edit some changelog text --- ChangeLog | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index 077e8a4..6d40010 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,14 +1,16 @@ Changes in version 0.2.7.4-rc - 2015-10-21 - Tor 0.2.7.4-rc is the second release candidate in the 0.2.7 servies. - It a few small bugfixes, notably fixes for compilation and portability - on different platforms. If no further significant bounds are found, - the next release will the the official stable release. + Tor 0.2.7.4-rc is the second release candidate in the 0.2.7 series. + It fixes some important memory leaks, and a scary-looking (but mostly + harmless in practice) invalid-read bug. It also has a few small + bugfixes, notably fixes for compilation and portability on different + platforms. If no further significant bounds are found, the next + release will the the official stable release. o Major bugfixes (security, correctness): - - Fix a programming error that could cause us to read 4 bytes before - the beginning of an openssl string. This could be used to provoke - a crash on systems with an unusual malloc implementation, or - systems with unsual hardening installed. Fixes bug 17404; bugfix + - Fix an error that could cause us to read 4 bytes before + the beginning of an openssl string. This bug could be used to + cause Tor to crash on systems with unusual malloc implementations, or + systems with unusual hardening installed. Fixes bug 17404; bugfix on 0.2.3.6-alpha. o Major bugfixes (correctness):

1 0