September 2014 - tor-commits - lists.torproject.org

[tor/maint-0.2.5] Bump maint-0.2.5 to 0.2.5.7-rc-dev
by nickm＠torproject.org 12 Sep '14

12 Sep '14

commit 550c03336ccc256dd9221d2cf9fdc5cef1f87908 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 21:38:32 2014 -0400 Bump maint-0.2.5 to 0.2.5.7-rc-dev --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index c37f154..676fad1 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ dnl Copyright (c) 2004-2006, Roger Dingledine, Nick Mathewson dnl Copyright (c) 2007-2013, The Tor Project, Inc. dnl See LICENSE for licensing information -AC_INIT([tor],[0.2.5.6-alpha]) +AC_INIT([tor],[0.2.5.7-rc-dev]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) AM_INIT_AUTOMAKE diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 5d94fd9..2415f45 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.2.5.6-alpha" +!define VERSION "0.2.5.7-rc-dev" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 9873955..43ccbc5 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -241,7 +241,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.2.5.6-alpha" +#define VERSION "0.2.5.7-rc-dev"

1 0

r26948: {website} 0.2.5.7-rc tarball is up (in website/trunk: . include)
by Roger Dingledine 12 Sep '14

12 Sep '14

Author: arma Date: 2014-09-12 01:36:27 +0000 (Fri, 12 Sep 2014) New Revision: 26948 Modified: website/trunk/Makefile website/trunk/include/versions.wmi Log: 0.2.5.7-rc tarball is up Modified: website/trunk/Makefile =================================================================== --- website/trunk/Makefile 2014-09-10 12:28:52 UTC (rev 26947) +++ website/trunk/Makefile 2014-09-12 01:36:27 UTC (rev 26948) @@ -11,7 +11,7 @@ # 5. ./publish export STABLETAG=tor-0.2.4.23 -export DEVTAG=tor-0.2.5.6-alpha +export DEVTAG=tor-0.2.5.7-rc WMLBASE=. SUBDIRS=docs eff projects press about download getinvolved donate docs/torbutton Modified: website/trunk/include/versions.wmi =================================================================== --- website/trunk/include/versions.wmi 2014-09-10 12:28:52 UTC (rev 26947) +++ website/trunk/include/versions.wmi 2014-09-12 01:36:27 UTC (rev 26948) @@ -1,5 +1,5 @@ <define-tag version-stable whitespace=delete>0.2.4.23</define-tag> -<define-tag version-alpha whitespace=delete>0.2.5.6-alpha</define-tag> +<define-tag version-alpha whitespace=delete>0.2.5.7-rc</define-tag> <define-tag version-win32-stable whitespace=delete>0.2.4.23</define-tag> <define-tag version-win32-alpha whitespace=delete>0.2.4.23</define-tag>

1 0

[tor/master] forward-port changelog from 0.2.5.7-rc
by nickm＠torproject.org 12 Sep '14

12 Sep '14

commit 383238b2f6d30120f1f5c9f99327c3194dbd0654 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 21:25:03 2014 -0400 forward-port changelog from 0.2.5.7-rc --- ChangeLog | 102 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+) diff --git a/ChangeLog b/ChangeLog index 688d655..34d9fec 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,108 @@ Changes in version 0.2.6.1-alpha - 2014-??-?? +Changes in version 0.2.5.7-rc - 2014-09-11 + Tor 0.2.5.7-rc fixes several regressions from earlier in the 0.2.5.x + release series, and some long-standing bugs related to ORPort reachability + testing and failure to send CREATE cells. It is the first release + candidate for the Tor 0.2.5.x series. + + o Major bugfixes (client, startup): + - Start making circuits as soon as DisabledNetwork is turned off. + When Tor started with DisabledNetwork set, it would correctly + conclude that it shouldn't build circuits, but it would mistakenly + cache this conclusion, and continue believing it even when + DisableNetwork is set to 0. Fixes the bug introduced by the fix + for bug 11200; bugfix on 0.2.5.4-alpha. + - Resume expanding abbreviations for command-line options. The fix + for bug 4647 accidentally removed our hack from bug 586 that + rewrote HashedControlPassword to __HashedControlSessionPassword + when it appears on the commandline (which allowed the user to set + her own HashedControlPassword in the torrc file while the + controller generates a fresh session password for each run). Fixes + bug 12948; bugfix on 0.2.5.1-alpha. + - Warn about attempts to run hidden services and relays in the same + process: that's probably not a good idea. Closes ticket 12908. + + o Major bugfixes (relay): + - Avoid queuing or sending destroy cells for circuit ID zero when we + fail to send a CREATE cell. Fixes bug 12848; bugfix on 0.0.8pre1. + Found and fixed by "cypherpunks". + - Fix ORPort reachability detection on relays running behind a + proxy, by correctly updating the "local" mark on the controlling + channel when changing the address of an or_connection_t after the + handshake. Fixes bug 12160; bugfix on 0.2.4.4-alpha. + + o Minor features (bridge): + - Add an ExtORPortCookieAuthFileGroupReadable option to make the + cookie file for the ExtORPort g+r by default. + + o Minor features (geoip): + - Update geoip and geoip6 to the August 7 2014 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (logging): + - Reduce the log severity of the "Pluggable transport proxy does not + provide any needed transports and will not be launched." message, + since Tor Browser includes several ClientTransportPlugin lines in + its torrc-defaults file, leading every Tor Browser user who looks + at her logs to see these notices and wonder if they're dangerous. + Resolves bug 13124; bugfix on 0.2.5.3-alpha. + - Downgrade "Unexpected onionskin length after decryption" warning + to a protocol-warn, since there's nothing relay operators can do + about a client that sends them a malformed create cell. Resolves + bug 12996; bugfix on 0.0.6rc1. + - Log more specific warnings when we get an ESTABLISH_RENDEZVOUS + cell on a cannibalized or non-OR circuit. Resolves ticket 12997. + - When logging information about an EXTEND2 or EXTENDED2 cell, log + their names correctly. Fixes part of bug 12700; bugfix + on 0.2.4.8-alpha. + - When logging information about a relay cell whose command we don't + recognize, log its command as an integer. Fixes part of bug 12700; + bugfix on 0.2.1.10-alpha. + - Escape all strings from the directory connection before logging + them. Fixes bug 13071; bugfix on 0.1.1.15. Patch from "teor". + + o Minor bugfixes (controller): + - Restore the functionality of CookieAuthFileGroupReadable. Fixes + bug 12864; bugfix on 0.2.5.1-alpha. + - Actually send TRANSPORT_LAUNCHED and HS_DESC events to + controllers. Fixes bug 13085; bugfix on 0.2.5.1-alpha. Patch + by "teor". + + o Minor bugfixes (compilation): + - Fix compilation of test.h with MSVC. Patch from Gisle Vanem; + bugfix on 0.2.5.5-alpha. + - Make the nmake make files work again. Fixes bug 13081. Bugfix on + 0.2.5.1-alpha. Patch from "NewEraCracker". + - In routerlist_assert_ok(), don't take the address of a + routerinfo's cache_info member unless that routerinfo is non-NULL. + Fixes bug 13096; bugfix on 0.1.1.9-alpha. Patch by "teor". + - Fix a large number of false positive warnings from the clang + analyzer static analysis tool. This should make real warnings + easier for clang analyzer to find. Patch from "teor". Closes + ticket 13036. + + o Distribution (systemd): + - Verify configuration file via ExecStartPre in the systemd unit + file. Patch from intrigeri; resolves ticket 12730. + - Explicitly disable RunAsDaemon in the systemd unit file. Our + current systemd unit uses "Type = simple", so systemd does not + expect tor to fork. If the user has "RunAsDaemon 1" in their + torrc, then things won't work as expected. This is e.g. the case + on Debian (and derivatives), since there we pass "--defaults-torrc + /usr/share/tor/tor-service-defaults-torrc" (that contains + "RunAsDaemon 1") by default. Patch by intrigeri; resolves + ticket 12731. + + o Documentation: + - Adjust the URLs in the README to refer to the new locations of + several documents on the website. Fixes bug 12830. Patch from + Matt Pagan. + - Document 'reject6' and 'accept6' ExitPolicy entries. Resolves + ticket 12878. + + Changes in version 0.2.5.6-alpha - 2014-07-28 Tor 0.2.5.6-alpha brings us a big step closer to slowing down the risk from guard rotation, and fixes a variety of other issues to get

1 0

[tor/release-0.2.5] 0.2.5.7-rc is not the first release candidate for 0.2.5.7-rc
by arma＠torproject.org 12 Sep '14

12 Sep '14

commit 40233cadbbbf77214913db818a1458c6ddd14a9f Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Sep 11 20:26:38 2014 -0400 0.2.5.7-rc is not the first release candidate for 0.2.5.7-rc --- ChangeLog | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 12fb2e6..424f208 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,8 +1,8 @@ Changes in version 0.2.5.7-rc - 2014-09-11 Tor 0.2.5.7-rc fixes several regressions from earlier in the 0.2.5.x release series, and some long-standing bugs related to ORPort reachability - testing and failure to send CREATE cells. It is the first release - candidate for 0.2.5.7-rc. + testing and failure to send CREATE cells. It is the first release + candidate for the Tor 0.2.5.x series. o Major bugfixes (client, startup): - Start making circuits as soon as DisabledNetwork is turned off. @@ -28,7 +28,7 @@ Changes in version 0.2.5.7-rc - 2014-09-11 - Fix ORPort reachability detection on relays running behind a proxy, by correctly updating the "local" mark on the controlling channel when changing the address of an or_connection_t after the - handshake. Fixes bug #12160; bugfix on 0.2.4.4-alpha. + handshake. Fixes bug 12160; bugfix on 0.2.4.4-alpha. o Minor features (bridge): - Add an ExtORPortCookieAuthFileGroupReadable option to make the

1 0

[tor/master] One more whitespace fix
by nickm＠torproject.org 11 Sep '14

11 Sep '14

commit 89e32c7c08ae039c8aed8a26189d561ae4dcba43 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 14:40:19 2014 -0400 One more whitespace fix --- src/test/test_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_util.c b/src/test/test_util.c index a3fec9b..2692f36 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -4097,3 +4097,4 @@ struct testcase_t util_tests[] = { UTIL_TEST(max_mem, 0), END_OF_TESTCASES }; +

1 0

[tor/master] Whitespace cleanups in transports/test_pt
by nickm＠torproject.org 11 Sep '14

11 Sep '14

commit 6d66e9068baa758cf12f34f1d07625d485264cf9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 14:36:51 2014 -0400 Whitespace cleanups in transports/test_pt --- src/or/transports.c | 2 +- src/test/test_pt.c | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/or/transports.c b/src/or/transports.c index 8dc2cfd..5c7c0b7 100644 --- a/src/or/transports.c +++ b/src/or/transports.c @@ -473,7 +473,7 @@ proxy_needs_restart(const managed_proxy_t *mp) } SMARTLIST_FOREACH_END(t); ret = 0; -needs_restart: + needs_restart: tor_free(proxy_uri); return ret; } diff --git a/src/test/test_pt.c b/src/test/test_pt.c index 05ba24e..0737ff4 100644 --- a/src/test/test_pt.c +++ b/src/test/test_pt.c @@ -528,7 +528,6 @@ test_get_pt_proxy_uri(void *arg) tor_free(uri); } - #define PT_LEGACY(name) \ { #name, legacy_test_helper, 0, &legacy_setup, test_pt_ ## name }

1 0

[tor/master] Whitespace cleanups in test_util
by nickm＠torproject.org 11 Sep '14

11 Sep '14

commit 32f75c870e78611a456fed11351a19395d11673f Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 14:37:12 2014 -0400 Whitespace cleanups in test_util --- src/test/test_util.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/test/test_util.c b/src/test/test_util.c index 6f95c7b..a3fec9b 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -2625,7 +2625,7 @@ test_util_exit_status(void *ptr) int n; (void)ptr; - + clear_hex_errno(hex_errno); test_streq("", hex_errno); @@ -2635,7 +2635,7 @@ test_util_exit_status(void *ptr) test_eq(n, strlen(hex_errno)); #if SIZEOF_INT == 4 - + clear_hex_errno(hex_errno); n = format_helper_exit_status(0, 0x7FFFFFFF, hex_errno); test_streq("0/7FFFFFFF\n", hex_errno); @@ -2646,20 +2646,20 @@ test_util_exit_status(void *ptr) test_streq("FF/-80000000\n", hex_errno); test_eq(n, strlen(hex_errno)); test_eq(n, HEX_ERRNO_SIZE); - + #elif SIZEOF_INT == 8 - + clear_hex_errno(hex_errno); n = format_helper_exit_status(0, 0x7FFFFFFFFFFFFFFF, hex_errno); test_streq("0/7FFFFFFFFFFFFFFF\n", hex_errno); test_eq(n, strlen(hex_errno)); - + clear_hex_errno(hex_errno); n = format_helper_exit_status(0xFF, -0x8000000000000000, hex_errno); test_streq("FF/-8000000000000000\n", hex_errno); test_eq(n, strlen(hex_errno)); test_eq(n, HEX_ERRNO_SIZE); - + #endif clear_hex_errno(hex_errno); @@ -2671,7 +2671,7 @@ test_util_exit_status(void *ptr) n = format_helper_exit_status(0x08, -0x242, hex_errno); test_streq("8/-242\n", hex_errno); test_eq(n, strlen(hex_errno)); - + clear_hex_errno(hex_errno); test_streq("", hex_errno); @@ -4097,4 +4097,3 @@ struct testcase_t util_tests[] = { UTIL_TEST(max_mem, 0), END_OF_TESTCASES }; -

1 0

[tor/master] Update HACKING instructions to mention format_changelog script
by nickm＠torproject.org 11 Sep '14

11 Sep '14

commit b16254dce9fe8a4a2b96ecbb55489d55b0df163e Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 11:34:57 2014 -0400 Update HACKING instructions to mention format_changelog script --- doc/HACKING | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/HACKING b/doc/HACKING index 6b21426..4e9c4e3 100644 --- a/doc/HACKING +++ b/doc/HACKING @@ -512,7 +512,7 @@ interesting and understandable. 2.6) Clean everything one last time. - 2.7) Run it through fmt to make it pretty. + 2.7) Run ./scripts/maint/format_changelog.py to make it prettier. 3) Compose a short release blurb to highlight the user-facing changes. Insert said release blurb into the ChangeLog stanza. If it's

1 0

[tor/release-0.2.5] Add a release blurb and increment the version in the changelog.
by nickm＠torproject.org 11 Sep '14

11 Sep '14

commit 76f72e3b41c7d4e149ec1a353de1f62048c4b234 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 11:33:36 2014 -0400 Add a release blurb and increment the version in the changelog. (Remember, this isn't the final release until it's tagged.) --- ChangeLog | 7 ++++++- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 16df957..12fb2e6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,4 +1,9 @@ -Changes in version 0.2.5.7-rc - 2014-09-1x +Changes in version 0.2.5.7-rc - 2014-09-11 + Tor 0.2.5.7-rc fixes several regressions from earlier in the 0.2.5.x + release series, and some long-standing bugs related to ORPort reachability + testing and failure to send CREATE cells. It is the first release + candidate for 0.2.5.7-rc. + o Major bugfixes (client, startup): - Start making circuits as soon as DisabledNetwork is turned off. When Tor started with DisabledNetwork set, it would correctly diff --git a/configure.ac b/configure.ac index c37f154..97a7a33 100644 --- a/configure.ac +++ b/configure.ac @@ -3,7 +3,7 @@ dnl Copyright (c) 2004-2006, Roger Dingledine, Nick Mathewson dnl Copyright (c) 2007-2013, The Tor Project, Inc. dnl See LICENSE for licensing information -AC_INIT([tor],[0.2.5.6-alpha]) +AC_INIT([tor],[0.2.5.7-rc]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) AM_INIT_AUTOMAKE diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 5d94fd9..51297a7 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.2.5.6-alpha" +!define VERSION "0.2.5.7-rc" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index 9873955..7f6745b 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -241,7 +241,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.2.5.6-alpha" +#define VERSION "0.2.5.7-rc"

1 0

[tor/release-0.2.5] Remove bug12693 changelog entry.
by nickm＠torproject.org 11 Sep '14

11 Sep '14

commit 5958261f23188d449a5a3ef0753239ab334d5826 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Sep 11 11:23:47 2014 -0400 Remove bug12693 changelog entry. It looks like this was stale and sitting around uncommitted in my changes directory, having not been committed on my bug12693_025 branch. The fix for bug12693_025 is not in fact merged. --- ChangeLog | 2 -- 1 file changed, 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index f3b603f..16df957 100644 --- a/ChangeLog +++ b/ChangeLog @@ -63,8 +63,6 @@ Changes in version 0.2.5.7-rc - 2014-09-1x by "teor". o Minor bugfixes (compilation): - - Allow our autoconf to run correctly with autoconf 2.62 again. - Fixes bug 12693; bugfix on 0.2.5.2-alpha. - Fix compilation of test.h with MSVC. Patch from Gisle Vanem; bugfix on 0.2.5.5-alpha. - Make the nmake make files work again. Fixes bug 13081. Bugfix on

1 0