August 2014 - tor-commits - lists.torproject.org

[tor/release-0.2.5] Downgrade "Unexpected onionskin length after decryption" warning
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 7a878c192f5000c5ef5d29a71924a41b6e5adf42 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Aug 29 16:38:54 2014 -0400 Downgrade "Unexpected onionskin length after decryption" warning It's now a protocol-warn, since there's nothing relay operators can do about a client that sends them a malformed create cell. Resolves bug 12996; bugfix on 0.0.6rc1. --- changes/bug12996 | 5 +++++ src/or/onion_tap.c | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/changes/bug12996 b/changes/bug12996 new file mode 100644 index 0000000..4b4fb0d --- /dev/null +++ b/changes/bug12996 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Downgrade "Unexpected onionskin length after decryption" warning + to a protocol-warn, since there's nothing relay operators can do + about a client that sends them a malformed create cell. Resolves + bug 12996; bugfix on 0.0.6rc1. diff --git a/src/or/onion_tap.c b/src/or/onion_tap.c index 9a9f374..65f8275 100644 --- a/src/or/onion_tap.c +++ b/src/or/onion_tap.c @@ -122,8 +122,9 @@ onion_skin_TAP_server_handshake( "Couldn't decrypt onionskin: client may be using old onion key"); goto err; } else if (len != DH_KEY_LEN) { - log_warn(LD_PROTOCOL, "Unexpected onionskin length after decryption: %ld", - (long)len); + log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, + "Unexpected onionskin length after decryption: %ld", + (long)len); goto err; }

1 0

[tor/release-0.2.5] Improve "Tried to establish rendezvous on non-OR or non-edge circuit"
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 4a6f5bb2dda188ed1d1a80455bf9c9b0b3f00066 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:05:58 2014 -0400 Improve "Tried to establish rendezvous on non-OR or non-edge circuit" Instead of putting it all in one warning message, log what exactly was wrong with the circuit. Resolves ticket 12997. --- changes/bug12997 | 3 +++ src/or/rendmid.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/changes/bug12997 b/changes/bug12997 new file mode 100644 index 0000000..fb6e7a8 --- /dev/null +++ b/changes/bug12997 @@ -0,0 +1,3 @@ + o Minor features: + - Log more specific warnings when we get an ESTABLISH_RENDEZVOUS cell + on a cannibalized or non-OR circuit. Resolves ticket 12997. diff --git a/src/or/rendmid.c b/src/or/rendmid.c index 1103816..d89cdf6 100644 --- a/src/or/rendmid.c +++ b/src/or/rendmid.c @@ -224,9 +224,16 @@ rend_mid_establish_rendezvous(or_circuit_t *circ, const uint8_t *request, log_info(LD_REND, "Received an ESTABLISH_RENDEZVOUS request on circuit %u", (unsigned)circ->p_circ_id); - if (circ->base_.purpose != CIRCUIT_PURPOSE_OR || circ->base_.n_chan) { + if (circ->base_.purpose != CIRCUIT_PURPOSE_OR) { + log_warn(LD_PROTOCOL, + "Tried to establish rendezvous on non-OR circuit with purpose %s", + circuit_purpose_to_string(circ->base_.purpose)); + goto err; + } + + if (circ->base_.n_chan) { log_warn(LD_PROTOCOL, - "Tried to establish rendezvous on non-OR or non-edge circuit."); + "Tried to establish rendezvous on non-edge circuit"); goto err; }

1 0

[tor/release-0.2.5] Merge remote-tracking branch 'arma/bug12996b' into maint-0.2.5
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 41058dce95b4e94c10b156728524d24d69620ed0 Merge: 4a6f5bb 7a878c1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:44:50 2014 -0400 Merge remote-tracking branch 'arma/bug12996b' into maint-0.2.5 changes/bug12996 | 5 +++++ src/or/onion_tap.c | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-)

1 0

[tor/release-0.2.5] Merge remote-tracking branch 'origin/maint-0.2.5' into release-0.2.5
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit b969ee9dad0c582bf470c189beba458293f342a8 Merge: ef89fd1 41058dc Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:45:10 2014 -0400 Merge remote-tracking branch 'origin/maint-0.2.5' into release-0.2.5 changes/bug12948 | 8 ++++++++ changes/bug12996 | 5 +++++ changes/bug12997 | 3 +++ src/or/config.c | 3 ++- src/or/onion_tap.c | 5 +++-- src/or/rendmid.c | 11 +++++++++-- 6 files changed, 30 insertions(+), 5 deletions(-)

1 0

[tor/maint-0.2.5] Downgrade "Unexpected onionskin length after decryption" warning
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 7a878c192f5000c5ef5d29a71924a41b6e5adf42 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Aug 29 16:38:54 2014 -0400 Downgrade "Unexpected onionskin length after decryption" warning It's now a protocol-warn, since there's nothing relay operators can do about a client that sends them a malformed create cell. Resolves bug 12996; bugfix on 0.0.6rc1. --- changes/bug12996 | 5 +++++ src/or/onion_tap.c | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/changes/bug12996 b/changes/bug12996 new file mode 100644 index 0000000..4b4fb0d --- /dev/null +++ b/changes/bug12996 @@ -0,0 +1,5 @@ + o Minor bugfixes: + - Downgrade "Unexpected onionskin length after decryption" warning + to a protocol-warn, since there's nothing relay operators can do + about a client that sends them a malformed create cell. Resolves + bug 12996; bugfix on 0.0.6rc1. diff --git a/src/or/onion_tap.c b/src/or/onion_tap.c index 9a9f374..65f8275 100644 --- a/src/or/onion_tap.c +++ b/src/or/onion_tap.c @@ -122,8 +122,9 @@ onion_skin_TAP_server_handshake( "Couldn't decrypt onionskin: client may be using old onion key"); goto err; } else if (len != DH_KEY_LEN) { - log_warn(LD_PROTOCOL, "Unexpected onionskin length after decryption: %ld", - (long)len); + log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, + "Unexpected onionskin length after decryption: %ld", + (long)len); goto err; }

1 0

[tor/maint-0.2.5] Merge remote-tracking branch 'arma/bug12996b' into maint-0.2.5
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 41058dce95b4e94c10b156728524d24d69620ed0 Merge: 4a6f5bb 7a878c1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:44:50 2014 -0400 Merge remote-tracking branch 'arma/bug12996b' into maint-0.2.5 changes/bug12996 | 5 +++++ src/or/onion_tap.c | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-)

1 0

r26932: {website} Updated various information on the volunteer page. (website/trunk/getinvolved/en)
by Matt Pagan 29 Aug '14

29 Aug '14

Author: mttp Date: 2014-08-29 20:27:36 +0000 (Fri, 29 Aug 2014) New Revision: 26932 Modified: website/trunk/getinvolved/en/volunteer.wml Log: Updated various information on the volunteer page. Modified: website/trunk/getinvolved/en/volunteer.wml =================================================================== --- website/trunk/getinvolved/en/volunteer.wml 2014-08-29 19:57:08 UTC (rev 26931) +++ website/trunk/getinvolved/en/volunteer.wml 2014-08-29 20:27:36 UTC (rev 26932) @@ -166,6 +166,14 @@ </tr> <tr> + <td><a href="#project-torlauncher">TorLauncher</a></td> + <td>Browser Add-on</td> + <td>Javascript, XUL</td> + <td>Heavy</td> + <td>Pearl Crescent</td> + </tr> + + <tr> <td><a href="#project-httpseverywhere">HTTPS Everywhere</a></td> <td>Browser Add-on</td> <td>Javascript</td> @@ -454,15 +462,16 @@ </p> <a id="project-torbrowser"></a> - <h3><a href="<page projects/torbrowser>">Tor Browser Bundle</a> (<a + <h3><a href="<page projects/torbrowser>">Tor Browser</a> (<a href="https://gitweb.torproject.org/torbrowser.git">code</a>, <a href="https://trac.torproject.org/projects/tor/query?status=accepted&status=assig…">bug tracker</a>, <a href="https://www.torproject.org/projects/torbrowser/design/">design doc</a>)</h3> <p> - The Tor Browser Bundle is an easy-to-use portable package of Tor, Vidalia, - Torbutton, and a Firefox fork preconfigured to work together out of - the box. It contains a modified copy of Firefox that aims to resolve the + Tor Browser is an easy-to-use, portable package of Tor, HTTPS-Everywhere, + NoScript, TorLauncher, Torbutton, and a Firefox fork, all preconfigured + to work together out of + the box. The modified copy of Firefox aims to resolve the privacy and security issues in mainline version. </p> @@ -480,11 +489,23 @@ <p> Firefox addon that addresses many of the client-side threats to browsing the Internet anonymously. Mike has since continued to adapt it to new - threats, updated versions of Firefox, and possibly <a - href="https://blog.torproject.org/blog/google-chrome-incognito-mode-tor-and-finge…">Chrome - as well</a>. + threats and updated versions of Firefox</a>. </p> + <a id="project-torlauncher"></a> + <h3>TorLauncher (<a + href="https://gitweb.torproject.org/torlauncher.git">code</a>, <a + href="https://trac.torproject.org/projects/tor/query?status=accepted&status=assig…">bug + tracker</a>)</h3> + + <p> + Firefox addon that interfaces between the browser components and Tor. It + addresses many usability issues of Tor Browser by making certain common + Tor configurations, like bridge use, easy to set. Kathy and Mark of Pearl + Crescent continue to add improvements as Tor Browser's feature set + increases. </a>. + </p> + <a id="project-httpseverywhere"></a> <h3><a href="https://www.eff.org/https-everywhere">HTTPS Everywhere</a> (<a href="https://gitweb.torproject.org/https-everywhere.git">code</a>, <a @@ -1031,7 +1052,7 @@ <br> Likely Mentors: <i>Nick (nickm)</i> <p> - The Tor code is almost 10 years old in places, and we haven't always had + The Tor code is more than 10 years old in places, and we haven't always had enough time or wisdom to write things as well as we could have. Our unit test coverage is shamefully low, and the dependency graph of our modules is shamefully convoluted . We could use refactoring and unit tests! Please @@ -1083,11 +1104,12 @@ <p> We have deployed <a - href="<page projects/obfsproxy>">obfsproxy</a> - and <a href="http://crypto.stanford.edu/flashproxy/">flashproxy</a> bridges - for a while, accessible using separately-installed pluggable transport - clients. Recently, we added this client support to the main Tor Browser - Bundle, and are adding more transports such as scramblesuit and fteproxy. + href="<page projects/obfsproxy>">obfsproxy</a>, + <a href="http://crypto.stanford.edu/flashproxy/">flashproxy</a>, + <a href="http://www.cs.kau.se/philwint/scramblesuit/">scramblesuit</a>, + <a href="https://trac.torproject.org/projects/tor/wiki/doc/meek">meek</a>, + and <a href="https://fteproxy.org/about">FTE</a> bridges into the main + Tor Browser.</a> </p> <p> @@ -1104,7 +1126,7 @@ transports together to take advantage of orthogonal types of blocking resistance.</li> <li>Improve the UX for selecting the appropriate pluggable transport in - the new Tor Browser Bundle, whilst maintaining user security.</li> + the new Tor Browser, whilst maintaining user security.</li> <li>Implement a new pluggable transport that resists blocking in a novel way. <ul> @@ -1789,17 +1811,17 @@ Likely Mentors: <i>Sukhbir Singh (sukhe), Nima Fatemi (mrphs)</i> <p> GetTor is a program that serves Tor bundles and related components over SMTP. -Users request the Tor Browser Bundle by sending an email to GetTor, which sends -back the bundle as email attachments. In countries where the Tor Project -website is blocked, GetTor is a convenient way for users to get access to the -bundles. +Users request the Tor Browser by sending an email to GetTor, which sends +back Tor Browser as email attachments. In countries where the Tor Project +website is blocked, GetTor is a convenient way for users to get access to Tor +Browser. </p> <p> GetTor has been unmaintained for a while and needs a revamp. The main issue is -that because the Tor Browser Bundle size exceeds 25 MB, sending it through +that because the Tor Browser size exceeds 25 MB, sending it through GetTor no longer works as most email providers don't support attachments -exceeding 25 MB. To alleviate this issue, bundles are now uploaded on +exceeding 25 MB. To alleviate this issue, Tor Browsers are now uploaded on cloud-based services such as Google Drive and Dropbox and links are sent out in the email body instead of attachments. This current setup is far from complete -- GetTor needs a lot of work to get it to a point where it can do

1 0

[tor/master] Improve "Tried to establish rendezvous on non-OR or non-edge circuit"
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 4a6f5bb2dda188ed1d1a80455bf9c9b0b3f00066 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:05:58 2014 -0400 Improve "Tried to establish rendezvous on non-OR or non-edge circuit" Instead of putting it all in one warning message, log what exactly was wrong with the circuit. Resolves ticket 12997. --- changes/bug12997 | 3 +++ src/or/rendmid.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/changes/bug12997 b/changes/bug12997 new file mode 100644 index 0000000..fb6e7a8 --- /dev/null +++ b/changes/bug12997 @@ -0,0 +1,3 @@ + o Minor features: + - Log more specific warnings when we get an ESTABLISH_RENDEZVOUS cell + on a cannibalized or non-OR circuit. Resolves ticket 12997. diff --git a/src/or/rendmid.c b/src/or/rendmid.c index 1103816..d89cdf6 100644 --- a/src/or/rendmid.c +++ b/src/or/rendmid.c @@ -224,9 +224,16 @@ rend_mid_establish_rendezvous(or_circuit_t *circ, const uint8_t *request, log_info(LD_REND, "Received an ESTABLISH_RENDEZVOUS request on circuit %u", (unsigned)circ->p_circ_id); - if (circ->base_.purpose != CIRCUIT_PURPOSE_OR || circ->base_.n_chan) { + if (circ->base_.purpose != CIRCUIT_PURPOSE_OR) { + log_warn(LD_PROTOCOL, + "Tried to establish rendezvous on non-OR circuit with purpose %s", + circuit_purpose_to_string(circ->base_.purpose)); + goto err; + } + + if (circ->base_.n_chan) { log_warn(LD_PROTOCOL, - "Tried to establish rendezvous on non-OR or non-edge circuit."); + "Tried to establish rendezvous on non-edge circuit"); goto err; }

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.5'
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit d6fa8239c86f49413e9ee86765059f43ceeb06c6 Merge: 573d627 4a6f5bb Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:13:04 2014 -0400 Merge remote-tracking branch 'origin/maint-0.2.5' changes/bug12997 | 3 +++ src/or/rendmid.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.2.5] Improve "Tried to establish rendezvous on non-OR or non-edge circuit"
by nickm＠torproject.org 29 Aug '14

29 Aug '14

commit 4a6f5bb2dda188ed1d1a80455bf9c9b0b3f00066 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Aug 29 16:05:58 2014 -0400 Improve "Tried to establish rendezvous on non-OR or non-edge circuit" Instead of putting it all in one warning message, log what exactly was wrong with the circuit. Resolves ticket 12997. --- changes/bug12997 | 3 +++ src/or/rendmid.c | 11 +++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/changes/bug12997 b/changes/bug12997 new file mode 100644 index 0000000..fb6e7a8 --- /dev/null +++ b/changes/bug12997 @@ -0,0 +1,3 @@ + o Minor features: + - Log more specific warnings when we get an ESTABLISH_RENDEZVOUS cell + on a cannibalized or non-OR circuit. Resolves ticket 12997. diff --git a/src/or/rendmid.c b/src/or/rendmid.c index 1103816..d89cdf6 100644 --- a/src/or/rendmid.c +++ b/src/or/rendmid.c @@ -224,9 +224,16 @@ rend_mid_establish_rendezvous(or_circuit_t *circ, const uint8_t *request, log_info(LD_REND, "Received an ESTABLISH_RENDEZVOUS request on circuit %u", (unsigned)circ->p_circ_id); - if (circ->base_.purpose != CIRCUIT_PURPOSE_OR || circ->base_.n_chan) { + if (circ->base_.purpose != CIRCUIT_PURPOSE_OR) { + log_warn(LD_PROTOCOL, + "Tried to establish rendezvous on non-OR circuit with purpose %s", + circuit_purpose_to_string(circ->base_.purpose)); + goto err; + } + + if (circ->base_.n_chan) { log_warn(LD_PROTOCOL, - "Tried to establish rendezvous on non-OR or non-edge circuit."); + "Tried to establish rendezvous on non-edge circuit"); goto err; }

1 0