December 2014 - tor-commits - lists.torproject.org

[tor/master] changs file for 13808
by nickm＠torproject.org 23 Dec '14

23 Dec '14

commit dfebefe68f707c452a3a3f2b1b86c146cf0ca30b Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Dec 23 10:59:48 2014 -0500 changs file for 13808 --- changes/bug13808 | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/changes/bug13808 b/changes/bug13808 new file mode 100644 index 0000000..b24a01c --- /dev/null +++ b/changes/bug13808 @@ -0,0 +1,9 @@ + o Minor features (transparent proxy): + - Use the correct option when using IPv6 with transparent proxy + support on Linux. Resolves 13808. Patch by Francisco Blas + Izquierdo Riera. + + o Minor bugfixes (sandbox): + - Make transparent proxy support work along with the seccomp2 + sandbox. Fixes part of bug 13808; bugfix on 0.2.5.1-alpha. + Patch by Francisco Blas Izquierdo Riera.

1 0

[tor/maint-0.2.5] whoops; missing changes file for 14013
by nickm＠torproject.org 23 Dec '14

23 Dec '14

commit 184a2dbbdd27f958f5ac290fe030d1fac2959157 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Dec 23 10:55:25 2014 -0500 whoops; missing changes file for 14013 --- changes/bug14013 | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/changes/bug14013 b/changes/bug14013 new file mode 100644 index 0000000..640cf85 --- /dev/null +++ b/changes/bug14013 @@ -0,0 +1,6 @@ + o Major bugfixes: + - When reading a hexadecimal, base-32, or base-64 encoded value + from a string, always overwrite the complete output buffer. This + prevents some bugs where we would look at (but fortunately, not + reveal) uninitialized memory on the stack. Fixes bug 14013; + bugfix on all versions of Tor.

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 23 Dec '14

23 Dec '14

commit 0856b86dce1bead767645f50afdc62b0886e64a8 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Dec 23 12:15:53 2014 +0000 Update translations for torbutton-torbuttondtd --- fi/torbutton.dtd | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/fi/torbutton.dtd b/fi/torbutton.dtd index 4573fcf..d35ef23 100644 --- a/fi/torbutton.dtd +++ b/fi/torbutton.dtd @@ -44,7 +44,7 @@ <!ENTITY torbutton.context_menu.openTorWindow.key "U"> <!ENTITY torbutton.button.label "Torbutton"> <!ENTITY torbutton.button.tooltip "Klikkaa Torbutton aktiiviseksi"> -<!ENTITY torbutton.prefs.privacy_security_settings "Privacy and Security Settings"> +<!ENTITY torbutton.prefs.privacy_security_settings "Yksityisyys ja Turvallisuus Asetukset"> <!ENTITY torbutton.prefs.block_thread "Estä historiatietojen lukeminen Torin ollessa käytössä. (tärkeää)"> <!ENTITY torbutton.prefs.block_thwrite "Estä historiatietojen tallentaminen Torin ollessa käytössä. (suositeltua)"> <!ENTITY torbutton.prefs.block_nthread "Estä historiatietojen lukeminen Torin ollessa pois käytöstä. (valinnaista)"> @@ -144,14 +144,14 @@ <!ENTITY torbutton.prefs.engine5 "duckduckgo.com"> <!ENTITY torbutton.prefs.fix_google_srch "Poista yksilöintitiedot (laitteisto ja kieliasetukset) Google hakuja suoritettaessa "> <!ENTITY torbutton.prefs.transparentTor "Käytä Toria läpinäkyvästi (edellyttää mukautetun transproxyn tai Tor-reitittimen käyttöä)"> -<!ENTITY torbutton.prefs.priv_caption "Privacy Settings"> +<!ENTITY torbutton.prefs.priv_caption "Yksityisyys Asetukset"> <!ENTITY torbutton.prefs.block_disk "Älä säilytä selaushistoriaa tai verkkosivuston tietoa (käynnistää yksityisen selauksen)"> <!ENTITY torbutton.prefs.restrict_thirdparty "Estä kolmannen osapuolen evästeet ja muut seurantatiedot"> <!ENTITY torbutton.prefs.block_plugins "Poista liitännäiset (Flash yms.) käytöstä"> <!ENTITY torbutton.prefs.resist_fingerprinting "Muuta lisätietoja, jotka erottavat sinut muista Tor Browser -käyttäjistä"> -<!ENTITY torbutton.prefs.sec_caption "Security Level"> -<!ENTITY torbutton.prefs.sec_low "Low (default)"> -<!ENTITY torbutton.prefs.sec_med_low "Medium-Low"> -<!ENTITY torbutton.prefs.sec_med_high "Medium-High"> -<!ENTITY torbutton.prefs.sec_high "High"> -<!ENTITY torbutton.prefs.sec_custom "Custom Values"> +<!ENTITY torbutton.prefs.sec_caption "Turvallisuus Taso"> +<!ENTITY torbutton.prefs.sec_low "Alhainen (oletus)"> +<!ENTITY torbutton.prefs.sec_med_low "Keskitaso-Alhainen"> +<!ENTITY torbutton.prefs.sec_med_high "Keskitaso-Korkea"> +<!ENTITY torbutton.prefs.sec_high "Korkea"> +<!ENTITY torbutton.prefs.sec_custom "Mukautetut Arvot">

1 0

[translation/tails-persistence-setup_completed] Update translations for tails-persistence-setup_completed
by translation＠torproject.org 23 Dec '14

23 Dec '14

commit a4862f0d3c7fa7023b2c6a05100aeb9ae610a473 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Dec 23 12:15:23 2014 +0000 Update translations for tails-persistence-setup_completed --- fi/fi.po | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fi/fi.po b/fi/fi.po index 0a54b49..2c1b864 100644 --- a/fi/fi.po +++ b/fi/fi.po @@ -11,9 +11,9 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" -"POT-Creation-Date: 2014-07-01 22:15+0200\n" -"PO-Revision-Date: 2014-07-19 10:40+0000\n" -"Last-Translator: karvjorm <karvonen.jorma(a)gmail.com>\n" +"POT-Creation-Date: 2014-12-02 09:42+0100\n" +"PO-Revision-Date: 2014-12-23 11:50+0000\n" +"Last-Translator: Finland355 <ville.ehrukainen2(a)gmail.com>\n" "Language-Team: Finnish (http://www.transifex.com/projects/p/torproject/language/fi/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -82,8 +82,8 @@ msgid "Browser bookmarks" msgstr "Selaimen kirjanmerkit" #: ../lib/Tails/Persistence/Configuration/Presets.pm:120 -msgid "Bookmarks saved in Iceweasel browser" -msgstr "Iceweasel-selaimen tallennetut kirjanmerkit" +msgid "Bookmarks saved in the Tor Browser" +msgstr "Kirjanmerkit tallennettu Tor Selaimeen" #: ../lib/Tails/Persistence/Configuration/Presets.pm:128 msgid "Printers"

1 0

[translation/tails-persistence-setup] Update translations for tails-persistence-setup
by translation＠torproject.org 23 Dec '14

23 Dec '14

commit dbb68241fa6414bf52a0fe7957c1a891d12be570 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Dec 23 12:15:18 2014 +0000 Update translations for tails-persistence-setup --- fi/fi.po | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fi/fi.po b/fi/fi.po index 176d5f2..2c1b864 100644 --- a/fi/fi.po +++ b/fi/fi.po @@ -11,9 +11,9 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" -"POT-Creation-Date: 2014-10-08 21:13+0200\n" -"PO-Revision-Date: 2014-10-09 10:19+0000\n" -"Last-Translator: runasand <runa.sandvik(a)gmail.com>\n" +"POT-Creation-Date: 2014-12-02 09:42+0100\n" +"PO-Revision-Date: 2014-12-23 11:50+0000\n" +"Last-Translator: Finland355 <ville.ehrukainen2(a)gmail.com>\n" "Language-Team: Finnish (http://www.transifex.com/projects/p/torproject/language/fi/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -83,7 +83,7 @@ msgstr "Selaimen kirjanmerkit" #: ../lib/Tails/Persistence/Configuration/Presets.pm:120 msgid "Bookmarks saved in the Tor Browser" -msgstr "" +msgstr "Kirjanmerkit tallennettu Tor Selaimeen" #: ../lib/Tails/Persistence/Configuration/Presets.pm:128 msgid "Printers"

1 0

[stem/master] Citing blog announcement for our release
by atagar＠torproject.org 22 Dec '14

22 Dec '14

commit 39fd63f9ca85e42fb7653f77f215b21b9afbcd1f Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Dec 22 14:27:16 2014 -0800 Citing blog announcement for our release --- docs/change_log.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/change_log.rst b/docs/change_log.rst index d487ceb..bb32659 100644 --- a/docs/change_log.rst +++ b/docs/change_log.rst @@ -46,10 +46,10 @@ The following are only available within Stem's `git repository Version 1.3 ----------- -With Stem's 1.3 release it's much easier to `work with hidden services -<tutorials/over_the_river.html>`_. This release also improves our -descriptor parsing performance by 40%, and includes many other -improvements. +With `Stem's 1.3 release <https://blog.torproject.org/blog/stem-release-13>`_ +it's now much easier to `work with hidden services +<tutorials/over_the_river.html>`_, 40% faster to read decriptors, and includes +a myriad of other improvements. * **Controller**

1 0

[tor/master] When decoding a base-{16, 32, 64} value, clear the target buffer first
by nickm＠torproject.org 22 Dec '14

22 Dec '14

commit 47760c7ba5f1c87c945f4a018e3b3da6d127a8b9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 22 12:56:35 2014 -0500 When decoding a base-{16,32,64} value, clear the target buffer first This is a good idea in case the caller stupidly doesn't check the return value from baseX_decode(), and as a workaround for the current inconsistent API of base16_decode. Prevents any fallout from bug 14013. --- src/common/crypto.c | 6 ++++++ src/common/util.c | 3 +++ 2 files changed, 9 insertions(+) diff --git a/src/common/crypto.c b/src/common/crypto.c index 925beb3..6327614 100644 --- a/src/common/crypto.c +++ b/src/common/crypto.c @@ -2678,6 +2678,8 @@ base64_decode(char *dest, size_t destlen, const char *src, size_t srclen) if (destlen > SIZE_T_CEILING) return -1; + memset(dest, 0, destlen); + EVP_DecodeInit(&ctx); EVP_DecodeUpdate(&ctx, (unsigned char*)dest, &len, (unsigned char*)src, srclen); @@ -2699,6 +2701,8 @@ base64_decode(char *dest, size_t destlen, const char *src, size_t srclen) if (destlen > SIZE_T_CEILING) return -1; + memset(dest, 0, destlen); + /* Iterate over all the bytes in src. Each one will add 0 or 6 bits to the * value we're decoding. Accumulate bits in <b>n</b>, and whenever we have * 24 bits, batch them into 3 bytes and flush those bytes to dest. @@ -2878,6 +2882,8 @@ base32_decode(char *dest, size_t destlen, const char *src, size_t srclen) tor_assert((nbits/8) <= destlen); /* We need enough space. */ tor_assert(destlen < SIZE_T_CEILING); + memset(dest, 0, destlen); + /* Convert base32 encoded chars to the 5-bit values that they represent. */ tmp = tor_malloc_zero(srclen); for (j = 0; j < srclen; ++j) { diff --git a/src/common/util.c b/src/common/util.c index 5eb0f9a..036fd25 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -1076,6 +1076,9 @@ base16_decode(char *dest, size_t destlen, const char *src, size_t srclen) return -1; if (destlen < srclen/2 || destlen > SIZE_T_CEILING) return -1; + + memset(dest, 0, destlen); + end = src+srclen; while (src<end) { v1 = hex_decode_digit_(*src);

1 0

[tor/master] Merge remote-tracking branch 'public/bug14013_024' into maint-0.2.5
by nickm＠torproject.org 22 Dec '14

22 Dec '14

commit 6d728ba8801031b27937436cbcad033f4406a8b5 Merge: 5b55778 47760c7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 22 15:58:49 2014 -0500 Merge remote-tracking branch 'public/bug14013_024' into maint-0.2.5 src/common/crypto.c | 6 ++++++ src/common/util.c | 3 +++ 2 files changed, 9 insertions(+)

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.5'
by nickm＠torproject.org 22 Dec '14

22 Dec '14

commit 0965bbd5ac3a3dc4016a0c13082506ac2039905e Merge: 03d2df6 6d728ba Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 22 16:02:47 2014 -0500 Merge remote-tracking branch 'origin/maint-0.2.5' src/common/crypto.c | 6 ++++++ src/common/util.c | 3 +++ 2 files changed, 9 insertions(+)

1 0

[tor/master] Tweak channel unit tests so we don't see coverity complaints
by nickm＠torproject.org 22 Dec '14

22 Dec '14

commit 808e2b856bd77fa9b431272a6f37596655fd5945 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 22 16:06:05 2014 -0500 Tweak channel unit tests so we don't see coverity complaints channel_write_*_cell() can delete its argument, so coverity doesn't like us doing pointer comparison against that argument later. Silly. --- src/test/test_channel.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/test/test_channel.c b/src/test/test_channel.c index 0766415..59f4596 100644 --- a/src/test/test_channel.c +++ b/src/test/test_channel.c @@ -1293,6 +1293,7 @@ test_channel_queue_impossible(void *arg) int old_count; cell_queue_entry_t *q = NULL; uint64_t global_queue_estimate; + uintptr_t cellintptr; /* Cache the global queue size (see below) */ global_queue_estimate = channel_get_global_queue_estimate(); @@ -1320,6 +1321,7 @@ test_channel_queue_impossible(void *arg) /* Get a fresh cell and write it to the channel*/ cell = tor_malloc_zero(sizeof(cell_t)); make_fake_cell(cell); + cellintptr = (uintptr_t)(void*)cell; channel_write_cell(ch, cell); /* Now it should be queued */ @@ -1328,7 +1330,7 @@ test_channel_queue_impossible(void *arg) tt_assert(q); if (q) { tt_int_op(q->type, ==, CELL_QUEUE_FIXED); - tt_ptr_op(q->u.fixed.cell, ==, cell); + tt_assert((uintptr_t)q->u.fixed.cell == cellintptr); } /* Do perverse things to it */ tor_free(q->u.fixed.cell); @@ -1349,6 +1351,7 @@ test_channel_queue_impossible(void *arg) ch->state = CHANNEL_STATE_MAINT; var_cell = tor_malloc_zero(sizeof(var_cell_t) + CELL_PAYLOAD_SIZE); make_fake_var_cell(var_cell); + cellintptr = (uintptr_t)(void*)var_cell; channel_write_var_cell(ch, var_cell); /* Check that it's queued */ @@ -1357,7 +1360,7 @@ test_channel_queue_impossible(void *arg) tt_assert(q); if (q) { tt_int_op(q->type, ==, CELL_QUEUE_VAR); - tt_ptr_op(q->u.var.var_cell, ==, var_cell); + tt_assert((uintptr_t)q->u.var.var_cell == cellintptr); } /* Remove the cell from the queue entry */ @@ -1376,6 +1379,7 @@ test_channel_queue_impossible(void *arg) ch->state = CHANNEL_STATE_MAINT; packed_cell = packed_cell_new(); tt_assert(packed_cell); + cellintptr = (uintptr_t)(void*)packed_cell; channel_write_packed_cell(ch, packed_cell); /* Check that it's queued */ @@ -1384,7 +1388,7 @@ test_channel_queue_impossible(void *arg) tt_assert(q); if (q) { tt_int_op(q->type, ==, CELL_QUEUE_PACKED); - tt_ptr_op(q->u.packed.packed_cell, ==, packed_cell); + tt_assert((uintptr_t)q->u.packed.packed_cell == cellintptr); } /* Remove the cell from the queue entry */

1 0