November 2014 - tor-commits - lists.torproject.org

[tor/master] Add Window compatibility note to docs
by nickm＠torproject.org 05 Nov '14

05 Nov '14

commit a6f2d2091b4abd7a699d75e6c89ebbbb2384cc8e Author: David Stainton <dstainton415(a)gmail.com> Date: Tue Sep 2 18:09:58 2014 +0000 Add Window compatibility note to docs HiddenServiceDirGroupReadable has no effect in Windows --- doc/tor.1.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index bf0f5c9..25a602e 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -2082,6 +2082,7 @@ The following options are used to configure a hidden service. If this option is set to 1, allow the filesystem group to read the hidden service directory and hostname file. If the option is set to 0, only owner is able to read the hidden service directory. (Default: 0) + Has no effect on Windows. TESTING NETWORK OPTIONS -----------------------

1 0

[tor/master] Fix permissions logic
by nickm＠torproject.org 05 Nov '14

05 Nov '14

commit b59fd2efb61e0b6def3fdbf4b8e359acc852776c Author: David Stainton <dstainton415(a)gmail.com> Date: Thu Sep 4 22:21:30 2014 +0000 Fix permissions logic --- src/common/util.c | 26 ++++++++++++++------------ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/src/common/util.c b/src/common/util.c index 3f04932..bf00270 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -1988,23 +1988,25 @@ check_private_dir(const char *dirname, cpd_check_t check, tor_free(process_groupname); return -1; } - if (check & CPD_CHECK_MODE_ONLY) { - if (check & CPD_GROUP_OK || check & CPD_GROUP_READ) { - if (!st.st_mode & 0027) { - log_warn(LD_FS, "Incorrect permissions on directory %s a.", dirname); - return -1; - } - } + if (check & (CPD_GROUP_OK|CPD_GROUP_READ)) { + mask = 0027; } else { - log_warn(LD_FS, "Fixing permissions on directory %s", dirname); + mask = 0077; + } + if (st.st_mode & mask) { unsigned new_mode; - new_mode = 0700; - if (check & CPD_GROUP_OK) { - new_mode = 0700; + if (check & CPD_CHECK_MODE_ONLY) { + log_warn(LD_FS, "Permissions on directory %s are too permissive.", + dirname); + return -1; } + log_warn(LD_FS, "Fixing permissions on directory %s", dirname); + new_mode = st.st_mode; + new_mode |= 0700; /* Owner should have rwx */ if (check & CPD_GROUP_READ) { - new_mode = 0750; + new_mode |= 0050; /* Group should have rx */ } + new_mode &= ~mask; /* Clear the other bits that we didn't want set...*/ if (chmod(dirname, new_mode)) { log_warn(LD_FS, "Could not chmod directory %s: %s", dirname, strerror(errno));

1 0

[tor/master] Remove HiddenServiceDirGroupReadable from or_options_t
by nickm＠torproject.org 05 Nov '14

05 Nov '14

commit 59e052b896dfdfd1c185d2f93b4a135de9bdb6ed Author: David Stainton <dstainton415(a)gmail.com> Date: Wed Sep 3 17:22:15 2014 +0000 Remove HiddenServiceDirGroupReadable from or_options_t ...and also fix whitespace. --- src/common/util.c | 4 ++-- src/or/or.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/common/util.c b/src/common/util.c index 791ca13..3f04932 100644 --- a/src/common/util.c +++ b/src/common/util.c @@ -1988,8 +1988,8 @@ check_private_dir(const char *dirname, cpd_check_t check, tor_free(process_groupname); return -1; } - if(check & CPD_CHECK_MODE_ONLY) { - if(check & CPD_GROUP_OK || check & CPD_GROUP_READ) { + if (check & CPD_CHECK_MODE_ONLY) { + if (check & CPD_GROUP_OK || check & CPD_GROUP_READ) { if (!st.st_mode & 0027) { log_warn(LD_FS, "Incorrect permissions on directory %s a.", dirname); return -1; diff --git a/src/or/or.h b/src/or/or.h index 33a582b..cbdc95e 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -4224,10 +4224,6 @@ typedef struct { /** Should we send the timestamps that pre-023 hidden services want? */ int Support022HiddenServices; - /** Create the Hidden Service directories - and hostname files group readable. */ - int HiddenServiceDirGroupReadable; - } or_options_t; /** Persistent state for an onion router, as saved to disk. */

1 0

[tor/master] Additional test for error-case
by nickm＠torproject.org 05 Nov '14

05 Nov '14

commit 3d0d49be230a8720ebdadf668b993f8ba2c5b2ca Author: meejah <meejah(a)meejah.ca> Date: Wed Oct 15 02:17:54 2014 -0600 Additional test for error-case This error-case was already fixed by previous changes, this is to cover it in case there's a regression. --- src/test/test_checkdir.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/test/test_checkdir.c b/src/test/test_checkdir.c index 1580e62..7bf735e 100644 --- a/src/test/test_checkdir.c +++ b/src/test/test_checkdir.c @@ -43,6 +43,14 @@ test_checkdir_perms(void *testdata) tt_int_op(0, ==, (st.st_mode & unix_verify_optsmask)); tor_free(testdir); + /* test: should get an error on existing dir with + wrong perms */ + testdir = get_datadir_fname("checkdir_new_groupok_err"); + tt_int_op(0, ==, mkdir(testdir, 027)); + cpd_chkopts = CPD_CHECK_MODE_ONLY|CPD_CREATE|CPD_GROUP_OK; + tt_int_op(-1, ==, check_private_dir(testdir, cpd_chkopts, NULL)); + tor_free(testdir); + /* test: create new dir, CPD_GROUP_READ option set. */ testdir = get_datadir_fname("checkdir_new_groupread"); cpd_chkopts = CPD_CREATE|CPD_GROUP_READ;

1 0

[tor-messenger-build/master] Fix small typo in the preferences patch
by sukhbir＠torproject.org 05 Nov '14

05 Nov '14

commit 90766e6ba77b645e9ff3d73042b4c595be237370 Author: Sukhbir Singh <sukhbir(a)torproject.org> Date: Thu Nov 6 00:38:28 2014 +0530 Fix small typo in the preferences patch --- projects/instantbird/preferences.patch | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/projects/instantbird/preferences.patch b/projects/instantbird/preferences.patch index 43be54c..8d05d84 100644 --- a/projects/instantbird/preferences.patch +++ b/projects/instantbird/preferences.patch @@ -98,6 +98,6 @@ diff --git a/im/app/profile/all-instantbird.js b/im/app/profile/all-instantbird. +// Disable text formatting (remove the tags) +pref("messenger.options.filterMode", 0); + -+// Navigator ++// Media +// Disable "Take Picture" functionality that accesses the webcam +pref("media.navigator.video.enabled", false);

1 0

[tor-messenger-build/master] Disable link formatting and webcam access
by sukhbir＠torproject.org 05 Nov '14

05 Nov '14

commit 9f3264c0a60c0608d2074164740de36d091f327c Author: Sukhbir Singh <sukhbir(a)torproject.org> Date: Thu Nov 6 00:34:53 2014 +0530 Disable link formatting and webcam access --- projects/instantbird/preferences.patch | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/projects/instantbird/preferences.patch b/projects/instantbird/preferences.patch index c681674..43be54c 100644 --- a/projects/instantbird/preferences.patch +++ b/projects/instantbird/preferences.patch @@ -95,3 +95,9 @@ diff --git a/im/app/profile/all-instantbird.js b/im/app/profile/all-instantbird. +// Disable caching +pref("browser.cache.disk.enable", false); +pref("browser.cache.offline.enable", false); ++// Disable text formatting (remove the tags) ++pref("messenger.options.filterMode", 0); ++ ++// Navigator ++// Disable "Take Picture" functionality that accesses the webcam ++pref("media.navigator.video.enabled", false);

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 05 Nov '14

05 Nov '14

commit 99c66a6dc406007bb7e6010ee7c9571938845842 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Nov 5 14:15:47 2014 +0000 Update translations for torbutton-torbuttondtd --- bg/torbutton.dtd | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/bg/torbutton.dtd b/bg/torbutton.dtd index 178cb37..221b82a 100644 --- a/bg/torbutton.dtd +++ b/bg/torbutton.dtd @@ -44,7 +44,7 @@ <!ENTITY torbutton.context_menu.openTorWindow.key "d"> <!ENTITY torbutton.button.label "Torbutton"> <!ENTITY torbutton.button.tooltip "Натисни за инициализиране на Torbutton"> -<!ENTITY torbutton.prefs.privacy_security_settings "Privacy and Security Settings"> +<!ENTITY torbutton.prefs.privacy_security_settings "Лични и защитни настройки"> <!ENTITY torbutton.prefs.block_thread "Block history reads during Tor (crucial)"> <!ENTITY torbutton.prefs.block_thwrite "Block history writes during Tor (recommended)"> <!ENTITY torbutton.prefs.block_nthread "Block history reads during Non-Tor (optional)"> @@ -144,14 +144,14 @@ <!ENTITY torbutton.prefs.engine5 "duckduckgo.com"> <!ENTITY torbutton.prefs.fix_google_srch "Strip platform and language off of Google Search Box queries"> <!ENTITY torbutton.prefs.transparentTor "Transparent Torification (Requires custom transproxy or Tor router)"> -<!ENTITY torbutton.prefs.priv_caption "Privacy Settings"> +<!ENTITY torbutton.prefs.priv_caption "Лични настройки"> <!ENTITY torbutton.prefs.block_disk "Don't record browsing history or website data (enables Private Browsing Mode)"> <!ENTITY torbutton.prefs.restrict_thirdparty "Restrict third party cookies and other tracking data"> <!ENTITY torbutton.prefs.block_plugins "Disable browser plugins (such as Flash)"> <!ENTITY torbutton.prefs.resist_fingerprinting "Change details that distinguish you from other Tor Browser users"> -<!ENTITY torbutton.prefs.sec_caption "Security Level"> -<!ENTITY torbutton.prefs.sec_low "Low (default)"> -<!ENTITY torbutton.prefs.sec_med_low "Medium-Low"> -<!ENTITY torbutton.prefs.sec_med_high "Medium-High"> -<!ENTITY torbutton.prefs.sec_high "High"> -<!ENTITY torbutton.prefs.sec_custom "Custom Values"> +<!ENTITY torbutton.prefs.sec_caption "Ниво на защита"> +<!ENTITY torbutton.prefs.sec_low "Ниско (по подразбиране)"> +<!ENTITY torbutton.prefs.sec_med_low "Средно-ниско"> +<!ENTITY torbutton.prefs.sec_med_high "Средно-високо"> +<!ENTITY torbutton.prefs.sec_high "Високо"> +<!ENTITY torbutton.prefs.sec_custom "Стойности по избор">

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 05 Nov '14

05 Nov '14

commit dcdf1afbf2677b75594f7a0c53519a7e83660d69 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Nov 5 13:15:46 2014 +0000 Update translations for torbutton-torbuttondtd --- bg/torbutton.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bg/torbutton.dtd b/bg/torbutton.dtd index 3356b53..178cb37 100644 --- a/bg/torbutton.dtd +++ b/bg/torbutton.dtd @@ -65,7 +65,7 @@ <!ENTITY torbutton.prefs.cookies "Бисквитки"> <!ENTITY torbutton.prefs.cache "Кеш"> <!ENTITY torbutton.prefs.history "История"> -<!ENTITY torbutton.prefs.no_search "Disable search suggestions during Tor (recommended)"> +<!ENTITY torbutton.prefs.no_search "Изключи предпочитанията за търсене през Tor (препоръчано)"> <!ENTITY torbutton.prefs.shutdown "Изключване"> <!ENTITY torbutton.prefs.tor_shutdown "Clear Tor cookies during Tor-enabled browser shutdown"> <!ENTITY torbutton.prefs.all_shutdown "Clear cookies during any browser shutdown">

1 0

[onionoo/master] Fix bug where we never updated bridge descriptor details.
by karsten＠torproject.org 05 Nov '14

05 Nov '14

commit 0c604542be39d80470785b29ddfa157239f4a8c3 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Nov 5 09:46:56 2014 +0100 Fix bug where we never updated bridge descriptor details. Spotted by eli in #13658. --- .../org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java b/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java index f09a46c..9f748db 100644 --- a/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java +++ b/src/main/java/org/torproject/onionoo/updater/NodeDetailsStatusUpdater.java @@ -230,8 +230,8 @@ public class NodeDetailsStatusUpdater implements DescriptorListener, DetailsStatus.class, true, fingerprint); if (detailsStatus == null) { detailsStatus = new DetailsStatus(); - } else if (detailsStatus.getDescPublished() <= - descriptor.getPublishedMillis()) { + } else if (descriptor.getPublishedMillis() <= + detailsStatus.getDescPublished()) { return; } long lastRestartedMillis = descriptor.getPublishedMillis()

1 0

[translation/tor-and-https_completed] Update translations for tor-and-https_completed
by translation＠torproject.org 05 Nov '14

05 Nov '14

commit 1b181fd4d04d97b717ab4873ac4b019b4bc51fb9 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Nov 5 08:46:11 2014 +0000 Update translations for tor-and-https_completed --- sl_SI.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sl_SI.po b/sl_SI.po index b94925e..ea222c0 100644 --- a/sl_SI.po +++ b/sl_SI.po @@ -5,7 +5,7 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2014-07-17 14:23+0000\n" -"PO-Revision-Date: 2014-11-05 07:37+0000\n" +"PO-Revision-Date: 2014-11-05 08:22+0000\n" "Last-Translator: Dušan <dusan.k(a)zoho.com>\n" "Language-Team: Slovenian (Slovenia) (http://www.transifex.com/projects/p/torproject/language/sl_SI/)\n" "MIME-Version: 1.0\n"

1 0