November 2013 - tor-commits - lists.torproject.org

[check/master] Add a run script.
by arlo＠torproject.org 16 Nov '13

16 Nov '13

commit f624697cdab1c6f9f232079ac86c7b67d83ac5fe Author: Arlo Breault <arlolra(a)gmail.com> Date: Fri Nov 15 22:17:07 2013 -0800 Add a run script. To be run at cron @reboot. --- scripts/run.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/run.sh b/scripts/run.sh new file mode 100755 index 0000000..977f771 --- /dev/null +++ b/scripts/run.sh @@ -0,0 +1,5 @@ +#!/usr/bin/env bash + +BASE=/home/arlo/git/check +$BASE/check -base="$BASE" -log="$BASE/check.log" -pid="$BASE/check.pid" & +

1 0

r26430: {website} fix a broken link (website/trunk/docs/en)
by Roger Dingledine 16 Nov '13

16 Nov '13

Author: arma Date: 2013-11-16 05:22:55 +0000 (Sat, 16 Nov 2013) New Revision: 26430 Modified: website/trunk/docs/en/faq.wml Log: fix a broken link Modified: website/trunk/docs/en/faq.wml =================================================================== --- website/trunk/docs/en/faq.wml 2013-11-12 05:48:40 UTC (rev 26429) +++ website/trunk/docs/en/faq.wml 2013-11-16 05:22:55 UTC (rev 26430) @@ -1473,8 +1473,7 @@ zone is correct.</li> <li>Is your Internet connection <a href="#FirewallPorts">firewalled by port</a>, or do you normally need to use a <a -href="<wikifaq>#MyInternetconnectionrequiresanHTTPorSOCKSproxy.">proxy</ -a>? +href="<wikifaq>#MyInternetconnectionrequiresanHTTPorSOCKSproxy.">proxy</a>? </li> <li>Are you running programs like Norton Internet Security or SELinux that

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 16 Nov '13

16 Nov '13

commit 2270bcab7c04ce6bc395e8adb765a8752617a43b Author: Translation commit bot <translation(a)torproject.org> Date: Sat Nov 16 00:16:09 2013 +0000 Update translations for tails-misc --- pl.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pl.po b/pl.po index 1a5dfb5..330d559 100644 --- a/pl.po +++ b/pl.po @@ -9,7 +9,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2013-10-26 23:41+0200\n" -"PO-Revision-Date: 2013-11-15 23:42+0000\n" +"PO-Revision-Date: 2013-11-15 23:58+0000\n" "Last-Translator: sebx\n" "Language-Team: Polish (http://www.transifex.com/projects/p/torproject/language/pl/)\n" "MIME-Version: 1.0\n" @@ -267,7 +267,7 @@ msgstr "" #: config/chroot_local-includes/usr/local/bin/tails-security-check:113 msgid "atom_str was passed an undefined argument" -msgstr "" +msgstr "atom_str przepuścił niezdefiniowany argument" #: config/chroot_local-includes/usr/local/bin/tails-security-check:177 msgid "Empty fetched feed." @@ -409,7 +409,7 @@ msgstr "TrueCrypt wkrótce będzie usunięty z systemu Tails z powodu licencji i #: ../config/chroot_local-includes/etc/skel/Desktop/Report_an_error.desktop.in.h:1 msgid "Report an error" -msgstr "" +msgstr "Zgłóś błąd" #: ../config/chroot_local-includes/etc/skel/Desktop/Tails_documentation.desktop.in.h:1 msgid "Tails documentation"

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 15 Nov '13

15 Nov '13

commit cca800ece7156d4565b65edd3620b7cb96ee5f66 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 15 23:46:19 2013 +0000 Update translations for tails-misc --- pl.po | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/pl.po b/pl.po index 9f70f15..1a5dfb5 100644 --- a/pl.po +++ b/pl.po @@ -9,7 +9,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2013-10-26 23:41+0200\n" -"PO-Revision-Date: 2013-11-09 15:10+0000\n" +"PO-Revision-Date: 2013-11-15 23:42+0000\n" "Last-Translator: sebx\n" "Language-Team: Polish (http://www.transifex.com/projects/p/torproject/language/pl/)\n" "MIME-Version: 1.0\n" @@ -105,9 +105,9 @@ msgstr "Mapowanie (fingerprint):" #: config/chroot_local-includes/usr/local/bin/gpgApplet:394 msgid "User ID:" msgid_plural "User IDs:" -msgstr[0] "" -msgstr[1] "" -msgstr[2] "" +msgstr[0] "ID użytkownika:" +msgstr[1] "Użytkownika IDs:" +msgstr[2] "Użytkownika IDs:" #: config/chroot_local-includes/usr/local/bin/gpgApplet:424 msgid "None (Don't sign)" @@ -142,16 +142,16 @@ msgstr "Czy ufasz tym kluczom?" #: config/chroot_local-includes/usr/local/bin/gpgApplet:551 msgid "The following selected key is not fully trusted:" msgid_plural "The following selected keys are not fully trusted:" -msgstr[0] "" -msgstr[1] "" -msgstr[2] "" +msgstr[0] "Poniżej wybrane klucze nie są do końca zaufane:" +msgstr[1] "Poniżej wybrane klucze nie są do końca zaufane:" +msgstr[2] "Poniżej wybrane klucze nie są do końca zaufane:" #: config/chroot_local-includes/usr/local/bin/gpgApplet:569 msgid "Do you trust this key enough to use it anyway?" msgid_plural "Do you trust these keys enough to use them anyway?" -msgstr[0] "" -msgstr[1] "" -msgstr[2] "" +msgstr[0] "Czy wystarczająco temu kluczowi, aby z niego korzystać?" +msgstr[1] "Czy wystarczająco ufasz tym kluczom, aby z nich korzystać?" +msgstr[2] "Czy wystarczająco ufasz tym kluczom, aby z nich korzystać?" #: config/chroot_local-includes/usr/local/bin/gpgApplet:582 msgid "No keys selected"

1 0

[translation/tails-persistence-setup] Update translations for tails-persistence-setup
by translation＠torproject.org 15 Nov '13

15 Nov '13

commit 49b7c6cdaafee83e7d992f0d1e4fcb05ec3cd840 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Nov 15 23:45:59 2013 +0000 Update translations for tails-persistence-setup --- ms_MY/ms_MY.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ms_MY/ms_MY.po b/ms_MY/ms_MY.po index 53c2885..f625dd2 100644 --- a/ms_MY/ms_MY.po +++ b/ms_MY/ms_MY.po @@ -10,8 +10,8 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" "POT-Creation-Date: 2013-11-07 16:37+0100\n" -"PO-Revision-Date: 2013-11-15 09:19+0000\n" -"Last-Translator: runasand <runa.sandvik(a)gmail.com>\n" +"PO-Revision-Date: 2013-11-15 23:26+0000\n" +"Last-Translator: shahril <mohd_shahril_96(a)yahoo.com>\n" "Language-Team: Malay (Malaysia) (http://www.transifex.com/projects/p/torproject/language/ms_MY/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -73,7 +73,7 @@ msgstr "Sambungan Rangkaian" #: ../lib/Tails/Persistence/Configuration/Presets.pm:110 msgid "Configuration of network devices and connections" -msgstr "" +msgstr "Konfigurasi peranti rangkaian dan sambungan" #: ../lib/Tails/Persistence/Configuration/Presets.pm:118 msgid "Browser bookmarks"

1 0

[tor/release-0.2.4] Improved circuit queue out-of-memory handler
by arma＠torproject.org 15 Nov '13

15 Nov '13

commit 1b8ceb83c951f1cdea6b71a615a10d33b8adf2b3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Nov 7 12:15:30 2013 -0500 Improved circuit queue out-of-memory handler Previously, when we ran low on memory, we'd close whichever circuits had the most queued cells. Now, we close those that have the *oldest* queued cells, on the theory that those are most responsible for us running low on memory, and that those are the least likely to actually drain on their own if we wait a little longer. Based on analysis from a forthcoming paper by Jansen, Tschorsch, Johnson, and Scheuermann. Fixes bug 9093. --- changes/bug9093 | 7 +++++++ src/or/circuitlist.c | 56 +++++++++++++++++++++++++++++++++++++++++--------- src/or/or.h | 5 +++++ src/or/relay.c | 8 ++++++-- 4 files changed, 64 insertions(+), 12 deletions(-) diff --git a/changes/bug9093 b/changes/bug9093 new file mode 100644 index 0000000..06b6cb9 --- /dev/null +++ b/changes/bug9093 @@ -0,0 +1,7 @@ + o Minor features: + - Improve the circuit queue out-of-memory handler. Previously, when + we ran low on memory, we'd close whichever circuits had the most + queued cells. Now, we close those that have the *oldest* queued + cells, on the theory that those are most responsible for us + running low on memory. Based on analysis from a forthcoming paper + by Jansen, Tschorsch, Johnson, and Scheuermann. Fixes bug 9093. \ No newline at end of file diff --git a/src/or/circuitlist.c b/src/or/circuitlist.c index d9ea4d1..6250c11 100644 --- a/src/or/circuitlist.c +++ b/src/or/circuitlist.c @@ -1383,25 +1383,56 @@ n_cells_in_circ_queues(const circuit_t *c) return n; } -/** helper to sort a list of circuit_q by total queue lengths, in descending - * order. */ +/** + * Return the age of the oldest cell queued on c, in milliseconds. + * Return 0 if there are no cells queued on c. Requires that now be + * the current time in milliseconds since the epoch, truncated. + * + * This function will return incorrect results if the oldest cell queued on + * the circuit is older than 2**32 msec (about 49 days) old. + */ +static uint32_t +circuit_max_queued_cell_age(const circuit_t *c, uint32_t now) +{ + uint32_t age = 0; + if (c->n_conn_cells.head) + age = now - c->n_conn_cells.head->inserted_time; + + if (! CIRCUIT_IS_ORIGIN(c)) { + const or_circuit_t *orcirc = TO_OR_CIRCUIT((circuit_t*)c); + if (orcirc->p_conn_cells.head) { + uint32_t age2 = now - orcirc->p_conn_cells.head->inserted_time; + if (age2 > age) + return age2; + } + } + return age; +} + +/** Temporary variable for circuits_compare_by_oldest_queued_cell_ This is a + * kludge to work around the fact that qsort doesn't provide a way for + * comparison functions to take an extra argument. */ +static uint32_t circcomp_now_tmp; + +/** Helper to sort a list of circuit_t by age of oldest cell, in descending + * order. Requires that circcomp_now_tmp is set correctly. */ static int -circuits_compare_by_queue_len_(const void **a_, const void **b_) +circuits_compare_by_oldest_queued_cell_(const void **a_, const void **b_) { const circuit_t *a = *a_; const circuit_t *b = *b_; - size_t a_n = n_cells_in_circ_queues(a); - size_t b_n = n_cells_in_circ_queues(b); + uint32_t age_a = circuit_max_queued_cell_age(a, circcomp_now_tmp); + uint32_t age_b = circuit_max_queued_cell_age(b, circcomp_now_tmp); - if (a_n < b_n) + if (age_a < age_b) return 1; - else if (a_n == b_n) + else if (age_a == age_b) return 0; else return -1; } -#define FRACTION_OF_CIRCS_TO_RETAIN_ON_OOM 0.90 +#define FRACTION_OF_CELLS_TO_RETAIN_ON_OOM 0.90 /** We're out of memory for cells, having allocated current_allocation * bytes' worth. Kill the 'worst' circuits until we're under @@ -1414,13 +1445,14 @@ circuits_handle_oom(size_t current_allocation) circuit_t *circ; size_t n_cells_removed=0, n_cells_to_remove; int n_circuits_killed=0; + struct timeval now; log_notice(LD_GENERAL, "We're low on memory. Killing circuits with " "over-long queues. (This behavior is controlled by " "MaxMemInCellQueues.)"); { size_t mem_target = (size_t)(get_options()->MaxMemInCellQueues * - FRACTION_OF_CIRCS_TO_RETAIN_ON_OOM); + FRACTION_OF_CELLS_TO_RETAIN_ON_OOM); size_t mem_to_recover; if (current_allocation <= mem_target) return; @@ -1433,9 +1465,13 @@ circuits_handle_oom(size_t current_allocation) for (circ = global_circuitlist; circ; circ = circ->next) smartlist_add(circlist, circ); + /* Set circcomp_now_tmp so that the sort can work. */ + tor_gettimeofday_cached(&now); + circcomp_now_tmp = (uint32_t)tv_to_msec(&now); + /* This is O(n log n); there are faster algorithms we could use instead. * Let's hope this doesn't happen enough to be in the critical path. */ - smartlist_sort(circlist, circuits_compare_by_queue_len_); + smartlist_sort(circlist, circuits_compare_by_oldest_queued_cell_); /* Okay, now the worst circuits are at the front of the list. Let's mark * them, and reclaim their storage aggressively. */ diff --git a/src/or/or.h b/src/or/or.h index b8f334e..4622391 100644 --- a/src/or/or.h +++ b/src/or/or.h @@ -912,8 +912,13 @@ typedef struct var_cell_t { typedef struct packed_cell_t { struct packed_cell_t *next; /**< Next cell queued on this circuit. */ char body[CELL_NETWORK_SIZE]; /**< Cell as packed for network. */ + uint32_t inserted_time; /**< Time (in milliseconds since epoch, with high + * bits truncated) when this cell was inserted. */ } packed_cell_t; +/* XXXX This next structure may be obsoleted by inserted_time in + * packed_cell_t */ + /** Number of cells added to a circuit queue including their insertion * time on 10 millisecond detail; used for buffer statistics. */ typedef struct insertion_time_elem_t { diff --git a/src/or/relay.c b/src/or/relay.c index fda9e89..a193ad8 100644 --- a/src/or/relay.c +++ b/src/or/relay.c @@ -1904,15 +1904,19 @@ cell_queue_append(cell_queue_t *queue, packed_cell_t *cell) void cell_queue_append_packed_copy(cell_queue_t *queue, const cell_t *cell) { + struct timeval now; packed_cell_t *copy = packed_cell_copy(cell); + tor_gettimeofday_cached(&now); + copy->inserted_time = (uint32_t)tv_to_msec(&now); + /* Remember the time when this cell was put in the queue. */ + /*XXXX This may be obsoleted by inserted_time */ if (get_options()->CellStatistics) { - struct timeval now; uint32_t added; insertion_time_queue_t *it_queue = queue->insertion_times; if (!it_pool) it_pool = mp_pool_new(sizeof(insertion_time_elem_t), 1024); - tor_gettimeofday_cached(&now); + #define SECONDS_IN_A_DAY 86400L added = (uint32_t)(((now.tv_sec % SECONDS_IN_A_DAY) * 100L) + ((uint32_t)now.tv_usec / (uint32_t)10000L));

1 0

[tor/release-0.2.4] missing changes file for #10124
by arma＠torproject.org 15 Nov '13

15 Nov '13

commit a82b18f2168ce19e0637740fed5746d6daac4e3a Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 11 10:49:44 2013 -0500 missing changes file for #10124 --- changes/bug10124 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/changes/bug10124 b/changes/bug10124 new file mode 100644 index 0000000..95b0838 --- /dev/null +++ b/changes/bug10124 @@ -0,0 +1,3 @@ + o Documentation: + - Replace remaining references to DirServer in man page and + log entries. Resolves ticket 10124.

1 0

[tor/release-0.2.4] Merge branch 'bug9093_023' into maint-0.2.3
by arma＠torproject.org 15 Nov '13

15 Nov '13

commit 9e907076025ccd91abfad7fc70c09ba4c9228f82 Merge: 82d8944 1b8ceb8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 15 15:23:51 2013 -0500 Merge branch 'bug9093_023' into maint-0.2.3 changes/bug9093 | 7 +++++++ src/or/circuitlist.c | 56 +++++++++++++++++++++++++++++++++++++++++--------- src/or/or.h | 5 +++++ src/or/relay.c | 8 ++++++-- 4 files changed, 64 insertions(+), 12 deletions(-)

1 0

[tor/release-0.2.4] Merge branch 'maint-0.2.4' into release-0.2.4
by arma＠torproject.org 15 Nov '13

15 Nov '13

commit 5d1a004e0dd0ef33f60985c47f86c255a3404a0f Merge: f503f30 59f50c8 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Nov 15 17:10:31 2013 -0500 Merge branch 'maint-0.2.4' into release-0.2.4 changes/bug10124 | 3 +++ changes/bug9093 | 7 +++++++ src/common/util.c | 12 +++++++++++ src/common/util.h | 1 + src/or/circuitlist.c | 56 +++++++++++++++++++++++++++++++++++++++++--------- src/or/or.h | 5 +++++ src/or/relay.c | 8 ++++++-- 7 files changed, 80 insertions(+), 12 deletions(-)

1 0

[tor/release-0.2.4] Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4
by arma＠torproject.org 15 Nov '13

15 Nov '13

commit 59f50c80d443a7e148f85cfed493e3e703cc4386 Merge: a82b18f 9e90707 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 15 15:29:24 2013 -0500 Merge remote-tracking branch 'origin/maint-0.2.3' into maint-0.2.4 Conflicts: src/or/or.h src/or/relay.c Conflicts were simple to resolve. More fixes were needed for compilation, including: reinstating the tv_to_msec function, and renaming *_conn_cells to *_chan_cells. changes/bug9093 | 7 +++++++ src/common/util.c | 12 +++++++++++ src/common/util.h | 1 + src/or/circuitlist.c | 56 +++++++++++++++++++++++++++++++++++++++++--------- src/or/or.h | 5 +++++ src/or/relay.c | 8 ++++++-- 6 files changed, 77 insertions(+), 12 deletions(-) diff --cc src/common/util.c index ae385e1,b16afa1..5eb0f9a --- a/src/common/util.c +++ b/src/common/util.c @@@ -1232,6 -1322,6 +1232,18 @@@ tv_mdiff(const struct timeval *start, c return mdiff; } ++/** ++ * Converts timeval to milliseconds. ++ */ ++int64_t ++tv_to_msec(const struct timeval *tv) ++{ ++ int64_t conv = ((int64_t)tv->tv_sec)*1000L; ++ /* Round ghetto-style */ ++ conv += ((int64_t)tv->tv_usec+500)/1000L; ++ return conv; ++} ++ /** Yield true iff y is a leap-year. */ #define IS_LEAPYEAR(y) (!(y % 4) && ((y % 100) || !(y % 400))) /** Helper: Return the number of leap-days between Jan 1, y1 and Jan 1, y2. */ diff --cc src/common/util.h index 96a02dd,8977d27..73daa6e --- a/src/common/util.h +++ b/src/common/util.h @@@ -251,8 -239,11 +251,9 @@@ void base16_encode(char *dest, size_t d int base16_decode(char *dest, size_t destlen, const char *src, size_t srclen); /* Time helpers */ -double tv_to_double(const struct timeval *tv); -int64_t tv_to_msec(const struct timeval *tv); -int64_t tv_to_usec(const struct timeval *tv); long tv_udiff(const struct timeval *start, const struct timeval *end); long tv_mdiff(const struct timeval *start, const struct timeval *end); ++int64_t tv_to_msec(const struct timeval *tv); int tor_timegm(const struct tm *tm, time_t *time_out); #define RFC1123_TIME_LEN 29 void format_rfc1123_time(char *buf, time_t t); diff --cc src/or/circuitlist.c index daeaa37,6250c11..b0e24a5 --- a/src/or/circuitlist.c +++ b/src/or/circuitlist.c @@@ -1525,10 -1383,41 +1525,41 @@@ n_cells_in_circ_queues(const circuit_t return n; } - /** helper to sort a list of circuit_q by total queue lengths, in descending - * order. */ + /** + * Return the age of the oldest cell queued on c, in milliseconds. + * Return 0 if there are no cells queued on c. Requires that now be + * the current time in milliseconds since the epoch, truncated. + * + * This function will return incorrect results if the oldest cell queued on + * the circuit is older than 2**32 msec (about 49 days) old. + */ + static uint32_t + circuit_max_queued_cell_age(const circuit_t *c, uint32_t now) + { + uint32_t age = 0; - if (c->n_conn_cells.head) - age = now - c->n_conn_cells.head->inserted_time; ++ if (c->n_chan_cells.head) ++ age = now - c->n_chan_cells.head->inserted_time; + + if (! CIRCUIT_IS_ORIGIN(c)) { + const or_circuit_t *orcirc = TO_OR_CIRCUIT((circuit_t*)c); - if (orcirc->p_conn_cells.head) { - uint32_t age2 = now - orcirc->p_conn_cells.head->inserted_time; ++ if (orcirc->p_chan_cells.head) { ++ uint32_t age2 = now - orcirc->p_chan_cells.head->inserted_time; + if (age2 > age) + return age2; + } + } + return age; + } + + /** Temporary variable for circuits_compare_by_oldest_queued_cell_ This is a + * kludge to work around the fact that qsort doesn't provide a way for + * comparison functions to take an extra argument. */ + static uint32_t circcomp_now_tmp; + + /** Helper to sort a list of circuit_t by age of oldest cell, in descending + * order. Requires that circcomp_now_tmp is set correctly. */ static int - circuits_compare_by_queue_len_(const void **a_, const void **b_) + circuits_compare_by_oldest_queued_cell_(const void **a_, const void **b_) { const circuit_t *a = *a_; const circuit_t *b = *b_; diff --cc src/or/or.h index eff5a6d,4622391..5318b0f --- a/src/or/or.h +++ b/src/or/or.h @@@ -1076,9 -911,14 +1076,14 @@@ typedef struct var_cell_t /** A cell as packed for writing to the network. */ typedef struct packed_cell_t { struct packed_cell_t *next; /**< Next cell queued on this circuit. */ - char body[CELL_NETWORK_SIZE]; /**< Cell as packed for network. */ + char body[CELL_MAX_NETWORK_SIZE]; /**< Cell as packed for network. */ + uint32_t inserted_time; /**< Time (in milliseconds since epoch, with high + * bits truncated) when this cell was inserted. */ } packed_cell_t; + /* XXXX This next structure may be obsoleted by inserted_time in + * packed_cell_t */ + /** Number of cells added to a circuit queue including their insertion * time on 10 millisecond detail; used for buffer statistics. */ typedef struct insertion_time_elem_t { diff --cc src/or/relay.c index 29dc361,a193ad8..63119cb --- a/src/or/relay.c +++ b/src/or/relay.c @@@ -2146,13 -1902,16 +2146,17 @@@ cell_queue_append(cell_queue_t *queue, /** Append a newly allocated copy of cell to the end of queue */ void -cell_queue_append_packed_copy(cell_queue_t *queue, const cell_t *cell) +cell_queue_append_packed_copy(cell_queue_t *queue, const cell_t *cell, + int wide_circ_ids) { + struct timeval now; - packed_cell_t *copy = packed_cell_copy(cell); + packed_cell_t *copy = packed_cell_copy(cell, wide_circ_ids); + tor_gettimeofday_cached(&now); + copy->inserted_time = (uint32_t)tv_to_msec(&now); + /* Remember the time when this cell was put in the queue. */ + /*XXXX This may be obsoleted by inserted_time */ if (get_options()->CellStatistics) { - struct timeval now; uint32_t added; insertion_time_queue_t *it_queue = queue->insertion_times; if (!it_pool)

1 0