September 2011 - tor-commits - lists.torproject.org

[arm/release] fix: tor process detection limited to our user
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 795f5a061f2960cbb0659a6e5f796423e7873187 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Sep 21 09:01:12 2011 -0700 fix: tor process detection limited to our user When checking to see if a tor process is already running I forgot the '-A' flag for ps, limiting the check to our user. --- src/util/torTools.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/util/torTools.py b/src/util/torTools.py index f6d9d86..8c7a1ed 100644 --- a/src/util/torTools.py +++ b/src/util/torTools.py @@ -352,7 +352,7 @@ def isTorRunning(): """ # suggestions welcome for making this more reliable - commandResults = sysTools.call("ps co command") + commandResults = sysTools.call("ps -A co command") if commandResults: for cmd in commandResults: if cmd.strip() == "tor": return True

1 0

[arm/release] Event handling for the interpretor
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit b2d22453d55516c97d1ba3af8f2f218e8450c71a Author: Damian Johnson <atagar(a)torproject.org> Date: Mon Sep 19 09:59:48 2011 -0700 Event handling for the interpretor Intercepts SETEVENTS requests and provides received events via an "/events [TYPE]" option. --- src/util/torInterpretor.py | 70 ++++++++++++++++++++++++++++++++++++++++--- 1 files changed, 65 insertions(+), 5 deletions(-) diff --git a/src/util/torInterpretor.py b/src/util/torInterpretor.py index 1f208ba..cb2dcb7 100644 --- a/src/util/torInterpretor.py +++ b/src/util/torInterpretor.py @@ -10,6 +10,12 @@ import readline import version +# TODO: util should never import from the cli. This is being done as a hack to +# simplify event listening, but we should later move the TorEventObserver into +# the util. + +from cli.logPanel import TorEventObserver + from util import connections, enum, hostnames, torConfig, torTools, uiTools COLOR_PROMPT = True # provides a colored interpretor prompt @@ -47,16 +53,18 @@ RESET = CSI % "0" # limits used for cropping BACKLOG_LIMIT = 100 +EVENTS_LIMIT = 200 CONTENT_LIMIT = 20000 MULTILINE_UNIMPLEMENTED_NOTICE = "Multi-line control options like this are not yet implemented." GENERAL_HELP = """Interpretor commands include: - /help - provides information for interpretor and tor commands/config options - /write - saves backlog to a given location - /info - general information for a relay - /find - searches backlog for lines with the given regex - /quit - shuts down the interpretor + /help - provides information for interpretor and tor commands/config options + /info - general information for a relay + /find - searches backlog for lines with the given regex + /events - prints events that we've received + /write - saves backlog to a given location + /quit - shuts down the interpretor Tor commands include: GETINFO - queries information from tor @@ -93,6 +101,10 @@ Example: HELP_WRITE = """Writes the interpretor's backlog to the given path. If no location is specified then this saves to the last path specified (initially '%s').""" % DEFAULT_WRITE_PATH +HELP_EVENTS = """Provides events that we've received belonging to the given event types. If +no types are specified then this provides all the messages that we've +received.""" + HELP_INFO = """Provides general information for a relay that's currently in the consensus. If no relay is specified then this provides information on ourselves.""" @@ -205,6 +217,7 @@ before authenticating to the control port.""" HELP_OPTIONS = { "HELP": ("/help [OPTION]", HELP_HELP), "WRITE": ("/write [PATH]", HELP_WRITE), + "EVENTS": ("/events [types]", HELP_EVENTS), "INFO": ("/info [relay fingerprint, nickname, or IP address]", HELP_INFO), "FIND": ("/find PATTERN", HELP_FIND), "QUIT": ("/quit", HELP_QUIT), @@ -428,6 +441,21 @@ class ControlInterpretor: self.backlog = [] # prior requests the user has made self.contents = [] # (msg, format list) tuples for what's been displayed self.writePath = DEFAULT_WRITE_PATH # last location we've saved to + self.eventBuffer = [] # unread event messages + self.loggedEvents = [] # event types that we're listening for + + torTools.getConn().addEventListener(TorEventObserver(self.registerEvent)) + + def registerEvent(self, event): + """ + Adds the event to our buffer so it'll be in '/events' output. + """ + + if event.type in self.loggedEvents: + self.eventBuffer.append(event) + + eventsCrop = len(self.eventBuffer) - EVENTS_LIMIT + if eventsCrop > 0: self.eventBuffer = self.eventBuffer[eventsCrop:] def getBacklog(self): """ @@ -573,6 +601,23 @@ class ControlInterpretor: else: outputEntry.append((line + "\n", OUTPUT_FORMAT + (Attr.BOLD, ))) + def doEvents(self, arg, outputEntry): + """ + Performs the '/events' operation, dumping the events that we've received + belonging to the given types. If no types are specified then this provides + all buffered events. + """ + + bufferedEvents = self.eventBuffer + + # if we have an argument then restrict it to those event types + eventTypes = arg.upper().split() + if eventTypes: + bufferedEvents = [event for event in self.eventBuffer if event.type in eventTypes] + + for event in bufferedEvents: + outputEntry.append((event.getDisplayMessage() + "\n", OUTPUT_FORMAT)) + def doWrite(self, arg, outputEntry): """ Performs the '/write' operation, which attempts to save the backlog to a @@ -803,6 +848,7 @@ class ControlInterpretor: elif cmd == "/help": self.doHelp(arg, outputEntry) elif cmd == "/write": self.doWrite(arg, outputEntry) elif cmd == "/find": self.doFind(arg, outputEntry) + elif cmd == "/events": self.doEvents(arg, outputEntry) elif cmd == "/info": self.doInfo(arg, outputEntry) else: outputEntry.append(("Not yet implemented...", ERROR_FORMAT)) # TODO: implement @@ -865,6 +911,20 @@ class ControlInterpretor: conn.setOptions(paramList, isReset) except Exception, exc: outputEntry.append((str(exc), ERROR_FORMAT)) + elif cmd == "SETEVENTS": + self.loggedEvents = arg.split() + allEvents = torTools.getConn().setControllerEvents(self.loggedEvents) + setEvents = set(self.loggedEvents).intersection(allEvents) + + if setEvents: + outputEntry.append(("Successfully set event listening to: %s\n" % ", ".join(setEvents), OUTPUT_FORMAT)) + else: + if not self.loggedEvents: + # we purposefully disabled event listening + outputEntry.append(("Disabled event listening\n", OUTPUT_FORMAT)) + else: + # we tried to set events but they all failed + outputEntry.append(("Unable to set any of the events. Event listening disabled.\n", ERROR_FORMAT)) elif cmd.replace("+", "") in ("LOADCONF", "POSTDESCRIPTOR"): # provides a notice that multi-line controller input isn't yet implemented outputEntry.append((MULTILINE_UNIMPLEMENTED_NOTICE + "\n", ERROR_FORMAT))

1 0

[arm/release] fix: using all controller authentication methods
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 8070fd004acde588f4d56d75bf6aa2c3f4d61b77 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Sep 21 09:33:28 2011 -0700 fix: using all controller authentication methods This is a hacked up version of the fix for https://trac.torproject.org/projects/tor/ticket/3958 It's a bit of a Frankenstein and will be removed when the TorCtl fix is merged. --- src/starter.py | 9 ++- src/util/torTools.py | 181 ++++++++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 186 insertions(+), 4 deletions(-) diff --git a/src/starter.py b/src/starter.py index dd5f5c9..4315f06 100644 --- a/src/starter.py +++ b/src/starter.py @@ -203,15 +203,16 @@ def _torCtlConnect(controlAddr="127.0.0.1", controlPort=9051, passphrase=None, i conn = None try: - conn, authType, authValue = TorCtl.TorCtl.preauth_connect(controlAddr, controlPort) + #conn, authType, authValue = TorCtl.TorCtl.preauth_connect(controlAddr, controlPort) + conn, authTypes, authValue = util.torTools.preauth_connect_alt(controlAddr, controlPort) - if authType == TorCtl.TorCtl.AUTH_TYPE.PASSWORD: + if TorCtl.TorCtl.AUTH_TYPE.PASSWORD in authTypes: # password authentication, promting for the password if it wasn't provided if passphrase: authValue = passphrase else: try: authValue = getpass.getpass("Controller password: ") except KeyboardInterrupt: return None - elif authType == TorCtl.TorCtl.AUTH_TYPE.COOKIE and authValue[0] != "/": + elif TorCtl.TorCtl.AUTH_TYPE.COOKIE in authTypes and authValue[0] != "/": # Connecting to the control port will probably fail if it's using cookie # authentication and the cookie path is relative (unfortunately this is # the case for TBB). This is discussed in: @@ -226,7 +227,7 @@ def _torCtlConnect(controlAddr="127.0.0.1", controlPort=9051, passphrase=None, i except IOError: pass # appends the path prefix if it's set - if authType == TorCtl.TorCtl.AUTH_TYPE.COOKIE: + if TorCtl.TorCtl.AUTH_TYPE.COOKIE in authTypes: pathPrefix = util.torTools.getConn().getPathPrefix() # The os.path.join function is kinda stupid. If given an absolute path diff --git a/src/util/torTools.py b/src/util/torTools.py index 8c7a1ed..e59b35e 100644 --- a/src/util/torTools.py +++ b/src/util/torTools.py @@ -359,6 +359,187 @@ def isTorRunning(): return False +# ============================================================ +# TODO: Remove when TorCtl can handle multiple auth methods +# https://trac.torproject.org/projects/tor/ticket/3958 +# +# The following is a hacked up version of the fix in that ticket. +# ============================================================ + +class FixedConnection(TorCtl.Connection): + def __init__(self, sock): + TorCtl.Connection.__init__(self, sock) + self._authTypes = [] + + def get_auth_types(self): + """ + Provides the list of authentication types used for the control port. Each + are members of the AUTH_TYPE enumeration and return results will always + have at least one result. This raises an IOError if the query to + PROTOCOLINFO fails. + """ + + if not self._authTypes: + # check PROTOCOLINFO for authentication type + try: + authInfo = self.sendAndRecv("PROTOCOLINFO\r\n")[1][1] + except Exception, exc: + if exc.message: excMsg = ": %s" % exc + else: excMsg = "" + raise IOError("Unable to query PROTOCOLINFO for the authentication type%s" % excMsg) + + # parses the METHODS and COOKIEFILE entries for details we need to + # authenticate + + authTypes, cookiePath = [], None + + for entry in authInfo.split(): + if entry.startswith("METHODS="): + # Comma separated list of our authentication types. If we have + # multiple then any of them will work. + + methodsEntry = entry[8:] + + for authEntry in methodsEntry.split(","): + if authEntry == "NULL": + authTypes.append(TorCtl.AUTH_TYPE.NONE) + elif authEntry == "HASHEDPASSWORD": + authTypes.append(TorCtl.AUTH_TYPE.PASSWORD) + elif authEntry == "COOKIE": + authTypes.append(TorCtl.AUTH_TYPE.COOKIE) + else: + # not of a recognized authentication type (new addition to the + # control-spec?) + + raise IOError("Unrecognized authentication type: %s" % authEntry) + elif entry.startswith("COOKIEFILE=\"") and entry.endswith("\""): + # Quoted path of the authentication cookie. This only exists if we're + # using cookie auth and, of course, doesn't account for chroot. + + cookiePath = entry[12:-1] + + # There should always be a AUTH METHODS entry. If we didn't then throw a + # wobbly. + + if not authTypes: + raise IOError("PROTOCOLINFO response didn't include any authentication methods") + + self._authType = authTypes[0] + self._authTypes = authTypes + self._cookiePath = cookiePath + + return list(self._authTypes) + + def authenticate(self, secret=""): + """ + Authenticates to the control port. If an issue arises this raises either of + the following: + - IOError for failures in reading an authentication cookie or querying + PROTOCOLINFO. + - TorCtl.ErrorReply for authentication failures or if the secret is + undefined when using password authentication + """ + + # fetches authentication type and cookie path if still unloaded + if not self._authTypes: self.get_auth_types() + + # validates input + if TorCtl.AUTH_TYPE.PASSWORD in self._authTypes and secret == "": + raise TorCtl.ErrorReply("Unable to authenticate: no passphrase provided") + + # tries each of our authentication methods, throwing the last exception if + # they all fail + + raisedExc = None + for authMethod in self._authTypes: + authCookie = None + try: + if authMethod == TorCtl.AUTH_TYPE.NONE: + self.authenticate_password("") + elif authMethod == TorCtl.AUTH_TYPE.PASSWORD: + self.authenticate_password(secret) + else: + authCookie = open(self._cookiePath, "r") + self.authenticate_cookie(authCookie) + authCookie.close() + + # Did the above raise an exception? No? Cool, we're done. + return + except TorCtl.ErrorReply, exc: + if authCookie: authCookie.close() + issue = str(exc) + + # simplifies message if the wrong credentials were provided (common + # mistake) + if issue.startswith("515 Authentication failed: "): + if issue[27:].startswith("Password did not match"): + issue = "password incorrect" + elif issue[27:] == "Wrong length on authentication cookie.": + issue = "cookie value incorrect" + + raisedExc = TorCtl.ErrorReply("Unable to authenticate: %s" % issue) + except IOError, exc: + if authCookie: authCookie.close() + issue = None + + # cleaner message for common errors + if str(exc).startswith("[Errno 13] Permission denied"): + issue = "permission denied" + elif str(exc).startswith("[Errno 2] No such file or directory"): + issue = "file doesn't exist" + + # if problem's recognized give concise message, otherwise print exception + # string + if issue: raisedExc = IOError("Failed to read authentication cookie (%s): %s" % (issue, self._cookiePath)) + else: raisedExc = IOError("Failed to read authentication cookie: %s" % exc) + + # if we got to this point then we failed to authenticate and should have a + # raisedExc + + if raisedExc: raise raisedExc + +def preauth_connect_alt(controlAddr="127.0.0.1", controlPort=9051, + ConnClass=FixedConnection): + """ + Provides an uninitiated torctl connection components for the control port, + returning a tuple of the form... + (torctl connection, authTypes, authValue) + + The authValue corresponds to the cookie path if using an authentication + cookie, otherwise this is the empty string. This raises an IOError in case + of failure. + + Arguments: + controlAddr - ip address belonging to the controller + controlPort - port belonging to the controller + ConnClass - connection type to instantiate + """ + + conn = None + try: + s = socket.socket(socket.AF_INET, socket.SOCK_STREAM) + s.connect((controlAddr, controlPort)) + conn = ConnClass(s) + authTypes, authValue = conn.get_auth_types(), "" + + if TorCtl.AUTH_TYPE.COOKIE in authTypes: + authValue = conn.get_auth_cookie_path() + + return (conn, authTypes, authValue) + except socket.error, exc: + if conn: conn.close() + + if "Connection refused" in exc.args: + # most common case - tor control port isn't available + raise IOError("Connection refused. Is the ControlPort enabled?") + + raise IOError("Failed to establish socket: %s" % exc) + except Exception, exc: + if conn: conn.close() + raise IOError(exc) + +# ============================================================ + def getConn(): """ Singleton constructor for a Controller. Be aware that this starts as being

1 0

[arm/release] fix: concurrency issue could crash from CIRC event
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit e884fcbd894c9e764c60e6b40c5bd3e14583352e Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 13:03:20 2011 -0700 fix: concurrency issue could crash from CIRC event If we got a CIRC event while populating the cache of relays that we're attached to we could reset _fingerprintsAttachedCache to None while we were in the middle of populating it. Manipulation of this cache is supposed to be governed by the connection lock, so fixing that for the CIRC event's reset. --- src/util/torTools.py | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/util/torTools.py b/src/util/torTools.py index e59b35e..3d18fcb 100644 --- a/src/util/torTools.py +++ b/src/util/torTools.py @@ -2004,7 +2004,9 @@ class Controller(TorCtl.PostEventListener): # CIRC events aren't required, but if one's received then flush this cache # since it uses circuit-status results. + self.connLock.acquire() self._fingerprintsAttachedCache = None + self.connLock.release() self._cachedParam["circuits"] = None @@ -2085,6 +2087,10 @@ class Controller(TorCtl.PostEventListener): relayPort - orport of relay (to further narrow the results) """ + # Events can reset _fingerprintsAttachedCache to None, so all uses of this + # function need to be under the connection lock (skipping that might also + # scew with the conn usage of this function...) + # If we were provided with a string port then convert to an int (so # lookups won't mismatch based on type). if isinstance(relayPort, str): relayPort = int(relayPort)

1 0

[arm/release] fix: clarifying missing armrc message
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 73de20de4a69bc055cf23d5852e0ac8b007af1a9 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 12:54:39 2011 -0700 fix: clarifying missing armrc message Occasionally people are confused by the notice that no armrc was loaded, thinking that it's a problem. Trying to clarify the message (it's just supposed to inform users that they can customize arm's behavior). --- src/starter.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/starter.py b/src/starter.py index 4315f06..2347f7b 100644 --- a/src/starter.py +++ b/src/starter.py @@ -94,7 +94,7 @@ DESC_SAVE_FAILED_MSG = "Unable to save configuration descriptions (%s)" NO_INTERNAL_CFG_MSG = "Failed to load the parsing configuration. This will be problematic for a few things like torrc validation and log duplication detection (%s)" STANDARD_CFG_LOAD_FAILED_MSG = "Failed to load configuration (using defaults): \"%s\"" -STANDARD_CFG_NOT_FOUND_MSG = "No configuration found at '%s', using defaults" +STANDARD_CFG_NOT_FOUND_MSG = "No armrc loaded, using defaults. You can customize arm by placing a configuration file at '%s' (see the armrc.sample for its options)." # torrc entries that are scrubbed when dumping PRIVATE_TORRC_ENTRIES = ["HashedControlPassword", "Bridge", "HiddenServiceDir"]

1 0

[arm/release] fix: wizard showed wrong torrc path for sys torrc
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 458073c58d103b8dc633b36f56d77602865911e7 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 14:33:25 2011 -0700 fix: wizard showed wrong torrc path for sys torrc When the user opts for the generated torrc to be for the system instance the wizard shows the wrong path in the confirmation panel. --- src/cli/wizard.py | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index 4cb65ad..da4e645 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -356,15 +356,15 @@ def showWizard(): generatedTorrc = getTorrc(relayType, config, disabledOpt) torrcLocation = manager.getTorrcPath() + isSystemReplace = not Options.SYSTEM in disabledOpt and config[Options.SYSTEM].getValue() + if isSystemReplace: torrcLocation = SYSTEM_DROP_PATH + controller.redraw() confirmationSelection = showConfirmationDialog(generatedTorrc, torrcLocation) if confirmationSelection == NEXT: log.log(log.INFO, "Writing torrc to '%s':\n%s" % (torrcLocation, generatedTorrc)) - isSystemReplace = not Options.SYSTEM in disabledOpt and config[Options.SYSTEM].getValue() - if isSystemReplace: torrcLocation = SYSTEM_DROP_PATH - # if the torrc already exists then save it to a _bak file isBackedUp = False if os.path.exists(torrcLocation) and not isSystemReplace:

1 0

[arm/release] Quiting wizard when the user presses 'q'
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 30fc358c617ebd075119e20fd6e532150b432e24 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 13:14:54 2011 -0700 Quiting wizard when the user presses 'q' Users could cancel the wizard by prssing esc, but it's also intuitive to expect 'q' to do the same (since that's the keybinding to quit arm entirely). Respecting this option too. This was requested by monochromec on... https://trac.torproject.org/projects/tor/ticket/3995 This also fixes a minor bug where the config options dialog wouldn't respect a cancel signal (instead looping on that dialog). --- src/cli/wizard.py | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index 40cf632..4cb65ad 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -351,6 +351,7 @@ def showWizard(): selection = promptConfigOptions(relayType, config, disabledOpt) if selection == BACK: relayType = None + elif selection == CANCEL: break elif selection == NEXT: generatedTorrc = getTorrc(relayType, config, disabledOpt) @@ -536,7 +537,7 @@ def promptRelayType(initialSelection): if key == curses.KEY_UP: selection = (selection - 1) % len(options) elif key == curses.KEY_DOWN: selection = (selection + 1) % len(options) elif uiTools.isSelectionKey(key): return options[selection].getValue() - elif key == 27: return CANCEL # esc - cancel + elif key in (27, ord('q'), ord('Q')): return CANCEL # esc or q - cancel finally: cli.popups.finalize() @@ -635,7 +636,7 @@ def promptConfigOptions(relayType, config, disabledOpt): except ValueError, exc: cli.popups.showMsg(str(exc), 3) cli.controller.getController().redraw() - elif key == 27: selection, key = -1, curses.KEY_ENTER # esc - cancel + elif key in (27, ord('q'), ord('Q')): return CANCEL finally: cli.popups.finalize() @@ -857,7 +858,7 @@ def showConfirmationDialog(torrcContents, torrcLocation): if selection == 0: return CANCEL elif selection == 1: return BACK else: return NEXT - elif key == 27: return CANCEL + elif key in (27, ord('q'), ord('Q')): return CANCEL finally: cli.popups.finalize()

1 0

[arm/release] fix: renaming prompt and format to avoid ambiguity
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit e2e3091c1af2741e046831fdecd73677b3c1652b Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 17:29:05 2011 -0700 fix: renaming prompt and format to avoid ambiguity Renaming the prompt function and format variable to avoid a naming conflict with other uses of that name in the module. Not actually an error, but could lead to headaches if it did cause a bug. Caught by pylint. --- src/starter.py | 2 +- src/util/torInterpretor.py | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/starter.py b/src/starter.py index b184330..625000c 100644 --- a/src/starter.py +++ b/src/starter.py @@ -538,7 +538,7 @@ if __name__ == '__main__': import gui.controller gui.controller.start_gui() elif launchPrompt: - util.torInterpretor.prompt() + util.torInterpretor.showPrompt() else: cli.controller.startTorMonitor(time.time() - initTime) diff --git a/src/util/torInterpretor.py b/src/util/torInterpretor.py index cb2dcb7..1ff3b84 100644 --- a/src/util/torInterpretor.py +++ b/src/util/torInterpretor.py @@ -960,7 +960,7 @@ class ControlInterpretor: return (inputLines, outputLines) -def prompt(): +def showPrompt(): # For Python 2.6 and earlier cycling history via the readline module with # up/down is buggy with a color prompt. For more information see: # http://bugs.python.org/issue12972 @@ -1041,17 +1041,17 @@ def _splitOnNewlines(entry): entry = list(entry) # shallow copy while entry: - msg, format = entry.pop(0) + msg, msgFormat = entry.pop(0) if "\n" in msg: msg, remainder = msg.split("\n", 1) - entry.insert(0, (remainder, format)) + entry.insert(0, (remainder, msgFormat)) - tmpLine.append((msg, format)) + tmpLine.append((msg, msgFormat)) results.append(tmpLine) tmpLine = [] else: - tmpLine.append((msg, format)) + tmpLine.append((msg, msgFormat)) if tmpLine: results.append(tmpLine) return results

1 0

[arm/release] fix: dropping os check for startup wizard option
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 7a187c482f306fbfbe83552cc2a618e393e357e3 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 14:43:35 2011 -0700 fix: dropping os check for startup wizard option The startup wizard option is currently unimplemented and disabled in the setting.cfg. However, there was an os compatability check left over from when I was gonna implement it. That and its comment were confusing since the option's not implemented so commenting it out with a more up to date expanation. --- src/cli/wizard.py | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/cli/wizard.py b/src/cli/wizard.py index da4e645..86522d1 100644 --- a/src/cli/wizard.py +++ b/src/cli/wizard.py @@ -331,10 +331,15 @@ def showWizard(): if not os.path.exists(os.path.dirname(SYSTEM_DROP_PATH)) or not os.path.exists(OVERRIDE_SCRIPT): disabledOpt.append(Options.SYSTEM) + # TODO: The STARTUP option is currently disabled in the 'settings.cfg', and I + # don't currently have plans to implement it (it would be a big pita, and the + # tor deb already handles it). *If* it is implemented then I'd limit support + # for the option to Debian and Ubuntu to start with, via the following... + # Running at startup is currently only supported for Debian and Ubuntu. # Patches welcome for supporting other platforms. - if not platform.dist()[0] in ("debian", "Ubuntu"): - disabledOpt.append(Options.STARTUP) + #if not platform.dist()[0] in ("debian", "Ubuntu"): + # disabledOpt.append(Options.STARTUP) while True: if relayType == None:

1 0

[arm/release] Toning down arm's notice when resolvers fail
by atagar＠torproject.org 26 Sep '11

26 Sep '11

commit 019ee06a104b796bee4398efc7b6dff4c368fc09 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Sep 24 15:27:38 2011 -0700 Toning down arm's notice when resolvers fail When arm failed to query tor's connections it would give a short warning saying so. This often spooked users so lowering this to be a NOTICE and giving more information on both what happened and how to fix it (99% of the time this is a simple permissions issue). Change requested by Sebastian --- armrc.sample | 2 +- src/cli/controller.py | 2 +- src/util/connections.py | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/armrc.sample b/armrc.sample index 8f65fbc..7daba30 100644 --- a/armrc.sample +++ b/armrc.sample @@ -303,7 +303,7 @@ log.configDescriptions.persistance.saveFailed NOTICE log.connResolverOptions INFO log.connLookupFailed INFO log.connLookupFailover NOTICE -log.connLookupAbandon WARN +log.connLookupAbandon NOTICE log.connLookupRateGrowing NONE log.hostnameCacheTrimmed INFO log.cursesColorSupport INFO diff --git a/src/cli/controller.py b/src/cli/controller.py index a841492..4e6dc82 100644 --- a/src/cli/controller.py +++ b/src/cli/controller.py @@ -670,7 +670,7 @@ def startTorMonitor(startTime): connections.getResolver("tor").setPaused(not conn.isAlive()) # hack to display a better (arm specific) notice if all resolvers fail - connections.RESOLVER_FINAL_FAILURE_MSG += " (connection related portions of the monitor won't function)" + connections.RESOLVER_FINAL_FAILURE_MSG = "We were unable to use any of your system's resolvers to get tor's connections. This is fine, but means that the connections page will be empty. This is usually permissions related so if you would like to fix this then run arm with the same user as tor (ie, \"sudo -u <tor user> arm\")." # provides a notice about any event types tor supports but arm doesn't missingEventTypes = cli.logPanel.getMissingEventTypes() diff --git a/src/util/connections.py b/src/util/connections.py index 97de3ea..9350cb8 100644 --- a/src/util/connections.py +++ b/src/util/connections.py @@ -72,13 +72,13 @@ RUN_BSD_PROCSTAT = "procstat -f %s | grep TCP | grep -v 0.0.0.0:0" RESOLVERS = [] # connection resolvers available via the singleton constructor RESOLVER_FAILURE_TOLERANCE = 3 # number of subsequent failures before moving on to another resolver -RESOLVER_SERIAL_FAILURE_MSG = "Querying connections with %s failed, trying %s" +RESOLVER_SERIAL_FAILURE_MSG = "Unable to query connections with %s, trying %s" RESOLVER_FINAL_FAILURE_MSG = "All connection resolvers failed" CONFIG = {"queries.connections.minRate": 5, "log.connResolverOptions": log.INFO, "log.connLookupFailed": log.INFO, "log.connLookupFailover": log.NOTICE, - "log.connLookupAbandon": log.WARN, + "log.connLookupAbandon": log.NOTICE, "log.connLookupRateGrowing": None, "log.configEntryTypeError": log.NOTICE}

1 0