November 2011 - tor-commits - lists.torproject.org

[tor/master] Don't leak an extend_info_t in rend_client_any_intro_points_usable
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit 65a0d7e7ef03cc2390cad81264e451e59206842b Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Mon Nov 7 08:35:51 2011 -0800 Don't leak an extend_info_t in rend_client_any_intro_points_usable --- changes/bug4424 | 6 ++++++ src/or/rendclient.c | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/changes/bug4424 b/changes/bug4424 new file mode 100644 index 0000000..6928745 --- /dev/null +++ b/changes/bug4424 @@ -0,0 +1,6 @@ + o Major bugfixes + + - Don't leak memory when we check whether a hidden service + descriptor has any usable introduction points left. Fixes bug + 4424. Bugfix on 0.2.2.25-alpha; found by frosty_un. + diff --git a/src/or/rendclient.c b/src/or/rendclient.c index f84475a..3dfca58 100644 --- a/src/or/rendclient.c +++ b/src/or/rendclient.c @@ -952,8 +952,14 @@ rend_client_get_random_intro_impl(const rend_cache_entry_t *entry, int rend_client_any_intro_points_usable(const rend_cache_entry_t *entry) { - return rend_client_get_random_intro_impl( - entry, get_options()->StrictNodes, 0) != NULL; + extend_info_t *extend_info = + rend_client_get_random_intro_impl(entry, get_options()->StrictNodes, 0); + int rv = extend_info != NULL; + + if (extend_info != NULL) + extend_info_free(extend_info); + + return rv; } /** Client-side authorizations for hidden services; map of onion address to

1 0

[tor/master] Remove an extraneous "if" in the 4424 fix
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit 02d89c5c663ec5370386de0173accaa66c1e69f5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 7 11:46:51 2011 -0500 Remove an extraneous "if" in the 4424 fix --- src/or/rendclient.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/or/rendclient.c b/src/or/rendclient.c index 3dfca58..f951dad 100644 --- a/src/or/rendclient.c +++ b/src/or/rendclient.c @@ -954,11 +954,10 @@ rend_client_any_intro_points_usable(const rend_cache_entry_t *entry) { extend_info_t *extend_info = rend_client_get_random_intro_impl(entry, get_options()->StrictNodes, 0); - int rv = extend_info != NULL; - if (extend_info != NULL) - extend_info_free(extend_info); + int rv = (extend_info != NULL); + extend_info_free(extend_info); return rv; }

1 0

[tor/master] Merge branch 'bug4424' into maint-0.2.2
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit ca282e53263de564774944a8aa93e88271983461 Merge: 4d8306e 02d89c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 7 11:47:28 2011 -0500 Merge branch 'bug4424' into maint-0.2.2 changes/bug4424 | 6 ++++++ src/or/rendclient.c | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)

1 0

[tor/master] Merge remote-tracking branch 'origin/maint-0.2.2'
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit ceebc8283f4ba8fbc19c0b788d855855f5bbdbb8 Merge: 21dd6ea ca282e5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 7 11:48:02 2011 -0500 Merge remote-tracking branch 'origin/maint-0.2.2' changes/bug4424 | 6 ++++++ src/or/rendclient.c | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.2.2] Don't leak an extend_info_t in rend_client_any_intro_points_usable
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit 65a0d7e7ef03cc2390cad81264e451e59206842b Author: Robert Ransom <rransom.8774(a)gmail.com> Date: Mon Nov 7 08:35:51 2011 -0800 Don't leak an extend_info_t in rend_client_any_intro_points_usable --- changes/bug4424 | 6 ++++++ src/or/rendclient.c | 10 ++++++++-- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/changes/bug4424 b/changes/bug4424 new file mode 100644 index 0000000..6928745 --- /dev/null +++ b/changes/bug4424 @@ -0,0 +1,6 @@ + o Major bugfixes + + - Don't leak memory when we check whether a hidden service + descriptor has any usable introduction points left. Fixes bug + 4424. Bugfix on 0.2.2.25-alpha; found by frosty_un. + diff --git a/src/or/rendclient.c b/src/or/rendclient.c index f84475a..3dfca58 100644 --- a/src/or/rendclient.c +++ b/src/or/rendclient.c @@ -952,8 +952,14 @@ rend_client_get_random_intro_impl(const rend_cache_entry_t *entry, int rend_client_any_intro_points_usable(const rend_cache_entry_t *entry) { - return rend_client_get_random_intro_impl( - entry, get_options()->StrictNodes, 0) != NULL; + extend_info_t *extend_info = + rend_client_get_random_intro_impl(entry, get_options()->StrictNodes, 0); + int rv = extend_info != NULL; + + if (extend_info != NULL) + extend_info_free(extend_info); + + return rv; } /** Client-side authorizations for hidden services; map of onion address to

1 0

[tor/maint-0.2.2] Remove an extraneous "if" in the 4424 fix
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit 02d89c5c663ec5370386de0173accaa66c1e69f5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 7 11:46:51 2011 -0500 Remove an extraneous "if" in the 4424 fix --- src/or/rendclient.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/or/rendclient.c b/src/or/rendclient.c index 3dfca58..f951dad 100644 --- a/src/or/rendclient.c +++ b/src/or/rendclient.c @@ -954,11 +954,10 @@ rend_client_any_intro_points_usable(const rend_cache_entry_t *entry) { extend_info_t *extend_info = rend_client_get_random_intro_impl(entry, get_options()->StrictNodes, 0); - int rv = extend_info != NULL; - if (extend_info != NULL) - extend_info_free(extend_info); + int rv = (extend_info != NULL); + extend_info_free(extend_info); return rv; }

1 0

[tor/maint-0.2.2] Merge branch 'bug4424' into maint-0.2.2
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit ca282e53263de564774944a8aa93e88271983461 Merge: 4d8306e 02d89c5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 7 11:47:28 2011 -0500 Merge branch 'bug4424' into maint-0.2.2 changes/bug4424 | 6 ++++++ src/or/rendclient.c | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-)

1 0

[tor/master] Added man entry for ClientTransportPlugin.
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit 1c532594e77aa22617c51b988a93084cfc0dc900 Author: George Kadianakis <desnacked(a)gmail.com> Date: Sun Nov 6 00:50:22 2011 +0100 Added man entry for ClientTransportPlugin. --- doc/tor.1.txt | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 89dd7dc..cea2d75 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -110,6 +110,12 @@ Other options can be specified either on the command-line (--option You should never need to change this value, since a network-wide value is published in the consensus and your relay will use that value. (Default: 0) +**ClientTransportPlugin** __transport__ socks4|socks5 __IP__:__PORT__:: + When set along with a corresponding Bridge line, the Tor client + forwards its traffic to a SOCKS-speaking proxy on "IP:PORT". It's + the duty of that proxy to properly forward the traffic to the + bridge. + **ConnLimit** __NUM__:: The minimum number of file descriptors that must be available to the Tor process before it will start. Tor will ask the OS for as many file @@ -483,13 +489,17 @@ The following options are useful only for clients (that is, if so using these relays might make your client stand out. (Default: 1) -**Bridge** __IP__:__ORPort__ [fingerprint]:: +**Bridge** [__transport__] __IP__:__ORPort__ [__fingerprint__]:: When set along with UseBridges, instructs Tor to use the relay at "IP:ORPort" as a "bridge" relaying into the Tor network. If "fingerprint" is provided (using the same format as for DirServer), we will verify that the relay running at that location has the right fingerprint. We also use fingerprint to look up the bridge descriptor at the bridge authority, if - it's provided and if UpdateBridgesFromAuthority is set too. + it's provided and if UpdateBridgesFromAuthority is set too. + + + + If "transport" is provided, and matches to a ClientTransportPlugin + line, we use that pluggable transports proxy to transfer data to + the bridge. **LearnCircuitBuildTimeout** **0**|**1**:: If 0, CircuitBuildTimeout adaptive learning is disabled. (Default: 1)

1 0

[tor/master] Merge remote-tracking branch 'asn-mytor/bug4012_clienttransportplugin'
by nickm＠torproject.org 07 Nov '11

07 Nov '11

commit 21dd6eae9eb6904586fc0f809a257943b85314be Merge: 51f53b5 1c53259 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Nov 7 11:37:29 2011 -0500 Merge remote-tracking branch 'asn-mytor/bug4012_clienttransportplugin' doc/tor.1.txt | 14 ++++++++++++-- 1 files changed, 12 insertions(+), 2 deletions(-)

1 0

[tor-cloud/master] Tried to add more info to the BUILD instructions, will clean up the text later
by runa＠torproject.org 07 Nov '11

07 Nov '11

commit f11df67e8d0b5021927170a9696f130193005b5a Author: Runa A. Sandvik <runa.sandvik(a)gmail.com> Date: Mon Nov 7 16:34:39 2011 +0000 Tried to add more info to the BUILD instructions, will clean up the text later --- BUILD | 43 ++++++++++++++++++++++++++++++++++++------- 1 files changed, 36 insertions(+), 7 deletions(-) diff --git a/BUILD b/BUILD index 5866339..461ddc1 100644 --- a/BUILD +++ b/BUILD @@ -1,11 +1,16 @@ - Installation: - 1) Install ec2-api-tools on your laptop or build machine - 2) Generate and save your private keys: - export EC2_PRIVATE_KEY=~/keys/pk.cert - export EC2_CERT=~./keys/cert.pem - 3) Test your ec2-api-tools: + 0) Edit /etc/apt/sources.list to include multiverse + 1) Install ec2-api-tools and git-core on your laptop or build machine + 2) If the setup of openjdk-6-jre-headless is giving you a headache (e.g. crashing the instance), try using the 64-bit Ubuntu image instead. + 3) Clone https://git.torproject.org/tor-cloud.git + 4) Get the private keys (pk.cert and cert.pem) from Amazon and put them somewhere safe + 5) Run the following two commands to make sure the system knows about the private keys: + + # export EC2_PRIVATE_KEY=/path/to/pk.cert + # export EC2_CERT=/path/to/cert.pem + + 1) Test that ec2-api-tools is working: root@inf0:~/Tor-Cloud# ec2-describe-regions REGION eu-west-1 ec2.eu-west-1.amazonaws.com REGION us-east-1 ec2.us-east-1.amazonaws.com @@ -13,7 +18,16 @@ Installation: REGION us-west-1 ec2.us-west-1.amazonaws.com REGION ap-southeast-1 ec2.ap-southeast-1.amazonaws.com - 4) Generate private keys for each region: + 4) Create Generate private keys for each region. For each key + generated, save it in keys/: + + # ec2-add-keypair --region us-east-1 tor-cloud-us-east-1 + # ec2-add-keypair --region us-west-1 tor-cloud-us-west-1 + # ec2-add-keypair --region us-west-1 tor-cloud-eu-west-1 + # ec2-add-keypair --region us-west-1 tor-cloud-ap-northeast-1 + # ec2-add-keypair --region us-west-1 tor-cloud-ap-southeast-1 + + for example: ec2-add-keypair --region us-east-1 tor-cloud-east-1 and save the key in: ~/keys/tor-cloud-east-1.pem, don't forget to run chmod 600 ~/keys/* @@ -25,12 +39,27 @@ Installation: -rw------- 1 root root 1.7K 2011-09-12 19:09 tor-cloud-us-east-1.pem -rw------- 1 root root 1.7K 2011-09-12 19:09 tor-cloud-us-west-1.pem + + + 5) Create a Security Group called "tor-cloud-build" and allow SSH inbound traffic. 6) You are now ready to build Bridge AMIs: For example, to build in "ap-southeast-1" region run: ./build.sh bridge ap-southeast-1 /home/architect/keys/tor-cloud-ap-southeast-1.pem tor-cloud-ap-southeast-1 + 7) The last thing the build.sh will spit out is the region and the AMI ID: + + ec2-describe-snapshots --region us-east-1 + IMAGE ami-5799503e + + 8) Before other people can launch it, make sure you make it + public in AWS: + + - Images, AMIs, right clic, edit permissions, set to public + + + TIP: You can run the build command for all the regions at the same time. Use screen or & to send the process to background!

1 0