commit 227e9f2503e0d300a2fc4072c4d5c9f570398ebb Author: Rusty Bird rustybird@net-c.com Date: Thu Nov 26 17:59:59 2020 +0000

Bug 40024: Rip out remnants of Torbutton's internal version check

Since Tor Browser 9.0 (when the Onion Button was removed), Torbutton's internal browser version check is no longer hooked up to any UI. But it was still chugging along - making requests and logging to the Browser Console.

Delete it, along with some now unnecessary support code. --- chrome/content/torbutton.js | 203 +------------------------------------------- 1 file changed, 2 insertions(+), 201 deletions(-)

diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index d795f642..db597c84 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -30,9 +30,6 @@ let { } = ChromeUtils.import("resource://torbutton/modules/utils.js", {}); let { configureControlPortModule } = Cu.import("resource://torbutton/modules/tor-control-port.js", {});

-const k_tb_last_browser_version_pref = "extensions.torbutton.lastBrowserVersion"; -const k_tb_browser_update_needed_pref = "extensions.torbutton.updateNeeded"; -const k_tb_last_update_check_pref = "extensions.torbutton.lastUpdateCheck"; const k_tb_tor_check_failed_topic = "Torbutton:TorCheckFailed";

var m_tb_prefs = Services.prefs; @@ -65,33 +62,6 @@ async function clearData(flags) { }); }

-// Bug 1506 P1: This object is only for updating the UI for toggling and style -var torbutton_window_pref_observer = -{ - register: function() - { - m_tb_prefs.addObserver("extensions.torbutton", this, false); - }, - - unregister: function() - { - m_tb_prefs.removeObserver("extensions.torbutton", this); - }, - - // topic: what event occurred - // subject: what nsIPrefBranch we're observing - // data: which pref has been changed (relative to subject) - observe: function(subject, topic, data) - { - if (topic != "nsPref:changed") return; - switch (data) { - case k_tb_browser_update_needed_pref: - torbutton_notify_if_update_needed(); - break; - } - } -} - // Bug 1506 P2: This object keeps Firefox prefs in sync with Torbutton prefs. // It probably could stand some simplification (See #3100). It also belongs // in a component, not the XUL overlay. @@ -242,32 +212,6 @@ torbutton_init = function() { } m_tb_wasinited = true;

- // Determine if we are running inside Tor Browser. - var cur_version; - try { - cur_version = m_tb_prefs.getCharPref("torbrowser.version"); - torbutton_log(3, "This is a Tor Browser"); - } catch(e) { - torbutton_log(3, "This is not a Tor Browser: "+e); - } - - // If the Tor Browser version has changed since the last time Torbutton - // was loaded, reset the version check preferences in order to avoid - // incorrectly reporting that the browser needs to be updated. - var last_version; - try { - last_version = m_tb_prefs.getCharPref(k_tb_last_browser_version_pref); - } catch (e) {} - if (cur_version != last_version) { - m_tb_prefs.setBoolPref(k_tb_browser_update_needed_pref, false); - if (m_tb_prefs.prefHasUserValue(k_tb_last_update_check_pref)) { - m_tb_prefs.clearUserPref(k_tb_last_update_check_pref); - } - - if (cur_version) - m_tb_prefs.setCharPref(k_tb_last_browser_version_pref, cur_version); - } - let tlps; try { tlps = Cc["@torproject.org/torlauncher-protocol-service;1"] @@ -347,14 +291,10 @@ torbutton_init = function() { // listen for our toolbar button being added so we can initialize it torbutton_init_toolbutton();

- torbutton_log(1, 'registering pref observer'); - torbutton_window_pref_observer.register(); - torbutton_log(1, "registering Tor check observer"); torbutton_tor_check_observer.register();

torbutton_update_toolbutton(); - torbutton_notify_if_update_needed();

try { createTorCircuitDisplay("extensions.torbutton.display_circuit"); @@ -505,128 +445,6 @@ function torbutton_get_toolbutton() { return o_toolbutton; }

-function torbutton_update_is_needed() { - var updateNeeded = false; - try { - updateNeeded = m_tb_prefs.getBoolPref(k_tb_browser_update_needed_pref); - } catch (e) {} - - return updateNeeded; -} - -function torbutton_notify_if_update_needed() { - function setOrClearAttribute(aElement, aAttrName, aValue) - { - if (!aElement || !aAttrName) - return; - - if (aValue) - aElement.setAttribute(aAttrName, aValue); - else - aElement.removeAttribute(aAttrName); - } - - let updateNeeded = torbutton_update_is_needed(); - - // Change look of toolbar item (enable/disable animated update icon). - var btn = torbutton_get_toolbutton(); - setOrClearAttribute(btn, "tbUpdateNeeded", updateNeeded); - - // Make the "check for update" menu item bold if an update is needed. - var item = document.getElementById("torbutton-checkForUpdate"); - setOrClearAttribute(item, "tbUpdateNeeded", updateNeeded); -} - -// Bug 1506 P4: Checking for Tor Browser updates is pretty important, -// probably even as a fallback if we ever do get a working updater. -function torbutton_do_async_versioncheck() { - if (!m_tb_prefs.getBoolPref("extensions.torbutton.versioncheck_enabled")) { - return; - } - - // Suppress update check if done recently. - const kMinSecsBetweenChecks = 120 * 60; // 2.0 hours - var now = Date.now() / 1000; - var lastCheckTime; - try { - lastCheckTime = parseFloat(m_tb_prefs.getCharPref(k_tb_last_update_check_pref)); - if (isNaN(lastCheckTime)) - lastCheckTime = undefined; - } catch (e) {} - - if (lastCheckTime && ((now - lastCheckTime) < kMinSecsBetweenChecks)) - return; - - m_tb_prefs.setCharPref(k_tb_last_update_check_pref, now); - - torbutton_log(3, "Checking version with socks port: " - +m_tb_prefs.getIntPref("network.proxy.socks_port")); - try { - var req = new XMLHttpRequest(); - var url = m_tb_prefs.getCharPref("extensions.torbutton.versioncheck_url"); - req.open('GET', url, true); - req.channel.loadFlags |= Ci.nsIRequest.LOAD_BYPASS_CACHE; - req.overrideMimeType("text/json"); - req.onreadystatechange = function (oEvent) { - if (req.readyState === 4) { - if(req.status == 200) { - if(!req.responseText) { - torbutton_log(5, "Version check failed! No JSON present!"); - return -1; - } - try { - var version_list = JSON.parse(req.responseText); - var my_version = m_tb_prefs.getCharPref("torbrowser.version"); - var platformSuffix; - var platform = Services.appinfo.OS; - switch (platform) { - case "WINNT": - platformSuffix = "Windows"; - break; - case "Darwin": - platformSuffix = "MacOS"; - break; - case "Linux": - case "Android": - platformSuffix = platform; - break; - } - if (platformSuffix) - my_version += "-" + platformSuffix; - - if (version_list.indexOf(my_version) >= 0) { - torbutton_log(3, "Version check passed."); - m_tb_prefs.setBoolPref(k_tb_browser_update_needed_pref, false); - return; - } - torbutton_log(5, "Your Tor Browser is out of date."); - m_tb_prefs.setBoolPref(k_tb_browser_update_needed_pref, true); - return; - } catch(e) { - torbutton_log(5, "Version check failed! JSON parsing error: "+e); - return; - } - } else if (req.status == 404) { - // We're going to assume 404 means the service is not implemented yet. - torbutton_log(3, "Version check failed. Versions file is 404."); - return -1; - } - torbutton_log(5, "Version check failed! Web server error: "+req.status); - return -1; - } - }; - req.send(null); - } catch(e) { - if(e.result == 0x80004005) { // NS_ERROR_FAILURE - torbutton_log(5, "Version check failed! Is tor running?"); - return -1; - } - torbutton_log(5, "Version check failed! Tor internal error: "+e); - return -1; - } - -} - function torbutton_update_toolbutton() { let o_toolbutton = torbutton_get_toolbutton(); @@ -1625,16 +1443,6 @@ function torbutton_do_startup() } }

-// Perform version check when a new tab is opened. -function torbutton_new_tab(event) -{ - // listening for new tabs - torbutton_log(3, "New tab"); - - /* Perform the version check on new tab, module timer */ - torbutton_do_async_versioncheck(); -} - // Bug 1506 P3: Used to decide if we should resize the window. // // Returns true if the window wind is neither maximized, full screen, @@ -1705,9 +1513,8 @@ function setupPreferencesForMobile() { }); }

-// Bug 1506 P3: This is needed pretty much only for the version check -// and the window resizing. See comments for individual functions for -// details +// Bug 1506 P3: This is needed pretty much only for the window resizing. +// See comments for individual functions for details function torbutton_new_window(event) { torbutton_log(3, "New window"); @@ -1721,8 +1528,6 @@ function torbutton_new_window(event) if (!m_tb_wasinited) { torbutton_init(); } - // Add tab open listener.. - browser.tabContainer.addEventListener("TabOpen", torbutton_new_tab, false);

torbutton_do_startup();

@@ -1734,16 +1539,12 @@ function torbutton_new_window(event) Ci.nsIWebProgress.NOTIFY_STATE_DOCUMENT); }

- // Check the version on every new window. We're already pinging check in these cases. - torbutton_do_async_versioncheck(); - torbutton_do_tor_check(); }

// Bug 1506 P2: This is only needed because we have observers // in XUL that should be in an XPCOM component function torbutton_close_window(event) { - torbutton_window_pref_observer.unregister(); torbutton_tor_check_observer.unregister();

window.removeEventListener("sizemodechange", m_tb_resize_handler,