[tor-dev] [PATCH] Implement proposal xxx: ignore subdomains in hidden service addresses
lunar at debian.org
Sun Jul 8 07:38:35 UTC 2012
On Sat, Jul 07, 2012 at 01:13:52PM -0400, Nick Mathewson wrote:
> Looks good except for a few things:
> * It needs a "changes" file; see doc/HACKING for the format there.
> * The documentation for the function doesn't say that it accepts the
> new syntax, and doesn't say that it removes the leading material from
> the hostname.
> * It considers .aaaaaaaaaaaaaaa.onion to be a valid hostname; is that wrong?
> * The tests should probably make sure that it modifies the hostname
> as expected
v2 fixes all these issues.
> > Warning! Tests on this patch were limited to 'make check'.
> * Somebody should run this to make sure that it works. :)
Still not done. :D
> BTW, it's usually a good idea to put patches on the bugtracker at
> trac.torproject.org: that way it is way harder for me to forget about
> them, drop them on the floor, or anything like that.
I was waiting for the proposal to gets its number, I guess. Let's move
the discussion on the ticket from now on.
Jérémy Bobbio .''`.
lunar at debian.org : :Ⓐ : # apt-get install anarchism
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the tor-dev