[tor-commits] [torspec/master] prop284: Improve the ADD_ONION new key type wording

[nickm at torproject.org]

commit f8122635bc45342243c248d9763b8fbb281a62b7
Author: David Goulet <dgoulet at torproject.org>
Date:   Tue Nov 7 15:04:16 2017 -0500

    prop284: Improve the ADD_ONION new key type wording
    
    Also define the new ed25519 key blob encoding format which is the same
    format as the current v2 key blob is expected to be in.
    
    Closes #24165
    
    Signed-off-by: David Goulet <dgoulet at torproject.org>
---
 proposals/284-hsv3-control-port.txt | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/proposals/284-hsv3-control-port.txt b/proposals/284-hsv3-control-port.txt
index f2d03f6..e229bf9 100644
--- a/proposals/284-hsv3-control-port.txt
+++ b/proposals/284-hsv3-control-port.txt
@@ -88,11 +88,16 @@ Status: Open
    New "KeyType" value to "ED25519-V3" which identifies the key type to be a
    v3 ed25519 key.
 
-   New "KeyBlob" value to support the new "ED25519-V3", if specified, will
-   generate a new ed25519 private key.
+   With the KeyType == "ED25519-V3", the "KeyBlob" should be a base64 encoded
+   ed25519 private key.
+
+   The "NEW:BEST" option will still return a version 2 address as long as the
+   HiddenServiceVersion torrc option default is 2. To ask for a new v3 key,
+   this should be used: "NEW:ED25519-V3".
 
    Because client authentication is not yet implemented, the "ClientAuth"
-   field is ignored as well as "Flags=BasicAuth".
+   field is ignored as well as "Flags=BasicAuth". A 513 error is returned if
+   "ClientAuth" is used with an ED25519-V3 key type.
 
 3.1.4. DEL_ONION