[tor-commits] [stem/master] Issuing exit status 1 if there's any testing failures

atagar at torproject.org atagar at torproject.org
Sat Mar 23 19:35:30 UTC 2013


commit cba36249020b0f322ce0ca6438d31dd5d4281905
Author: Damian Johnson <atagar at torproject.org>
Date:   Sat Mar 23 12:33:56 2013 -0700

    Issuing exit status 1 if there's any testing failures
    
    We explicitely set an exit status at several points but we don't set one for
    the most important situation: testing success/failure at the very end. Caught
    by weasel.
---
 run_tests.py |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/run_tests.py b/run_tests.py
index 62d3799..ead0fb8 100755
--- a/run_tests.py
+++ b/run_tests.py
@@ -612,7 +612,9 @@ if __name__ == '__main__':
   else:
     runtime_label = "(%i seconds)" % runtime
 
-  if testing_failed or error_tracker.has_error_occured():
+  has_error = testing_failed or error_tracker.has_error_occured()
+
+  if has_error:
     test.output.print_line("TESTING FAILED %s" % runtime_label, *ERROR_ATTR)
 
     for line in error_tracker:
@@ -624,3 +626,5 @@ if __name__ == '__main__':
   else:
     test.output.print_line("TESTING PASSED %s" % runtime_label, term.Color.GREEN, term.Attr.BOLD)
     print
+
+  sys.exit(1 if has_error else 0)



More information about the tor-commits mailing list