[tor-bugs] #34200 [Core Tor/Tor]: Refactor tor's circuit path node selection checks

[Tor Bug Tracker & Wiki]

#34200: Refactor tor's circuit path node selection checks
-------------------------------+-------------------------------------------
     Reporter:  teor           |      Owner:  teor
         Type:  defect         |     Status:  assigned
     Priority:  Medium         |  Milestone:  Tor: 0.4.4.x-final
    Component:  Core Tor/Tor   |    Version:
     Severity:  Normal         |   Keywords:  ipv6, prop311, technical-debt
Actual Points:  1              |  Parent ID:  #33221
       Points:  1              |   Reviewer:
      Sponsor:  Sponsor55-can  |
-------------------------------+-------------------------------------------
 In #33222, we added an extra "can extend over IPv6" check to tor's circuit
 path node selection code.

 To make sure it's applied consistently, I did a refactor of that code, so
 all those checks are in one function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34200>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online