[tor-bugs] #34200 [Core Tor/Tor]: Refactor tor's circuit path node selection checks

[Tor Bug Tracker & Wiki]

#34200: Refactor tor's circuit path node selection checks
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  teor
     Type:  defect                         |         Status:  needs_review
 Priority:  Medium                         |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  ipv6, prop311, technical-debt  |  Actual Points:  1
Parent ID:  #33221                         |         Points:  1
 Reviewer:                                 |        Sponsor:  Sponsor55-can
-------------------------------------------+-------------------------------
Changes (by teor):

 * cc: nickm (added)
 * status:  assigned => needs_review


Comment:

 See my PR, which is based on #33222:
 * incomplete: https://github.com/torproject/tor/pull/1888

 This PR still needs unit tests and changes files for the extra refactor on
 top of #33222.

 The stem tests will fail due to:
 * https://github.com/torproject/stem/issues/63
 Reverting to the most recent stem release, or stem commit 13e401d, should
 resolve this issue.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/34200#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online