[tor-bugs] #33898 [Core Tor/Tor]: Stop modifying addr on connections, and delete real_addr

[Tor Bug Tracker & Wiki]

#33898: Stop modifying addr on connections, and delete real_addr
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  nickm
     Type:  defect                         |         Status:  assigned
 Priority:  High                           |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  ipv6, technical-debt, prop311  |  Actual Points:
Parent ID:  #33048                         |         Points:  1
 Reviewer:                                 |        Sponsor:  Sponsor55-can
-------------------------------------------+-------------------------------

Comment (by dgoulet):

 Sounds legit to have the strategy of pushing down the address for the
 common use case in let say `connection_t` (if any). Then, specialize as we
 go up the hierarchy tree.

 To try to comment on the "what part we do now", maybe identifying if the
 low level `connection_t` could have an address field that is common to all
 other objects. If yes, do that change, if not, specialize the "address"
 concept in each higher level objects?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33898#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online