[tor-bugs] #33898 [Core Tor/Tor]: Stop modifying addr on connections, and delete real_addr

[Tor Bug Tracker & Wiki]

#33898: Stop modifying addr on connections, and delete real_addr
-------------------------------------------+-------------------------------
 Reporter:  teor                           |          Owner:  nickm
     Type:  defect                         |         Status:  assigned
 Priority:  High                           |      Milestone:  Tor:
                                           |  0.4.4.x-final
Component:  Core Tor/Tor                   |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  ipv6, technical-debt, prop311  |  Actual Points:
Parent ID:  #33048                         |         Points:  1
 Reviewer:                                 |        Sponsor:  Sponsor55-can
-------------------------------------------+-------------------------------

Comment (by nickm):

 So what do we do at this point?  I think we need a long term plan for
 these fields and a plan for the OR fields specifically.

 As a long-term plan, I think we should move towards disabling "addr" as
 meaning anything other than "the network address we are connected to,
 possibly through a local proxy".  If we retain "address", it should be
 display-only.  Possibly we should rename these fields to avoid confusion.

 We should have a "display peer for logging" function that we use instead
 of addr/port/address in log messages.

 We'll need additional fields for the following purposes:
    * Canonical address of peer, to use in OR connections.
    * Requested address and resolved address, to use in exit connections.
    * Address to re-bind to, for listeners.
    * Best guess at peer's real internet address, for tunneled directory
 connections, to be used for X-Your-Address-Is.

 So what parts of this do we do now?

 First I should solicit comment on this plan.  Then, I should open a ticket
 or three about this. Then, we should document all of this in the code, and
 create the "describe this peer" function.  Then finally we should adjust
 OR connections so that they use the fields in the intended manner.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/33898#comment:10>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online