[tor-bugs] #27194 [Core Tor/Tor]: Reject protover extra commas in protover

[Tor Bug Tracker & Wiki]

#27194: Reject protover extra commas in protover
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.4-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, rust, security-low,    |  Actual Points:  0.2
  consider-backport-if-needed, 035-backport,     |
  041-backport, 042-backport, 043-backport, 032  |
  -unreached-backport, 035-deferred-20190115,    |
  041-proposed, 033-unreached-backport, 040      |
  -unreached-backport                            |
Parent ID:                                       |         Points:  0.2
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * cc: nickm (added)
 * keywords:
     needs-consensus-method, rust, security-low, 035-backport,
     040-backport, 041-backport, 032-unreached-backport,
     035-deferred-20190115, 041-proposed, 033-unreached-backport
     =>
     extra-review, rust, security-low, consider-backport-if-needed,
     035-backport, 041-backport, 042-backport, 043-backport, 032-unreached-
     backport, 035-deferred-20190115, 041-proposed, 033-unreached-backport,
     040-unreached-backport
 * status:  needs_revision => needs_review
 * milestone:  Tor: unspecified => Tor: 0.4.4.x-final


Comment:

 Thanks for updating this branch!

 The good news is that the backport situation is a bit simpler now:
 * 0.2.9 and 0.4.0 are unsupported
 * 0.3.5, 0.4.1, 0.4.2, and 0.4.3 may need backports
 * all supported versions have Rust

 We can't fix this issue in 0.4.3, because it's in final alpha testing, and
 these issues have historically been risky.

 Since directory authorities only use the latest two stable versions, we
 may only need to backport to 0.4.2 and 0.4.3. Or we might decide not to
 backport this change at all.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27194#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online