[tor-bugs] #27194 [Core Tor/Tor]: Reject protover extra commas in protover

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Feb 10 08:16:37 UTC 2020


#27194: Reject protover extra commas in protover
-------------------------------------------------+-------------------------
 Reporter:  cyberpunks                           |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.4.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.4-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  extra-review, rust, security-low,    |  Actual Points:  0.2
  consider-backport-if-needed, 035-backport,     |
  041-backport, 042-backport, 043-backport, 032  |
  -unreached-backport, 035-deferred-20190115,    |
  041-proposed, 033-unreached-backport, 040      |
  -unreached-backport                            |
Parent ID:                                       |         Points:  0.2
 Reviewer:  ahf                                  |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by teor):

 As you note in one of your commit messages, we might want to rename the
 function protover_contains_long_protocol_names()` to something more like
 `protover_line_is_valid()`.

 (And invert all the checks.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27194#comment:28>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list