[tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

[Tor Bug Tracker & Wiki]

#32088: Proposal 310 - choose guards in sampled order
--------------------------------------+------------------------------------
 Reporter:  Jaym                      |          Owner:  (none)
     Type:  enhancement               |         Status:  needs_revision
 Priority:  High                      |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tor-spec prop271 prop310  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  nickm                     |        Sponsor:
--------------------------------------+------------------------------------
Changes (by nickm):

 * status:  needs_review => needs_revision


Comment:

 Sorry for the delay: the last week or so has been hugely busy.

 The changes look good, but CI still isn't passing.  It looks like these
 tests are failing on appveyor:
 {{{
 entrynodes/confirming_guards: [forking] Skipping 1 testcases.
   FAIL ../src/test/test_entrynodes.c:1513: assert(g1->confirmed_idx OP_EQ
 0): 2 vs 0
   [confirming_guards FAILED]
 entrynodes/confirming_guards_reasonably_future: [forking] Skipping 1
 testcases.
   FAIL ../src/test/test_entrynodes.c:1513: assert(g1->confirmed_idx OP_EQ
 0): 2 vs 0
   [confirming_guards_reasonably_future FAILED]
 entrynodes/confirming_guards_reasonably_past: [forking] Skipping 1
 testcases.
   FAIL ../src/test/test_entrynodes.c:1513: assert(g1->confirmed_idx OP_EQ
 0): 2 vs 0
   [confirming_guards_reasonably_past FAILED]
 }}}

 I'm also seeing more practracker issues on Travis:
 {{{
 problem function-size
 /src/feature/client/entrynodes.c:entry_guard_parse_from_state() 272
 }}}

 For this one we should probably look for some code we can extract into a
 new function, to simplify this function.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32088#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online