[tor-bugs] #32088 [Core Tor/Tor]: Proposal 310 - choose guards in sampled order

[Tor Bug Tracker & Wiki]

#32088: Proposal 310 - choose guards in sampled order
--------------------------------------+------------------------------------
 Reporter:  Jaym                      |          Owner:  (none)
     Type:  enhancement               |         Status:  needs_revision
 Priority:  High                      |      Milestone:  Tor: 0.4.4.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tor-spec prop271 prop310  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:  nickm                     |        Sponsor:
--------------------------------------+------------------------------------

Comment (by Jaym):

 Hello Nick,

 Thanks for the review!

 Things have been fixed and github looks happy now.

 Summary: The problem was apparently due to a qsort() behavior difference
 between my setup and appveyor running on windows (I wasn't experiencing
 the failure). Yet, the test was doing something weird; i.e., setting
 confirmed_idx of different guards to the same value, which is not
 something that seems ok to test. It means unstable behaviors with sorted
 lists, and we don't like unstable behaviors :)

 I've slightly modified the original test since now the confirmed_guards
 are sorted by sampled_idx, and it makes sure that the confirmed guards are
 sorted as expected, with valid confirmed_idx (i.e., not the same).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32088#comment:21>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online