[tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton,                       |  Actual Points:
  TorBrowserTeam201911R                          |
Parent ID:  #30506                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by acat):

 * keywords:  tbb-torbutton, TorBrowserTeam201911 => tbb-torbutton,
     TorBrowserTeam201911R
 * status:  needs_revision => needs_review


Comment:

 Revised branches: https://github.com/acatarineu/tor-
 browser/commits/28745+2 and
 https://github.com/acatarineu/torbutton/commits/28745+2.

 I moved the `extensions.torbutton.launch_warning = false` mobile override
 to `000-tor-browser-android.js`.

 >Have you tested that moving browser.startup.homepage is fine now and that
 we can ditch non-localized.properties in torbutton? The code mentioned in
 the comment is still there. But I guess we don't hit the codepath as we
 are not setting any default prefs in the extension anymore?
 Yes, I tested that it works fine.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online