[tor-bugs] #28745 [Applications/Tor Browser]: THE Torbutton clean-up

[Tor Bug Tracker & Wiki]

#28745: THE Torbutton clean-up
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201911  |  Actual Points:
Parent ID:  #30506                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-torbutton, TorBrowserTeam201911R => tbb-torbutton,
     TorBrowserTeam201911


Comment:

 Commit 46b550c5550d3ad4a7d526a402a33bbb40dce5e2 on your `torbutton` branch
 has
 {{{
 -      // Disable the External App Blocker on Android
 -      if ((aPrefName === "extensions.torbutton.launch_warning") &&
 -          (Services.appinfo.OS === "Android")) {
 -        defaultPrefBranch.setBoolPref(aPrefName, false);
 -      }
 }}}
 It seems we want to keep that part, though, and I don't see a matching
 counterpart in any of your related `tor-browser` commits.

 Commit f797d8ba19c5838032abff6da3c4b5e8cabc518f on your `tor-browser`
 branch:
 {{{
 +pref("extensions.torbutton.cookie_protections",true);
 +pref("extensions.torbutton.cookie_auto_protect",false);
 }}}
 That's already gone, I think.
 {{{
 +pref("extensions.torbutton.prompt_torbrowser", true);
 }}}
 No need to add this anymore, see my previous comment.
 {{{
 +// TODO: This is just part of a stopgap until #14429 gets properly
 implemented.
 +// See #7255 for details. We display the warning three times to make sure
 the
 +// user did not click on it by accident.
 }}}
 I think we should update the comment at least. We still have this
 mechanism for users that disable letterboxing, I think.

 Have you tested that moving `browser.startup.homepage` is fine now and
 that we can ditch `non-localized.properties` in `torbutton`? The code
 mentioned in the comment is still there. But I guess we don't hit the
 codepath as we are not setting any default prefs in the extension anymore?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28745#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online