[tor-bugs] #29706 [Core Tor/Tor]: Test failure due to memory leaks in shared-random unit tests

[Tor Bug Tracker & Wiki]

#29706: Test failure due to memory leaks in shared-random unit tests
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  teor
         Type:  defect   |     Status:  assigned
     Priority:  Very     |  Milestone:  Tor: 0.4.1.x-final
  High                   |
    Component:  Core     |    Version:  Tor: 0.2.9.1-alpha
  Tor/Tor                |   Keywords:  tor-ci, tor-test, memory-
     Severity:  Normal   |  management, 029-backport, 034-backport,
                         |  035-backport, 040-backport
Actual Points:  0.3      |  Parent ID:
       Points:  0.3      |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 In #29599 we fixed some leaks in the shared-random unit tests. But there
 are still some test failures.

 The shared random state claims to take over ownership of SRVs passed to it
 using PUT. But it doesn't free them automatically: instead, the caller has
 to remember to call state_del_current_srv() first. (Or one of its
 callers.)

 The current app code is ok, but the test code doesn't always call the
 functions in the right order.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29706>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online