[tor-bugs] #29706 [Core Tor/Tor]: Test failure due to memory leaks in shared-random unit tests

[Tor Bug Tracker & Wiki]

#29706: Test failure due to memory leaks in shared-random unit tests
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  teor
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.4.1.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.2.9.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  tor-ci, tor-test, memory-            |  Actual Points:  0.3
  management, 029-backport-partial,              |
  034-backport, 035-backport, 040-backport       |
Parent ID:                                       |         Points:  0.3
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * keywords:
     tor-ci, tor-test, memory-management, 029-backport, 034-backport,
     035-backport, 040-backport
     =>
     tor-ci, tor-test, memory-management, 029-backport-partial,
     034-backport, 035-backport, 040-backport
 * status:  assigned => needs_review


Comment:

 Here's one example of a failure after #29599 was merged:
 https://travis-ci.org/torproject/tor/jobs/503849917

 I have two pull requests on 0.2.9:

 A minimal version that fixes the unit tests on 0.2.9:
 https://github.com/torproject/tor/pull/774

 A refactor that fixes the underlying memory management bug on 0.2.9:
 https://github.com/torproject/tor/pull/775

 And a merge of the refactor to 0.3.4:
 https://github.com/torproject/tor/pull/776
 (There were some trivial conflicts where I needed to combine two sets of
 changes.)

 I expect that we'll backport the minimal version to 0.2.9 after CI has
 succeeded on master and 0.4.0.

 We can merge the refactor to 0.4.0 and master, and then decide whether to
 backport it after it has been tested in a few alphas. In particular, we
 should get arma to deploy an alpha or nightly on his authority.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/29706#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online