[tor-bugs] #32542 [Core Tor/Tor]: hs-v3: Add the 2 missing SOCKS extended errors from prop304

[Tor Bug Tracker & Wiki]

#32542: hs-v3: Add the 2 missing SOCKS extended errors from prop304
--------------------------+------------------------------------
 Reporter:  dgoulet       |          Owner:  dgoulet
     Type:  defect        |         Status:  needs_review
 Priority:  Medium        |      Milestone:  Tor: 0.4.3.x-final
Component:  Core Tor/Tor  |        Version:
 Severity:  Normal        |     Resolution:
 Keywords:  tor-hs        |  Actual Points:  0.4
Parent ID:  #14389        |         Points:  1
 Reviewer:  asn           |        Sponsor:  Sponsor27-must
--------------------------+------------------------------------
Changes (by dgoulet):

 * status:  assigned => needs_review
 * actualpoints:   => 0.4


Comment:

 Branch: `ticket32542_043_01`
 PR: https://github.com/torproject/tor/pull/1597

 (No tor-spec patch since socks-extension.txt points to the man page for
 the error codes.)

 This is a bit tricky as in the "from where we report the codes" so word of
 advise for the reviewer.

 The introduction failure codes are reported back if the descriptor we just
 fetched has no usable introduction points. This is a bit counter intuitive
 but the reason is because tor will refetch a descriptor if all intro
 points fail and then notice they are the same again and stop. That very
 moment is where the failure is reported.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32542#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online