[tor-bugs] #32672 [Core Tor/Tor]: Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()

[Tor Bug Tracker & Wiki]

#32672: Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  task                                 |         Status:
                                                 |  needs_information
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  043-should, 041-backport,            |  Actual Points:
  042-backport, consider-backport-after-         |
  authority-test, fast-fix, network-health       |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by teor):

 * status:  needs_review => needs_information


Comment:

 Replying to [comment:7 neel]:
 > About blocking 0.4.1 alphas/rc, I would be against it unless there is a
 crippling bug on the 0.4.1 alphas/rc releases. For instance, 0.2.9.5-rc is
 allowed on the network because it "works" (may not be the most secure, but
 technically works), whereas 0.2.9.4 and below have a consensus bug.

 Yes, we decided to keep 0.2.9.5-rc, when we made a decision about 0.2.9.

 But recently, when we made a decision about 0.3.5, we rejected unstable
 versions of 0.3.5 because those versions are not supported. (And there
 were not many relays on those versions.)
 https://github.com/torproject/tor/pull/1588/files#diff-
 c535b81e06d7fed27d5d3cdaabf1c4b8R331

 Unless there is some compelling reason to keep 0.4.0 unstable relays, we
 should encourage their operators to upgrade.

 > The changes are posted to both the original PR based off master and the
 0.4.1 PR here: https://github.com/torproject/tor/pull/1588
 >
 > I don't know if two PRs will work for you, but here it is.

 We normally do backports with multiple PRs. Because of the way that git
 does merges, the best way to get a good merge is to do the common changes
 in one commit, and the extra changes for later versions in other commits.
 You won't need to do that here, this patch is small enough that we can
 resolve any merge conflicts ourselves.

 To move forward with this ticket, we need to:
 * find out how many relays are on unstable 0.4.0 versions
 * decide if we want to reject those versions

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32672#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online