[tor-bugs] #32672 [Core Tor/Tor]: Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()

[Tor Bug Tracker & Wiki]

#32672: Reject 0.2.9 and 0.4.0 in dirserv_rejects_tor_version()
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  neel
     Type:  task                                 |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.4.3.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  043-should, 041-backport,            |  Actual Points:
  042-backport, consider-backport-after-         |
  authority-test, fast-fix, network-health       |
Parent ID:                                       |         Points:  0.5
 Reviewer:  teor                                 |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by neel):

 * status:  needs_revision => needs_review


Comment:

 Rebasing this branch over 0.4.1 doesn't make sense, as the tests are
 missing on that branch. However, I have a secondary PR for 0.4.1.

 About blocking 0.4.1 alphas/rc, I would be against it unless there is a
 crippling bug on the 0.4.1 alphas/rc releases. For instance, 0.2.9.5-rc is
 allowed on the network because it "works" (may not be the most secure, but
 technically works), whereas 0.2.9.4 and below have a consensus bug.

 The changes are posted to both the original PR based off master and the
 0.4.1 PR here: https://github.com/torproject/tor/pull/1588

 I don't know if two PRs will work for you, but here it is.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/32672#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online