[tor-bugs] #28312 [Core Tor/Tor]: Crash when configuring a PidFile containing ~

[Tor Bug Tracker & Wiki]

#28312: Crash when configuring a PidFile containing ~
-------------------------------------------------+-------------------------
 Reporter:  teor                                 |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.2.1-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  memory-safety, regression,           |  Actual Points:
  security-low                                   |
Parent ID:  #28298                               |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by arma):

 First issue is that our PidFile handling never calls expand_filename(). If
 we want it to, we could fix that. We probably should.

 Also, this might be a good time to wonder if there is a better way to call
 expand_filename more uniformly on config options that should expect it.
 Maybe want a new config type FILENAME, rather than the current ambiguous
 choice STRING ? Oh wait, we *have* one of those already, e.g.
 DirPortFrontPage is one. So the bug here is that PidFile is a STRING not a
 FILENAME? And the second bug is that we don't uniformly run
 expand_filename() on config options of type FILENAME?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28312#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online