[tor-bugs] #28312 [Core Tor/Tor]: Crash when configuring a PidFile containing ~

[Tor Bug Tracker & Wiki]

#28312: Crash when configuring a PidFile containing ~
-------------------------+-------------------------------------------------
     Reporter:  teor     |      Owner:  (none)
         Type:  defect   |     Status:  new
     Priority:  High     |  Milestone:  Tor: 0.3.5.x-final
    Component:  Core     |    Version:  Tor: 0.3.2.1-alpha
  Tor/Tor                |   Keywords:  memory-safety, regression,
     Severity:  Normal   |  security-low
Actual Points:           |  Parent ID:  #28298
       Points:           |   Reviewer:
      Sponsor:           |
-------------------------+-------------------------------------------------
 The patch in #28298 may avoids the "~" bug in DataDirectory, but adding ~
 to many other configured path crashes tor:
 {{{
 tor DisableNetwork 1 PidFile "~/.torpid"
 }}}
 with this error:
 {{{
 Nov 04 15:35:10.740 [notice] Tor 0.3.4.8 (git-da95b91355248ad8) running on
 Darwin with Libevent 2.1.8-stable, OpenSSL 1.0.2p, Zlib 1.2.11, Liblzma
 N/A, and Libzstd N/A.
 ...
 Nov 04 15:35:10.744 [warn] Path for PidFile (~/.torpid) is relative and
 will resolve to /Users/base/~/.torpid. Is this what you wanted?
 ...
 Nov 04 15:35:10.000 [warn] Unable to open "~/.torpid" for writing: No such
 file or directory
 Nov 04 15:35:10.000 [err] Unable to write PIDFile "~/.torpid"
 Nov 04 15:35:10.000 [err] set_options: Bug: Acting on config options left
 us in a broken state. Dying. (on Tor 0.3.4.8 da95b91355248ad8)
 Nov 04 15:35:10.000 [err] Reading config failed--see warnings above.
 tor(79983,0x7fffa9c06380) malloc: *** error for object 0x7: pointer being
 freed was not allocated
 *** set a breakpoint in malloc_error_break to debug
 Abort trap: 6
 Exit 134
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28312>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online