[tor-bugs] #27225 [Core Tor/Tor]: Perform fewer allocations in summarize_protocol_flags()

[Tor Bug Tracker & Wiki]

#27225: Perform fewer allocations in summarize_protocol_flags()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #26630                               |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by nickm):

 We do not require such an ordering.

 It's intentional that we can exceed MAX_PROTOVER_SUMMARY_MAP_LEN -- the
 outcome there is just a performance regression, though, rather than any
 kind of exhaustion.

 We could start enforcing this ordering at the authorities if we want: this
 would take a new proposal. Do you think it's worth it?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27225#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online