[tor-bugs] #27225 [Core Tor/Tor]: Perform fewer allocations in summarize_protocol_flags()

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Nov 1 20:54:32 UTC 2018


#27225: Perform fewer allocations in summarize_protocol_flags()
-------------------------------------------------+-------------------------
 Reporter:  nickm                                |          Owner:  nickm
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:  Tor:
                                                 |  0.3.6.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  035-roadmap-master, 035-triaged-     |  Actual Points:
  in-20180711                                    |
Parent ID:  #26630                               |         Points:
 Reviewer:  mikeperry                            |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------

Comment (by mikeperry):

 Hrmm question: Do we require a specific ordering on protover keywords? The
 proposal says we "should" sort by keyword. But if other tor
 implementations do not carefully order protover strings (or if
 modularization of core-tor makes the protover strings dynamically
 generated in non-deterministic order), then we may exceed
 MAX_PROTOVER_SUMMARY_MAP_LEN, right?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/27225#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tor-bugs mailing list