[tor-bugs] #25245 [Core Tor/Tor]: Crash in assert_connection_ok when changing Exit options

[Tor Bug Tracker & Wiki]

#25245: Crash in assert_connection_ok when changing Exit options
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  crash, regression?, tor-exit, tor-   |  Actual Points:
  relay, ipv6                                    |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by rl1987):

 I figure this happens because we do not properly cleanup/close existing
 edge connections when `ExitRelay` is switched off. A solution would be to
 keep track of child connections that listeners spawn when `accept()`
 succeeds and close all of them when closing the listener.

 Something like:
 * https://github.com/rl1987/tor/compare/bug25245_hax?expand=1

 Does this make sense?

 If this is correct approach I could finalise the patch into mergeable
 shape.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25245#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online