[tor-bugs] #25245 [Core Tor/Tor]: Crash in assert_connection_ok when changing Exit options

[Tor Bug Tracker & Wiki]

#25245: Crash in assert_connection_ok when changing Exit options
-------------------------------------------------+-------------------------
 Reporter:  toralf                               |          Owner:  (none)
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:  Tor:
                                                 |  0.3.3.x-final
Component:  Core Tor/Tor                         |        Version:  Tor:
                                                 |  0.3.3.2-alpha
 Severity:  Normal                               |     Resolution:
 Keywords:  crash, regression?, tor-exit, tor-   |  Actual Points:
  relay, ipv6                                    |
Parent ID:                                       |         Points:  1
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by nickm):

 Hm.  We don't actually want to close all of the "Foo" connections when the
 "FooListener" is closed.  If we did that, then our hibernation code would
 break, since it assumes that you we continue servicing existing
 connections after we've closed all the listeners.

 I think instead the problem here is that there is something wrong with the
 tor_assert().  Can you help me understand how the problem here relates to
 the fix?  That is, why does setting ExitRelay 0 make these connections
 trigger the assertion if they do not get closed?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25245#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online