[tor-bugs] #24290 [Metrics]: Configure timeout for metrics-lib clients, e.g., those using DescriptorIndexCollector

[Tor Bug Tracker & Wiki]

#24290: Configure timeout for metrics-lib clients, e.g., those using
DescriptorIndexCollector
---------------------+-----------------------------------
 Reporter:  karsten  |          Owner:  iwakeh
     Type:  defect   |         Status:  needs_information
 Priority:  High     |      Milestone:
Component:  Metrics  |        Version:
 Severity:  Normal   |     Resolution:
 Keywords:           |  Actual Points:
Parent ID:           |         Points:
 Reviewer:           |        Sponsor:
---------------------+-----------------------------------

Comment (by karsten):

 Replying to [comment:8 iwakeh]:
 > As operator I might be able to know if some other host sits on the same
 rack in the same server room or is on a slow connection far away.

 Well, I guess we can safely assume that none of our tools runs in such an
 environment.

 > The above properties shouldn't be overridden in code.  To provide a
 better default behavior and avoid overriding a sort of system property I'd
 suggest setting a timeout only if
 `sun.net.client.default<Connect|Read>Timeout` is not set.

 Right, I didn't mean to override those properties. I was rather thinking
 of switching to methods that allow us to specify connect/read timeouts.

 But I also don't think we need to respect system properties starting with
 `sun.net.*`. We can just ignore them and set the timeout we think is
 right.

 > Maybe, one minute for connect and two for read?

 Anything between 1 and 5 minutes should be okay to start with.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24290#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online