[tor-bugs] #24290 [Metrics]: Configure timeout for metrics-lib clients, e.g., those using DescriptorIndexCollector

[Tor Bug Tracker & Wiki]

#24290: Configure timeout for metrics-lib clients, e.g., those using
DescriptorIndexCollector
---------------------+-----------------------------------
 Reporter:  karsten  |          Owner:  iwakeh
     Type:  defect   |         Status:  needs_information
 Priority:  High     |      Milestone:
Component:  Metrics  |        Version:
 Severity:  Normal   |     Resolution:
 Keywords:           |  Actual Points:
Parent ID:           |         Points:
 Reviewer:           |        Sponsor:
---------------------+-----------------------------------
Changes (by iwakeh):

 * status:  needs_revision => needs_information


Comment:

 Replying to [comment:7 karsten]:
 > Great that you were able to track this down!
 >
 > Regarding the suggested solution, leaving this as JVM property feels a
 bit ugly to me. First, with every config option we're making it harder to
 remember how to run our tools. And in this case, if somebody forgets to
 set the option, they'll end up with a bad default value. Second, this
 timeout is something that we should decide as developers and not leave up
 to operators. If we don't know what a good value is, how do the operators?
 And it's not that environments vary by that much.

 As operator I might be able to know if some other host sits on the same
 rack in the same server room or is on a slow connection far away.  The
 above properties shouldn't be overridden in code.  To provide a better
 default behavior and avoid overriding a sort of system property I'd
 suggest setting a timeout only if
 `sun.net.client.default<Connect|Read>Timeout` is not set.  Maybe, one
 minute for connect and two for read?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24290#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online