[tor-bugs] #24290 [Metrics]: Configure timeout for metrics-lib clients, e.g., those using DescriptorIndexCollector

[Tor Bug Tracker & Wiki]

#24290: Configure timeout for metrics-lib clients, e.g., those using
DescriptorIndexCollector
---------------------+--------------------------------
 Reporter:  karsten  |          Owner:  iwakeh
     Type:  defect   |         Status:  needs_revision
 Priority:  High     |      Milestone:
Component:  Metrics  |        Version:
 Severity:  Normal   |     Resolution:
 Keywords:           |  Actual Points:
Parent ID:           |         Points:
 Reviewer:           |        Sponsor:
---------------------+--------------------------------
Changes (by karsten):

 * status:  needs_review => needs_revision


Comment:

 Great that you were able to track this down!

 Regarding the suggested solution, leaving this as JVM property feels a bit
 ugly to me. First, with every config option we're making it harder to
 remember how to run our tools. And in this case, if somebody forgets to
 set the option, they'll end up with a bad default value. Second, this
 timeout is something that we should decide as developers and not leave up
 to operators. If we don't know what a good value is, how do the operators?
 And it's not that environments vary by that much.

 Should we simply hard-code five minutes? It's way better than waiting
 infinitely, and five seconds seems possibly too short. And if we find out
 that five minutes is a bad value, we can further tweak it in the future.
 Of course, we should document this timeout in the relevant documentation.
 And then it should be okay to hard-code it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24290#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online