[tor-bugs] #20424 [Core Tor/Tor]: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc is used)

[Tor Bug Tracker & Wiki]

#20424: Remove --enable-openbsd-malloc (Tor maxes CPU when --enable-openbsd-malloc
is used)
-------------------------------------------------+-------------------------
 Reporter:  icanhasaccount                       |          Owner:  (none)
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Low                                  |      Milestone:  Tor:
                                                 |  0.3.5.x-final
Component:  Core Tor/Tor                         |        Version:
 Severity:  Minor                                |     Resolution:
 Keywords:  review-group-31,                     |  Actual Points:
  034-triage-20180328, fast-fix, 035-triaged-    |
  in-20180711                                    |
Parent ID:                                       |         Points:  .2
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by nickm):

 * status:  needs_revision => needs_review
 * reviewer:  nickm =>


Comment:

 Let's try to get this unstuck, by disentangling the various options.

 I've made a branch `remove_openbsd_malloc` that ports icanhasaccount's
 removal code to master if we decide to do that.  PR at
 https://github.com/torproject/tor/pull/224 . Not my preferred approach.

 And I've made a branch called `with_malloc` that ports the parts of
 Hello71's patch that I agree with to master: it adds --with-malloc=,
 doesn't change our default, doesn't break old configure options, and keeps
 openbsd malloc as an option.  Works for me, but probably needs more review
 and testing. PR at https://github.com/torproject/tor/pull/225 .

 The above two branches apply to master only and are mutually exclusive,
 though we could probably combine them into one.

 For backport purposes, I have a branch `fix_nonstandard_malloc_029` that
 only does the minimum needed to fix the originally supported issue. PR at
 https://github.com/torproject/tor/pull/226 . Works for me.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20424#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online